- 19 Apr, 2017 1 commit
-
-
Adam Klein authored
There's no reason to keep track, for a preparsed function itself, whether that function calls eval. All that matters is that the ancestor scopes are marked as having an inner scope which calls eval. The function will have its "calls eval" bit persisted if/when it's fully parsed. The only "behavioral" change in this patch is the removal of a DCHECK. Bug: v8:6092 Change-Id: I17e396c8a265030fe0ad941707e4a97972e6650b Reviewed-on: https://chromium-review.googlesource.com/481223 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#44732}
-
- 12 Apr, 2017 1 commit
-
-
pwnall authored
This is necessary to appease "gn check" if gtest_prod.h becomes a part of the Chromium checkout, instead of a third-party repository brought over by Chromium's DEPS. The file is already listed in v8's DEPS, but gn does not use DEPS as an input. BUG=chromium:630705 Review-Url: https://codereview.chromium.org/2807353002 Cr-Commit-Position: refs/heads/master@{#44604}
-
- 11 Apr, 2017 2 commits
-
-
Wiktor Garbacz authored
This a step towards using CompilerDispatcher in parallel parsing. BUG=v8:6093 Change-Id: Idee84105e342950badb5694fa2a850e05430abaa Reviewed-on: https://chromium-review.googlesource.com/473246 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#44573}
-
Wiktor Garbacz authored
This a step towards using CompilerDispatcher in parallel parsing. BUG=v8:6093 Change-Id: I7c0dc0a5f5b25652a8aa98c94b1e069c1f081a5b Reviewed-on: https://chromium-review.googlesource.com/473106Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#44570}
-
- 05 Apr, 2017 3 commits
-
-
Wiktor Garbacz authored
It enables jobs without a SharedFunctionInfo. BUG=v8:6093 Change-Id: I70e226638fdb5b3a0634cc4437d128771c838eee Reviewed-on: https://chromium-review.googlesource.com/468966Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#44411}
-
Michael Achenbach authored
This reverts commit 4bca9dc7. Reason for revert: Breaks mips builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/8600 Original change's description: > [compiler-dispatcher] Use an integer job id. > > It enables jobs without a SharedFunctionInfo. > > BUG=v8:6093 > > Change-Id: Icc5f01512c270a55349087d418b6be82ad5c6cb4 > Reviewed-on: https://chromium-review.googlesource.com/467148 > Commit-Queue: Wiktor Garbacz <wiktorg@google.com> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#44402} TBR=rmcilroy@chromium.org,marja@chromium.org,jochen@chromium.org,rmcilroy@google.com,wiktorg@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6093 Change-Id: Ie8d26f4e2d42f67a1cfa91269e80e407ed3f0799 Reviewed-on: https://chromium-review.googlesource.com/468887Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#44404}
-
Wiktor Garbacz authored
It enables jobs without a SharedFunctionInfo. BUG=v8:6093 Change-Id: Icc5f01512c270a55349087d418b6be82ad5c6cb4 Reviewed-on: https://chromium-review.googlesource.com/467148 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#44402}
-
- 03 Mar, 2017 1 commit
-
-
Ross McIlroy authored
Spinning up a new background task is expensive, and many times an existing task will finish it's work before a new task starts work on a job, so enable the existing tasks to do more than one background job. BUG=v8:5203 Change-Id: Ibbef317c8bb3921c36a096fed88d244716be9c42 Reviewed-on: https://chromium-review.googlesource.com/441706 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43593}
-
- 22 Feb, 2017 2 commits
-
-
Ross McIlroy authored
This reverts commit 087e95ba. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Compiler] Use IdentityMap to store jobs in CompilerDispatcher. > > Stores jobs in an IdentityMap keyed by their SharedFunctionInfo to enable > fast checking of whether a job is enqueued. > > BUG=v8:5203 > > Change-Id: I6c37972093515a27077f79594cad27e32e1a4e7c > Reviewed-on: https://chromium-review.googlesource.com/444768 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43370} TBR=rmcilroy@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Change-Id: I5d1101bdae6939378dad595b26698fe2aaaad35e Reviewed-on: https://chromium-review.googlesource.com/446357Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43372}
-
Ross McIlroy authored
Stores jobs in an IdentityMap keyed by their SharedFunctionInfo to enable fast checking of whether a job is enqueued. BUG=v8:5203 Change-Id: I6c37972093515a27077f79594cad27e32e1a4e7c Reviewed-on: https://chromium-review.googlesource.com/444768Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43370}
-
- 10 Feb, 2017 5 commits
-
-
Ross McIlroy authored
If a job was already enqueued, EnqueueAndStep would still step the job one more step. However, since it didn't take the job out of the pending_background_jobs pool, the job could get picked up by a background thread which would try to step it, but it the job is now at a step which can't be run on the background. BUG=v8:5203,chromium:685515 Change-Id: I2cee2a33625ba455aca49a8037601be9ff8bb73f Reviewed-on: https://chromium-review.googlesource.com/441084 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43121}
-
rmcilroy authored
Don't block on inner function compilation before competing outer function compilation. Instead wait for the compilation to complete when the function is called. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2686673002 Cr-Commit-Position: refs/heads/master@{#43116}
-
rmcilroy authored
In order to compile eager inner functions on a background thread we need to keep the handles created during parsing and scope analysis alive until the background compilation is complete. In order to do that, we allocate the handles in a deferred handle scope and keep the deferred handles alive with a shared_ptr in the ParseInfo and CompileInfo respectively. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2650883002 Cr-Commit-Position: refs/heads/master@{#43107}
-
rmcilroy authored
Revert of [Compiler] Enable handles created during parsing and scope analysis to be deferred. (patchset #9 id:180001 of https://codereview.chromium.org/2650883002/ ) Reason for revert: Issue on arm64: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/5752 Original issue's description: > [Compiler] Enable handles created during parsing and scope analysis to be deferred. > > In order to compile eager inner functions on a background thread we need to > keep the handles created during parsing and scope analysis alive until the > background compilation is complete. In order to do that, we allocate the > handles in a deferred handle scope and keep the deferred handles alive with > a shared_ptr in the ParseInfo and CompileInfo respectively. > > BUG=v8:5203 > > Review-Url: https://codereview.chromium.org/2650883002 > Cr-Commit-Position: refs/heads/master@{#43091} > Committed: https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c2a115 TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2687973003 Cr-Commit-Position: refs/heads/master@{#43093}
-
rmcilroy authored
In order to compile eager inner functions on a background thread we need to keep the handles created during parsing and scope analysis alive until the background compilation is complete. In order to do that, we allocate the handles in a deferred handle scope and keep the deferred handles alive with a shared_ptr in the ParseInfo and CompileInfo respectively. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2650883002 Cr-Commit-Position: refs/heads/master@{#43091}
-
- 25 Jan, 2017 1 commit
-
-
rmcilroy authored
Enable enqueueing of eager inner function compilation onto the compiler dispatcher. This enables these tasks to be performed in parallel to compilation of the outer functio (only for Ignition functions). We currently synchronize to ensure all inner function compilations are complete before executing the outer function - future work will allow outer function execution to happenin parallel to inner function compilation. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2611313002 Cr-Commit-Position: refs/heads/master@{#42667}
-
- 17 Jan, 2017 2 commits
-
-
machenbach authored
Revert of [complier] Enable parallel eager inner function compilation with compiler dispatcher. (patchset #11 id:260001 of https://codereview.chromium.org/2611313002/ ) Reason for revert: Some crashes on mac: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/11982/steps/Ignition%20-%20turbofan/logs/regress-crbug-429159 https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/10966 Original issue's description: > [complier] Enable parallel eager inner function compilation with compiler dispatcher. > > Enable enqueueing of eager inner function compilation onto the compiler > dispatcher. This enables these tasks to be performed in parallel to > compilation of the outer functio (only for Ignition functions). > We currently synchronize to ensure all inner function compilations > are complete before executing the outer function - future work will > allow outer function execution to happenin parallel to inner function > compilation. > > BUG=v8:5203,v8:5215 > > Review-Url: https://codereview.chromium.org/2611313002 > Cr-Commit-Position: refs/heads/master@{#42413} > Committed: https://chromium.googlesource.com/v8/v8/+/f12661a1ece4e9c9cb8df5c2d349db960356e604 TBR=jochen@chromium.org,marja@chromium.org,mstarzinger@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2637123002 Cr-Commit-Position: refs/heads/master@{#42416}
-
rmcilroy authored
Enable enqueueing of eager inner function compilation onto the compiler dispatcher. This enables these tasks to be performed in parallel to compilation of the outer functio (only for Ignition functions). We currently synchronize to ensure all inner function compilations are complete before executing the outer function - future work will allow outer function execution to happenin parallel to inner function compilation. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2611313002 Cr-Commit-Position: refs/heads/master@{#42413}
-
- 16 Jan, 2017 1 commit
-
-
jochen authored
BUG=v8:5215 R=rmcilroy@chromium.org,hpayer@chromium.org,vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2625413004 Cr-Commit-Position: refs/heads/master@{#42361}
-
- 09 Jan, 2017 1 commit
-
-
jochen authored
If this is possible at all, we need to at least do the first step (prepare to parse). BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2610173004 Cr-Commit-Position: refs/heads/master@{#42124}
-
- 05 Jan, 2017 2 commits
-
-
jochen authored
BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2618503002 Cr-Commit-Position: refs/heads/master@{#42091}
-
jochen authored
BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2608163006 Cr-Commit-Position: refs/heads/master@{#42084}
-
- 04 Jan, 2017 1 commit
-
-
jochen authored
BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2615603002 Cr-Commit-Position: refs/heads/master@{#42068}
-
- 03 Jan, 2017 3 commits
-
-
jochen authored
Original issue's description: > Use background tasks for the compiler dispatcher > > BUG=v8:5215 > R=marja@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2606263002 > Cr-Commit-Position: refs/heads/master@{#42035} > Committed: https://chromium.googlesource.com/v8/v8/+/7a1b3a7bebbef88e72c9f7747e1930f10ee10c80 BUG=v8:5215 TBR=marja@chromium.org,vogelheim@chromium.org,rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2613483002 Cr-Commit-Position: refs/heads/master@{#42040}
-
rmcilroy authored
Revert of Use background tasks for the compiler dispatcher (patchset #5 id:80001 of https://codereview.chromium.org/2606263002/ ) Reason for revert: Causes IgnitionCompilerDispatcherTest.FinishNowWithBackgroundTask to fail. https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/11209 Original issue's description: > Use background tasks for the compiler dispatcher > > BUG=v8:5215 > R=marja@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2606263002 > Cr-Commit-Position: refs/heads/master@{#42035} > Committed: https://chromium.googlesource.com/v8/v8/+/7a1b3a7bebbef88e72c9f7747e1930f10ee10c80 TBR=marja@chromium.org,vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2614433002 Cr-Commit-Position: refs/heads/master@{#42037}
-
jochen authored
BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2606263002 Cr-Commit-Position: refs/heads/master@{#42035}
-
- 02 Jan, 2017 1 commit
-
-
jochen authored
Original issue's description: > Disable the CompilerDispatcher if we don't have idle time > > Since we can't do all steps on background threads, we need idle time to > work > > BUG=v8:5215 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2600743002 > Cr-Commit-Position: refs/heads/master@{#41944} > Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a 2d3184cbbfd6adb243e BUG=v8:5215 Review-Url: https://codereview.chromium.org/2606233002 Cr-Commit-Position: refs/heads/master@{#42009}
-
- 23 Dec, 2016 2 commits
-
-
machenbach authored
Revert of Disable the CompilerDispatcher if we don't have idle time (patchset #1 id:1 of https://codereview.chromium.org/2600743002/ ) Reason for revert: [Sheriff] Speculative revert since we got persistent timeouts on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6417 Please reland if it doesn't help. Original issue's description: > Disable the CompilerDispatcher if we don't have idle time > > Since we can't do all steps on background threads, we need idle time to > work > > BUG=v8:5215 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2600743002 > Cr-Commit-Position: refs/heads/master@{#41944} > Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a2d3184cbbfd6adb243e TBR=danno@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2600773002 Cr-Commit-Position: refs/heads/master@{#41948}
-
jochen authored
Since we can't do all steps on background threads, we need idle time to work BUG=v8:5215 R=danno@chromium.org Review-Url: https://codereview.chromium.org/2600743002 Cr-Commit-Position: refs/heads/master@{#41944}
-
- 16 Dec, 2016 1 commit
-
-
jochen authored
BUG=v8:5215 R=rmcilroy@chromium.org,marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2573493002 Cr-Commit-Position: refs/heads/master@{#41767}
-
- 12 Dec, 2016 1 commit
-
-
jochen authored
It doesn't schedule steps yet, but there are tests. BUG=v8:5215 R=rmcilroy@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2558293004 Cr-Commit-Position: refs/heads/master@{#41650}
-