- 19 Jan, 2017 1 commit
-
-
eholk authored
The IA32AddPair and IA32SubPair instructions were using an input register as a temporary value, which led to registers sometimes being clobbered when they shouldn't have been. This led to problems, for example, in calling printf to format doubles: printf("%f", 1.2345) => 0.61725 (on x86) BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5800 Review-Url: https://codereview.chromium.org/2637583002 Cr-Commit-Position: refs/heads/master@{#42486}
-
- 18 Jan, 2017 3 commits
-
-
titzer authored
R=rossberg@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2640013003 Cr-Commit-Position: refs/heads/master@{#42473}
-
rossberg authored
Makes us pass the spec's memory.wast test. R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2640453003 Cr-Commit-Position: refs/heads/master@{#42452}
-
gdeepti authored
- Currently WebAssembly.Memory.grow() assumes that it always has an instance associated with it, fix to grow and reflect new size when no instance is associated with memory object. - Correctness fixes for the js api, throw range errors instead of generic errors BUG=chromium:680938 R=bradnelson@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2638243002 Cr-Commit-Position: refs/heads/master@{#42432}
-
- 10 Jan, 2017 1 commit
-
-
ahaas authored
R=clemensh@chromium.org BUG=chromium:663994 Review-Url: https://codereview.chromium.org/2622563002 Cr-Commit-Position: refs/heads/master@{#42163}
-
- 09 Jan, 2017 1 commit
-
-
titzer authored
R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
-
- 19 Dec, 2016 1 commit
-
-
yangguo authored
The scenario here: the asm function fails asm validation, so we emit a message. In doing so, we create a JSValue wrapper for the script object that we cache on the script object. This wrapper is context-dependent and causes the code serializer to choke. R=mtrofin@chromium.org, titzer@chromium.org BUG=chromium:674446,chromium:673321 Review-Url: https://codereview.chromium.org/2586943003 Cr-Commit-Position: refs/heads/master@{#41794}
-
- 15 Dec, 2016 1 commit
-
-
mtrofin authored
Determine if the scope of the function to be serialized includes asm- wasm, and if so, bypass serialization, since we do not support it in that scenario. In this change, we do so regardless of whether the asm-wasm path was successful. This is so we keep the design simple, since the guidance to developers, moving forward, is to use wasm. BUG=643595 Review-Url: https://codereview.chromium.org/2573193002 Cr-Commit-Position: refs/heads/master@{#41704}
-
- 08 Dec, 2016 1 commit
-
-
gdeepti authored
BUG=chromium:670683 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2548223002 Cr-Commit-Position: refs/heads/master@{#41603}
-
- 22 Nov, 2016 1 commit
-
-
mtrofin authored
Previous fuzzer fix broke the case when the pending assessment came from the same block. In that case, the assessments table does not have an entry yet for the block, because we register only when we're done processing a block. BUG=667745 Review-Url: https://codereview.chromium.org/2519973004 Cr-Commit-Position: refs/heads/master@{#41193}
-
- 21 Nov, 2016 2 commits
-
-
mtrofin authored
The verifier needs to use the block and assessments in that block corresponding to a predecessor of a "pending" assessment. Not doing that causes incorrect assessments when 2 locations are swapped. BUG=665402 Review-Url: https://codereview.chromium.org/2515803002 Cr-Commit-Position: refs/heads/master@{#41159}
-
eholk authored
This fixes a bug found by the fuzzer where we would attempt to dereference a null handle if memory allocation failed. In this case, the failure was because the amount of memory requested was above V8's hardcoded limit. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741 Review-Url: https://codereview.chromium.org/2514983002 Cr-Commit-Position: refs/heads/master@{#41158}
-
- 08 Nov, 2016 1 commit
-
-
gdeepti authored
- When module bytes have a memory maximum defined, compiled module object should set maximum memory - Exported memory objects should set maximum value on the memory objects - Update tests to use declared maximum values. R=ahaas@chromium.org Review-Url: https://codereview.chromium.org/2474333003 Cr-Commit-Position: refs/heads/master@{#40820}
-
- 26 Oct, 2016 1 commit
-
-
titzer authored
R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG=chromium:575167, chromium:659591 Review-Url: https://codereview.chromium.org/2440953002 Cr-Commit-Position: refs/heads/master@{#40600}
-
- 19 Oct, 2016 2 commits
-
-
titzer authored
This CL refactors the handling of metadata associated with WebAssembly modules to reduce the duplicate marshalling of data from the C++ world to the JavaScript world. It does this by wrapping the C++ WasmModule* object in a Foreign that is rooted from the on-heap WasmCompiledModule (which is itself just a FixedArray). Upon serialization, the C++ object is ignored and the original WASM wire bytes are serialized. Upon deserialization, the C++ object is reconstituted by reparsing the bytes. This is motivated by increasing complications in implementing the JS API, in particular WebAssembly.Table, which must perform signature canonicalization across instances. Additionally, this CL implements the proper base + offset initialization behavior for tables. R=rossberg@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org,yangguo@chromium.org BUG=v8:5507, chromium:575167, chromium:657316 Review-Url: https://chromiumcodereview.appspot.com/2424623002 Cr-Commit-Position: refs/heads/master@{#40434}
-
ahaas authored
Using uint32 to store the the number of control outputs allows WebAssembly switches to have more than 2^16 case. BUG=v8:5531 TEST=mjsunit/regress/wasm/regression-5531 R=titzer@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2425983002 Cr-Commit-Position: refs/heads/master@{#40420}
-
- 13 Oct, 2016 2 commits
-
-
ahaas authored
A decoder error sets builder_ to null, which causes builder_->StackCheck to segfault. R=titzer@chromium.org TEST=mjsunit/regress/wasm/loop-stack-check Review-Url: https://codereview.chromium.org/2416873002 Cr-Commit-Position: refs/heads/master@{#40271}
-
ahaas authored
BUG=chromium:654377 TEST=mjsunit/regress/wasm/regression-654377 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2403013002 Cr-Commit-Position: refs/heads/master@{#40246}
-
- 07 Oct, 2016 1 commit
-
-
gdeepti authored
- Added gating code in the module-decoder to allow SIMD code only when it can be decoded correctly - SIMD128 values should not be exported to JS - Try/Catch should not be available in asmjs modules - Trivial fixes for S128 values BUG=chromium:648079 R=ahaas@chromium.org, titzer@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2400863003 Cr-Commit-Position: refs/heads/master@{#40067}
-
- 05 Oct, 2016 3 commits
-
-
ahaas authored
The implementation of MemorySize with RelocatableInt32Constants is problematic if MemorySize is placed close to a GrowMemory instruction in the code. The use of a runtime function guarantees that the order in which MemorySize and GrowMemory is executed is correct. R=titzer@chromium.org BUG=chromium:651961 TEST=mjsunit/regress/wasm/regression-651961 Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689 Review-Url: https://codereview.chromium.org/2386183004 Cr-Original-Commit-Position: refs/heads/master@{#39972} Cr-Commit-Position: refs/heads/master@{#39980}
-
ahaas authored
Revert of [wasm] Call a runtime function for a MemorySize instruction. (patchset #2 id:20001 of https://codereview.chromium.org/2386183004/ ) Reason for revert: Patch problem Original issue's description: > [wasm] Call a runtime function for a MemorySize instruction. > > The implementation of MemorySize with RelocatableInt32Constants is > problematic if MemorySize is placed close to a GrowMemory instruction in > the code. The use of a runtime function guarantees that the order in > which MemorySize and GrowMemory is executed is correct. > > R=titzer@chromium.org > BUG=chromium:651961 > TEST=mjsunit/regress/wasm/regression-651961 > > Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689 > Cr-Commit-Position: refs/heads/master@{#39972} TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651961 Review-Url: https://codereview.chromium.org/2391223002 Cr-Commit-Position: refs/heads/master@{#39973}
-
ahaas authored
The implementation of MemorySize with RelocatableInt32Constants is problematic if MemorySize is placed close to a GrowMemory instruction in the code. The use of a runtime function guarantees that the order in which MemorySize and GrowMemory is executed is correct. R=titzer@chromium.org BUG=chromium:651961 TEST=mjsunit/regress/wasm/regression-651961 Review-Url: https://codereview.chromium.org/2386183004 Cr-Commit-Position: refs/heads/master@{#39972}
-
- 04 Oct, 2016 1 commit
-
-
mtrofin authored
This fixes a gc stress bug. We cannot rely on an ordering of clearing of the weak cells, so we explicitly reset the weak link to the owning instance, when finalizing a compiled module. In turn, this serves as a reliable signal when GCs happen while instantiating, allowing us to correctly link the new instance. BUG=chromium:652425 Review-Url: https://codereview.chromium.org/2393443003 Cr-Commit-Position: refs/heads/master@{#39964}
-
- 29 Sep, 2016 2 commits
-
-
mtrofin authored
BUG=chromium:651070 Review-Url: https://codereview.chromium.org/2371403003 Cr-Commit-Position: refs/heads/master@{#39848}
-
mtrofin authored
The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 Review-Url: https://codereview.chromium.org/2347333002 Cr-Commit-Position: refs/heads/master@{#39845}
-
- 17 Sep, 2016 1 commit
-
-
mtrofin authored
We'd like wasm regressions to live under a subfolder of the mjsunit regression folder. BUG= Review-Url: https://codereview.chromium.org/2344373002 Cr-Commit-Position: refs/heads/master@{#39483}
-