Skip to content

V
V8
Switch branch/tag
  1. 27 Jul, 2022 1 commit
    • Anton Bikineev's avatar
      cppgc: Don't verify stack if PC is enabled. · 2746000c
      Anton Bikineev authored 
      V8 compaction, which currently runs before verification, can update
stack slots, which could lead to more false positives when we scan
compressed pointers on stack. The CL disables the stack verification if
pointer compression. The intent is to investigate if verification can be
moved before compaction.

Bug: chromium:1325007
Change-Id: Idc01df9c58bfbf338b5e95caf5f03a88593c6478
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789381
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81997}
      2746000c
  3. 10 Jun, 2022 1 commit
    • Anton Bikineev's avatar
      cppgc: Fix caged-heap reservation when pointer compression is enabled · ae41f7df
      Anton Bikineev authored 
      Currently, PageAllocator assumes that FreePages(start, size) will always
be called on the same region that was passed to AllocatePages(start,
size). This assumption is made in:
1) leak-sanitizer (LsanPageAllocator) that checks it explicitly,
2) on Windows, FreePages() calls VirtualFree() with zero-size and
   MEM_RELEASE, which causes the entire reservation to be freed.

The CL temporarily fixes the bot failures just by holding the unneeded
half and adds a TODO to return the unneded part back to the OS.

Bug: chromium:1325007
Change-Id: I2bd878876d43d693cf2138020f410ffe1615b4e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695363Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81059}
      ae41f7df
  5. 09 Jun, 2022 1 commit
  7. 13 Apr, 2022 1 commit
  9. 06 Dec, 2021 1 commit
    • Michael Lippautz's avatar
      cppgc: Do not run stack verification with TSAN · 806a207f
      Michael Lippautz authored 
      Avoid verifying the stack when running with TSAN as the TSAN runtime
changes stack contents when e.g. working with locks.

Specifically, the marker uses locks in slow path operations which
results in stack changes throughout marking. This means that the
conservative iteration in the verifier may find more objects then the
regular marker. The difference is benign as the delta of objects is
not reachable from user code but it prevents verification.

Bug: chromium:1275581
Change-Id: Ie316ab65a5b90a1b72c09966f72d61af91224091
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3317976
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78260}
      806a207f
  11. 29 Nov, 2021 3 commits
  13. 25 Oct, 2021 1 commit
  15. 16 Aug, 2021 1 commit
    • Michael Lippautz's avatar
      cppgc: Introduce cppgc_enable_verify_heap · 334d439c
      Michael Lippautz authored 
      Adds a heap verification GN arg to gate the marking verifier and live
bytes verification on. The flag may be used in future for other more
expensive checks as well.

Currently, the flag is automatically enabled in dcheck_is_on and debug
builds.

The change enables live bytes verification for the library in regular
debug builds which may flush out issues.

Bug: v8:11785
Change-Id: I0f41bc0d76ebea9f6a8c9315c947598015ee5d68
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097868
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76325}
      334d439c
  17. 28 May, 2021 1 commit
  19. 18 May, 2021 1 commit
  21. 12 May, 2021 1 commit
  23. 03 May, 2021 1 commit
  25. 29 Apr, 2021 1 commit
  27. 15 Mar, 2021 1 commit
  29. 23 Feb, 2021 1 commit
  31. 22 Oct, 2020 1 commit
  33. 21 Oct, 2020 1 commit
  35. 14 Oct, 2020 1 commit
  37. 08 Oct, 2020 1 commit
  39. 15 Sep, 2020 1 commit
  41. 02 Sep, 2020 1 commit
  43. 16 Jul, 2020 1 commit