- 13 Jun, 2016 16 commits
-
-
machenbach authored
Revert of [wasm] Refactor function name table and lookup (patchset #2 id:20001 of https://codereview.chromium.org/2057523002/ ) Reason for revert: [Sheriff] Speculative revert for flaky gc stress crashes, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6592 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6143 Original issue's description: > [wasm] Refactor function name table and lookup > > The function name table will now always be set; a CHECK will fail if > the length would exceed the integer range. > Also, the resolution of undefined function names to "<WASM UNNAMED>" is > moved over to the wasm side. > > R=titzer@chromium.org > > Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310 > Cr-Commit-Position: refs/heads/master@{#36918} TBR=titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2062793002 Cr-Commit-Position: refs/heads/master@{#36925}
-
mstarzinger authored
This moves the decision whether to optimize generator or async functions into the AstNumberingVisitor. Optimization heuristics that are based on the function source should be encapsulated in this class. R=neis@chromium.org Review-Url: https://codereview.chromium.org/2065543002 Cr-Commit-Position: refs/heads/master@{#36924}
-
cbruni authored
Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) Reason for revert: failing tests Original issue's description: > Replace all remaining Oddball checks with new function > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > The new method all take the isolate as parameter. > > BUG= > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > Cr-Commit-Position: refs/heads/master@{#36921} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2060213002 Cr-Commit-Position: refs/heads/master@{#36923}
-
mstarzinger authored
This makes the aforementioned visitation function independent of the target architecture by leveraging existing abstractions. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2060173002 Cr-Commit-Position: refs/heads/master@{#36922}
-
cbruni authored
This CL removes the IsUndefined() and Co. methods from Object and HeapObject. The new method all take the isolate as parameter. BUG= Review-Url: https://codereview.chromium.org/2043183003 Cr-Commit-Position: refs/heads/master@{#36921}
-
cbruni authored
Array.prototype.sort would not work properly on sloppy arguments of size > 2. BUG=chromium:618613 Review-Url: https://codereview.chromium.org/2051413004 Cr-Commit-Position: refs/heads/master@{#36920}
-
mvstanton authored
We'd like to track performance metrics in an automated way. This CL introduces --turbo-stats-nvp which exposes --turbo-stats information in {"name"=value} pair format. BUG= Review-Url: https://codereview.chromium.org/2053383002 Cr-Commit-Position: refs/heads/master@{#36919}
-
clemensh authored
The function name table will now always be set; a CHECK will fail if the length would exceed the integer range. Also, the resolution of undefined function names to "<WASM UNNAMED>" is moved over to the wasm side. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2057523002 Cr-Commit-Position: refs/heads/master@{#36918}
-
mstarzinger authored
This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-614727 BUG=chromium:614727 Review-Url: https://codereview.chromium.org/2054853002 Cr-Commit-Position: refs/heads/master@{#36917}
-
bmeurer authored
Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. R=yangguo@chromium.org BUG=v8:5086,v8:5095 Review-Url: https://codereview.chromium.org/2065503002 Cr-Commit-Position: refs/heads/master@{#36916}
-
ishell authored
Review-Url: https://codereview.chromium.org/2033423002 Cr-Commit-Position: refs/heads/master@{#36915}
-
bmeurer authored
Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). Drive-by-fix: Add some more test coverage for the log function. R=yangguo@chromium.org BUG=v8:5086,v8:5092 Review-Url: https://codereview.chromium.org/2060743002 Cr-Commit-Position: refs/heads/master@{#36914}
-
bmeurer authored
Instead of manually adopting the ancient fdlibm sources, import the msun versions from FreeBSD instead, which were already adopted to ANSI C. Still under the same copyright. R=yangguo@chromium.org BUG=v8:5065,v8:5086 Review-Url: https://codereview.chromium.org/2065473002 Cr-Commit-Position: refs/heads/master@{#36913}
-
mtrofin authored
We were able to achieve our goals for register allocation independent of the allocation algorithm. Performance data so far is inconclusive re. the value of the Greedy algorithm, compared to the particular Linear Scan implementation we're currently using, and the performance measurement techniques we currently use are too imprecise to help with this matter. Retiring the algorithm to lower maintenance and evolution cost (e.g. lower cost of adding aliasing support). Once we improve benchmarking stability, and establish a suite sensitive enough for codegen improvement studies, we may revive the algorithm, should the need arise. BUG= Review-Url: https://codereview.chromium.org/2060673002 Cr-Commit-Position: refs/heads/master@{#36912}
-
mtrofin authored
MemoryOperands, on IA32. This needed to be fixed so that we can compile wasm code before creating instances, since the compiled code needs to be patched up for memory and globals references. This surfaces in asm-to-wasm scenarios. Added testing (rather, enhanced existing tests). Note patch#1 where we fail on ia32, and patch#2 with the fix. BUG=v8:5072 Review-Url: https://codereview.chromium.org/2061583002 Cr-Commit-Position: refs/heads/master@{#36911}
-
bmeurer authored
Revert of Add a trace-event for each runtime-stats timer (patchset #6 id:100001 of https://codereview.chromium.org/2052523002/ ) Reason for revert: Seems to break TSAN, see http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10057 Original issue's description: > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > BUG=v8:5089 > > Committed: https://crrev.com/44ec143f26769bd103662643bfeafc7d0834cc90 > Cr-Commit-Position: refs/heads/master@{#36909} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2064553002 Cr-Commit-Position: refs/heads/master@{#36910}
-
- 12 Jun, 2016 2 commits
-
-
fmeawad authored
The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. BUG=v8:5089 Review-Url: https://codereview.chromium.org/2052523002 Cr-Commit-Position: refs/heads/master@{#36909}
-
v8-autoroll authored
Rolling v8/build to ea70305807f935b36a930586aa08c66bfc6fbf8d Rolling v8/tools/mb to 649b5791b19e4ed3df0c5542b23950d34ca8f3e7 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2063593002 Cr-Commit-Position: refs/heads/master@{#36908}
-
- 11 Jun, 2016 3 commits
-
-
peria authored
It is expected that temporarily used strings die while they are in new heap. So we can avoid to pay a heavy cost to externalize them. If they are used for times, externalization will happen when they move to an old heap. BUG=chrmoium:606093 Review-Url: https://codereview.chromium.org/2046933002 Cr-Commit-Position: refs/heads/master@{#36907}
-
v8-autoroll authored
Rolling v8/build to e3d91384eb1f9ee5d3a26ad790f87fc51f3cfc61 Rolling v8/tools/clang to 7f07c3fce21f45df52cf39f0f52277d19b7e3573 Rolling v8/tools/mb to ad1b97c34985d6c464b5b74e75c7c9ec9716fec2 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2057403004 Cr-Commit-Position: refs/heads/master@{#36906}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2053393004 Cr-Commit-Position: refs/heads/master@{#36905}
-
- 10 Jun, 2016 19 commits
-
-
jyan authored
Port c8ac0d86 Original commit message: Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2060483002 Cr-Commit-Position: refs/heads/master@{#36904}
-
littledan authored
This patch adds a test for async/await analogous to a previous Promise test. It also fixes a typo in promise.js and makes a previous Promise test more correct by ensuring that all assertions run before completion, fixing the test expectations for the real result (which seems correct). BUG=v8:4483 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2037653002 Cr-Commit-Position: refs/heads/master@{#36903}
-
jyan authored
Port 757221e5 Original commit message: Neither globals nor lookup slots can be hole-initialized anymore, thus removing some dead code from the code generators and runtime-scopes. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2060473002 Cr-Commit-Position: refs/heads/master@{#36902}
-
bjaideep authored
Port c8ac0d86 Original commit message: Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/2057253002 Cr-Commit-Position: refs/heads/master@{#36901}
-
bjaideep authored
Port 2fd55667 Original commit message: We ported hashmap.h into libsampler as a workaround before, so the main focus of this patch is to reduce code duplication. This patch moves the hashmap into src/base as well as creates DefaultAllocationPolicy using malloc and free. R=lpy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5050 LOG=N Review-Url: https://codereview.chromium.org/2057263002 Cr-Commit-Position: refs/heads/master@{#36900}
-
bjaideep authored
Port 757221e5 Original commit message: Neither globals nor lookup slots can be hole-initialized anymore, thus removing some dead code from the code generators and runtime-scopes. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2061443002 Cr-Commit-Position: refs/heads/master@{#36899}
-
alph authored
Review-Url: https://codereview.chromium.org/2047243002 Cr-Commit-Position: refs/heads/master@{#36898}
-
nikolaos authored
This patch attempts to reduce the (stack) memory footprint of expression classifiers. Instead of keeping space in each classifier for all possible error messages that will (potentially) be reported, if an expression turns out to be a pattern or a non-pattern, such error messages are placed in a list shared by the FunctionState and each classifier keeps a couple of indices in this list. This requires that classifiers are used strictly in a stack-based fashion, which is also in line with my previous patch for revisiting non-pattern rewriting. R=adamk@chromium.org BUG=chromium:528697 Review-Url: https://codereview.chromium.org/1708193003 Cr-Commit-Position: refs/heads/master@{#36897}
-
neis authored
In commit b3bfc0bd, I corrected the source position of yield-exceptions by not setting the "return position" on returns that correspond to yields. It turns out that this caused a bug with debug stepping. The proper fix is to keep the return position on those returns but additionally attach the yield's source position to the Throw emitted in VisitYield. R=rmcilroy@chromium.org, yangguo@chromium.org BUG=v8:4907 Review-Url: https://codereview.chromium.org/2051783002 Cr-Commit-Position: refs/heads/master@{#36896}
-
neis authored
R=mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2056283002 Cr-Commit-Position: refs/heads/master@{#36895}
-
ulan authored
after the first GC if time allows and there is memory to be freed. BUG=chromium:618958 LOG=NO Review-Url: https://codereview.chromium.org/2057103002 Cr-Commit-Position: refs/heads/master@{#36894}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2058003002 Cr-Commit-Position: refs/heads/master@{#36893}
-
ahaas authored
This CL sets the default value of the flag wasm_num_compilation_tasks to 10. The actual number of compilation tasks is the minimum of the flag value and V8::GetCurrentPlatform()->NumberOfAvailableBackgroundThreads(), which is 8 on my machine. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2054093002 Cr-Commit-Position: refs/heads/master@{#36892}
-
jkummerow authored
BUG=chromium:618845 Review-Url: https://codereview.chromium.org/2058063002 Cr-Commit-Position: refs/heads/master@{#36891}
-
yangguo authored
R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2052433003 Cr-Commit-Position: refs/heads/master@{#36890}
-
oth authored
TBR=rmcilroy@chromium.org BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2056243002 Cr-Commit-Position: refs/heads/master@{#36889}
-
danno authored
Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/2024253002 Cr-Commit-Position: refs/heads/master@{#36888}
-
yangguo authored
R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2051043003 Cr-Commit-Position: refs/heads/master@{#36887}
-
jarin authored
TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2057063002 Cr-Commit-Position: refs/heads/master@{#36886}
-