Skip to content

V
V8
Switch branch/tag
  1. 02 Jun, 2015 1 commit
  3. 26 May, 2015 1 commit
    • erikcorry's avatar
      Move hash code from hidden string to a private symbol · eca5b5d7
      erikcorry authored 
      * Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code.  The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++.  Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.

Performance figures are in the comments to the code review.  Summary: Most of js-perf-test/Collections is neutral.  Set and Map with object keys are 40-50% better.  WeakMap is -5% and WeakSet is +9%.  After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.

In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this.  Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately).  With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.

In a similar vein we could give the magic zero hash code to the hash code
symbol.  Then when we look up the hash code we would sometimes see the table
with all the hidden properties.  This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it.  I'd be loath to bring it back.  On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.

One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS.  I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.

R=adamk@chromium.org, verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1149863005

Cr-Commit-Position: refs/heads/master@{#28622}
      eca5b5d7
  5. 29 Apr, 2015 1 commit
  7. 21 Apr, 2015 1 commit
  9. 20 Apr, 2015 1 commit
  11. 10 Apr, 2015 1 commit
  13. 07 Apr, 2015 1 commit
  15. 24 Feb, 2015 1 commit
  17. 11 Feb, 2015 1 commit
  19. 05 Feb, 2015 1 commit
  21. 16 Jan, 2015 1 commit
  23. 13 Jan, 2015 1 commit
  25. 18 Dec, 2014 1 commit
  27. 05 Nov, 2014 1 commit
  29. 27 Oct, 2014 1 commit
  31. 20 Oct, 2014 2 commits
  33. 10 Oct, 2014 1 commit
  35. 07 Oct, 2014 1 commit
  37. 02 Oct, 2014 1 commit
  39. 22 Sep, 2014 1 commit
    • svenpanne@chromium.org's avatar
      Further improve deopt reason output. · 73844675
      svenpanne@chromium.org authored 
      * Make the detailed deopt reason mandatory on x64, other platforms
  will follow in separate CLs.

* Extracted and improved jump table entry sharing logic: When
  --trace-deopt is on, we get separate entries for different deopt
  reasons. This enables us to distinguish the several reasons single
  instructions can have.

* Don't emit superfluous jump table comments: The bailout ID is still
  visible, and the jump table entry number is not interesting (but
  easy to determine if really needed).

* Unify the internal name of the jump table member across platforms.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/595513002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      73844675
  41. 15 Sep, 2014 1 commit
  43. 12 Sep, 2014 2 commits
  45. 11 Sep, 2014 1 commit
  47. 10 Sep, 2014 1 commit
  49. 08 Sep, 2014 2 commits
  51. 02 Sep, 2014 1 commit
  53. 06 Aug, 2014 1 commit
  55. 04 Aug, 2014 1 commit
  57. 29 Jul, 2014 1 commit
  59. 11 Jul, 2014 1 commit
  61. 03 Jul, 2014 1 commit
  63. 30 Jun, 2014 1 commit
  65. 24 Jun, 2014 2 commits
  67. 18 Jun, 2014 1 commit
  69. 17 Jun, 2014 1 commit
  71. 13 Jun, 2014 1 commit