Commits · 50be4425154a916d54b21b505aa35f77ccf6d8ba · Linshizhi / V8

11 Jun, 2015 3 commits

Revert of Revert of Remove GetAttributes from the mix to avoid another virtual... · 360e0204

verwaest authored 9 years ago

Revert of Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/)

Reason for revert:
Reland, this didn't break anything.

Original issue's description:
> Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/)
>
> Reason for revert:
> It broke webkit_unit_tests
>
> Original issue's description:
> > Remove GetAttributes from the mix to avoid another virtual dispatch.
> >
> > BUG=chromium:495949,v8:4137
> > LOG=n
> >
> > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
> > Cr-Commit-Position: refs/heads/master@{#28953}
>
> TBR=verwaest@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:495949,v8:4137
>
> Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440
> Cr-Commit-Position: refs/heads/master@{#28958}

TBR=ishell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:495949,v8:4137

Review URL: https://codereview.chromium.org/1182603002

Cr-Commit-Position: refs/heads/master@{#28966}

360e0204

Revert of Remove GetAttributes from the mix to avoid another virtual dispatch.... · ae639d2a

ishell authored 9 years ago

Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/)

Reason for revert:
It broke webkit_unit_tests

Original issue's description:
> Remove GetAttributes from the mix to avoid another virtual dispatch.
>
> BUG=chromium:495949,v8:4137
> LOG=n
>
> Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
> Cr-Commit-Position: refs/heads/master@{#28953}

TBR=verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:495949,v8:4137

Review URL: https://codereview.chromium.org/1179933002

Cr-Commit-Position: refs/heads/master@{#28958}

ae639d2a

Remove GetAttributes from the mix to avoid another virtual dispatch. · 2269b8b5

verwaest authored 9 years ago

BUG=chromium:495949,v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1175973002

Cr-Commit-Position: refs/heads/master@{#28953}

2269b8b5

08 Jun, 2015 1 commit

Micro-optimize not-found for elements on objects with empty_fixed_array backing store · 29b572d4

verwaest authored 9 years ago

BUG=chromium:495949
LOG=n

Review URL: https://codereview.chromium.org/1163033004

Cr-Commit-Position: refs/heads/master@{#28831}

29b572d4

02 Jun, 2015 3 commits

Use LookupIterator for GetElementAttributes and friends · 823682ea

verwaest authored 9 years ago

BUG=v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1153583006

Cr-Commit-Position: refs/heads/master@{#28757}

823682ea

Use GetProperty for getting elements. · 2fb894fa

verwaest authored 9 years ago

This also fixes issues with
- kMaxUint32 being a valid length but not index cornercases
- exotic integer objects masking "exotic indexes" even though its in the prototype chain
- concating of holey sloppy arguments

BUG=v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1159433003

Cr-Commit-Position: refs/heads/master@{#28754}

2fb894fa

GlobalDictionary now stores PropertyDetails in PropertyCells. · 1f24c38b

ishell authored 9 years ago

BUG=

Review URL: https://codereview.chromium.org/1156993018

Cr-Commit-Position: refs/heads/master@{#28752}

1f24c38b

01 Jun, 2015 1 commit
- Starting using GlobalDictionary for global objects instead of NameDictionary. · 144be2c4
  ishell authored 9 years ago
```
Review URL: https://codereview.chromium.org/1165603002

Cr-Commit-Position: refs/heads/master@{#28737}
```
  144be2c4
21 May, 2015 1 commit

Start adding support for elements to the LookupIterator · 16484824

verwaest authored 9 years ago

BUG=

Review URL: https://codereview.chromium.org/1144883002

Cr-Commit-Position: refs/heads/master@{#28546}

16484824

19 Mar, 2015 1 commit

Add debug checks to catch PropertyCell::cast failures. · 87af6018

yangguo authored 9 years ago

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/1025433002

Cr-Commit-Position: refs/heads/master@{#27309}

87af6018

18 Mar, 2015 1 commit

add interceptors which do not mask existing properties · 0880d4da

dcarney authored 9 years ago

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/962613002

Cr-Commit-Position: refs/heads/master@{#27271}

0880d4da

12 Mar, 2015 1 commit

remove DeletedField from PropertyDetails · 2d3311b8

dcarney authored 9 years ago

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/1002703002

Cr-Commit-Position: refs/heads/master@{#27166}

2d3311b8

10 Mar, 2015 1 commit

handle the special snowflakes that are Integer Indexed Exotic objects · 040225a3

dcarney authored 9 years ago

the implementation doesn't yet throw on strict mode assignment

BUG=

Review URL: https://codereview.chromium.org/992913002

Cr-Commit-Position: refs/heads/master@{#27121}

040225a3

26 Feb, 2015 1 commit

Don't perform access checks for internally used properties · 1e0c067d

verwaest authored 10 years ago

BUG=
TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/956283003

Cr-Commit-Position: refs/heads/master@{#26878}

1e0c067d

19 Jan, 2015 1 commit

Massive renaming of PropertyType values and other implied stuff. · 33994b4a

ishell authored 10 years ago

PropertyKind:
  DATA -> kData
  ACCESSOR -> kAccessor

PropertyType:
  FIELD -> DATA
  CONSTANT -> DATA_CONSTANT
  ACCESSOR_FIELD -> ACCESSOR
  CALLBACKS -> ACCESSOR_CONSTANT

PropertyLocation:
  IN_OBJECT -> kField
  IN_DESCRIPTOR -> kDescriptor

StoreMode:
  FORCE_IN_OBJECT -> FORCE_FIELD

FieldDescriptor -> DataDescriptor
ConstantDescriptor -> DataConstantDescriptor
CallbacksDescriptor -> AccessorConstantDescriptor

Review URL: https://codereview.chromium.org/856503002

Cr-Commit-Position: refs/heads/master@{#26146}

33994b4a

16 Dec, 2014 1 commit

Introduced PropertyType ACCESSOR_FIELD. · 08146dc0

ishell authored 10 years ago

Review URL: https://codereview.chromium.org/805453002

Cr-Commit-Position: refs/heads/master@{#25842}

08146dc0

19 Nov, 2014 1 commit

PropertyDetails cleanup: NORMAL property type merged with FIELD. · f3d1888f

ishell authored 10 years ago

First step towards replacing PropertyType with two enums: {DATA,ACCESSOR} x {CONST,WRITABLE}.

Review URL: https://codereview.chromium.org/733253004

Cr-Commit-Position: refs/heads/master@{#25417}

f3d1888f

16 Sep, 2014 1 commit

Simplify the LookupIterator · 7d90f7e9

verwaest@chromium.org authored 10 years ago

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/570293002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23975 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d90f7e9

04 Sep, 2014 2 commits

Get rid of special property_encoding flag on the LookupIterator · 9f57d626

verwaest@chromium.org authored 10 years ago

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/539083002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f57d626

Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers · 3ef09440

verwaest@chromium.org authored 10 years ago

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/540903002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23692 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ef09440

03 Sep, 2014 1 commit

Never skip access checks in the lookup iterator · 5941bb4e

verwaest@chromium.org authored 10 years ago

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/536943002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5941bb4e

25 Aug, 2014 2 commits

Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals · 46ac7c2c

verwaest@chromium.org authored 10 years ago

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/502903002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

46ac7c2c

Clean up LookupIterator::Configuration naming · 01cfeb12

verwaest@chromium.org authored 10 years ago

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/503663003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23349 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

01cfeb12

22 Aug, 2014 1 commit

Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 · 3baab5e6

verwaest@chromium.org authored 10 years ago

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/478043006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23305 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3baab5e6

21 Aug, 2014 1 commit

Get rid of all non-IC uses of LookupOwnRealNamedProperty · 2d2396a8

verwaest@chromium.org authored 10 years ago

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/491023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23262 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2d2396a8

19 Aug, 2014 1 commit

Use LookupIterator to transition to accessors · 1a8bed47

verwaest@chromium.org authored 10 years ago

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/490533002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a8bed47

05 Aug, 2014 1 commit

Inline LookupInHolder and NextHolder · 62714a58

verwaest@chromium.org authored 10 years ago

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/437513002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22853 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62714a58