1. 23 Jun, 2017 1 commit
  2. 15 May, 2017 1 commit
  3. 29 Mar, 2017 1 commit
    • Leszek Swirski's avatar
      [turbolizer] Use textContent to set code view · 7b8d8e9a
      Leszek Swirski authored
      Previously code view was set using innerHTML. This would cause problems
      for html characters in the code -- in particular, '<' without a space
      after it would start new HTML tags, and the code following it wouldn't
      be visible.
      
      Now, the source text is set using textContent, which doesn't parse the
      value as HTML and implicitly escapes any HTML characters in the code.
      
      Change-Id: I612a18c37bbb4da6a87063bb39d7f7123a3c4c0d
      Reviewed-on: https://chromium-review.googlesource.com/461826Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#44233}
      7b8d8e9a
  4. 24 Nov, 2016 1 commit
  5. 07 Nov, 2016 1 commit
  6. 14 Sep, 2016 1 commit
  7. 08 Sep, 2016 1 commit
  8. 11 Aug, 2016 1 commit
  9. 10 Aug, 2016 4 commits
  10. 09 Aug, 2016 2 commits
  11. 08 Aug, 2016 1 commit
  12. 28 Jul, 2016 2 commits
    • Alexander.Gilday2's avatar
      [turbolizer] Fixed naming of turbolizer perf script. · 6e01fe20
      Alexander.Gilday2 authored
      Change was meant to be in previous patch but was accidentally reverted.
      README.md updated with new filename, also.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2184223005
      Cr-Commit-Position: refs/heads/master@{#38134}
      6e01fe20
    • Alexander.Gilday2's avatar
      [turbolizer] Add support for showing perf profiling information. · 286e2b14
      Alexander.Gilday2 authored
      perf-turbo.py merges a perf data file and a turbofan trace file into a
      single json object which can then be piped to a file and uploaded to
      turbolizer to display the profiling data in the disassembly. With the
      changes, turbolizer now shows the event counts for instruction in
      percentage form and with heatmap-stype colouring. Multiple different
      events can be recorded at once with a new drop-down menu to select which
      event to view the counts of. The documentation has been updated with
      instructions. Using the script is optional and turbolizer retains
      previous functionality if a trace without profiling data is uploaded.
      
      BUG=None
      
      Review-Url: https://codereview.chromium.org/2174803002
      Cr-Commit-Position: refs/heads/master@{#38124}
      286e2b14
  13. 26 Jul, 2016 1 commit
  14. 25 Jul, 2016 5 commits
  15. 15 Jul, 2016 1 commit
    • bgeron's avatar
      [turbolizer] Show a label with a shorter parameter for some opcodes. · feb93dd6
      bgeron authored
      With this patch, every node in turbo-*.json has an opcode, a title, and
      a label. The label field is new; the opcode and title were already
      there. The title is for the mouseover text. The label is what will be
      displayed in the graph view, unless it's too long, in which case only
      the opcode will be displayed. (This is similar to the preexisting
      behaviour of putting titles in labels, except that the titles were
      rarely short enough to fit in a label.)
      
      With this patch, the labels generated are in practice the same as the
      titles we had before, except for LoadField and StoreField, which will be
      rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the
      offset).
      
      This diff adds an overloadable method
      
          virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity)
      
      for each type T to Operator1. Its default implementation just uses
      operator<<(ostream&, T const&) and adds square brackets around it, but
      it is overridden for FieldAccess to print "[+432]" in the example case.
      
      BUG=
      R=jarin,danno
      
      Review-Url: https://codereview.chromium.org/2093013002
      Cr-Commit-Position: refs/heads/master@{#37795}
      feb93dd6
  16. 11 Jul, 2016 1 commit
    • Alexander.Gilday2's avatar
      [turbolizer] Improve code comments in disassembly · 7f162dbc
      Alexander.Gilday2 authored
      This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler).
      
      Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker.
      
      Review-Url: https://codereview.chromium.org/2133663002
      Cr-Commit-Position: refs/heads/master@{#37627}
      7f162dbc
  17. 22 Jun, 2016 1 commit
  18. 21 Jun, 2016 1 commit
  19. 13 Jun, 2016 2 commits
    • danno's avatar
      [turbolizer]: Fix bugs · deb67d7d
      danno authored
      * The default text (placeholder) in the search box is now present.
      * All key events handled by turbolizer are not passed through to Chrome.
      
      Review-Url: https://codereview.chromium.org/2061713002
      Cr-Commit-Position: refs/heads/master@{#36936}
      deb67d7d
    • danno's avatar
      [turbolizer] Features and bug-fixes · e52907f8
      danno authored
      Fix bugs and add a few small useful features:
      
      * Fix Schedule view to properly parse schedule output and respond to switching
        back to graph views.
      * Add shorcuts for showing edges of selected nodes.
        - 'i' shows all inputs
        - 'o' shows all outputs
        - '1'-'9' shows all nodes nth input where 1 <= n <= 9
        - 'c' shows all control inputs
        - 'e' shows all effect inputs
      * Holding the control key down when using a edge-showing shortcut toggles edge
        state rather the just showing.
      * 'a' selects all nodes in graph view.
      * Node selection is preserved between graph views and Schedule views.
      * Holding control key down when using regular expression search shows currently
        hidden nodes that match the regex search.
      * Pane expansion buttons now respond to clicks in entire button area.
      * Default text in regex search box makes searching more discoverable.
      
      Review-Url: https://codereview.chromium.org/2059193002
      Cr-Commit-Position: refs/heads/master@{#36932}
      e52907f8
  20. 19 May, 2016 1 commit