1. 20 Nov, 2018 2 commits
  2. 19 Nov, 2018 3 commits
  3. 16 Nov, 2018 5 commits
  4. 15 Nov, 2018 10 commits
    • Peter Marshall's avatar
      [cpu-profiler] Fix flaky MultipleIsolates test · 8f4c5abf
      Peter Marshall authored
      This test is only flaky because the js code being profiled causes a
      'fast-c-call' which is a call from JS to C without an exit frame.
      
      The profiler stumbles on these and reads the stack of C++ frames when
      it shouldn't, causing ASAN errors. This is not actually related to
      the multiple isolates, so I'm changing the test to profile different
      JS code that does not cause these types of calls. There is already a
      test for fast-c-calls - NativeFrameStackTrace (which currently fails).
      
      Bug: v8:8464
      Change-Id: I32818f0894e5680cf5a39779a2779eda36dfe9f1
      Reviewed-on: https://chromium-review.googlesource.com/c/1337571
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57547}
      8f4c5abf
    • Jakob Gruber's avatar
      Reland "[snapshot] Emit the embedded blob as assembly instead of inline assembly" · bd8ed720
      Jakob Gruber authored
      This is a reland of 0b13f0f5
      
      Original change's description:
      > [snapshot] Emit the embedded blob as assembly instead of inline assembly
      >
      > The motivation behind this is that MSVC doesn't support inline assembly
      > on x64. Emitting the embedded blob as a plain assembly file will give us
      > MSVC support (and possibly faster compilation times as a side-effect).
      >
      > Bug: v8:6666,v8:8349
      > Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1329205
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57524}
      
      Tbr: yangguo@chromium.org,mvstanton@chromium.org
      Bug: v8:6666, v8:8349
      Change-Id: Ib35696b60a9cd01bc2edf459c8e8d84716e3438d
      Reviewed-on: https://chromium-review.googlesource.com/c/1337733Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57546}
      bd8ed720
    • Jakob Gruber's avatar
      Reland "[builtins] Support embedded builtins in nosnapshot builds" · e1044d10
      Jakob Gruber authored
      This is a reland of bf2f0a02
      
      Original change's description:
      > [builtins] Support embedded builtins in nosnapshot builds
      >
      > This CL adds support for embedded builtins in nosnap builds by creating
      > and setting an 'embedded blob' after builtin generation. Unlike
      > snapshot builds, the blob is not embedded into the .text section but
      > located on the C++ heap.
      >
      > This makes nosnap builds more consistent with mksnapshot, and allows us
      > to simplify there and in serializer cctests.
      >
      > Complications arise from the different workflows we need to support:
      >
      > 1. the standard mksnapshot build process,
      > 2. nosnap builds (which reuse the blob created by the first Isolate),
      > 2. and tests with various complicated serialization workflows.
      >
      > To cover all of these cases, this CL introduces two knobs to twiddle:
      >
      > 1. A 'sticky' embedded blob which overrides compiled-in default
      >    embedded blobs at Isolate setup.
      > 2. The blob lifecycle can be managed manually or through refcounting.
      >
      > These are described in more detail in isolate.cc.
      >
      > Tbr: ulan@chromium.org
      > Bug: v8:6666, v8:8350
      > Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d
      > Reviewed-on: https://chromium-review.googlesource.com/c/1310195
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57523}
      
      Tbr: ulan@chromium.org,yangguo@chromium.org
      Bug: v8:6666, v8:8350
      Change-Id: I13b523c9e7406b39a3cd28465c06f17f1744a738
      Reviewed-on: https://chromium-review.googlesource.com/c/1337578
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57540}
      e1044d10
    • Toon Verwaest's avatar
      [parser] Better separate scope_info-backed lookup from other lookup · 11a10861
      Toon Verwaest authored
      Change-Id: Id81b028629d552e2f3ebbab8bc3ab1f0e9cff3fb
      Reviewed-on: https://chromium-review.googlesource.com/c/1337572Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57537}
      11a10861
    • Ross McIlroy's avatar
      [Compiler] Ensure TurboFan holds onto BytecodeArray to keep it alive. · fed1364a
      Ross McIlroy authored
      With Bytecode flushing, the a SharedFunctionInfo's bytecode might be flushed
      while the compiler is expecting it to still exist. Rather than continually
      getting the bytecode from the SFI, instead bottleneck the points where we get
      BytecodeArray from SFIs and maintain an explicit strong reference to the
      BytecodeArray from that point onwards to prevent flushing.
      
      BUG=v8:8395
      
      Change-Id: I6a18adec99402838690971eb37ee0617cdc15920
      Reviewed-on: https://chromium-review.googlesource.com/c/1309763
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57536}
      fed1364a
    • Jakob Gruber's avatar
      Revert "[builtins] Support embedded builtins in nosnapshot builds" · 856be9c2
      Jakob Gruber authored
      This reverts commit bf2f0a02.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21753
      
      Original change's description:
      > [builtins] Support embedded builtins in nosnapshot builds
      > 
      > This CL adds support for embedded builtins in nosnap builds by creating
      > and setting an 'embedded blob' after builtin generation. Unlike
      > snapshot builds, the blob is not embedded into the .text section but
      > located on the C++ heap.
      > 
      > This makes nosnap builds more consistent with mksnapshot, and allows us
      > to simplify there and in serializer cctests.
      > 
      > Complications arise from the different workflows we need to support:
      > 
      > 1. the standard mksnapshot build process,
      > 2. nosnap builds (which reuse the blob created by the first Isolate),
      > 2. and tests with various complicated serialization workflows.
      > 
      > To cover all of these cases, this CL introduces two knobs to twiddle:
      > 
      > 1. A 'sticky' embedded blob which overrides compiled-in default
      >    embedded blobs at Isolate setup.
      > 2. The blob lifecycle can be managed manually or through refcounting.
      > 
      > These are described in more detail in isolate.cc.
      > 
      > Tbr: ulan@chromium.org
      > Bug: v8:6666, v8:8350
      > Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d
      > Reviewed-on: https://chromium-review.googlesource.com/c/1310195
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57523}
      
      TBR=ulan@chromium.org,yangguo@chromium.org,jgruber@chromium.org
      
      Change-Id: I6e35a0cb7186fb50f1012f5c618fb8b48b24a813
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6666, v8:8350
      Reviewed-on: https://chromium-review.googlesource.com/c/1337577Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57529}
      856be9c2
    • Jakob Gruber's avatar
      Revert "[snapshot] Emit the embedded blob as assembly instead of inline assembly" · ec4b2be1
      Jakob Gruber authored
      This reverts commit 0b13f0f5.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20debug/17373
      
      Original change's description:
      > [snapshot] Emit the embedded blob as assembly instead of inline assembly
      > 
      > The motivation behind this is that MSVC doesn't support inline assembly
      > on x64. Emitting the embedded blob as a plain assembly file will give us
      > MSVC support (and possibly faster compilation times as a side-effect).
      > 
      > Bug: v8:6666,v8:8349
      > Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1329205
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57524}
      
      TBR=yangguo@chromium.org,mvstanton@chromium.org,jgruber@chromium.org
      
      Change-Id: I35f7763f86b4de01e74827a95706b969b43af55e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6666, v8:8349
      Reviewed-on: https://chromium-review.googlesource.com/c/1337574Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57528}
      ec4b2be1
    • Jakob Gruber's avatar
      [snapshot] Emit the embedded blob as assembly instead of inline assembly · 0b13f0f5
      Jakob Gruber authored
      The motivation behind this is that MSVC doesn't support inline assembly
      on x64. Emitting the embedded blob as a plain assembly file will give us
      MSVC support (and possibly faster compilation times as a side-effect).
      
      Bug: v8:6666,v8:8349
      Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2
      Reviewed-on: https://chromium-review.googlesource.com/c/1329205
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57524}
      0b13f0f5
    • Jakob Gruber's avatar
      [builtins] Support embedded builtins in nosnapshot builds · bf2f0a02
      Jakob Gruber authored
      This CL adds support for embedded builtins in nosnap builds by creating
      and setting an 'embedded blob' after builtin generation. Unlike
      snapshot builds, the blob is not embedded into the .text section but
      located on the C++ heap.
      
      This makes nosnap builds more consistent with mksnapshot, and allows us
      to simplify there and in serializer cctests.
      
      Complications arise from the different workflows we need to support:
      
      1. the standard mksnapshot build process,
      2. nosnap builds (which reuse the blob created by the first Isolate),
      2. and tests with various complicated serialization workflows.
      
      To cover all of these cases, this CL introduces two knobs to twiddle:
      
      1. A 'sticky' embedded blob which overrides compiled-in default
         embedded blobs at Isolate setup.
      2. The blob lifecycle can be managed manually or through refcounting.
      
      These are described in more detail in isolate.cc.
      
      Tbr: ulan@chromium.org
      Bug: v8:6666, v8:8350
      Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d
      Reviewed-on: https://chromium-review.googlesource.com/c/1310195Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57523}
      bf2f0a02
    • Deepti Gandluri's avatar
      [wasm] Update SIMD opcodes to match toolchain/spec · aba38b3c
      Deepti Gandluri authored
      BUG:v8:6020
      
      Change-Id: I289a43d834765635425276afb80c2361152fdcb0
      Reviewed-on: https://chromium-review.googlesource.com/c/1336113
      Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      Reviewed-by: 's avatarAseem Garg <aseemgarg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57519}
      aba38b3c
  5. 14 Nov, 2018 3 commits
  6. 13 Nov, 2018 5 commits
  7. 12 Nov, 2018 9 commits
  8. 09 Nov, 2018 3 commits