Skip to content

V
V8
Switch branch/tag
  1. 21 Aug, 2014 1 commit
  3. 20 Aug, 2014 2 commits
  5. 07 Aug, 2014 2 commits
  7. 06 Aug, 2014 3 commits
  9. 05 Aug, 2014 2 commits
  11. 04 Aug, 2014 1 commit
  13. 01 Aug, 2014 2 commits
  15. 22 Jul, 2014 3 commits
  17. 16 Jul, 2014 1 commit
  19. 17 Jun, 2014 1 commit
  21. 22 May, 2014 1 commit
  23. 15 May, 2014 1 commit
  25. 06 May, 2014 1 commit
  27. 02 May, 2014 1 commit
  29. 29 Apr, 2014 1 commit
  31. 25 Apr, 2014 1 commit
  33. 02 Apr, 2014 2 commits
  35. 21 Mar, 2014 1 commit
  37. 18 Mar, 2014 1 commit
  39. 17 Mar, 2014 2 commits
  41. 13 Mar, 2014 1 commit
  43. 11 Mar, 2014 1 commit
  45. 10 Mar, 2014 1 commit
  47. 08 Mar, 2014 1 commit
  49. 12 Feb, 2014 1 commit
  51. 10 Feb, 2014 1 commit
  53. 05 Feb, 2014 1 commit
    • marja@chromium.org's avatar
      Make strict more error messages about "eval" and "arguments" less specific. · 81504642
      marja@chromium.org authored 
      We used to have error messages which provide context, like "Variable name may
not be eval or arguments in strict mode", but for other illegal words we only
have non-context specific error messages like "Unexpected reserved word".

Providing the context makes the code unnecessarily complex, since every
individual place must remember to check for eval or arguments. This CL produces
a unified error message ("Unexpected eval or arguments in strict mode"), and puts
the error reporting to (Pre)Parser::ParseIdentifier.

Notes:

- The module feature is so experimental, that I decided to not allow "eval" or
"arguments" as module-related identifiers in the strict mode (even though this
check wasn't there before).

- Unfortunately, there were some inconsistencies, since it was the
responsibility of the caller of ParseIdentifier to check "eval" and "arguments"
and some places didn't have the check for no good reason. This CL is supposed to
keep backward compatibility and *not* introduce any new errors.

- ECMA allows "eval" and "arguments" as labels even in strict mode. (Syntax:
"LabelledStatement: Identifier : Statement", and no strict mode restrictions on
Identifier are listed.)

- Tests which compare error message strings will fail, and need to be updated.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/152813005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      81504642
  55. 04 Feb, 2014 1 commit
  57. 31 Jan, 2014 2 commits