- 08 Jun, 2022 1 commit
-
-
Samuel Groß authored
If enabled, a signal handler is installed which intercepts memory access violations (e.g. SIGSEGV) and checks whether they occurred inside the sandbox address space, in which case the process is terminated cleanly as this does not represent a (security) issue with the sandbox. However, if the access violation occurred outside the sandbox, the access violation is forwarded to the original signal handler. The filter can be enabled in d8 by specifying --enable-sandbox-crash-filter. Bug: v8:12878 Change-Id: If9d76267e90ee79ee81ab793d7774afed6226b7c Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688408Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80999}
-
- 25 May, 2022 1 commit
-
-
Maya Lekova authored
The generated code checks if the receiver is a JS_API_OBJECT and if the receiver requires an access check, and if not it lowers the call to an API call. We also add compilation dependencies on the protector cell to deopt if our invariants change. (Note - the actual invalidation of these cells will be implemented in a follow up CL) Bug: v8:11321 Change-Id: I15722f1e5fac7176e292da4a35186e4609636aba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719563 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80748}
-
- 13 May, 2022 1 commit
-
-
Clemens Backes authored
Now that we require C++17 support, we can just use the standard static_assert without message, instead of our STATIC_ASSERT macro. R=leszeks@chromium.org Bug: v8:12425 Change-Id: I1d4e39c310b533bcd3a4af33d027827e6c083afe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647353Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80524}
-
- 02 May, 2022 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: Ifec7ff76b5407d61f339d298a6f2eabbe77b7731 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3613398Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80294}
-
- 27 Apr, 2022 1 commit
-
-
Camillo Bruni authored
Change-Id: Ib94979f4cf7f52a1544f2b3c0d51c0266a4fa14c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3586985Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80223}
-
- 13 Apr, 2022 1 commit
-
-
Jakob Kummerow authored
This makes the installation sequence of WebAssembly.Tag slightly shorter, slightly faster, slightly cleaner in corner-case semantics, and slightly better documented. To allow testing this code, Isolate::InstallConditionalFeatures is exposed as d8.test.installConditionalFeatures(). Fixed: chromium:1314616 Change-Id: I44285e398b8797e0e7d2d8c782cecec3ba68a503 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582382 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#79956}
-
- 07 Apr, 2022 1 commit
-
-
Camillo Bruni authored
- Always return a MaybeLocal<String> - Don't crash on long filenames Bug: chromium:1311923 Change-Id: I96e10337ceb32aeafafe0b73c78651a1ac38fb9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576122Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79859}
-
- 05 Apr, 2022 1 commit
-
-
Clemens Backes authored
This includes two fixes: 1. For dynamic tiering, the budget must always be reduced when jumping backwards, otherwise we might never trigger tier up, which makes the loop non-interruptible (because the tier-up check replaces the stack check). 2. The d8 worker implementation also needs to terminate the isolate via an interrupt, in addition to scheduling a task, because the worker might never return to the event queue. This CL also fixes one of the failure modes of the inspector fuzzer (see https://crbug.com/1180018). R=jkummerow@chromium.org, marja@chromium.org Bug: v8:12767, chromium:1180018 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: Ia01d1725fc14931d2ea54c4769c4ee93f866ed63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568470Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79773}
-
- 18 Mar, 2022 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I74190f2136e91107deea2c31f750a2d1a43dc18a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528502Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79531}
-
- 18 Feb, 2022 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I6a5c1cad0257157df605efb9777737d7fe40a42c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472078Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79175}
-
- 26 Jan, 2022 3 commits
-
-
Shu-yu Guo authored
This is a reland of 5320fe8d Changes since revert: - Remove stale DCHECK in deserializer Original change's description: > Reland "[string] Support shared strings in Value{Serializer,Deserializer}" > > This is a reland of 3cb4039c > > Changes since revert: > - Fix FLAG_stress_scavenge interaction with shared Isolate > - Use the shared Isolate's global handles to keep shared values > alive in transit during a postMessage > > Original change's description: > > [string] Support shared strings in Value{Serializer,Deserializer} > > > > When FLAG_shared_string_table is true, postMessaging strings will share > > instead of copy. > > > > Note that not all operations on shared strings are supported, and shared > > strings may be slower than non-shared strings for some operations. Bug: v8:12007 Change-Id: I70782978ed05558615eca03bafc4c12eba3644ca Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3417189Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78791}
-
Nico Hartmann authored
This reverts commit 5320fe8d. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/38175/overview Original change's description: > Reland "[string] Support shared strings in Value{Serializer,Deserializer}" > > This is a reland of 3cb4039c > > Changes since revert: > - Fix FLAG_stress_scavenge interaction with shared Isolate > - Use the shared Isolate's global handles to keep shared values > alive in transit during a postMessage > > Original change's description: > > [string] Support shared strings in Value{Serializer,Deserializer} > > > > When FLAG_shared_string_table is true, postMessaging strings will share > > instead of copy. > > > > Note that not all operations on shared strings are supported, and shared > > strings may be slower than non-shared strings for some operations. > > > > Bug: v8:12007 > > Change-Id: I3462128e15410d2568868143571571b3025722c1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Shu-yu Guo <syg@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#78614} > > Bug: v8:12007 > Change-Id: I5d9b99b2dac6f26d5ef046d7aec94f1a1d219419 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3389533 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78761} Bug: v8:12007 Change-Id: Ie8e54b30055324e6592562450b51d5a11e11c9d0 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416232 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78762}
-
Shu-yu Guo authored
This is a reland of 3cb4039c Changes since revert: - Fix FLAG_stress_scavenge interaction with shared Isolate - Use the shared Isolate's global handles to keep shared values alive in transit during a postMessage Original change's description: > [string] Support shared strings in Value{Serializer,Deserializer} > > When FLAG_shared_string_table is true, postMessaging strings will share > instead of copy. > > Note that not all operations on shared strings are supported, and shared > strings may be slower than non-shared strings for some operations. > > Bug: v8:12007 > Change-Id: I3462128e15410d2568868143571571b3025722c1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78614} Bug: v8:12007 Change-Id: I5d9b99b2dac6f26d5ef046d7aec94f1a1d219419 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3389533Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78761}
-
- 25 Jan, 2022 1 commit
-
-
legendecas authored
1. Expose all the functions to empty builtins. 2. Wire up the basic structure of ShadowRealm and internal slots. Bug: v8:11989 Change-Id: If7545fe18a74b2bd4b70a1a25776e41f03aaff89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195532Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chengzhong Wu <legendecas@gmail.com> Cr-Commit-Position: refs/heads/main@{#78757}
-
- 14 Jan, 2022 2 commits
-
-
Leszek Swirski authored
This reverts commit 3cb4039c. Reason for revert: TSAN failure in newly added test: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/18086/overview Original change's description: > [string] Support shared strings in Value{Serializer,Deserializer} > > When FLAG_shared_string_table is true, postMessaging strings will share > instead of copy. > > Note that not all operations on shared strings are supported, and shared > strings may be slower than non-shared strings for some operations. > > Bug: v8:12007 > Change-Id: I3462128e15410d2568868143571571b3025722c1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78614} Bug: v8:12007 Change-Id: I5bb8f9b4e9b641c6d5cb16f963e9dbc1b13ac56a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3386799 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78615}
-
Shu-yu Guo authored
When FLAG_shared_string_table is true, postMessaging strings will share instead of copy. Note that not all operations on shared strings are supported, and shared strings may be slower than non-shared strings for some operations. Bug: v8:12007 Change-Id: I3462128e15410d2568868143571571b3025722c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78614}
-
- 20 Dec, 2021 1 commit
-
-
Camillo Bruni authored
We clear the worker state in the worker thread after processing all messages (and getting the terminate signal). This could cause a race condition when interacting with the worker from the main thread. This was previously working and broke with https://crrev.com/c/3318669 - Add is_joined_ variable which is mutex guarded - Simplify Worker::State - Mutex guard task_runner_ access Bug: v8:12487 Change-Id: Ib53e5a1a636cb29db50efdb63526b0023a5ea768 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345005Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78415}
-
- 08 Dec, 2021 1 commit
-
-
Camillo Bruni authored
The explicit state_ variable is used to prevent undefined behaviour by double-joining the worker thread. Bug: chromium:1276382 Change-Id: I338cfdb4a587eb57fec5a5a28b42371584c99102 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3318669Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78300}
-
- 07 Dec, 2021 1 commit
-
-
Clemens Backes authored
Counter updates were already atomic, but reading the counter values was not. This lead to data races if one isolate called `quit` while other isolates were still running. This makes counters fully atomic, and reflects that by making the fields {std::atomic<int>}. R=mlippautz@chromium.org Bug: v8:12481, v8:12482 Change-Id: I6fc78ad6461b93c4b3e87bec052b0a67694539e3 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3320428Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78279}
-
- 06 Dec, 2021 1 commit
-
-
Clemens Backes authored
--dump-counters and --dump-counters-nvp are only functional in d8, thus they should be d8-only flags. R=mlippautz@chromium.org Bug: v8:12464 Change-Id: Ie3295990a1b4691ab95f8403ff6d9932543b03cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312275Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78247}
-
- 01 Dec, 2021 1 commit
-
-
Clemens Backes authored
This fixes data races when lazily creating counters (and populating the {counter_map_}, and when concurrently adding samples to the counters. It also ensures that the Wasm engine is stopped (via {V8::Dispose}) before printing and deleting counters, as background threads might still try to update the counters otherwise. R=mlippautz@chromium.org CC=nikolaos@chromium.org Bug: v8:12453, chromium:1275117 Change-Id: Ie6beea6cc74eea52143d12f9921597da4a250f2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308710Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78191}
-
- 05 Nov, 2021 1 commit
-
-
Camillo Bruni authored
The new callback does no longer use ScriptOrModule but rather gets the host-defined options and the referrer name as separate arguments. This brings us one step closer to deprecate ScriptOrModule and putting the host-defined options in the script context. - Add v8::Data::IsFixedArray and cast helpers - Deprecate HostImportModuleDynamicallyWithImportAssertionsCallback soon - Add Script::Run entry point that explicitly takes host-defined options (unused yet) Bug: chromium:1244145 Change-Id: I08bc92cfb3b79d840e766fb71b8d91d301f4399c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263893 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77733}
-
- 04 Nov, 2021 3 commits
-
-
Camillo Bruni authored
This is a reland of 0446ab7c Additional fix: Manually set the host-defined options on deserialised scripts in d8. Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I8ddfdba27d84c36862323ab9e1aba14b2ff932a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259539 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77716}
-
Leszek Swirski authored
This reverts commit 0446ab7c. Reason for revert: Lots of failures https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/37355/overview Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I267f4bdbd8afce81934f4e813dbe1ec09ebdc1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259538 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77705}
-
Camillo Bruni authored
d8 never checked what the actual value of the host-defined options are. We now properly very that the host-defined options is a specific object so we we don't end up accidentally ignoring a wrong options object. Drive-by-fix: - Convert %AbortJS argument to string Bug: chromium:1244145 Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77699}
-
- 11 Oct, 2021 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I16191bfa03bb9bbfb57a48015244c780e8cf30e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217190Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77311}
-
- 08 Oct, 2021 1 commit
-
-
Shu-yu Guo authored
This CL reorders the initialization scheme for shared and client Isolates such that clients attach to the shared Isolate before setting up the Heap. This is to support sharing the string table. Bug: v8:12007 Change-Id: Icb0e40cc5ed84d516c8073a70d0f769f517044c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3039264 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77307}
-
- 07 Oct, 2021 1 commit
-
-
Camillo Bruni authored
Change-Id: I2ef2314deb2384dfdca06bd46f2d3640787c2011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211579 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77281}
-
- 26 Aug, 2021 1 commit
-
-
Maya Lekova authored
This CL introduces a d8-only flag --expose-fast-api which enables the test FastCAPI object if the --turbo-fast-api-calls flag is enabled. It also disables --stress-snapshot, which is incompatible with fast calls. Bug: v8:12137 Change-Id: I01e8321726b78be660fd6554225999bfc94006c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3117485Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#76505}
-
- 25 Aug, 2021 1 commit
-
-
Samuel Groß authored
In a follow-up CL, the backing stores will, when the sandbox is enabled, be referenced from V8 objects through offsets rather than raw pointers. For that to work, all backing stores must be located inside the virtual memory cage. This CL prepares for that. Bug: chromium:1218005 Change-Id: Ibb989626ed7094bd4f02ca15464539f4e2bda90f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114136 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76486}
-
- 24 Aug, 2021 1 commit
-
-
Dan Elphick authored
This is a reland of d1b27019 Fixes include: Adding missing file to bazel build Forward-declaring classing before friend-classing them to fix win/gcc Add missing v8-isolate.h include for vtune builds Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit Bug: v8:11965 Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76460}
-
- 23 Aug, 2021 2 commits
-
-
Dan Elphick authored
This reverts commit d1b27019. Reason for revert: Broke vtune build, tsan build and possibly others Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Bug: v8:11965 Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76428}
-
Dan Elphick authored
This moves every single class/function out of include/v8.h into a separate header in include/, which v8.h then includes so that externally nothing appears to have changed. Every include of v8.h from inside v8 has been changed to a more fine-grained include. Previously inline functions defined at the bottom of v8.h would call private non-inline functions in the V8 class. Since that class is now in v8-initialization.h and is rarely included (as that would create dependency cycles), this is not possible and so those methods have been moved out of the V8 class into the namespace v8::api_internal. None of the previous files in include/ now #include v8.h, which means if embedders were relying on this transitive dependency then it will give compile failures. v8-inspector.h does depend on v8-scripts.h for the time being to ensure that Chrome continue to compile but that change will be reverted once those transitive #includes in chrome are changed to include it directly. Full design: https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing Bug: v8:11965 Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76424}
-
- 19 Aug, 2021 1 commit
-
-
Al Muthanna Athamina authored
The NumFuzz fuzzers need to make use of this flag to ignore Mjsunit exceptions and other exceptions. The flag ignores the exit code 1. R=clemensb@chromium.org R=cbruni@chromium.org Bug: v8:11826 Change-Id: Ic0878078edec7292e43cdb18dd6fb32f7bbad12c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3103310 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76376}
-
- 30 Jun, 2021 1 commit
-
-
Clemens Backes authored
This flag only controls whether d8 installs the signal handler for wasm traps. Hence it should be a d8-only flag, to avoid confusion if used in other embeddings. We just introduced --wasm-enforce-bounds-checks to do what you might think --no-wasm-trap-handler would do. R=ahaas@chromium.org Bug: v8:11926 Change-Id: Ic1f33af36236a2981cf060f450bbfd02e51d9793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989130 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75459}
-
- 22 Jun, 2021 1 commit
-
-
Clemens Backes authored
After a series of CLs per component, this removes all remaining NOLINT annotations that my script identified as not needed (because removing them does not cause a presubmit error). R=mlippautz@chromium.org, jkummerow@chromium.org, leszeks@chromium.org R=cbruni@chromium.org Bug: v8:11879 Change-Id: Ia403c23588a0c2871b987931f6c26f85821e9e9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972733Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75296}
-
- 08 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL updates Realm.eval() to also handle reading source code as a JavaScript function or from a file. To distinguish between different argument types, an additional options bag needs to be provided. If no options bag is provided, the behavior defaults to the current one, which is reading source code from a string. Bug: v8:11525, v8:11706 Change-Id: I68238335eb91171041dca2c83db211c40dd68359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944435Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#75021}
-
- 04 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL introduces an ExplicitRealmScope in d8 for entering an existing Realm on demand. Bug: v8:11525, v8:11706 Change-Id: I3b556aed85fc615bb5efbd4a072e075534617258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936602 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74946}
-
- 03 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL updates WebSnapshotSerializer::TakeSnapshot() to accept exports as a Local<PrimitiveArray>. Bug: v8:11525, v8:11706 Change-Id: Ie3a752ac7dbcc51fc4fb258eb44ce42d0cfc6a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930173Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74936}
-
- 02 Jun, 2021 1 commit
-
-
Camillo Bruni authored
This is a reland of ed7e4554: - fixing platform names for tickprocessor - UnixCppEntriesProvider => LinuxCppEntriesProvider - MacCppEntriesProvider => MacOSCppEntriesProvider Original change's description: > [mjsunit][tools][d8] Full roundtrip tickprocessor test > > - Add os.d8Path property > - Add os.name property > - Change tickprocssor test to use command line arguments for testing > various configurations > - Change tickprocessor test to create a temporary v8.log and read it > back in on linux only > - Rearrange code in tickprocessor.mjs to allow instantiating the > CppEntriesProvider directly > - Drop complete symbol-list for tickprocessor-test-large.log for better > code searching in V8 > > Change-Id: Ib56dd0a1ba5377282c84c4de6f17e2fd69ee8123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929120 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74892} Change-Id: I5e121ba11f407af50108a2712d27c32867a22eb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929382Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74902}
-