- 22 Feb, 2021 40 commits
-
-
Milad Fa authored
Port 8136e399 Original Commit Message: Extract code sequence into macro-assembler for reuse between Liftoff and TurboFan. Small tweaks to macro-assembler functions Pmaddwd and Pmaddubsw to move src1 to dst on SSE when src != dst. TurboFan codegen won't be affected by this since it sets the right restrictions in instruction-selector. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Idaff4944dbb1ec5e6d7e798b6255a90744155006 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713842Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72928}
-
Milad Fa authored
Original change on arm: https://crrev.com/c/2463222 Change-Id: Ifb99b4dd1825814865ef2647ba3df3b3ab343cc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712394Reviewed-by:
-
Ng Zhi An authored
Optimize ia32 code sequences. This is the same sequences as x64, which have been optimized based on supported extensions. Bug: v8:11464 Change-Id: I10396a928a431cdd2de9b22bb8a395bc0adb4694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704897Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72926}
-
Ng Zhi An authored
Extract code sequence into macro-assembler for reuse between Liftoff and TurboFan. Similar to x64, there is a bit of register-aliasing checking due to the rather strict requirements for the code sequence depending on the CpuFetures that are supported. Bug: v8:11415 Change-Id: I3f855da25493941d158383020fbcafee8d18095f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698066 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72925}
-
Ng Zhi An authored
Extract code sequence into macro-assembler for reuse between Liftoff and TurboFan. Small tweaks to macro-assembler functions Pmaddwd and Pmaddubsw to move src1 to dst on SSE when src != dst. TurboFan codegen won't be affected by this since it sets the right restrictions in instruction-selector. Bug: v8:11086 Change-Id: I6c206dec332c8195a6a4d419d11a28e7058c905a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707253Reviewed-by:
-
Toon Verwaest authored
Bug: v8:11429 Change-Id: I98b65613dc05f593644af45388b1f2c2a7df34a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712567 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72923}
-
Georg Neis authored
These appear to be consistent with the pow implementation in ieee754.cc. Bug: v8:11371 Change-Id: I1b695facb5ba7dc1a7bd28914bdb535966e080c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710432 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72922}
-
Junliang Yan authored
Change-Id: I838bf9f9c0d83fc3cb96f7fb47b0fba3498680c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2709950Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72921}
-
Seth Brenith authored
This is a partial reland of https://crrev.com/c/v8/v8/+/2601880 . This change improves readability and helps prepare for when ScopeInfo will not be convertible to FixedArrayBase. Change-Id: I8de453c2b72ced51e98161e3d9e6426cd6ff7267 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707250Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72920}
-
Leszek Swirski authored
Now that we create a full frame for interrupts during the baseline out-of-line prologue, we shouldn't consider the out-of-line prologue builtin's frames as BASELINE, but rather have the frame above be the baseline frame. Change-Id: Icf96a6be4cf4bff0e482964bece12d397a26c268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712789 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#72919}
-
Milad Fa authored
Port 1c507667 Original Commit Message: There is no need for write barriers if the stored value is known to be a Smi. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I2b79511b7f2789e6fc95ae5cb349b0f2288822fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712787Reviewed-by:
-
gengjiawen authored
Fixes compilation with msvc 2019 toolchain. See: https://github.com/nodejs/node/pull/37330#issuecomment-783000812 Change-Id: I3b658d9ef49889c0a0467a1146e8d16b50fca65d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711152Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72917}
-
Almothana Athamneh authored
Bug: chromium:1126457 Change-Id: I3faa690d8b5d1fefcba7b75c38fb5d2c8570c3aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707165Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#72916}
-
Milad Fa authored
Port a3776a63 Original Commit Message: Backends do not care about the concrete type, they only need to know the "kind" (e.g. "ref" or "i32"). In order to prepare Liftoff to use the value kind instead of the value type for all stored data, this CL moves the kind out of the ValueType and makes it a top-level enum. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ia4111941313037aa1a77f2a0a1536d492ae9dc0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712392Reviewed-by:
-
Toon Verwaest authored
Bug: v8:11429 Change-Id: I626a30d44eca5e2b636d528a9fe0824b8608f4fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712568 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Yang Guo authored
This problem was found by Mathieu Schroeter <gamesover.ch@gmail.com>, who also suggested this fix. Kudos! R=cbruni@chromium.org Change-Id: I8865d1ea6dea29514c69296145cf72958ea8acb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712566 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72913}
-
Dan Elphick authored
Also add v8_config_headers dependency to cctest_headers. This reduces the number of gn check failures from 194 to 178. Bug: v8:7330 Change-Id: I6453b9789503c9d8ca3ed6bbe94bce3e2a69653f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712564 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This method used to be defined on Object and handled Strings and JSObjects; but only the object hierarchy rooted at JSObject has 'elements', and Strings are handled slightly differently. Thus it makes sense to split up into JSObject::GetOwnConstantElement String::GetCharAsString This way, we can also separate future work on making JSObjects and Strings never-serialized. Bug: v8:7790 Change-Id: I8e0f142fbd9cbf8e8abe1e9a189bcd948c2f1fa8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704080 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#72911}
-
Toon Verwaest authored
Bug: v8:11429 Change-Id: Ib85f759a763640a55e5e6dcaf350b3ed1629bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712563 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Using StackFrame::MANUAL was a bit of a hack to avoid frame markers to be pushed, but manual in FrameScope means Enter/LeaveFrame aren't called at all. This decouples those things. Bug: v8:11429 Change-Id: Ie1603bb3c6858f0b97a75e4bb0b9bd1244de6cce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707205 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Dan Elphick authored
Currently if gn check is enabled (with v8/third_party ignored), there are many errors due to headers being used without adding the proper dependency in BUILD.gn (or because it's being used transitively without a public_deps chain). This makes the number of errors go from 2114 to 195. Apart from adding dependencies, it also moves _v8_internal_Node_Print from objects-printer.cc to node.cc so it can see the Node::Print method which wouldn't otherwise be possible without a circular dependency. Also removes the previously deleted compiler/graph-builder-tester.h file. Bug: v8:7330 Change-Id: Icb34585fbef621588265cf4267cfc88ecbcf0a72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2702331Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#72908}
-
LiuYu authored
Besides, fix i64x2 widen i32x4 instructions in mips32. Change-Id: I85e3f8f4ab16c268a5b17189f67c78ef45762e39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711737Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72907}
-
Mythri A authored
Earlier we used the same interrupt budget always and waited for higher number of ticks when tiering up from Turboprop to TurboFan. On some of the real world pages this adds a reasonable overhead for processing these interrupts. This cl sets the interrupt budget to a higher value so there are fewer interrupts. This cl: 1. Sets the interrupt budget on feedback cell to FLAG_interrupt_budget * scale factor when we install optimized code. 2. Resets the budget to FLAG_interrupt_budget when there is a deoptimization. 3. Updates the runtime profiler to remove the scaling of number of ticks needed for optimization when tiering up from TP to TF. On sheets benchmark, we spend 40-50ms when servicing interrupts from Turboprop code. This change brings it down to ~7ms. We also see improvements on other pages. Bug: v8:9684 Change-Id: Ia3e5e998d1fff44f2e08a240a8769b7ebe794da2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696661 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#72906}
-
Clemens Backes authored
If webassembly is disabled via a gn arg, we will not be able to enable it via command-line switch. Hence make this flag read-only in that configuration. R=ecmziegler@chromium.org Bug: v8:11238 Change-Id: Ib93a55f74d4f018477f110b8b52aa9b645e86553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710426Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72905}
-
Jakob Gruber authored
This is a reland of 76a2ab06 Changes since the original CL: - Handle unserialized elements (optional result in getter). - Merge should_access_heap and --turbo-direct-heap-access paths. - Slightly update the serialized path in GetOwnCowElement. - Fix the cctest, add a regression test. Atomic JSObject::elements/JSArray::length setters are addressed in this CL: crrev.com/c/2704076. Original change's description: > [compiler] Direct heap reads for JSArrayRef > > There are two aspects to the non-JSObject parts of JSArrayRef: > > - JSArrayRef::length. Relevant only in two spots, 1. when reading > (immutable) array boilerplates and 2. for GetOwnCowElement. > > - JSArrayRef::GetOwnCowElement. May read into a copy-on-write backing > store. Relies on the invariant that cow backing stores are immutable. > > This CL renames the length accessor to length_unsafe to make the > danger explicit at callsites. > > For GetOwnCowElement the refactor is slightly larger, since we now > need to read into the backing store while keeping full control of > object reads (e.g. JSArray::length and JSArray::elements_kind). We > make all reads explicit at the call site by requiring that elements, > elements kind, and length are passed in as arguments to > GetOwnCowElement. Inside GetOwnCowElement, consistency between these > is *not* guaranteed due to concurrency. At runtime, consistency *is* > guaranteed through the reference-equality check on the elements seen > during compilation. The actual elements read is implemented in > ConcurrentLookupIterator::GetOwnCowElement. > > Bug: v8:7790 > Change-Id: I9aa169ce4f2b1e2bfe1e9232007669eb7654a995 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695403 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72834} Bug: v8:7790 Change-Id: I7577ad554992cafff81099a28c34f27db9bd8042 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710431 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
There is no need for write barriers if the stored value is known to be a Smi. R=thibaudm@chromium.org Bug: v8:11453 Change-Id: Id1cf306b246686c245d1be5f72c46b54ba9829ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707172Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72903}
-
Clemens Backes authored
The section might be the first EH-related part being found, and then it makes sense to include the hint about the flag in the error message. R=thibaudm@chromium.org Bug: v8:8091 Change-Id: I1680090f6ff3d9496a11db51f45d990d34f234ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707204Reviewed-by:
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: Ifb5a2cfa5f3fd2fbfecb84b1bf8f3dc464a823ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711264Reviewed-by:
-
Clemens Backes authored
This moves all asm.js tests (tests that use "%IsAsmWasmCode") into a separate directory. This will make it easier to skip them all in the v8_enable_webassembly=false configuration. R=ahaas@chromium.org Bug: v8:11238 Change-Id: I805f222b7977f5508f7dbee1f1bd61a88ccd34aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710427 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Both fields are accessed during background compilation and thus need to be written atomically. This CL changes the default setters `set_foo(value, mode)` to use relaxed stores underneath. Bug: v8:7790 Change-Id: I49161a548cb0ef6797bd3e5592dc5bf0c9a27a15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704076Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72899}
-
Clemens Backes authored
This CL introduces a test runner flag to detect if webassembly has been disabled. Since all tests that require wasm are alrady skipped in lite mode, we introduce a has_webassembly flag for the test runner which checks for v8_enable_webassembly=true and v8_enable_lite_mode=false. As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY preprocessor flag if lite mode is enabled. The status files are updated by splitting wasm tests from the "lite_mode" section and checking for "not has_webassembly" instead. Note that the v8_enable_webassembly=false configuration is not tested on any bot currently, but I will make sure that all tests keep passing on further changes in this configuration. R=machenbach@chromium.org Bug: v8:11238 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425Reviewed-by:
-
Omer Katz authored
Whenever we destroy an object that contains a (Weak)(CrossThread)Persistent, we call the Persistent's dtor which frees the relevant PersistentNode. To get the PersistentRegion for the node, we get the value, then get the the relevant page which holds a reference to the heap which holds the regions. During a termination GC there is no marking and no weak callback processing. That means that, when destroying a Persistent, the page on which the object referenced by the Persistent resides may have already been swept and destroyed. Then when we try to get the page we cleared or unallocated memory and crash. This issue presented as a sweeper crash in the web tests and content_browsertests. This issue affects only Weak(CrossThread)Persistent since the region for their strong counterparts are already cleared at the start of a termination GC. This is not an issue in the Blink impl because (1) Blink finds the elevant regions through ThreadState without going through pages, and (2) Blink runs a full GC on termination that includes executing weak callbacks. Alternatively we could trace the Weak(CrossThread)Persistent region which will run the weakness callbacks and clear all WeakPersistents. The cost and outcome is equivalent. Bug: chromium:1056170 Change-Id: I3db5b01424500eb695f9876247ef0c787d0d9ef2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2708645 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Clemens Backes authored
Backends do not care about the concrete type, they only need to know the "kind" (e.g. "ref" or "i32"). In order to prepare Liftoff to use the value kind instead of the value type for all stored data, this CL moves the kind out of the ValueType and makes it a top-level enum. R=manoskouk@chromium.org Bug: v8:11477 Change-Id: I489d6c5207e6ff1b66e2afbe78a156d66df27eb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707169 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: I39e97298bd1b802bd011214e820babc69f6e7d00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682639Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72895}
-
Manos Koukoutos authored
Constant reloading of the null reference impacted some wasm-gc benchmarks. This CL speeds some benchmarks by >5%. Note: This solution is not ideal as it technically generates invalid turbofan graphs. It is temporary until a proper optimization eliminating excessive loads is implemented. Change-Id: I7afa6fb8857f5dba3dde715bd30fe868ad06d92c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704668 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
The criteria is: 1) Regular method before Unsafe one 2) int index before non-int index 3) TNode<Object> before TNode<Smi> Bug: v8:6949, v8:11384 Change-Id: I499c835b956f6c92df26882ea37cb48e8fe737c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2690592Reviewed-by: -
Santiago Aboy Solanes authored
Removed the ones for types: * Symbol * Object * WordT * Int32T * HeapNumber Bug: v8:6949, v8:11384 Change-Id: Id09de31fe23d2a74d771100b293e45362c36a469 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707171Reviewed-by:
-
Thibaud Michaud authored
If a StackOverflow is caught, reload the pc and the limit from the catching frame, not from the target. R=clemensb@chromium.org Bug: chromium:1180339 Change-Id: I41bf94e6c7525106e990306913e446f2c4269df1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710436Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I32c87d4e3b98ab44699c1b7bf952aedef3e27002 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704667 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Remove try-catch for better debugging in DevTools Change-Id: Icfa1fcb21af45b785d570f226cd9e016a8371062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2685162Reviewed-by:
-
