Skip to content

V
V8
Switch branch/tag
  1. 25 Sep, 2018 2 commits
  3. 06 Jun, 2018 1 commit
  5. 27 Apr, 2018 1 commit
    • Michael Achenbach's avatar
      [V8] Add back owners check · 8961287a
      Michael Achenbach authored 
      This adds parts of Chromium's PanProjectChecks. We don't add all yet
as there is to much chance for the checks to fire on files later. We
first need to find a way to run the checks on all files (not only
changed ones).

NOTRY=true

Bug: v8:7689
Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85
Reviewed-on: https://chromium-review.googlesource.com/1029854Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52828}
      8961287a
  7. 08 Feb, 2018 1 commit
  9. 02 Feb, 2018 1 commit
  11. 23 Jan, 2018 1 commit
  13. 22 Dec, 2017 1 commit
  15. 03 Nov, 2017 1 commit
  17. 14 Sep, 2017 1 commit
  19. 11 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [presubmit] Add check for unbalanced #define / #undef · b8cc63ee
      Clemens Hammacher authored 
      With jumbo builds, we get spurious errors if several .cc files define
the same preprocessor macro without undefining it. This is also
disallowed by the style guide.
This patch adds a presubmit check to check that each #define is
eventually followed by a corresponding #undef. Special care has to be
taken for conditionally defined macros. Here, the logic to check that
there are not multiple defines and that they are undefined in all
cases is not perfect; it's optimistic in order to avoid false positives.

R=mstarzinger@chromium.org, machenbach@chromium.org

Bug: v8:6811
Change-Id: I55cde499399d97a5eb02fbc5ecfa34e6a8099d06
Reviewed-on: https://chromium-review.googlesource.com/657104
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47944}
      b8cc63ee
  21. 06 Jun, 2017 1 commit
  23. 22 May, 2017 1 commit
  25. 03 May, 2017 2 commits
    • Jochen Eisinger's avatar
      Reland "Make unittest link correctly again" · 668246a1
      Jochen Eisinger authored 
      This reverts commit 5db25a09.

Original change's description:
> Make unittest link correctly again
>
> Remains to port these fixes over to gyp.
>
> R=machenbach@chromium.org, jkummerow@chromium.org, mstarzinger@chromium.org
> BUG=v8:6325
>
> Change-Id: I3bebbc6d0ec52fcb60e3d51acd27e616f51d3dbb
> Reviewed-on: https://chromium-review.googlesource.com/490108
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#45026}

R=jkummerow@chromium.org
TBR=mstarzinger@chromium.org,clemensh@chromium.org
BUG=v8:6325

Change-Id: Ic3c0ffdf1f13045ea5a3929b720908e0b27a11c3
Reviewed-on: https://chromium-review.googlesource.com/494566Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45056}
      668246a1
    • Michael Achenbach's avatar
      Revert "Make unittest link correctly again" · 5db25a09
      Michael Achenbach authored 
      This reverts commit 0f5ebcca.

Reason for revert: Still blocks rolling:
https://codereview.chromium.org/2857903002/

Original change's description:
> Make unittest link correctly again
> 
> Remains to port these fixes over to gyp.
> 
> R=​machenbach@chromium.org, jkummerow@chromium.org, mstarzinger@chromium.org
> BUG=v8:6325
> 
> Change-Id: I3bebbc6d0ec52fcb60e3d51acd27e616f51d3dbb
> Reviewed-on: https://chromium-review.googlesource.com/490108
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#45026}

TBR=jkummerow@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jochen@chromium.org,clemensh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6325

Change-Id: Icb11e6e12cb6c7bd6c68677359596fee740b6531
Reviewed-on: https://chromium-review.googlesource.com/494467Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45049}
      5db25a09
  27. 02 May, 2017 1 commit
  29. 14 Mar, 2017 2 commits
  31. 17 Feb, 2017 1 commit
  33. 06 Dec, 2016 2 commits
  35. 28 Nov, 2016 1 commit
  37. 24 Nov, 2016 1 commit
  39. 14 Nov, 2016 1 commit
    • yangguo's avatar
      [serializer] small fixes for blink snapshot. · c759a3d8
      yangguo authored 
      Changes include:
 - Adding V8_EXPORT macro for SnapshotCreator
 - Removing outdated DCHECKs.
 - Allow nullptr as external reference. This required a...
 - Refactoring of hashmaps used by the serializer.
 - Remove external references for counters. These are not used
   anywhere for isolates that are being serialized.
 - Put template infos into the partial snapshot cache.
 - Remove unnecessary presubmit check for external references.
   mksnapshot crashes if external references are missing.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Review-Url: https://codereview.chromium.org/2490783004
Cr-Commit-Position: refs/heads/master@{#40949}
      c759a3d8
  41. 19 Sep, 2016 1 commit
  43. 23 Jun, 2016 1 commit
  45. 10 May, 2016 1 commit
  47. 14 Jan, 2016 2 commits
  49. 13 Jan, 2016 2 commits
  51. 03 Dec, 2015 1 commit
  53. 25 Nov, 2015 1 commit
  55. 23 Sep, 2015 1 commit
  57. 27 Aug, 2015 1 commit
  59. 18 Aug, 2015 1 commit
  61. 17 Jul, 2015 1 commit
  63. 30 Apr, 2015 1 commit
  65. 14 Apr, 2015 1 commit
  67. 09 Apr, 2015 1 commit