- 10 Mar, 2018 4 commits
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d8b353b..8e843a9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/df668c3..1537dce TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7f9c08d17ba2fb7b03547eb01a7a875194c2b94d Reviewed-on: https://chromium-review.googlesource.com/958202 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51860}
-
Jakob Kummerow authored
Add BigInt to the list of allowed result types. Bug: v8:6791, chromium:819871 Change-Id: Ib636859da07b38c462ce7017d720e5370ba618d6 Reviewed-on: https://chromium-review.googlesource.com/957422Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#51859}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:819555 Change-Id: I70e05a4b7fa917f3da22c9cf98ccd175f7b6a3ec Reviewed-on: https://chromium-review.googlesource.com/957723Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51858}
-
Caitlin Potter authored
Fixes an error where TemplateLiteral printing in --print-ast would try to read an element beyond the length of a vector. BUG=v8:7415, chromium:820596 R=adamk@chromium.org, gsathya@chromium.org Change-Id: Idf9e0da8c165ee62bc1a348a91c2ed5ed798404a Reviewed-on: https://chromium-review.googlesource.com/957883Reviewed-by:
-
- 09 Mar, 2018 30 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:793687 Change-Id: Iaa076a1dbbf2494e05763c71903ef569c76de519 Reviewed-on: https://chromium-review.googlesource.com/955858Reviewed-by:
-
Erik Luo authored
- Label as "bigint" in DevTools heap snapshot viewer - Treat as new primitive in injected-script-source - Show primitive value as property for BigIntObject - Adds the "n" suffix onto description, both with/without inspector being present Bug: v8:7486 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I47a02e32f9bdd9124a6c91056965574ecd443867 Reviewed-on: https://chromium-review.googlesource.com/940804 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51855}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:813065 Change-Id: Ic502079f66432aefe33a765d212389b4ab191c1d Reviewed-on: https://chromium-review.googlesource.com/955652 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Caitlin Potter authored
- Add a new bytecode for the ToString operation, replacing the old intrinsic call (currently does not collect type feedback). - Add a new AST node to represent TemplateLiterals, and avoid generating unnecessary ToString operations in some simple cases. - Use a single feedback slot for each string addition, because the type feedback should always be the same for each addition This seems to produce a very slight improvement on JSTests benchmarks and bench-ruben.js from v8:7415, and it's possible that type feedback for the ToString bytecode could provide more opportunities to eliminate the runtime call in TurboFan. Doesn't touch tagged templates BUG=v8:7415 R=rmcilroy@chromium.org, ishell@chromium.org, bmeurer@chromium.org Change-Id: If5a8c68558431f058db894d65776324abf54218e Reviewed-on: https://chromium-review.googlesource.com/945408Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#51853}
-
jgruber authored
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8.ports%2FV8_Linux_-_mipsel_-_sim%2F9763%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2FBreakPointJSBuiltin%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux64_-_debug_-_fyi%2F1461%2F%2B%2Frecipes%2Fsteps%2FCheck_-_stress_off_heap_code%2F0%2Flogs%2FBreakPointBuiltin%2F0 TBR=yangguo@chromium.org Bug: v8:7543 Change-Id: I137372b3330102fbd24f356d365206ce785eca83 Reviewed-on: https://chromium-review.googlesource.com/956048 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51852}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:820458 Change-Id: I962cdb57a89b1b852e92919812fcf67c7e38e3ed Reviewed-on: https://chromium-review.googlesource.com/955853 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
jgruber authored
The macro list avoids duplication in external-reference-table and will allow us to statically determine the size of the table in a follow-up. TBR=mlippautz@chromium.org Bug: v8:6666 Change-Id: I06bb2e8c25970b3c1047dafd6c63d7ca291fe37e Reviewed-on: https://chromium-review.googlesource.com/956187 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51850}
-
Leszek Swirski authored
This was a shim for the non-I+TF codepath, which is now the only codepath (that still uses this tier-up mechanism anyway). There were a couple of places we were accidentally using it due to CompileLazy or deopts, so this also fixes those. Reland of https://chromium-review.googlesource.com/951490 Change-Id: I1101eeda7b16651610c6f120062771bdc3c8a49f Reviewed-on: https://chromium-review.googlesource.com/957032Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#51849}
-
jgruber authored
Mips big-endian builders don't like embedded builtins. Disable embedded builtins on mips for now and defer investigation for when there's time. Example failures: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20big%20endian%20-%20nosnap%20-%201/builds/6666 https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20big%20endian%20-%20nosnap%20-%202/builds/5188 Two issues: test failures due to big-endianness and mismatches in the isolate-independence list. TBR=yangguo@chromium.org Bug: v8:6666 Change-Id: I73750668c03c132a9bb4d4ae9ed2bafd6d91f816 Reviewed-on: https://chromium-review.googlesource.com/955699Reviewed-by:
-
Mike Stanton authored
We can reduce boilerplate if we pass the continuation to some InstructionSelector::Emit.* methods. Change-Id: I0221f446129cc086122d3f77a00de7d1256d3ee1 bug: v8:7310 Reviewed-on: https://chromium-review.googlesource.com/934454 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#51847}
-
sreten.kovacevic authored
Since there are some regression tests that use this instruction many times in a row, trampoline pool can't be emitted. This commit fixes this issue. Change-Id: I7b575c4920f7e72a39051dee1ccca4baf9562ff1 Reviewed-on: https://chromium-review.googlesource.com/955696 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#51846}
-
Georg Neis authored
If the value can be converted, we can skip the write barrier. Change-Id: I88ac7f3756ddfaf4b8e58dc36a9b26faf544f0d9 Reviewed-on: https://chromium-review.googlesource.com/957033 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: chromium:820312 Change-Id: Ie9237a5c53ac7121e469af460a2f0ad5016d9d03 Reviewed-on: https://chromium-review.googlesource.com/957090 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Mathias Bynens authored
This patch removes the TypedArrayConstructor_ConstructStub builtin, merging its functionality into the refactored TypedArrayConstructor TurboFan builtin. This brings us closer to our goal of deprecating the `construct_stub` field in `SharedFunctionInfo`. Bug: v8:7503, v8:7518 Change-Id: I264aa0933b3c80814e021b05033636196dc289da Reviewed-on: https://chromium-review.googlesource.com/956044 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Peter Marshall authored
Previously we used a FixedArray for the FeedbackMetadata, packing bits of information into Smi fields. On 64-bit platforms, we waste at least half of the available memory by using the Smi representation. Given that this is just raw data (no pointers), we can just use a new type that uses the existing packing scheme to store the data in int32 format instead. This CL changes FeedbackMetadata to a new subclass of HeapObject. This is to reduce the API surface exposed, in comparison to extending/using a more general purpose data structure like ByteArray, which is also just raw data. FeedbackMetadata only exposes general purpose methods for accessing slots, but hides the implementation detail of packing bits into int32 fields. This CL also introduces a sentinal EmptyFeedbackMetadata, because there are ~750 empty FeedbackMetadata objects when running an empty program in V8. These are probably for builtins. Bug: v8:7500 Change-Id: Ic85563153abbd71a22854cee8519260c32b1e9ab Reviewed-on: https://chromium-review.googlesource.com/945730 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#51842}
-
Clemens Hammacher authored
This adds support for f32.convert_{s,u}/i{32,64}. On 32-bit platforms, i64 conversions are implemented by a call to a c function. Since the signature of this c function is very different to the currently used functions in Liftoff (in particular they contain an out parameter), this CL requires a major refactoring of how Liftoff generates c-calls. R=titzer@chromium.org Bug: v8:6600 Change-Id: Iffb4d0263ca1ca3eb9c6216344220322cda16062 Reviewed-on: https://chromium-review.googlesource.com/952122 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51841}
-
Hannes Payer authored
This reverts commit e816d2ba. Reason for revert: <INSERT REASONING HERE> Original change's description: > [heap] Turn on --write-protect-code-memory. > > Bug: chromium:774108 > Change-Id: Ifcf9939f29c9a3dc14ed686dc14608860ff32678 > Reviewed-on: https://chromium-review.googlesource.com/950902 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51766} TBR=mstarzinger@chromium.org,hpayer@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:774108 Change-Id: Icf6da14ec795cf89d2c4085ff7f9afb892184c12 Reviewed-on: https://chromium-review.googlesource.com/955692Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51840}
-
Sigurd Schneider authored
This benchmark checks comparison with StringAt functions against each other and and constants. The benchmarks will serve to measure the effect of an optimization that will omit the implicit String.fromCharCode in such cases. Bug: v8:7531 Change-Id: I171df92301516c96beb6a4ed86f1dec8d10e34f5 Reviewed-on: https://chromium-review.googlesource.com/957086Reviewed-by:
-
jgruber authored
This is a move-only CL (except includes cleanup). Bug: v8:6666 Change-Id: I28422b4a21074e642e8d5c9b3a563ecafdafbda7 Reviewed-on: https://chromium-review.googlesource.com/957087Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51838}
-
jgruber authored
It turns out that with the help of Code::Instruction{Start,End,Size} helpers, we don't need custom profiler methods. InstructionStream is now all-static. Bug: v8:6666 Change-Id: I59e1d2d2cb72c128725a1ed03f11506d40e76224 Reviewed-on: https://chromium-review.googlesource.com/947973 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Jaroslav Sevcik authored
Bug: chromium:798964 Change-Id: I1ef202296744a39054366f2bc424d6952c3bbe9d Reviewed-on: https://chromium-review.googlesource.com/955588Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#51836}
-
jgruber authored
This is a reland of 6afd25ff Original change's description: > [builtins] Execute binary-embedded builtin code > > This CL creates trampolines into binary-embedded builtins on > isolate-creation, if --stress-off-heap-code is passed. > > Note that this still overwrites existing code objects with the > off-heap trampoline, and that off-heap builtins still exist both in > the snapshot and the binary. Addressing these points are the next > steps. > > Drive-by-change: More efficient off-heap code lookups now that the > off-heap memory area has a contiguous and static layout. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng > Bug: v8:6666 > Change-Id: I7e7ef0aa2cd7b8184ae3a13fa02bdcbb4f2c9f86 > Reviewed-on: https://chromium-review.googlesource.com/947969 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51809} TBR=mstarzinger@chromium.org Bug: v8:6666 Change-Id: I4e0684de90733e5f18f6f0ea4832e327d03dfbf7 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/955595Reviewed-by:
-
Clemens Hammacher authored
Some compilers complain that ConvertReturn is private in SimulatorBase, but used in the arm64 Simulator. This CL fixes this by making ConvertReturn protected. R=ulan@chromium.org Bug: v8:7541 Change-Id: I9326b2c746829e9c37c58c14561811b32929c615 Reviewed-on: https://chromium-review.googlesource.com/955689Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7490 Change-Id: I07905a57c47ad6663d2d7f6bf539858bed1041f1 Reviewed-on: https://chromium-review.googlesource.com/939164Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#51833}
-
jgruber authored
This is a reland of 491d5a81 Original change's description: > [builtins] Embed builtins into the binary > > This embeds code for off-heap-safe builtins into the binary. Actual > execution of embedded code is not implemented yet. > > The embedded file has the following format: > > namespace v8 { > namespace internal { > > namespace { > > V8_EMBEDDED_TEXT_HEADER(v8_embedded_blob_) > __asm__( /* builtin offsets and lengths */ ); > __asm__(V8_ASM_LABEL("Builtins_RecordWrite")); > __asm__( /* binary instruction stream */ ); > /* Repeat for other builtins. */ > > extern "C" const uint8_t v8_embedded_blob_[]; > static const uint32_t v8_embedded_blob_size_ = /* size in bytes */; > > } // namespace > > const uint8_t* DefaultEmbeddedBlob() { return v8_embedded_blob_; } > uint32_t DefaultEmbeddedBlobSize() { return v8_embedded_blob_size_; } > > } // namespace internal > } // namespace v8 > > Bug: v8:6666 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng > Change-Id: Ic989f01da69ebe2863f31d934bfbe2c5d6e80864 > Reviewed-on: https://chromium-review.googlesource.com/946011 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51759} TBR=yangguo@chromium.org Bug: v8:6666 Change-Id: I89b0498f22b4ce573723748d55d86a82ba285a88 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/957024Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Stephan Herhut authored
This reverts a previous accidential edit. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib6a2e31f600de242e960171dd921387e897e3bc9 Reviewed-on: https://chromium-review.googlesource.com/951305Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#51831}
-
Yang Guo authored
R=jgruber@chromium.org Bug: v8:178 Change-Id: I1cabed9aa2a04f86e582ba09742b2e2857a40f27 Reviewed-on: https://chromium-review.googlesource.com/956045Reviewed-by:
-
Leszek Swirski authored
This reverts commit daa224d4. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=819873 Original change's description: > [builtins] Remove CheckOptimizationMarker builtin > > This was a shim for the non-I+TF codepath, which is now the only > codepath (that still uses this tier-up mechanism anyway). There were a > couple of places we were accidentally using it due to CompileLazy or > deopts, so this also fixes those. > > Change-Id: I00a7fdf9fb5cf74844138dac62d01ceaaf192e17 > Reviewed-on: https://chromium-review.googlesource.com/951490 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51786} TBR=rmcilroy@chromium.org,machenbach@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I80765eb18aaf5086e6db5d5df96f608a317c999f Reviewed-on: https://chromium-review.googlesource.com/957022Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#51829}
-
Jakob Gruber authored
This reverts commit 36b32aa2. Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/Win%20V8%20FYI%20Release%20%28NVIDIA%29/builds/208 Original change's description: > Reland "[builtins] Embed builtins into the binary" > > This is a reland of 491d5a81 > > Original change's description: > > [builtins] Embed builtins into the binary > > > > This embeds code for off-heap-safe builtins into the binary. Actual > > execution of embedded code is not implemented yet. > > > > The embedded file has the following format: > > > > namespace v8 { > > namespace internal { > > > > namespace { > > > > V8_EMBEDDED_TEXT_HEADER(v8_embedded_blob_) > > __asm__( /* builtin offsets and lengths */ ); > > __asm__(V8_ASM_LABEL("Builtins_RecordWrite")); > > __asm__( /* binary instruction stream */ ); > > /* Repeat for other builtins. */ > > > > extern "C" const uint8_t v8_embedded_blob_[]; > > static const uint32_t v8_embedded_blob_size_ = /* size in bytes */; > > > > } // namespace > > > > const uint8_t* DefaultEmbeddedBlob() { return v8_embedded_blob_; } > > uint32_t DefaultEmbeddedBlobSize() { return v8_embedded_blob_size_; } > > > > } // namespace internal > > } // namespace v8 > > > > Bug: v8:6666 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng > > Change-Id: Ic989f01da69ebe2863f31d934bfbe2c5d6e80864 > > Reviewed-on: https://chromium-review.googlesource.com/946011 > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#51759} > > TBR=yangguo@chromium.org > > Bug: v8:6666 > Change-Id: I741554cb080b6811dfbcb0913c6e1594e74c0432 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/955084 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51804} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: I0e21f958f18b0e4d7edebece5e4a2a3ea094cdd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/956185Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ca739dc..d8b353b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/406b235..df668c3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I3712e0f496692dc50d2ee4e8374cc025a54658cd Reviewed-on: https://chromium-review.googlesource.com/955914 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
- 08 Mar, 2018 6 commits
-
-
Ali Ijaz Sheikh authored
This test depends on lack of randomness in the allocation path so it is not compatible with stress_incremental_marking. Extract it into a standalone tests which runs with the stress flag disabled. Revert "[cctests] Disable flaky cctest test-heap-profiler/SamplingHeapProfiler" This reverts commit 3ea2d6b0. Bug: v8:7444 Change-Id: Id246bca4699a61e6b9ff4b5b5d2ff1ce4ebbd0da Reviewed-on: https://chromium-review.googlesource.com/953865Reviewed-by:
-
Yang Guo authored
This reverts commit b342e611. Reason for revert: x64 msvc failure Original change's description: > Attempt to fix MSVC failure in test-debug/BreakPointJSBuiltin > > TBR=bmeurer@chromium.org > > Bug: v8:178 > Change-Id: Idfa86749f3ee49c9f3b2a7fc7c0d7d3285e45c20 > Reviewed-on: https://chromium-review.googlesource.com/956066 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51824} TBR=yangguo@chromium.org,clemensh@chromium.org,bmeurer@chromium.org Change-Id: I76c4df67416b982b3215df7dce23eb1e7d42ec4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:178 Reviewed-on: https://chromium-review.googlesource.com/955572Reviewed-by:
-
Yang Guo authored
TBR=bmeurer@chromium.org Bug: v8:178 Change-Id: Idfa86749f3ee49c9f3b2a7fc7c0d7d3285e45c20 Reviewed-on: https://chromium-review.googlesource.com/956066Reviewed-by:
-
Teddy Katz authored
This updates the scanner to use the correct error message when it encounters an octal escape sequence in a template literal. Previously, the error message referred to strict mode, even when the template literal was not in strict mode code. Bug: v8:7502 Change-Id: I37bb1338cf796c471108bc10f35f824cdf3ce0b7 Reviewed-on: https://chromium-review.googlesource.com/945411Reviewed-by:
-
Yang Guo authored
The number of embedder fields grows dynamically, but reading these fields do not perform bounds checks. The naming is taken from a similar method on v8::Isolate. Also changed the growing strategy for the backing store to not over-allocate. R=adamk@chromium.org, bmeurer@chromium.org Bug: v8:7533 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I70beab124a32296c940ffabd897a7790bc8ff47a Reviewed-on: https://chromium-review.googlesource.com/952923Reviewed-by:
-
Yang Guo authored
TBR=bmeurer@chromium.org NOTRY=true Bug: v8:178 Change-Id: I5f8b128d9f0e5ae0ad9c44da0b6cd599c47fdf6b Reviewed-on: https://chromium-review.googlesource.com/956064Reviewed-by:
-
