Commits · 4b0c0760528dc452ac269a7ccc67f8e93a19c1a3 · Linshizhi / V8

26 Aug, 2014 1 commit

Replace our homegrown ARRAY_SIZE() with Chrome's arraysize(). · 90c89325

bmeurer@chromium.org authored 10 years ago

Our own ARRAY_SIZE() was pretty bad at error checking. If you use
arrasize() in a wrong way, the compiler will issue an error instead of
silently doing the wrong thing. The previous ARRAY_SIZE() macro is still
available as ARRAYSIZE_UNSAFE() similar to Chrome.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/501323002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

90c89325

07 Aug, 2014 1 commit

Extend some operations to range types. · c972e8e2

neis@chromium.org authored 10 years ago

This is a reland of 22945, which failed to build on Windows due to
(some versions of?) Visual Studio lacking copysign().

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/448093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22977 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c972e8e2

06 Aug, 2014 7 commits

Revert "Extend some operations to range types." · 7692ec62

neis@chromium.org authored 10 years ago

This reverts commit 22945.  Turns out Visual Studio doesn't have copysign().

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450473002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22946 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7692ec62

Extend some operations to range types. · 86759140

neis@chromium.org authored 10 years ago

This is a reland of 22934, which failed to build on Windows due to a missing include, and on ARM due to a name clash with some predefined constants.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

86759140

Revert "Extend some operations to range types." · 19d07b2a

neis@chromium.org authored 10 years ago

This reverts 22934.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/443123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

19d07b2a

Extend some operations to range types. · a6ad240b

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/437393005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a6ad240b

Fix a bug in type fuzzing and several handlification bugs elsewhere. · a8729bdc

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444883005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22926 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a8729bdc

Add convenience method to print types for debugging. · df7057b3

mstarzinger@chromium.org authored 10 years ago

R=titzer@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/435403002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22908 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df7057b3

Remove non-trivial subtyping between bitset and non-bitset types. · 63a170aa

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444503005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

63a170aa

05 Aug, 2014 2 commits

Undo some unintended changes from the Turbofan merge · cae6842a

rossberg@chromium.org authored 10 years ago

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/435423002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cae6842a

Remove unnecesssary auxiliary definitions. · d04a2cbd

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/413983005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22860 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d04a2cbd

04 Aug, 2014 1 commit

Rename ASSERT* to DCHECK*. · d07a2eb8

bmeurer@chromium.org authored 10 years ago

This way we don't clash with the ASSERT* macros
defined by GoogleTest, and we are one step closer
to being able to replace our homegrown base/ with
base/ from Chrome.

R=jochen@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/430503007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d07a2eb8

30 Jul, 2014 1 commit

Land the Fan (disabled) · a1383e22

danno@chromium.org authored 10 years ago

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/426233002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1383e22

23 Jul, 2014 3 commits

Minor clarifications and simplifications as well as additional checks. · 61e1994f

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417553003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22573 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

61e1994f

Revert "Minor clarifications and simplifications as well as additional checks." · e999cf28

neis@chromium.org authored 10 years ago

This reverts commit d32eacbdea3fc0c119da06abe95b07a83c67aa48.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410083005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e999cf28

Minor clarifications and simplifications as well as additional checks. · 6c67275f

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/409743004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c67275f

22 Jul, 2014 1 commit

Add constructor for range types. · 6176dee6

neis@chromium.org authored 10 years ago

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/409543004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6176dee6

10 Jul, 2014 1 commit

Switch type of the-hole to be internal. · 2269da52

mstarzinger@chromium.org authored 10 years ago

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/381063002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2269da52

03 Jul, 2014 1 commit

Start using OStreams. · d7934d1f

svenpanne@chromium.org authored 10 years ago

Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
const-corrected on the way.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/334763003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d7934d1f

03 Jun, 2014 1 commit

Use full include paths everywhere · 56a486c3

jochen@chromium.org authored 10 years ago

- this avoids using relative include paths which are forbidden by the style guide
- makes the code more readable since it's clear which header is meant
- allows for starting to use checkdeps

BUG=none
R=jkummerow@chromium.org, danno@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/304153016

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

56a486c3

27 May, 2014 1 commit

Establish distributivity for type union & intersection · 7ac892c8

rossberg@chromium.org authored 10 years ago

This requires introducing proper bounds on all leaf types, so that intersection between bitsets and these types can be accurately represented. Extending a union also becomes more involved.

(On the upside, the modified union/intersect algorithm would now allow support for proper variance for function types.)

Not sure if it is worth landing this. Distributivity isn't really a crucial property for our use cases. It seems fine if intersection is slightly lossy.

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/251753005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7ac892c8

26 May, 2014 1 commit

Various extensions to types · dbf7d852

rossberg@chromium.org authored 10 years ago

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/296213005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dbf7d852

24 Apr, 2014 1 commit

Treat FOREIGN_TYPE as internal. · 81578179

bmeurer@chromium.org authored 10 years ago

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/257523002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81578179

22 Apr, 2014 1 commit

Fix issue with Map/SetIterator and types · 71750f7b

adamk@chromium.org authored 10 years ago

BUG=v8:3281
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/246993003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71750f7b

17 Apr, 2014 1 commit

Track up to 5 stable maps as field type. · 779e87b8

bmeurer@chromium.org authored 10 years ago

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/240813002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

779e87b8

16 Apr, 2014 5 commits

Implement structural function and array types · 926ec656

rossberg@chromium.org authored 10 years ago

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

926ec656

Revert "Implement structural function and array types" · e3e81d85

rossberg@chromium.org authored 10 years ago

TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/237963016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e3e81d85

Implement structural function and array types · 6782d9ce

rossberg@chromium.org authored 10 years ago

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6782d9ce

Revert "Implement structural function and array types" · a947aeb3

rossberg@chromium.org authored 10 years ago

TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/240143003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a947aeb3

Implement structural function and array types · 7de4c1c6

rossberg@chromium.org authored 10 years ago

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7de4c1c6

14 Apr, 2014 3 commits

Re-reland "More tests for Union & Intersect" · 7b7f787e

rossberg@chromium.org authored 10 years ago

R=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/237143002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b7f787e

Revert "Reland "More tests for Union & Intersect"" · b73257b7

rossberg@chromium.org authored 10 years ago

Need to reproduce wrong result only occurring with ASAN.

TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/236873002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b73257b7

Reland "More tests for Union & Intersect" · a3d743b4

rossberg@chromium.org authored 10 years ago

Fixes size approximation in Intersect. Also lowers the number of fuzzed types in test, to address time-outs.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/226523004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a3d743b4

11 Apr, 2014 3 commits

Revert "More tests for Union & Intersect" · ee9f7f89

dcarney@chromium.org authored 10 years ago

This reverts r20684.

TBR=rossberg@chromium.org

BUG=

Review URL: https://codereview.chromium.org/235133002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20687 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ee9f7f89

More tests for Union & Intersect · 80d8460a

rossberg@chromium.org authored 10 years ago

Some fixes of corner cases on the way

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/230923005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

80d8460a

Inline TypeImpl::NowContains(). · 9a544e18

bmeurer@chromium.org authored 10 years ago

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/234743003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9a544e18

10 Apr, 2014 3 commits

Treat uninitialized as internal type. · 990b57ba

bmeurer@chromium.org authored 10 years ago

TEST=cctest/test-types
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/232913002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

990b57ba

Yet more type system tests · cf4eddd3

rossberg@chromium.org authored 10 years ago

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/232843002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf4eddd3

Fix symmetry of Maybe() predicate. Fix bug in NowContains() predicate. · 4620ae5c

bmeurer@chromium.org authored 10 years ago

Add tests for TypeImpl::Of(), TypeImpl::NowOf() and
TypeImpl::NowContains(). Improves the implementation of
TypeImpl::NowIs() to match that of TypeImpl::NowContains().

Mark test-types with NO_VARIANTS to speedup testing, since
the variants do not affect the type system at all.

Also improve test coverage for types.

TEST=cctest/test-types
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/230673002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4620ae5c

09 Apr, 2014 1 commit

Fix various bugs in the type systems, and improve test coverage. · a0ac88db

bmeurer@chromium.org authored 10 years ago

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/230463003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a0ac88db