1. 29 Nov, 2018 2 commits
  2. 27 Nov, 2018 1 commit
  3. 22 Nov, 2018 1 commit
    • Shiyu Zhang's avatar
      Reland "Create a fast path to get migration target when updating map" · 69232ba6
      Shiyu Zhang authored
      This is a reland of 6ec90ece
      
      Original change's description:
      > Reland "Create a fast path to get migration target when updating map"
      >
      > This is a reland of c285380c
      >
      > Original change's description:
      > > Create a fast path to get migration target when updating map
      > >
      > > During map updating, store the pointer to new map in the
      > > raw_transitions slot of the old map that is deprecated from map
      > > transition tree. Thus, we can get the migration target directly
      > > instead of TryReplayPropertyTransitions when updating map.
      > >
      > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM
      > > Chromebook and ~9% on big-core Ubuntu.
      > >
      > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db
      > > Reviewed-on: https://chromium-review.googlesource.com/1233433
      > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#56303}
      >
      > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137
      > Reviewed-on: https://chromium-review.googlesource.com/c/1270261
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > Cr-Commit-Position: refs/heads/master@{#56588}
      
      Change-Id: Iad23455f66c83340430370be6670bac493c638a1
      Reviewed-on: https://chromium-review.googlesource.com/c/1309305
      Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57705}
      69232ba6
  4. 13 Nov, 2018 1 commit
  5. 05 Nov, 2018 1 commit
  6. 29 Oct, 2018 1 commit
  7. 26 Oct, 2018 1 commit
  8. 24 Oct, 2018 1 commit
  9. 15 Oct, 2018 1 commit
    • Igor Sheludko's avatar
      Revert "Reland "Create a fast path to get migration target when updating map"" · 1898944b
      Igor Sheludko authored
      This reverts commit 6ec90ece.
      
      Reason for revert: causes a lot of Canary crashes (chromium:895208).
      GC relies on an the fact that the transition array stays alive while it's owner map
      is alive (this is needed in order to properly transfer descriptor array ownership
      to the parent map when the map owning a shared descriptor array dies). We need to
      rethink a way of caching the migration target shortcut.
      
      Original change's description:
      > Reland "Create a fast path to get migration target when updating map"
      >
      > This is a reland of c285380c
      >
      > Original change's description:
      > > Create a fast path to get migration target when updating map
      > >
      > > During map updating, store the pointer to new map in the
      > > raw_transitions slot of the old map that is deprecated from map
      > > transition tree. Thus, we can get the migration target directly
      > > instead of TryReplayPropertyTransitions when updating map.
      > >
      > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM
      > > Chromebook and ~9% on big-core Ubuntu.
      > >
      > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db
      > > Reviewed-on: https://chromium-review.googlesource.com/1233433
      > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#56303}
      >
      > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137
      > Reviewed-on: https://chromium-review.googlesource.com/c/1270261
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > Cr-Commit-Position: refs/heads/master@{#56588}
      
      TBR=ishell@chromium.org,shiyu.zhang@intel.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Change-Id: Ie7e9b98395b041a1095da549d1cd71d7180a4888
      Bug: chromium:895208
      Reviewed-on: https://chromium-review.googlesource.com/c/1280223
      Commit-Queue: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56641}
      1898944b
  10. 12 Oct, 2018 1 commit
    • Shiyu Zhang's avatar
      Reland "Create a fast path to get migration target when updating map" · 6ec90ece
      Shiyu Zhang authored
      This is a reland of c285380c
      
      Original change's description:
      > Create a fast path to get migration target when updating map
      >
      > During map updating, store the pointer to new map in the
      > raw_transitions slot of the old map that is deprecated from map
      > transition tree. Thus, we can get the migration target directly
      > instead of TryReplayPropertyTransitions when updating map.
      >
      > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM
      > Chromebook and ~9% on big-core Ubuntu.
      >
      > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db
      > Reviewed-on: https://chromium-review.googlesource.com/1233433
      > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56303}
      
      Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137
      Reviewed-on: https://chromium-review.googlesource.com/c/1270261Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      Cr-Commit-Position: refs/heads/master@{#56588}
      6ec90ece
  11. 30 Sep, 2018 2 commits
  12. 17 Sep, 2018 1 commit
  13. 14 Sep, 2018 2 commits
    • Marja Hölttä's avatar
      Revert "[in-place weak refs] Fix MaybeObject function names" · 3a79fe23
      Marja Hölttä authored
      This reverts commit ad72d195.
      
      Reason for revert: Build failures on *san
      
      Original change's description:
      > [in-place weak refs] Fix MaybeObject function names
      > 
      > E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap
      > object, instead returned a weakly pointed heap object. Change the function names
      > (in this case, to "GetHeapObjectIfWeak") to reflect this.
      > 
      > Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>().
      > 
      > BUG=v8:7308
      > 
      > Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d
      > Reviewed-on: https://chromium-review.googlesource.com/1219025
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Marja Hölttä <marja@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55906}
      
      TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,tebbi@chromium.org,ishell@chromium.org
      
      Change-Id: I054b578518e3f6fd7dbcddf0b56cc018726c1e7a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7308
      Reviewed-on: https://chromium-review.googlesource.com/1226874Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55918}
      3a79fe23
    • Marja Hölttä's avatar
      [in-place weak refs] Fix MaybeObject function names · ad72d195
      Marja Hölttä authored
      E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap
      object, instead returned a weakly pointed heap object. Change the function names
      (in this case, to "GetHeapObjectIfWeak") to reflect this.
      
      Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>().
      
      BUG=v8:7308
      
      Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d
      Reviewed-on: https://chromium-review.googlesource.com/1219025Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55906}
      ad72d195
  14. 12 Jul, 2018 1 commit
    • Leszek Swirski's avatar
      [cleanup] Remove Isolate parameter from object print · 13b899a5
      Leszek Swirski authored
      With ReadOnlyRoots and GetIsolate on JSReceiver, we can remove almost
      every isolate parameter from <Object>::Print. The remaining ones, like
      Map, are special-caseable for read-only maps, and as a result we can
      remove isolate parameters from <Object>::Print entirely.
      
      This patch also opportunistically cleans up a few places where isolates
      were only needed for Object::Print, such as TransitionAccessors and
      DescriptorArrays.
      
      TBR=yangguo@chromium.org,mstarzinger@chromium.org
      
      Bug: v8:7786
      Change-Id: Id44bd53b9893e679eea5f37b9548257595a1bfd9
      Reviewed-on: https://chromium-review.googlesource.com/1133385Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54401}
      13b899a5
  15. 21 Jun, 2018 1 commit
  16. 05 Jun, 2018 1 commit
  17. 19 Apr, 2018 1 commit
  18. 18 Apr, 2018 2 commits
  19. 05 Apr, 2018 2 commits
  20. 04 Apr, 2018 1 commit
    • Igor Sheludko's avatar
      [ic] Implement TransitionArray lookup in CSA. · 139fe2db
      Igor Sheludko authored
      Drive-by cleanup: remove megamorphic stub cache lookup support from generic property
      store code. This lookup is no longer necessary because
      1) fast stores to existing properties get all the information from the map,
      2) transitioning store targets are taken directly from the transition array,
      so in both cases there's no point in doing a store handler lookup.
      
      Bug: v8:5988
      Change-Id: I95c0a08e7d1a76bb0f4475a9bd685e4e11e16a48
      Reviewed-on: https://chromium-review.googlesource.com/983921
      Commit-Queue: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52349}
      139fe2db
  21. 28 Mar, 2018 2 commits
  22. 07 Nov, 2017 1 commit
  23. 06 Nov, 2017 2 commits
  24. 28 Sep, 2017 1 commit
  25. 15 Sep, 2017 1 commit
  26. 11 Aug, 2017 1 commit
  27. 28 Jul, 2017 1 commit
    • Jakob Kummerow's avatar
      Refactor TransitionArray access · e567dd3a
      Jakob Kummerow authored
      in preparation for caching StoreIC-Transition handlers in there.
      This CL should not change behavior or performance.
      
      The TransitionArray class no longer serves a dual purpose; it is now
      simply the data structure serving that role. Further, it now supports
      storing transitioning handlers in its "target" slot, which in turn have
      a WeakCell pointing to the transition target (but this functionality
      is not being used yet).
      
      The interface for accessing a map's transitions, previously implemented
      as a set of static functions, is now handled by the TransitionsAccessor
      class. It distinguishes the following internal states:
      - kPrototypeInfo: map is a prototype map, will never cache any transitions.
      - kUninitialized: map can cache transitions, but doesn't have any.
      - kWeakCell: map caches a single transition, stored inline. Formerly known
                   as "IsSimpleTransition".
      - kFullTransitionArray: map uses a TransitionArray to store transitions.
      - kTuple3Handler, kFixedArrayHandler: to be used in the future for caching
                                            transitioning handlers.
      
      Change-Id: If2aa68390981f96f317b958445a6e0b935c2a14e
      Reviewed-on: https://chromium-review.googlesource.com/550118Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46981}
      e567dd3a
  28. 24 Jul, 2017 1 commit
    • Igor Sheludko's avatar
      Revert "Reland "[runtime] Add shortcuts for elements kinds transitions."" · 5520cae3
      Igor Sheludko authored
      This reverts commit 6e27386d.
      
      Reason for revert: There will be another much simpler and
      back-mergeable fix.
      
      Original change's description:
      > Reland "[runtime] Add shortcuts for elements kinds transitions."
      > 
      > This is a reland of b90e83f5
      > Original change's description:
      > > [runtime] Add shortcuts for elements kinds transitions.
      > >
      > > The shortcuts ensure that field type generalization is properly
      > > propagated in the transition graph.
      > >
      > > Bug: chromium:738763
      > > Change-Id: Id701a6f95ed6ea093c707fbe0bac228f1f856e9f
      > > Reviewed-on: https://chromium-review.googlesource.com/567992
      > > Commit-Queue: Igor Sheludko <ishell@chromium.org>
      > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#46622}
      > 
      > Bug: chromium:738763, chromium:742346, chromium:742381, chromium:745844
      > Change-Id: I93974e3906b2c7710bd525f15037a2dd97f263ad
      > Reviewed-on: https://chromium-review.googlesource.com/575227
      > Commit-Queue: Igor Sheludko <ishell@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46759}
      
      TBR=ulan@chromium.org,jkummerow@chromium.org,ishell@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:738763, chromium:742346, chromium:742381, chromium:745844
      Change-Id: I203dc748c47db554e0a86d61f0e2b7b8b96f2370
      Reviewed-on: https://chromium-review.googlesource.com/581547
      Commit-Queue: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46826}
      5520cae3
  29. 19 Jul, 2017 1 commit
  30. 18 Jul, 2017 1 commit
  31. 14 Jul, 2017 1 commit
  32. 13 Jul, 2017 1 commit
  33. 07 Oct, 2016 1 commit