- 21 Mar, 2018 1 commit
-
-
jgruber authored
Some debugging tests relied on the following anti-pattern: let exception = false; try { /* ... some code that may throw on test failure ... */ } catch (e) { exception = e; } assertFalse(exception); This may be problematic if a falseish value is thrown. Change-Id: I02eace4cc656fc9581928a90ac53cda4dc72b30c Reviewed-on: https://chromium-review.googlesource.com/972822Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52105}
-
- 16 Nov, 2016 1 commit
-
-
jgruber authored
This CL further extends the debug wrapper, migrates around 60 tests, and removes a few tests that use functionality we will not support anymore. In more detail: * Removed tests that use: * enable/disable individual breakpoints * invocationText() * the ScriptCollected event * showBreakPoints * evalFromScript (and similar) * mirror.constructedBy and mirror.referencedBy * event_data.promise() * Some frame.evaluate uses were adapted since due to differences between remote objects (inspector) and mirrors. For instance, exceptions are currently not recreated exactly, since the inspector protocol does not give us the stack and message separately. Other objects (such as 'this' in debug-evaluate-receiver-before-super) need to be explicitly converted to a string before the test works correctly. * Ensure that inspector stores the script before sending ScriptParsed and ScriptFailedToParse events in order to be able to use the script from within those events. * Better remote object reconstruction (e.g. for undefined and arrays). * New functionality in wrapper: * debuggerFlags().breakPointsActive.setValue() * scripts() * execState.setVariableValue() * execState.scopeObject().value() * execState.scopeObject().property() * execState.frame().allScopes() * eventData.exception() * eventData.script() * setBreakPointsActive() BUG=v8:5530 Review-Url: https://codereview.chromium.org/2497973002 Cr-Commit-Position: refs/heads/master@{#41019}
-
- 11 Dec, 2014 1 commit
-
-
kozyatinskiy authored
V8 didn't report compile events on pause before this patch. These events can be important for listener. For example, DevTools allows user to execute some JS code on pause and needs to show correct stack trace in message from it. BUG=396013 R=yurys@chromium.org Review URL: https://codereview.chromium.org/781623004 Cr-Commit-Position: refs/heads/master@{#25767}
-
- 02 Jul, 2014 1 commit
-
-
marja@chromium.org authored
BUG=v8:2948 LOG=N R=svenpanne@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/316173002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Jun, 2014 1 commit
-
-
yurys@chromium.org authored
This event is generated when the parser can not generate code. R=vsevik@chromium.org, yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/264333007 Patch from Alexey Kozyatinskiy <kozyatinskiy@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22043 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 May, 2013 1 commit
-
-
yurys@chromium.org authored
BUG=v8:2702 R=yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/15859010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Sep, 2011 1 commit
-
-
yangguo@chromium.org authored
Review URL: http://codereview.chromium.org/7826007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Oct, 2010 1 commit
-
-
lrn@chromium.org authored
Switch JSON parsing to creating the value directly instead of createing code to create the value. Review URL: http://codereview.chromium.org/4135004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Feb, 2010 1 commit
-
-
yurys@chromium.org authored
Review URL: http://codereview.chromium.org/596088 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Feb, 2010 1 commit
-
-
lrn@chromium.org authored
Review URL: http://codereview.chromium.org/549207 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Oct, 2009 1 commit
-
-
ager@chromium.org authored
used to allow these for compatibility, but both Safari and Firefox now disallow them. Review URL: http://codereview.chromium.org/242124 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3009 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Jun, 2009 1 commit
-
-
sgjesse@chromium.org authored
Scripts now have a compilation type which can be host, eval or JSON. Host scripts are compiled through the API, eval scripts are compiled through call to evan and JSON scripts are compiled as a result of calling JSON.parse. For scripts scripts compiled through eval the JavaScript function in top of the stack and the pc offset into the code is stored in the script object. This makes it possible to calculate the source position of the eval call later when requested. This information can be obtained through the script mirror object and is part of the script mirror JSON serialization for the debugger protocol. Moved the enumeration ScripType into class Script and remamed to Type. The new compilation type enumeration is also inside the class Script. This information is now shown when using the scripts command in he developer shell debugger. Review URL: http://codereview.chromium.org/119108 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 May, 2009 1 commit
-
-
yurys@chromium.org authored
Review URL: http://codereview.chromium.org/115128 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Feb, 2009 1 commit
-
-
sgjesse@chromium.org authored
The debugger compile events (BeforeCompile and AfterCompile) have not been used by any V8 debuggers lately and where actually not working any more. Added the correct information to the compile event. Added a simple 'trace compile' command to the developer shell for testing. Added a test for compile evnets. Review URL: http://codereview.chromium.org/21076 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Feb, 2009 1 commit
-
-
sgjesse@chromium.org authored
Changed the debugger API to allow only one debug event listener to be registered. The public API now only has SetDebugEventListener instead of AddDebugEventListener and RemoveDebugEventListener. Moved the registrered debug event listener from the context to a global handle in the Debugger class. Storing it in the context did not make much sense. Changed a lot of tests to handle the API change. BUG=1242707 Review URL: http://codereview.chromium.org/19753 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2008 1 commit
-
-
christian.plesner.hansen authored
In the shell sample don't print the result of executing a script, only evaluating expressions. Fixed issue when building samples on Windows using a shared V8 library. Added visibility option on Linux build which makes the generated library 18% smaller. Changed build system to accept multiple build modes in one build and generate seperate objects, libraries and executables for each mode. Removed deferred negation optimization (a * -b => -(a * b)) since this visibly changes operand conversion order. Improved parsing performance by introducing stack guard in preparsing. Without a stack guard preparsing always bails out with stack overflow. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2008 1 commit
-
-
kasper.lund authored
Added a few samples and support for building them. The samples include a simple shell that can be used to benchmark and test V8. Changed V8::GetVersion to return the version as a string. Added source for lazily loaded scripts to snapshots and made serialization non-destructive. Improved ARM support by fixing the write barrier code to use aligned loads and stores and by removing premature locals optimization that relied on broken support for callee-saved registers (removed). Refactored the code for marking live objects during garbage collection and the code for allocating objects in paged spaces. Introduced an abstraction for the map word of a heap-allocated object and changed the memory allocator to allocate executable memory only for spaces that may contain code objects. Moved StringBuilder to utils.h and ScopedLock to platform.h, where they can be used by debugging and logging modules. Added thread-safe message queues for dealing with debugger events. Fixed the source code reported by toString for certain builtin empty functions and made sure that the prototype property of a function is enumerable. Improved performance of converting values to condition flags in generated code. Merged disassembler-{arch} files. git-svn-id: http://v8.googlecode.com/svn/trunk@8 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-