- 16 Aug, 2016 4 commits
-
-
mlippautz authored
Slots in ConsString/SlicedString can point to an evacutaion candidate. The MakeExternal function makes in-place conversion to external string. After the conversion we can have a recorded slot containing an external pointer. As long as the external pointer is aligned, this is not a problem. We clear the recorded slots to fix verify-heap checks. BUG=chromium:631969 LOG=NO Finalizing CL: https://codereview.chromium.org/2199863002/ Review-Url: https://codereview.chromium.org/2242183003 Cr-Commit-Position: refs/heads/master@{#38653}
-
klaasb authored
Allows us to create a corresponding TurboFan node, so TF can optimize it. BUG=v8:4280 LOG=n Review-Url: https://codereview.chromium.org/2248633002 Cr-Commit-Position: refs/heads/master@{#38651}
-
mtrofin authored
A test exercising the public APIs for wasm serialization and simulates the serialization scenario - serialize in one isolate, deserialize in another. BUG=v8:5072 Review-Url: https://codereview.chromium.org/2249973002 Cr-Commit-Position: refs/heads/master@{#38644}
-
verwaest authored
Follow-up cleanup to https://codereview.chromium.org/2231813003 BUG= Review-Url: https://codereview.chromium.org/2237873002 Cr-Commit-Position: refs/heads/master@{#38643}
-
- 15 Aug, 2016 3 commits
-
-
jbroman authored
This includes UTF-8 strings and two-byte strings, both length-delimited (in bytes, not characters). Two-byte strings are written/read in host byte order. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2245753002 Cr-Commit-Position: refs/heads/master@{#38636}
-
klaasb authored
Adds TestResultScope and uses it to directly jump/fall through to the correct branch in expressions used as branch conditions. Should enable nicer TurboFan-graphs for easier control-flow transformations in the future. BUG=v8:4280 LOG=n Review-Url: https://codereview.chromium.org/2242463002 Cr-Commit-Position: refs/heads/master@{#38634}
-
jbroman authored
This includes unsigned integers (encoded as base-128 varints), signed integers (ZigZag-encoded, then varint-encoded) and doubles (written in host byte order). BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2232323004 Cr-Commit-Position: refs/heads/master@{#38630}
-
- 12 Aug, 2016 14 commits
-
-
caitp authored
No longer include the "async" keyword, or an async arrow function's single identifier parameter as part of its inferred name. BUG=v8:5281, v8:4483 R=adamk@chromium.org, littledan@chromium.org, marja@chromium.org Review-Url: https://codereview.chromium.org/2235423003 Cr-Commit-Position: refs/heads/master@{#38627}
-
jbroman authored
BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2232243003 Cr-Commit-Position: refs/heads/master@{#38625}
-
georgia.kouveli authored
Instead of loading 64 bits and shifting: ldr x0, [x1, #offset] asr x0, x0, #32 directly load the interesting 32 bits and sign-extend: ldrsw x0, [x1, #offset+4] BUG= Review-Url: https://codereview.chromium.org/2243843002 Cr-Commit-Position: refs/heads/master@{#38622}
-
yangguo authored
R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2246483002 Cr-Commit-Position: refs/heads/master@{#38621}
-
mstarzinger authored
This removes some compiler internals as well as some JavaScript specific helper from the CodeAssembler, by either hiding or moving the support into the CodeStubAssembler. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2246463002 Cr-Commit-Position: refs/heads/master@{#38617}
-
bmeurer authored
Properly deoptimize if the left hand side of a CheckedInt32Mod is negative and the result of the operation is zero. R=jarin@chromium.org BUG=v8:5286 Review-Url: https://codereview.chromium.org/2243803002 Cr-Commit-Position: refs/heads/master@{#38615}
-
mlippautz authored
Revert of "[heap] Switch to 500k pages" (patchset #11 id:220001 of https://codereview.chromium.org/2232653003/ ) Reason for revert: Breaks benchmark with --turbo on avx2 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/9895 Original issue's description: > Reland of "[heap] Switch to 500k pages" > > Decrease regular heap object size to 400k. In a follow up, we can now get rid of > the new space border page while keeping the 1M minimum new space size. > > BUG=chromium:636331 > > This reverts commit 555c9619. > > Committed: https://crrev.com/20e2ea80e169e85c5b8231adc02901fb6c989609 > Cr-Commit-Position: refs/heads/master@{#38608} TBR=hpayer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636331 Review-Url: https://codereview.chromium.org/2239323002 Cr-Commit-Position: refs/heads/master@{#38613}
-
georgia.kouveli authored
BUG= Review-Url: https://codereview.chromium.org/2240803003 Cr-Commit-Position: refs/heads/master@{#38612}
-
jgruber authored
This bug was triggered by a very specific combination: * A context-allocated variable at script scope. * OSR optimization. * A scheduled breakpoint, which triggers at stack checks. Stack checks differ from other possible breakpoint locations in that the context (among other things) may be in a register and not on the stack, making it impossible to recover during deoptimization. The frame_inspector then returns undefined when asked for the context. In GetFrameDetails, handle this case by omitting all context-allocated variables. BUG=v8:5279 Review-Url: https://codereview.chromium.org/2245603002 Cr-Commit-Position: refs/heads/master@{#38611}
-
yangguo authored
This test would have failed prior to 58524d6d. R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2235323003 Cr-Commit-Position: refs/heads/master@{#38610}
-
mlippautz authored
Decrease regular heap object size to 400k. In a follow up, we can now get rid of the new space border page while keeping the 1M minimum new space size. BUG=chromium:636331 This reverts commit 555c9619. Review-Url: https://codereview.chromium.org/2232653003 Cr-Commit-Position: refs/heads/master@{#38608}
-
machenbach authored
BUG=v8:5193 NOTRY=true Review-Url: https://codereview.chromium.org/2238193002 Cr-Commit-Position: refs/heads/master@{#38600}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2231813003 Cr-Commit-Position: refs/heads/master@{#38599}
-
yangguo authored
Previously, we would both instrument the code, and add/remove BreakPointInfo objects through BreakLocation. This is bad design and unsuitable for having two different code kinds. We would now add/remove BreakPointInfo objects, and use that as source of truth when instrumenting the code. If we have both bytecode and FCG code, we would simply apply these break points twice to either. Notable changes: - Removed many functionality from BreakLocation. - Instrumentation (patching code for breaks) happens by applying break point info onto code. - Instrumentation (code patching) is done by the BreakIterator. For bytecode, it's BytecodeArrayBreakIterator. For FCG code, it's CodeBreakIterator. - Changes to code instrumentation mostly involves clearing current instrumentation and then (re-)applying break points. - DebugInfo can now reference both bytecode and FCG code. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2238893002 Cr-Commit-Position: refs/heads/master@{#38596}
-
- 11 Aug, 2016 11 commits
-
-
dgozman authored
This target introduces a dependency on WebKit/platform which is not the way we want it. Keeping the build files in src/inspector, as they are not used and will be useful later on. BUG=none NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2239603002 Cr-Commit-Position: refs/heads/master@{#38587}
-
rmcilroy authored
This optimization required access to the heap which we can't do off-thread. There doesn't seem to be a regression without this optmization in anycase, so just rip it out. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2238853002 Cr-Commit-Position: refs/heads/master@{#38585}
-
mlippautz authored
Use CollectAllAvailableGarbage for initial GC. R=hpayer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2236403002 Cr-Commit-Position: refs/heads/master@{#38584}
-
machenbach authored
Revert of Throw when case mapping result > max string length (patchset #3 id:40001 of https://codereview.chromium.org/2236593002/ ) Reason for revert: The test is very flaky and made it on many configurations into the top 10 of the slowest tests: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/845 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/15418 https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/12369/steps/Check/logs/durations Original issue's description: > Throw when case mapping result > max string length > > Throw 'Range Error: invalid string length' when the result of > case mapping is longer than the max string length (kMaxLength in > objects.h = 1 << 28 - 16). > > This is for case mapping with ICU. > > BUG=v8:5271 > TEST=intl/general/case-mapping.js with --icu_case_mapping > > Committed: https://crrev.com/c7a2046670468b900b9dbbb4ce45beb5e0e717fd > Cr-Commit-Position: refs/heads/master@{#38565} TBR=littledan@chromium.org,jshin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5271 Review-Url: https://codereview.chromium.org/2236393002 Cr-Commit-Position: refs/heads/master@{#38582}
-
hpayer authored
BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2236543002 Cr-Commit-Position: refs/heads/master@{#38581}
-
verwaest authored
BUG=v8:5209 Review-Url: https://codereview.chromium.org/2230323004 Cr-Commit-Position: refs/heads/master@{#38580}
-
jpp authored
------------------------------------------------------------------------ This CL adds support for decoding eh-related wasm opcodes: * Throw: used for raising an exception; the thrown value lives on top of the evaluation stack; * TryCatch: used to start a try block that has a catch clause; * TryFinally: used to start a try block that has a finally clause; * TryCatchFinally: used to start a try block that has both catch and finally clauses; * Catch <local>: used to start the catch block of a TryCatch/TryCatchFinally block; the thrown value is stored in local <local>; and * Finally: used to start a finally block of TryFinally/TryCatchFinally. Three different opcodes are used to start a try block to simplify the AST construction during bytecode parsing. BUG= Review-Url: https://codereview.chromium.org/2222193004 Cr-Commit-Position: refs/heads/master@{#38579}
-
bmeurer authored
This adds a very first version of inlined Array.prototype.pop into TurboFan optimized code. We currently limit the inlining to fast object or smi elements, until the unclear situation around hole NaNs is resolved and we have a clear semantics inside the compiler. It's also probably overly defensive in when it's safe to inline the call to Array.prototype.pop, but we can always extend that later once we have sufficient trust in the implementation and see an actual need to extend it. BUG=v8:2229,v8:3952,v8:5267 R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2239703002 Cr-Commit-Position: refs/heads/master@{#38578}
-
bgeron authored
These places were found by the trybots. - regress-crbug-485410 BUG= Review-Url: https://codereview.chromium.org/2230923002 Cr-Commit-Position: refs/heads/master@{#38572}
-
ahaas authored
With this CL all kinds of Callable can imported into wasm. Please take a special look at the context that is used now in the WasmToJSWrapper. BUG=633895 TEST=mjsunit/wasm/ffi.js Review-Url: https://codereview.chromium.org/2208703002 Cr-Commit-Position: refs/heads/master@{#38569}
-
bmeurer authored
When we change representation from Float64 to Tagged and we know that the input value can never be -0, we don't need to bother introducing the check for -0 during effect/control linearization. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2231963002 Cr-Commit-Position: refs/heads/master@{#38568}
-
- 10 Aug, 2016 8 commits
-
-
jshin authored
Throw 'Range Error: invalid string length' when the result of case mapping is longer than the max string length (kMaxLength in objects.h = 1 << 28 - 16). This is for case mapping with ICU. BUG=v8:5271 TEST=intl/general/case-mapping.js with --icu_case_mapping Review-Url: https://codereview.chromium.org/2236593002 Cr-Commit-Position: refs/heads/master@{#38565}
-
gdeepti authored
This CL reverts the runtime lowering introduced here - https://codereview.chromium.org/1991143002/ Additional ops to the runtime pass will cause GC issues as WASM frames may have outgoing arguments to runtime calls that have pointers that aren't scanned. Preserving decoding of SIMD opcodes and macros for native implementations. R=bbudge@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2235013002 Cr-Commit-Position: refs/heads/master@{#38564}
-
lpy authored
1. The third parameter of strncpy should be the length of source string. 2. Value contains " should be valid. BUG=v8:4561 Review-Url: https://codereview.chromium.org/2232683002 Cr-Commit-Position: refs/heads/master@{#38563}
-
littledan authored
This patch adds additional tests for async functions and generators, in how they interact with destructuring, default arguments and shadow parameter copying. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2229243002 Cr-Commit-Position: refs/heads/master@{#38560}
-
adamk authored
This changes Scope::function_ (for holding the name binding for named function expression) from a VariableDeclaration to a Variable. No work is done when visiting this declaration, since it's kCreatedInitialized, so we can treat it like other function-specific variables. This simplifies a wide variety of code, and centralizes the logic for constructing the variable inside scopes.cc. This may one day make it easier to eliminate the CONST_LEGACY VariableMode. R=neis@chromium.org, verwaest@chromium.org BUG=v8:5209 Review-Url: https://codereview.chromium.org/2232633002 Cr-Commit-Position: refs/heads/master@{#38558}
-
adamk authored
R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2233533002 Cr-Commit-Position: refs/heads/master@{#38556}
-
adamk authored
In addition, make use of Variable::binding_needs_init() in addition to VariableMode when deciding whether to do hole checking in variable assignment. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2227203002 Cr-Commit-Position: refs/heads/master@{#38555}
-
lpy authored
This patch is based on alph's CL https://codereview.chromium.org/2128613004/. This patch makes GetStackSample propogate the register state when using simulator helper, and adds argument to avoid using register state from simulator when pass the native register state. BUG=v8:4789 LOG=N Review-Url: https://codereview.chromium.org/2189513002 Cr-Commit-Position: refs/heads/master@{#38554}
-