- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 12 Oct, 2018 1 commit
-
-
Clemens Hammacher authored
LockGuard is mostly used with Mutex. Since both are defined outside the internal namespace, we often have to write {base::LockGuard<base::Mutex>}. This CL shortens this to {base::MutexGuard} across the code base R=mlippautz@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I020d5933b73aafb98c4b72e3bb2dfd07c979ba73 Reviewed-on: https://chromium-review.googlesource.com/c/1278796Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56612}
-
- 16 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837, v8:6921 Change-Id: I0c2deaea3f2ff5b5b25ba658470850534f1900ac Reviewed-on: https://chromium-review.googlesource.com/681435 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48594}
-
- 13 Oct, 2017 1 commit
-
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 01 Mar, 2016 1 commit
-
-
yangguo authored
R=rossberg@chromium.org, ulan@chromium.org, vogelheim@chromium.org Review URL: https://codereview.chromium.org/1751863002 Cr-Commit-Position: refs/heads/master@{#34395}
-
- 20 Aug, 2015 2 commits
-
-
mstarzinger authored
This CL us a pure refactoring that makes an empty compilation unit including just "snapshot.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1287113010 Cr-Commit-Position: refs/heads/master@{#30270}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 27 Mar, 2015 1 commit
-
-
yangguo authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1041743002 Cr-Commit-Position: refs/heads/master@{#27501}
-
- 25 Feb, 2015 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org BUG=chromium:461259 LOG=N Review URL: https://codereview.chromium.org/949623006 Cr-Commit-Position: refs/heads/master@{#26845}
-
- 13 Feb, 2015 1 commit
-
-
Ross McIlroy authored
The external_snapshot_blob is a global and might be accessed from multiple threads. Protect it with a lock. BUG=457656 LOG=N R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/918213002 Cr-Commit-Position: refs/heads/master@{#26638}
-
- 14 Jan, 2015 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/848023002 Cr-Commit-Position: refs/heads/master@{#26049}
-
- 10 Dec, 2014 2 commits
-
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/789213002 Cr-Commit-Position: refs/heads/master@{#25747}
-
yangguo authored
Review URL: https://codereview.chromium.org/791723004 Cr-Commit-Position: refs/heads/master@{#25741}
-
- 09 Dec, 2014 2 commits
-
-
machenbach authored
Revert of Use same blob format for internal and external snapshots. (patchset #2 id:20001 of https://codereview.chromium.org/787033002/) Reason for revert: [sheriff] breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1293 Original issue's description: > Use same blob format for internal and external snapshots. > > R=vogelheim@chromium.org TBR=vogelheim@chromium.org,yangguo@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/792563002 Cr-Commit-Position: refs/heads/master@{#25729}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/787033002 Cr-Commit-Position: refs/heads/master@{#25727}
-
- 05 Dec, 2014 1 commit
-
-
yangguo authored
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_nosnap_rel Review URL: https://codereview.chromium.org/781943002 Cr-Commit-Position: refs/heads/master@{#25681}
-
- 04 Dec, 2014 2 commits
-
-
machenbach authored
Revert of Encode reservation meta data in the snapshot blob. (patchset #3 id:40001 of https://codereview.chromium.org/781443002/) Reason for revert: [sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/1540 Original issue's description: > Encode reservation meta data in the snapshot blob. > > This also makes reserving multiple chunks per object space possible. > > R=vogelheim@chromium.org TBR=vogelheim@chromium.org,baixo@chromium.org,yangguo@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/780833002 Cr-Commit-Position: refs/heads/master@{#25654}
-
yangguo authored
This also makes reserving multiple chunks per object space possible. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/781443002 Cr-Commit-Position: refs/heads/master@{#25652}
-
- 29 Oct, 2014 1 commit
-
-
rmcilroy@chromium.org authored
R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/684263002 Patch from André Baixo <baixo@google.com>. Cr-Commit-Position: refs/heads/master@{#24998} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24998 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/653033002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Sep, 2014 1 commit
-
-
yangguo@chromium.org authored
R=hpayer@chromium.org, mvstanton@chromium.org Review URL: https://codereview.chromium.org/581223004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2014 1 commit
-
-
jochen@chromium.org authored
> We also initialize the Isolate on creation. > > This should allow for getting rid of the last remaining default isolate > traces. Also, it'll speed up several isolate related operations that no > longer require locks. > > Embedders that relied on v8::Isolate to return an uninitialized Isolate > (so they can set ResourceConstraints for example, or set flags that > modify the way the isolate is created) should either do the setup before > creating the isolate, or use the recently added CreateParams to pass e.g. > ResourceConstraints. > > BUG=none > LOG=y > R=svenpanne@chromium.org > > Review URL: https://codereview.chromium.org/469783002 BUG=none LOG=y TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/583153002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 2 commits
-
-
jochen@chromium.org authored
LOG=n TBR=svenpanne@chromium.org BUG=none Review URL: https://codereview.chromium.org/582953002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24055 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
We also initialize the Isolate on creation. This should allow for getting rid of the last remaining default isolate traces. Also, it'll speed up several isolate related operations that no longer require locks. Embedders that relied on v8::Isolate to return an uninitialized Isolate (so they can set ResourceConstraints for example, or set flags that modify the way the isolate is created) should either do the setup before creating the isolate, or use the recently added CreateParams to pass e.g. ResourceConstraints. BUG=none LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/469783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24052 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
TBR=yangguo@chromium.org LOG=n BUG=none Review URL: https://codereview.chromium.org/341433005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Jun, 2014 2 commits
-
-
Jacob.Bramley@arm.com authored
This corrects a linter complaint. BUG= R=mstarzinger@chromium.org, vogelheim@chromium.org Review URL: https://codereview.chromium.org/351643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21947 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vogelheim@chromium.org authored
[Re-retry of r21696 and r21739] If the embedder chooses, the 'natives' (library sources) and the precompiled startup blob can be written to files during the build process and handed over to V8 at startup. The main purpose would be to reduce the size of the compiled binary for space constrained platforms. The build-time option is off by default. Nothing should change if it's not enabled. BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/334913004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21941 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jun, 2014 1 commit
-
-
machenbach@chromium.org authored
This reverts commit r21696 for breaking chromium windows compilation in the chromium cq. Conflicts: src/d8.cc BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/328693003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Jun, 2014 1 commit
-
-
vogelheim@chromium.org authored
[Retry of crrev.com/293993021, which caused problems with 'ninja all' in Chromium. First patch set if a clean apply of crrev.com/293993021. Subsequent sets are the actual fix for that issue.] If the embedder chooses, the 'natives' (library sources) and the precompiled startup blob can be written to files during the build process and handed over to V8 at startup. The main purpose would be to reduce the size of the compiled binary for space constrained platforms. The build-time option is off by default. Nothing should change if it's not enabled. BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/315033002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jun, 2014 1 commit
-
-
mvstanton@chromium.org authored
This reverts commit r21646, as it blocks pushing to chromium. TBR=vogelheim@chromium.org Review URL: https://codereview.chromium.org/317633003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
vogelheim@chromium.org authored
If the embedder chooses, the 'natives' (library sources) and the precompiled startup blob can be written to files during the build process and handed over to V8 at startup. The main purpose would be to reduce the size of the compiled binary for space constrained platforms. The build-time option is off by default. Nothing should change if it's not enabled. BUG= R=bmeurer@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/293993021 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-