1. 18 Feb, 2020 1 commit
  2. 05 Nov, 2019 1 commit
    • Eric Leese's avatar
      V8 Wasm locations should always be based on byte offsets · 5c23e6b5
      Eric Leese authored
      Currently there are two ways wasm locations are represented in the
      inspector. This remains unchanged for now. Also, currently there are
      multiple ways location is represented within V8, with the line number
      sometimes being a function index and sometimes being 0, and the column
      number being a byte offset which is sometimes function relative and
      sometimes module relative. With this change, the line number is never
      used within V8 (it is always 0), and the column number is always a
      byte offset from the beginning of the module. This simplifies
      translation logic and keeps it in one place, and will simplify future
      changes to wasm location representation in the inspector API.
      
      Bug: chromium:1013527
      Change-Id: I8813d47c881988f9ab49d7529fb81fe10dbbccff
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886915
      Commit-Queue: Eric Leese <leese@chromium.org>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64774}
      5c23e6b5
  3. 11 Jun, 2019 1 commit
  4. 30 Jan, 2019 1 commit
  5. 26 Oct, 2017 1 commit
  6. 12 Jun, 2017 1 commit
    • Clemens Hammacher's avatar
      [wasm] Decode and use module name · 237d21b2
      Clemens Hammacher authored
      * add functionality to wasm-module-builder.js to emit the module name
        in the name section.
      * extend WasmModule to store the module name length and offset.
      * add functionality to module-decoder.cc to decode the module name.
      * use the module name for printing stack traces. more uses should
        follow.
      * extend one message test to contain a module name.
      
      R=ahaas@chromium.org
      
      Change-Id: I94e6f1f2eb99cb656a92a85bb7afe0742292046f
      Reviewed-on: https://chromium-review.googlesource.com/530366Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#45846}
      237d21b2