- 12 May, 2015 4 commits
-
-
yangguo authored
Revert of Provide accessor for object internal properties that doesn't require debugger to be active (patchset #3 id:40001 of https://codereview.chromium.org/1126103006/) Reason for revert: GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio Original issue's description: > Provide accessor for object internal properties that doesn't require debugger to be active > > Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. > > Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. > > BUG=chromium:481845 > LOG=Y > > Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > Cr-Commit-Position: refs/heads/master@{#28362} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481845 Review URL: https://codereview.chromium.org/1133243002 Cr-Commit-Position: refs/heads/master@{#28365}
-
yurys authored
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. BUG=chromium:481845 LOG=Y Review URL: https://codereview.chromium.org/1126103006 Cr-Commit-Position: refs/heads/master@{#28362}
-
yurys authored
If there had been no debug listener v8::Debug::GetDebugContext would have created new context and wouln't have kept reference to it. This way we may well end up with several debug contexts and disabled debugger. As a side effect this change allows to efficiently distinguish debug context from blink contexts by simply comparing handles. BUG=chromium:482290 LOG=Y Review URL: https://codereview.chromium.org/1136733002 Cr-Commit-Position: refs/heads/master@{#28356}
-
jochen authored
Embedders need to always pass CreateParams now BUG=none LOG=y R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1133723004 Cr-Commit-Position: refs/heads/master@{#28353}
-
- 11 May, 2015 2 commits
-
-
erikcorry authored
R=jkummerow@chromium.org,hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1125383007 Cr-Commit-Position: refs/heads/master@{#28335}
-
machenbach authored
Revert of Add the concept of a V8 extras exports object (patchset #5 id:80001 of https://codereview.chromium.org/1128113006/) Reason for revert: [Sheriff] Causes gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2167 Original issue's description: > Add the concept of a V8 extras exports object > > Exposed to the extras as extrasExports (on the builtins object), on > which they can put things that should be accessible from C++. Exposed > to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). > > Adding a test (in test-api.cc) required adding a simple extra, > test-extra.js, which we build into the standalone builds. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 > Cr-Commit-Position: refs/heads/master@{#28317} TBR=jochen@chromium.org,yangguo@chromium.org,domenic@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1127313005 Cr-Commit-Position: refs/heads/master@{#28332}
-
- 08 May, 2015 1 commit
-
-
domenic authored
Exposed to the extras as extrasExports (on the builtins object), on which they can put things that should be accessible from C++. Exposed to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). Adding a test (in test-api.cc) required adding a simple extra, test-extra.js, which we build into the standalone builds. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1128113006 Cr-Commit-Position: refs/heads/master@{#28317}
-
- 06 May, 2015 1 commit
-
-
ben authored
I know the bug has been closed but this seems like a simple addition that may be useful in other ways as well. BUG=v8:2180 LOG=N Review URL: https://codereview.chromium.org/1128553002 Cr-Commit-Position: refs/heads/master@{#28261}
-
- 05 May, 2015 1 commit
-
-
bmeurer authored
These macros are not needed anymore, so there's no point in supporting them. Review URL: https://codereview.chromium.org/1123723003 Cr-Commit-Position: refs/heads/master@{#28214}
-
- 30 Apr, 2015 2 commits
-
-
jochen authored
Just give internal ones an ArrayBuffer with a NULL backing store. This simplifies the access checks a lot. BUG=v8:3996 R=hpayer@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1109353003 Cr-Commit-Position: refs/heads/master@{#28168}
-
Jochen Eisinger authored
R=machenbach@chromium.org TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1115133002 Cr-Commit-Position: refs/heads/master@{#28152}
-
- 29 Apr, 2015 2 commits
-
-
jochen authored
We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1116633002 Cr-Commit-Position: refs/heads/master@{#28127}
-
machenbach authored
Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/) Reason for revert: [Sheriff] This is still used and now blocks the roll here: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/47889 Original issue's description: > Reland: deprecate non-phantom weak callbacks > > BUG= > > Committed: https://crrev.com/3be656fb55ad49834ec8ec0a57ba858bb1b21f37 > Cr-Commit-Position: refs/heads/master@{#28094} TBR=jochen@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1117623002 Cr-Commit-Position: refs/heads/master@{#28121}
-
- 28 Apr, 2015 2 commits
-
-
ssid authored
For dumping memory statistics about v8 heap, we need the total available size of the heap. This CL adds extra field in HeapStatistics to return the available size. BUG=476013 LOG=Y Review URL: https://codereview.chromium.org/1104123002 Cr-Commit-Position: refs/heads/master@{#28100}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1103173002 Cr-Commit-Position: refs/heads/master@{#28094}
-
- 27 Apr, 2015 3 commits
-
-
machenbach authored
Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/) Reason for revert: [Sheriff] Fails compilation on chromium android: http://build.chromium.org/p/client.v8/builders/Android%20Builder/builds/4131 Is the chromium version our builder used maybe too old (it uses lkcr)? In that case please reland as soon as it's up-to-date. Original issue's description: > deprecate non-phantom weak callbacks > > BUG= > > Committed: https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982 > Cr-Commit-Position: refs/heads/master@{#28077} TBR=jochen@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1104163002 Cr-Commit-Position: refs/heads/master@{#28079}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1103173002 Cr-Commit-Position: refs/heads/master@{#28077}
-
yangguo authored
The debug event BreakForCommand is now deprecated, as it cannot happen any longer. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1089893002 Cr-Commit-Position: refs/heads/master@{#28071}
-
- 22 Apr, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1104463002 Cr-Commit-Position: refs/heads/master@{#27994}
-
- 21 Apr, 2015 2 commits
-
-
jochen authored
BUG=none R=danno@chromium.org LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1098873002 Cr-Commit-Position: refs/heads/master@{#27957}
-
dcarney authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/679143002 Cr-Commit-Position: refs/heads/master@{#27951}
-
- 20 Apr, 2015 4 commits
-
-
jochen authored
The embedder has to take appropriate steps to ensure that the ArrayBuffer doesn't die while it's accessing the pointer, e.g. keep a Local handle to it around BUG=none R=dslomov@chromium.org LOG=y Review URL: https://codereview.chromium.org/1095083002 Cr-Commit-Position: refs/heads/master@{#27942}
-
jochen authored
Embedders should use ArrayBuffers instead BUG=v8:3996 LOG=y R=verwaest@chromium.org,dslomov@chromium.org,kbr@chromium.org Review URL: https://codereview.chromium.org/1092923002 Cr-Commit-Position: refs/heads/master@{#27939}
-
jochen authored
Embedders should use the 2-args version. Number of cores is just ignored. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1080633006 Cr-Commit-Position: refs/heads/master@{#27938}
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 17 Apr, 2015 2 commits
-
-
ssid authored
This class was added in crrev.com/1058253003 and missed V8_EXPORT in definition. BUG=466141, 476013 LOG=Y Review URL: https://codereview.chromium.org/1090333002 Cr-Commit-Position: refs/heads/master@{#27926}
-
ssid authored
This is first step towards adding V8 heap statistics to the memory tracing infrastructure. For being able to get useful memory number into the memory dump, v8 needs to provide an external api needs to obtain more information about the heap. So, this Cl extends the api to give information about the memory allocated and used in the spaces. BUG=466141, 476013 LOG=Y Review URL: https://codereview.chromium.org/1058253003 Cr-Commit-Position: refs/heads/master@{#27919}
-
- 15 Apr, 2015 2 commits
-
-
jochen authored
The embedder can control how many threads it wants to use via the v8::Platform implementation. V8 internally doesn't spin up threads anymore. If the embedder doesn't want to use any threads at all, it's v8::Platform implementation must either run the background jobs on the foreground thread, or the embedder should specify --predictable BUG=none R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/1064723005 Cr-Commit-Position: refs/heads/master@{#27833}
-
jochen authored
An embedder that wants to avoid the check should use MaybeLocal::ToLocal. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1083943002 Cr-Commit-Position: refs/heads/master@{#27832}
-
- 14 Apr, 2015 1 commit
-
-
smcgruer authored
As uClibc defines __GLIBC__ in an attempt to look like glibc, V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc before glibc fixes this and restores the correct behavior. BUG= Review URL: https://codereview.chromium.org/1066573005 Cr-Commit-Position: refs/heads/master@{#27806}
-
- 13 Apr, 2015 1 commit
-
-
jochen authored
This allows the embedder to decide whether it's worthwhile to copy the contents to avoid materializing a buffer. BUG=v8:3996 R=dslomov@chromium.org,kbr@chromium.org LOG=y Review URL: https://codereview.chromium.org/1084513002 Cr-Commit-Position: refs/heads/master@{#27782}
-
- 10 Apr, 2015 4 commits
-
-
fedor authored
When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{#27766}
-
verwaest authored
This fixes the arm(64) and mips(64) write barriers BUG= Review URL: https://codereview.chromium.org/1073133002 Cr-Commit-Position: refs/heads/master@{#27751}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1074153002 Cr-Commit-Position: refs/heads/master@{#27750}
-
jochen authored
BUG=none R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1075133002 Cr-Commit-Position: refs/heads/master@{#27736}
-
- 09 Apr, 2015 3 commits
-
-
thakis authored
gcc rejects the following snippet, clang rejects it in -std=c++11 mode: namespace A { template<class T> class C {}; } namespace B { template class A::C<int>; } Indeed, the C++ standard says in 14.7.2p2 "An explicit instantiation shall appear in an enclosing namespace of its template", so cl.exe is incorrect to allow this. Just move the instantiation out of the v8 namespace to fix. No intended behavior change. Fixes building with clang-cl on Windows. BUG=chromium:475643 LOG=N TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1073903002 Cr-Commit-Position: refs/heads/master@{#27721}
-
adamk authored
Revert of Merge cellspace into old pointer space (patchset #8 id:180001 of https://codereview.chromium.org/1010803012/) Reason for revert: Causes test failures on ARM bots related to cells and write barriers. Original issue's description: > Merge cellspace into old pointer space > > BUG= > > Committed: https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 > Cr-Commit-Position: refs/heads/master@{#27707} TBR=hpayer@chromium.org,balazs.kilvady@imgtec.com,yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1053243003 Cr-Commit-Position: refs/heads/master@{#27711}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1010803012 Cr-Commit-Position: refs/heads/master@{#27707}
-
- 08 Apr, 2015 1 commit
-
-
loislo authored
BUG=chromium:452067 LOG=n Committed: https://crrev.com/baf927ff5115ec62a6dad684b9232ed9d3960e3a Cr-Commit-Position: refs/heads/master@{#27626} Review URL: https://codereview.chromium.org/1045753002 Cr-Commit-Position: refs/heads/master@{#27674}
-
- 07 Apr, 2015 1 commit
-
-
machenbach authored
Revert of CpuProfiler: public API for deopt info in cpu profiler. (patchset #6 id:150001 of https://codereview.chromium.org/1045753002/) Reason for revert: [Sheriff] Breaks compile here: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6115 Original issue's description: > CpuProfiler: public API for deopt info in cpu profiler. > > BUG=chromium:452067 > LOG=n > > Committed: https://crrev.com/baf927ff5115ec62a6dad684b9232ed9d3960e3a > Cr-Commit-Position: refs/heads/master@{#27626} TBR=alph@chromium.org,jkummerow@chromium.org,svenpanne@chromium.org,yurys@chromium.org,loislo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452067 Review URL: https://codereview.chromium.org/1062053004 Cr-Commit-Position: refs/heads/master@{#27628}
-