1. 09 Aug, 2018 1 commit
    • Ben L. Titzer's avatar
      [wasm] Add WasmFeatures to enable/detect features · 6aa2a253
      Ben L. Titzer authored
      This CL introduces a set of configuration options implemented as
      a struct of booleans that together comprise the set of enabled
      or detected features. The configuration options replace command-line
      flags that were checked deep in the implementation. As such, it is
      necessary to plumb them through multiple levels of abstraction.
      
      R=ahaas@chromium.org
      CC=mstarzinger@chromium.org
      BUG=chromium:868844
      
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Change-Id: I1b82f5826e4fd263f68e8cafcd923bac5818a637
      Reviewed-on: https://chromium-review.googlesource.com/1163670Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55018}
      6aa2a253
  2. 07 Aug, 2018 1 commit
    • Andreas Haas's avatar
      [wasm] During instantiation, pending_exceptions dominate new exceptions · 5f105141
      Andreas Haas authored
      For async instantiation of WebAssembly code we had the assumption that
      a pending exceptions (an exception which comes from
      execution JS code) and an ErrorThrower error cannot occur at the same
      time. This assumption turned out to be wrong. With this CL we handle
      this case by prefering pending_exceptions over ErrorThrower errors.
      
      In addition I extended the tests for failing instantiation to also
      exercise async instantiation, and I added a regression test.
      
      R=clemensh@chromium.org
      
      Bug: chromium:870646
      Change-Id: I4cb54ff8642ad4ea193b20f79905c9f6508c2b2e
      Reviewed-on: https://chromium-review.googlesource.com/1163511Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54940}
      5f105141
  3. 02 Aug, 2018 2 commits
    • Andreas Haas's avatar
      Revert "[wasm] Implement the new API for WebAssembly.instantiateStreaming" · fea9300d
      Andreas Haas authored
      This reverts commit b556c9ea.
      
      Reason for revert: Flakes in layout tests: https://crbug.com/870187
      
      Original change's description:
      > [wasm] Implement the new API for WebAssembly.instantiateStreaming
      > 
      > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to
      > make it spec compliant again. The design doc where the whole change is
      > discussed is available in the tracking bug. The tracking bug also
      > references prototype implementations of the whole change, which includes
      > the changes in this CL.
      > 
      > R=​mstarzinger@chromium.org
      > 
      > Bug: chromium:860637
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42
      > Reviewed-on: https://chromium-review.googlesource.com/1143187
      > Commit-Queue: Andreas Haas <ahaas@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54834}
      
      TBR=mstarzinger@chromium.org,ahaas@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:860637
      Change-Id: Icbf2603143068a49c61de162aa7185a753703e5d
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1160261Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54872}
      fea9300d
    • Ben L. Titzer's avatar
      [cleanup] Remove redundant wasm:: namespace prefixes · 99de47f1
      Ben L. Titzer authored
      The wasm/ directory is inconsistent in many places, often within the
      same file. For all code that exists in a v8::internal::wasm namespace,
      this CL removes any wasm:: qualifiers, which is especially helpful
      since most types are already Wasm-named, such as WasmCode, WasmModule,
      etc. Namespace qualifiers are redundant inside the wasm:: namespace and
      thus go against the main point of using namespaces. Removing the
      qualifiers for non Wasm-named classes also makes the code somewhat more
      future-proof, should we move some things that are not really WASM-specific
      (such as ErrorThrower and Decoder) into a higher namespace.
      
      R=clemensh@chromium.org,mstarzinger@chromium.org
      
      Change-Id: Ibff3e1e93c64c12dcb53c46c03d1bfb2fb0b7586
      Reviewed-on: https://chromium-review.googlesource.com/1160232
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54862}
      99de47f1
  4. 01 Aug, 2018 3 commits
  5. 31 Jul, 2018 2 commits
  6. 26 Jul, 2018 1 commit
  7. 25 Jul, 2018 1 commit
  8. 24 Jul, 2018 1 commit
  9. 16 Jul, 2018 3 commits
  10. 10 Jul, 2018 1 commit
    • Michael Starzinger's avatar
      [wasm] Add proper --turbo-stats-wasm flag. · dfffde4a
      Michael Starzinger authored
      This gathers TurboFan compilation statistics for WebAssembly separately
      from the JavaScript statistics. It is a preparation to having multiple
      Isolates trigger TurboFan compilations in a shared engine. By adding
      compilation statistics to the engine, their lifetime is independent of
      any particular Isolate.
      
      R=ahaas@chromium.org
      
      Change-Id: I1bd0fbe6d6bde65ca813ccfd1154558ea6cddb07
      Reviewed-on: https://chromium-review.googlesource.com/1131121
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54357}
      dfffde4a
  11. 28 Jun, 2018 1 commit
  12. 13 Jun, 2018 1 commit
  13. 11 Jun, 2018 1 commit
  14. 24 May, 2018 2 commits
  15. 09 May, 2018 1 commit
  16. 30 Apr, 2018 1 commit
  17. 27 Apr, 2018 1 commit
  18. 19 Mar, 2018 1 commit
  19. 02 Feb, 2018 1 commit
  20. 31 Jan, 2018 1 commit
  21. 22 Jan, 2018 1 commit
  22. 18 Jan, 2018 1 commit
  23. 17 Jan, 2018 1 commit
    • Ben L. Titzer's avatar
      [wasm] Hide SyncValidate() behind WasmEngine interface. · 84326fc4
      Ben L. Titzer authored
      This is the first in a series of CLs that will separate the JS API
      from the implementation of WebAssembly by bottlenecking interactions
      through the WasmEngine. In the long run, the JS API and much of V8
      should rely only on the WasmEngine interface, which will represent
      the "public interface" for embedding WebAssembly.
      
      Next: hide compilation-related methods behind WasmEngine.
      Bug: v8:7316
      Change-Id: I93404f0dc8a201ae99d30b4c1ca34606e3dddbca
      Reviewed-on: https://chromium-review.googlesource.com/868590
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50660}
      84326fc4