- 13 Mar, 2015 1 commit
-
-
arv authored
ES6 specs the function length property (it was not part of ES5) and it makes it configurable. BUG=v8:3045 LOG=N R=mstarzinger@chromium.org, adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/993073002 Cr-Commit-Position: refs/heads/master@{#27190}
-
- 12 Mar, 2015 1 commit
-
-
adamk authored
BUG=chromium:464695 LOG=n Review URL: https://codereview.chromium.org/1005553003 Cr-Commit-Position: refs/heads/master@{#27171}
-
- 04 Mar, 2015 1 commit
-
-
arv authored
Function name property is now standardized in ES6. It was a Mozilla proprietary extension before. With ES6, the property was made configurable, so that it can be used instead of another proprietary property, displayName. This is a revert of revert https://chromium.googlesource.com/v8/v8.git/+/c791d8411225aa95518c880defd9a5b1ea243afc. Last time this broke a Chrome browser test which has since been updated: https://chromium.googlesource.com/chromium/src/+/5f75a3be4c9334aba627d6c5eb884adf965e1d78 BUG=v8:3333 LOG=N R=mstarzinger@chromium.org,verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/977003004 Cr-Commit-Position: refs/heads/master@{#26996}
-
- 02 Mar, 2015 1 commit
-
-
arv authored
Revert of ES6: Make function name configurable (patchset #10 id:220001 of https://codereview.chromium.org/960343002/) Reason for revert: Breaks Chrome browser test that checks Object.name [16509:16509:0228/030150:INFO:CONSOLE(43)] "Uncaught Error: Clobbered Object.name getter", source: http://www.chromium.org:33611/assertions.js (43) http://build.chromium.org/p/client.v8/builders/Linux%20Tests%20%28dbg%29%281%29/builds/2328/steps/browser_tests/logs/stdio Original issue's description: > ES6: Make function name configurable > > This is partially based on r21609 but that CL was incomplete. > > Function name is still non writable so one has to use defineProperty > to change the actual value. > > BUG=v8:3333 > LOG=N > R=adamk, mstarzinger@chromium.org > > Committed: https://crrev.com/f7790f7670c8d859455a98fcb90ff1b66af1eca7 > Cr-Commit-Position: refs/heads/master@{#26924} TBR=adamk@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3333 Review URL: https://codereview.chromium.org/969683002 Cr-Commit-Position: refs/heads/master@{#26933}
-
- 27 Feb, 2015 1 commit
-
-
arv authored
This is partially based on r21609 but that CL was incomplete. Function name is still non writable so one has to use defineProperty to change the actual value. BUG=v8:3333 LOG=N R=adamk, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/960343002 Cr-Commit-Position: refs/heads/master@{#26924}
-
- 19 Dec, 2014 1 commit
-
-
adamk authored
This avoids touching the Array prototype, which may have been tampered with. BUG=chromium:443982 LOG=n Review URL: https://codereview.chromium.org/820503005 Cr-Commit-Position: refs/heads/master@{#25908}
-
- 05 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-collections flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. Depends on ES6 Symbols: https://codereview.chromium.org/421313004 BUG=v8:1622 LOG=Y R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/427723002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-symbols flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. BUG=v8:2158 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/421313004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jul, 2014 1 commit
-
-
danno@chromium.org authored
Also explicit length setting with a.length = N should remain in fast mode. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/416403002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jul, 2014 3 commits
-
-
verwaest@chromium.org authored
BUG=3462 LOG=Y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/417793002 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22606 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
Due to failures in mjsunit/array-functions-prototype-misc TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/417953004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
Also explicit length setting with a.length = N should remain in fast mode. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/397593008 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22595 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2014 2 commits
-
-
verwaest@chromium.org authored
Temporarily revert since blink has some properties like this on the prototype chain where it expects accessorpair-behavior (e.g., window.onload). TBR=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/378583002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=dcarney@chromium.org, mvstanton@chromium.org Review URL: https://codereview.chromium.org/368783006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22236 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 1 commit
-
-
aandrey@chromium.org authored
R=yangguo@chromium.org, adamk@chromium.org, rafaelw@chromium.org, rossberg@chromium.org BUG=chromium:272416 LOG=Y Review URL: https://codereview.chromium.org/362783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jul, 2014 2 commits
-
-
verwaest@chromium.org authored
Temporarily reverting until we figure out how to handle the API cases that use accessors to lazily compute values. dataAttributeGetterCustom in V8MessageEventCustom (at least) overwrites itself with the computed value using ForceSet. We can either force such clients to first use ForceDelete before caching, use some other caching mechanism; or provide an API for lazily computed properties. TBR=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/365903005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
This additionally removes special "prototype" handling for O.o, since it's broken; and added test. BUG= R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/368853003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
mvstanton@chromium.org authored
This reverts commit r21609 due to browser test failures. TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/313583002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:3333 LOG=N Review URL: https://codereview.chromium.org/303463006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=danno@google.com, danno@chromium.org Review URL: https://codereview.chromium.org/297163009 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:3333 LOG=N Review URL: https://codereview.chromium.org/296413003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 May, 2014 1 commit
-
-
adamk@chromium.org authored
Now throws if its argument is already observed, or if the argument is the global proxy. BUG=371782 LOG=Y R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/274163002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21256 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2014 1 commit
-
-
rossberg@chromium.org authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/266243003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 May, 2014 1 commit
-
-
rafaelw@chromium.org authored
This patch reverts r21062 which disabled Object.observe and the relevant tests. It also adds enforcement for the following three invariants: 1) No observer may receive a change record describing changes to an object which is in different security origin (context have differing security tokens) 2) No observer may receive a change record whose context's security token is different from that of the object described by the change. 3) Object.getNotifier will return null if the caller and the provided object are in differing security origins Further, it ensures that the global object can never be observed nor a notifier retrieved for it. Tests are included. R=verwaest@chromium.org, rossberg LOG=Y Review URL: https://codereview.chromium.org/265503002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
jochen@chromium.org authored
> R=mstarzinger@chromium.org > BUG= > > Committed: https://code.google.com/p/v8/source/detail?r=20211 > > Review URL: https://codereview.chromium.org/206163004 R=rossberg@chromium.org TBR=rossberg@chromium.org LOG=y BUG=n Review URL: https://codereview.chromium.org/219303002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20211 Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20313 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Reason: breaks Blink layout tests. R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/210853003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Split collections flag into weak and non-weak. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/201593004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20019 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Mar, 2014 1 commit
-
-
adamk@chromium.org authored
This re-re-re-lands enabling Object.observe. The Chromium tests that failed last time this was rolled into Chromium have been disabled in https://src.chromium.org/viewvc/chrome?view=revision&revision=256706 This patch should be safe to merge once that lands. BUG=v8:2409 LOG=Y TBR=rossberg@chromium.org,dslomov@chromium.org,rafaelw@chromium.org Review URL: https://codereview.chromium.org/198383002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Mar, 2014 1 commit
-
-
dslomov@chromium.org authored
This reverts commit r19734 for breeaking ChromiumOS browser tests. 'OpenSpecialTypes/FileManagerBrowserTest.Test/3' started to time out, bisecting the roll led to this change. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22224 TBR=rafaelw@chromium.org,rossberg@chromium.org BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/195123005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2014 3 commits
-
-
rafaelw@chromium.org authored
Original Issue: https://codereview.chromium.org/183683022/ TBR=rossberg BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/189513010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
TBR=rossberg BUG= Review URL: https://codereview.chromium.org/190853007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
R=rossberg@chromium.org, rossberg BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/183683022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-