- 31 May, 2017 12 commits
-
-
Clemens Hammacher authored
Most prototype implementations are not fully supported in the interpreter. This is the case at least for exception handling, simd, and atomics. Any function can be redirected to the interpreter though, either by passing --wasm-interpret-all, or by dynamically redirecting to the interpreter for debugging. Making the flags experimental keeps the fuzzer from playing around with these flags. Drive-by: Refactor tests which explicitly set the prototype flag to use a new scope for that. R=ahaas@chromium.org BUG=chromium:727584 Change-Id: I67da79f579f1ac93c67189afef40c6524bdd4430 Reviewed-on: https://chromium-review.googlesource.com/519402 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45639}
-
Alexey Kozyatinskiy authored
V8 provides ScriptCompiler::CompileFunctionInContext method which takes expression and compile it as anonymous function like (function() .. expression ..). To produce correct locations for stmts inside of this expression V8 compile this function with negative offset. Instead of stmt position blackboxing use function start position which is negative in described case. Bug: chromium:705963 Change-Id: I86b113198fb59e77b3bbf523c8cd943e22f8a6ca Reviewed-on: https://chromium-review.googlesource.com/519384 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#45637}
-
neis authored
Instead of allocating and embedding certain heap numbers into the code during code assembly, emit dummies but record the allocation requests. Later then, in Assembler::GetCode, allocate the heap numbers and patch the code by replacing the dummies with the actual objects. The RelocInfos for the embedded objects are already recorded correctly when emitting the dummies. R=jarin@chromium.org BUG=v8:6048 Review-Url: https://codereview.chromium.org/2900683002 Cr-Commit-Position: refs/heads/master@{#45635}
-
Tobias Tebbi authored
Bug: chromium:726638 Change-Id: Ib30b147ec60f9f13c5164765f8c63be7a1339e9f Reviewed-on: https://chromium-review.googlesource.com/517497Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#45634}
-
martyn.capewell authored
This reverts commit c5aad5f2 The CL was reverted due to missing Chromium dependencies. This commit removes the simulator trace-based tests, and the associated header file dependencies, previously pulled in by DEPS. The NEON support now has only hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added in a later patch. BUG=chromium:718439 Original issue's description: > Reland "ARM64: Add NEON support" > > This reverts commit cc047635. > The CL was reverted due to a missing DEPS mirror. > > Original issue's description: > > ARM64: Add NEON support > > > > Add assembler, disassembler and simulator support for NEON in the ARM64 backend. > > > > BUG= > > > > Review-Url: https://codereview.chromium.org/2622643005 > > Cr-Commit-Position: refs/heads/master@{#44306} > > BUG= > > Review-Url: https://codereview.chromium.org/2812573003 > Cr-Commit-Position: refs/heads/master@{#44652} Review-Url: https://codereview.chromium.org/2896303003 Cr-Commit-Position: refs/heads/master@{#45633}
-
Ulan Degenbaev authored
BUG=v8:6277 Change-Id: I80314e6c5146e1f5021d07081b9eda3da5da6834 Reviewed-on: https://chromium-review.googlesource.com/518047 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45632}
-
jgruber authored
BUG=v8:5737 Review-Url: https://codereview.chromium.org/2913783002 Cr-Commit-Position: refs/heads/master@{#45629}
-
Alexey Kozyatinskiy authored
In current implementation in expressions like await foo() we have break location right after foo call and before actual await. And we additionally have a lot of other statement locations because of do scope. Let's move async debugging closer to sync debugging and introduce only one break location for await - before awaited function call. Bug: v8:6425,v8:6162 Change-Id: I7568767856022c49101e7f3b7e39a2e401d21644 Reviewed-on: https://chromium-review.googlesource.com/514046Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45625}
-
Peter Marshall authored
Causes crashes on canary if there is a GC and the value makes it onto the stack. Bug: chromium:727662 Change-Id: I44fa8cf8a83b43d64418896c0a1f5518401b454f Reviewed-on: https://chromium-review.googlesource.com/519302Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#45623}
-
dusan.simicic authored
Add support for insert.df, andi.b, ori.b, nori.b, xori.b, bmnzi.b, bmzi.b, bseli.b, shf.df MSA instructions in mips32 and mips64 simulator. BUG= Review-Url: https://codereview.chromium.org/2908753002 Cr-Commit-Position: refs/heads/master@{#45620}
-
Igor Sheludko authored
TBR=jarin@chromium.org NOTRY=true Bug: v8:6447 Change-Id: Ied42c4ba8fc19f2441f6c2ffd31d3f56055ac487 Reviewed-on: https://chromium-review.googlesource.com/518823Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45616}
-
Marja Hölttä authored
- Enable aggressive lazy inner funcs (make non-declaration funcs lazy, ie let f = function() { ... } when --experimental-preparser-scope-analysis is on. - Turn on variable tracking for lazy top level functions: this makes their inner functions skippable. - Test fix for an testing bug uncovered by this work: when restoring the data for the relevant scope, don't assume it's the outermost scope for which we have data. - Fix: if we abort lazy parsing a function, we shouldn't produce any data for it. BUG=v8:5516 Change-Id: I0606fbabb5886dc57dbb53ab5f3fb894ff5d032e Reviewed-on: https://chromium-review.googlesource.com/518165Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45615}
-
- 30 May, 2017 8 commits
-
-
Jochen Eisinger authored
Use the appropriate ENTER_V8* macros instead BUG=v8:5830 R=marja@chromium.org Change-Id: I85d7ae69830f6bad4f7057c4a646906846a1baa0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/517793 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45612}
-
jgruber authored
This adds a bunch of assertions to CSA, mostly about documenting and checking parameter types. Drive-by-change: Removed unused function. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Original-Commit-Position: refs/heads/master@{#45398} Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Commit-Position: refs/heads/master@{#45443} Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda Review-Url: https://codereview.chromium.org/2847923003 Cr-Commit-Position: refs/heads/master@{#45607}
-
Camillo Bruni authored
Bug: chromium:726836 Change-Id: I2eaec8550e7ba038646a1f7834d4514a8d4009ea Reviewed-on: https://chromium-review.googlesource.com/517954Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45604}
-
Marja Hölttä authored
It's extremely difficult to get right: there have been several bugs related to this feature, especially when combined with non-simple parameter lists in arrow functions. BUG=chromium:727218 Change-Id: I97dfbc57a7650199964c5fe99de69143c8e537c2 Reviewed-on: https://chromium-review.googlesource.com/518145 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#45603}
-
Aleksey Kozyatinskiy authored
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. Benefits (see test for details): - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5909 Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294 Reviewed-on: https://chromium-review.googlesource.com/518116 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45598}
-
Igor Sheludko authored
This may happen in KeyedStoreIC when the last store via setter deprecates the receiver map. Bug: chromium:723366 Change-Id: Iff19e50c3761584401340d276ab4eead111883c3 Reviewed-on: https://chromium-review.googlesource.com/517952Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45592}
-
Clemens Hammacher authored
This time for the current memory size. This call also used to use the context object stored in the instance, hence it required the instance to be set. This is no longer the case, so the DCHECKs can just be removed. R=ahaas@chromium.org BUG=chromium:727222 Change-Id: I72a7e3e80c3beb15ecad00c5be068e803456797e Reviewed-on: https://chromium-review.googlesource.com/517947Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45587}
-
ulan authored
This is consistent with C++ memory model and avoids confusion with GC write barrier. BUG= Review-Url: https://codereview.chromium.org/2912773002 Cr-Commit-Position: refs/heads/master@{#45584}
-
- 29 May, 2017 14 commits
-
-
kschimpf authored
By moving StatsTable from class Isolate to class Counters, it make the class StatsTable thead safe. This is needed because these two classes call each other, and for background compilation, instances of the Counters class can persist longer that the corresponding Isolate it came from. It also removes unnecessary hops to the the Isolate, and checks if the StatsTable has been created, for these communications. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2906063002 Cr-Commit-Position: refs/heads/master@{#45576}
-
Michael Starzinger authored
This widens the range of value output counts to 32 bit on the {Operator} class. Note that the limit imposed by the parser is 65535 parameters for each function, but the {Start} node has additional value outputs. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-724153 BUG=chromium:724153 Change-Id: I21b5d947cc2305b255ddbbff6ec1dfa5c02784c7 Reviewed-on: https://chromium-review.googlesource.com/517489Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45573}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2906313002 Cr-Commit-Position: refs/heads/master@{#45571}
-
ulan authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2910933002 Cr-Commit-Position: refs/heads/master@{#45570}
-
Peter Marshall authored
Bug: chromium:725865 Change-Id: I94006d45aefb969fb0cf98ec475c30c14b3837fa Reviewed-on: https://chromium-review.googlesource.com/517488Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#45567}
-
Marja Hölttä authored
BUG=v8:5402 Change-Id: If5f763e6a11d446e36719277a18b00a0cd8df8fa Reviewed-on: https://chromium-review.googlesource.com/517162 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45565}
-
Camillo Bruni authored
Bug: v8:6211 Change-Id: If6d2ef7889ae6a0c3aa430d3f69c53f19cc1f1c6 Reviewed-on: https://chromium-review.googlesource.com/509571Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45563}
-
Clemens Hammacher authored
For lazy compilation, we encode information about table exports in the deoptimization data. This information is rebuilt on each instantiation, so we need to reset it when reusing code objects from another instance. R=ahaas@chromium.org BUG=chromium:727219 Change-Id: I90557ef06e692d0a8323223cac26679efcfa408b Reviewed-on: https://chromium-review.googlesource.com/517945Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45559}
-
Jochen Eisinger authored
All APIs that can throw exceptions should return Maybe<> values BUG=none R=neis@chromium.org,gsathya@chromium.org Change-Id: I6a6e5888cd71257bb02bdcfcc587c909d0c1d8f4 Reviewed-on: https://chromium-review.googlesource.com/517785 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#45557}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2900603004 Cr-Commit-Position: refs/heads/master@{#45553}
-
Michael Achenbach authored
Tests should instead be skipped or fixed. Existing timeout expectations are either optimistically deleted or replaced by the SLOW keyword. Change-Id: Ic43f52bf18d0702674c95f9263a109041a1c9cd8 Reviewed-on: https://chromium-review.googlesource.com/518122Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45552}
-
Sathya Gunasekaran authored
Implements the Allocate, Add, and HasKey operations. Also, adds GC support for this new instance type. Bug: v8:6443 Change-Id: I1cc7ba2faead2a11f7b0381a57858629e123aee6 Reviewed-on: https://chromium-review.googlesource.com/500447 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45551}
-
Ilija.Pavlovic authored
The test OneByteArrayJoin failed on MIPS64 in debug mode after https://chromium-review.googlesource.com/c/489946/ with error messages "allocation failure GC in old space requested" and "Fatal javascript OOM in CALL_AND_RETRY_LAST". Successful test execution is possible on two ways: with flag --max_old_space_size=7 or with modification in the test (constraints.set_max_old_space_size(7)). TEST=cctest/test-strings/OneByteArrayJoin BUG= Review-Url: https://codereview.chromium.org/2907803002 Cr-Commit-Position: refs/heads/master@{#45548}
-
Michael Achenbach authored
This reverts commit 7a9cc704. Reason for revert: Changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15882 This is about: inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html Original change's description: > [inspector] moved var initialization break location before init expression > > This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. > Benefits (see test for details): > - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), > - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. > > Bug: v8:5909 > Change-Id: I039d911903a2826c9859710a63ab0462c992e11b > Reviewed-on: https://chromium-review.googlesource.com/513926 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45530} TBR=dgozman@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5909 Change-Id: Ibf84401e8050d3c84db219d983de2c6bba0f697f Reviewed-on: https://chromium-review.googlesource.com/518102Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45547}
-
- 26 May, 2017 3 commits
-
-
Igor Sheludko authored
... to make AsyncFunction subclassing work. Bug: chromium:725537 Change-Id: I7edf4891e14e01567046e7536b3aa93877111448 Reviewed-on: https://chromium-review.googlesource.com/517087 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#45544}
-
Ross McIlroy authored
BUG=v8:6243 Change-Id: Ia6dfa407591d1b06d5b014627bb44413540aecb3 Reviewed-on: https://chromium-review.googlesource.com/516984Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45542}
-
Sathya Gunasekaran authored
Bug: chromium:726636 Change-Id: Ied6af8c969ed05b7a334238b30930658af060e7d Reviewed-on: https://chromium-review.googlesource.com/516734Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#45537}
-
- 25 May, 2017 2 commits
-
-
Alexey Kozyatinskiy authored
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. Benefits (see test for details): - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. Bug: v8:5909 Change-Id: I039d911903a2826c9859710a63ab0462c992e11b Reviewed-on: https://chromium-review.googlesource.com/513926 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#45530}
-
dusan.simicic authored
- Increase FPUregisters_[] element size to 128b in order to support MSA regs - Add skeleton for MSA instr. decoding in mips32 and mips64 simulator - Add support for fill.df, copy_u.df and copy_s.df MSA instructions - Assembler test for fill.df, copy_u.df and copy_s.df BUG= Review-Url: https://codereview.chromium.org/2799923002 Cr-Commit-Position: refs/heads/master@{#45529}
-
- 24 May, 2017 1 commit
-
-
ivica.bogosavljevic authored
Compilation failure is result to overloaded-virtual warning treated as error. BUG= Review-Url: https://codereview.chromium.org/2895923002 Cr-Commit-Position: refs/heads/master@{#45525}
-