- 14 May, 2019 2 commits
-
-
Simon Zünd authored
This CL adds support for macros, builtins, generics and specializations for the "textDocument/symbol" request. To filter out implicitly created specializations, the "is_user_defined" flag is hoisted from Macro to the Declarable super class. As a side-effect, errors thrown during specialization now have the correct SourcePosition. Drive-by-change: Using "Goto Definition" on the identifier of the specialization will jump to the associated generic. Bug: v8:8880 Change-Id: I0c60571c58107375c1b5d2a8e620cf12a0f0f3fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609795 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61486}
-
Simon Zünd authored
The language server needs Torque compilation artifacts like declarables for more advanced features. This CL moves the GlobalContext into the LanguageServerData class when Torque compilation finishes, to preserve all the compiler data. Additionally, all declarables are split up by source id. This makes providing all symbols of a file easier. R=tebbi@chromium.org Bug: v8:8880 Change-Id: I424d1ddc04fcd18934f76a736900bc5d08261c07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601132 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61462}
-
- 25 Apr, 2019 1 commit
-
-
Simon Zünd authored
This CL fixes a crash that happens on a goto definition lookup for a file with no data attached to it. Drive-by: Collect language server data even on compilation failures. R=tebbi@chromium.org Bug: v8:8880 Change-Id: Ia6323204391da3e64058e1fe47f87162186c15cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583721Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61012}
-
- 28 Feb, 2019 1 commit
-
-
Simon Zünd authored
This CL introduces a new contextual 'LanguageSererData'. Its purpose is to hold all the eagerly calculated data needed to answer language server requests. The first thing collected are the definitoins of some IdentifierExpresisons and macro/builtin call-sites. Collecting this data is not necessary for normal compilation, so it is disabled by default and can be enabled via a Torque compiler option. Since the holder class is a contextual for which no scope exists during normal compilation, accidental collection of unnecessary language server data *should* be prevented. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Iffcebad4c420a0a51b1ed3c37a37c3475c6ab2e8 Reviewed-on: https://chromium-review.googlesource.com/c/1491594Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59941}
-