- 09 Dec, 2015 2 commits
-
-
adamk authored
This is in preparation for turning the flag off by default. BUG=chromium:552100 LOG=n Review URL: https://codereview.chromium.org/1511293002 Cr-Commit-Position: refs/heads/master@{#32729}
-
jochen authored
Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1505803004 Cr-Commit-Position: refs/heads/master@{#32701}
-
- 02 Dec, 2015 1 commit
-
-
danno authored
* Add a sibling interface to InterpreterAssembler called CodeStubAssembler which provides a wrapper around the RawMachineAssembler and is intented to make it easy to build efficient cross-platform code stubs. Much of the implementation of CodeStubAssembler is shamelessly stolen from the InterpreterAssembler, and the idea is to eventually merge the two interfaces somehow, probably moving the InterpreterAssembler interface over to use the CodeStubAssembler. Short-term, however, the two interfaces shall remain decoupled to increase our velocity developing the two systems in parallel. * Implement the StringLength stub in TurboFan with the new CodeStubAssembler. Replace and remove the old Hydrogen-stub version. * Remove a whole slew of machinery to support JavaScript-style code stub generation, since it ultimately proved unwieldy, brittle and baroque. This cleanup includes removing the shared code stub context, several example stubs and a tangle of build file changes. BUG=v8:4587 LOG=n Review URL: https://codereview.chromium.org/1475953002 Cr-Commit-Position: refs/heads/master@{#32508}
-
- 02 Nov, 2015 1 commit
-
-
yangguo authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1424703005 Cr-Commit-Position: refs/heads/master@{#31711}
-
- 29 Oct, 2015 1 commit
-
-
jochen authored
Also deprecate hidden values BUG=none LOG=y R=rossberg@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1428793002 Cr-Commit-Position: refs/heads/master@{#31658}
-
- 23 Oct, 2015 1 commit
-
-
jochen authored
BUG=none LOG=n R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1410883006 Cr-Commit-Position: refs/heads/master@{#31495}
-
- 08 Oct, 2015 1 commit
-
-
mythria authored
Removes deprecated functions from the following files: test/cctest/test-object-observe.cc test/cctest/test-parsing.cc test/cctest/test-platform.cc test/cctest/test-platform-linux.cc test/cctest/test-platform-win32.cc test/cctest/test-profile-generator.cc test/cctest/test-random-number-generator.cc test/cctest/test-regexp.cc test/cctest/test-reloc-info.cc test/cctest/test-representation.cc test/cctest/test-sampler-api.cc test/cctest/test-serialize.cc test/cctest/test-simd.cc test/cctest/test-slots-buffer.cc test/cctest/test-spaces.cc test/cctest/test-strings.cc test/cctest/test-strtod.cc test/cctest/test-symbols.cc test/cctest/test-threads.cc BUG=v8:4134 LOG=n Review URL: https://codereview.chromium.org/1371363006 Cr-Commit-Position: refs/heads/master@{#31173}
-
- 16 Sep, 2015 1 commit
-
-
adamk authored
We already disallowed observing the global proxy; now we also disallow any observation of access-checked objects (regardless of whether the access check would succeed or fail, since there's not a good way to tell the embedder what kind of access is being requested). Also disallow Object.getNotifier for the same reasons. BUG=chromium:531891 LOG=y Review URL: https://codereview.chromium.org/1346813002 Cr-Commit-Position: refs/heads/master@{#30774}
-
- 31 Aug, 2015 2 commits
-
-
hablich authored
Revert of [heap] More flag cleanup. (patchset #8 id:140001 of https://codereview.chromium.org/1314863003/ ) Reason for revert: Breaks http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20-%202/builds/2372 Original issue's description: > [heap] GC flag cleanup/restructuring. > > * GC's flags are now proper flags and not int. > * Callback flags are not threaded through but only set once like gc flags > * Callers of methods that trigger GCs need to pass a reason when not using > the default parameters. > > Furthermore, each GC invocation can be passed the GC and GCCallback flags. We > usually override the currently set flags upon finishing a GC cylce, but are able > to restore the previously set if desired. This is useful for explicitely > triggered scavenges or external requests that interrupt the current behaviour. > > BUG= > > Committed: https://crrev.com/f4f3b431b9ce0778d926acf03c0d36dae5c0cba4 > Cr-Commit-Position: refs/heads/master@{#30457} TBR=hpayer@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1303393004 Cr-Commit-Position: refs/heads/master@{#30463}
-
mlippautz authored
* GC's flags are now proper flags and not int. * Callback flags are not threaded through but only set once like gc flags * Callers of methods that trigger GCs need to pass a reason when not using the default parameters. Furthermore, each GC invocation can be passed the GC and GCCallback flags. We usually override the currently set flags upon finishing a GC cylce, but are able to restore the previously set if desired. This is useful for explicitely triggered scavenges or external requests that interrupt the current behaviour. BUG= Review URL: https://codereview.chromium.org/1314863003 Cr-Commit-Position: refs/heads/master@{#30457}
-
- 13 Jul, 2015 1 commit
-
-
danno authored
Until now, TF-generated code stubs piggy-backed off of the builtin context. Since generation of code stubs is lazy, stubs generated at different times in different native contexts would contain embedded pointers different builtin contexts, leading to cross-context references and memory leaks. After this CL, all TF-generated code stubs are generated inside a internal thinned-out, native context that lives solely for the purpose of hosting generated code stubs. Review URL: https://codereview.chromium.org/1213203007 Cr-Commit-Position: refs/heads/master@{#29593}
-
- 23 Apr, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1099783003 Cr-Commit-Position: refs/heads/master@{#28024}
-
- 15 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (patchset #4 id:60001 of https://codereview.chromium.org/1082973003/) Reason for revert: [Sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3348 and maybe leads to timeouts/crashes on layout test bots: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002 Original issue's description: > Force full GC whenever CollectAllGarbage is meant to trigger a full GC. > > Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. > > Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. > > BUG= > > Committed: https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1 > Cr-Commit-Position: refs/heads/master@{#27831} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1088083002 Cr-Commit-Position: refs/heads/master@{#27834}
-
hpayer authored
Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. BUG= Review URL: https://codereview.chromium.org/1082973003 Cr-Commit-Position: refs/heads/master@{#27831}
-
- 31 Mar, 2015 1 commit
-
-
adamk authored
It triggers once per context that calls observe (or attempts to access any observation metadata, e.g. through Object.getNotifier). Review URL: https://codereview.chromium.org/1048213002 Cr-Commit-Position: refs/heads/master@{#27557}
-
- 20 Jan, 2015 1 commit
-
-
verwaest authored
This method circumvented JS semantics, and should not be used. BUG= Review URL: https://codereview.chromium.org/854493004 Cr-Commit-Position: refs/heads/master@{#26157}
-
- 12 Dec, 2014 1 commit
-
-
adamk authored
Such properties never notified prior to r21558, but the combination of that change and r23163 led to sending notifications when they were set via Object.defineProperty (but not when set via other means). This also allows some cleanup in v8natives.js and objects.cc, both of which were doing unnecessary contortions to produce the right change records. BUG=v8:3745 LOG=n Review URL: https://codereview.chromium.org/791243002 Cr-Commit-Position: refs/heads/master@{#25806}
-
- 17 Nov, 2014 1 commit
-
-
Adam Klein authored
R=rossberg@chromium.org BUG=v8:3076 LOG=n Review URL: https://codereview.chromium.org/733483003 Cr-Commit-Position: refs/heads/master@{#25384}
-
- 05 Nov, 2014 1 commit
-
-
aandrey@chromium.org authored
This also naturally handles pausing on uncaught exceptions in Object.observe callbacks. R=adamk@chromium.org, yangguo@chromium.org, yurys@chromium.org BUG=chromium:335660 LOG=Y Review URL: https://codereview.chromium.org/692313003 Cr-Commit-Position: refs/heads/master@{#25126} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
Our own ARRAY_SIZE() was pretty bad at error checking. If you use arrasize() in a wrong way, the compiler will issue an error instead of silently doing the wrong thing. The previous ARRAY_SIZE() macro is still available as ARRAYSIZE_UNSAFE() similar to Chrome. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/501323002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
Embedders should use e.g. isolate->IdleNotification(1000) instead of v8::V8::IdleNotification() BUG=397026 R=hpayer@chromium.org, ernstm@chromium.org LOG=y Review URL: https://codereview.chromium.org/412163003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/390833003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 May, 2014 1 commit
-
-
jarin@chromium.org authored
Now we remember new space's top pointer after the last GC to find out if there was a new space allocation since the last GC. Unfortunately, this not completely safe - the debugger has a callback hook (that can call to JS) at the end of the GC epilogue that can in theory allocate and possibly make the heap non-iterable. We can only hope this does not happen. BUG=373283 R=hpayer@chromium.org LOG=N Review URL: https://codereview.chromium.org/291193005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21431 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 May, 2014 2 commits
-
-
jarin@chromium.org authored
This reverts commit r21397. TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/299813002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
This relands r21388 (+ handlification of an offending function). BUG=373283 LOG=N R=hpayer@chromium.org Review URL: https://codereview.chromium.org/294903003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 May, 2014 2 commits
-
-
jarin@chromium.org authored
This reverts commit r21387. TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/291193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
We only consider heap iterable if the new space is empty (in addition to the exisiting old space check). The change also moves the iterability forcing + allocation prevention gadgets to HeapIterator so that it is impossible to miss them when iterating the heap. R=hpayer@chromium.org BUG=373283 LOG=N Review URL: https://codereview.chromium.org/285693006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 May, 2014 3 commits
-
-
adamk@chromium.org authored
Due to overlapping names of natives and runtime functions, the wrong context was used for Notifier.prototype.performChange. The leak test has been augmented to properly cover the leaky case, and the test now passes. Also tightened up type checks in runtime.cc and removed Object.observe functions from knownIssues in fuzz-natives-part2.js. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/264793015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
The Object.observe API may construct internal structures as a result of API calls. These structures can persist as long as an object that was once observed persists. This patch ensures that these structures are created in the correct context so as to avoid leaking contexts R=verwaest@chromium.org, dcarney BUG= Review URL: https://codereview.chromium.org/263833007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
This patch reverts r21062 which disabled Object.observe and the relevant tests. It also adds enforcement for the following three invariants: 1) No observer may receive a change record describing changes to an object which is in different security origin (context have differing security tokens) 2) No observer may receive a change record whose context's security token is different from that of the object described by the change. 3) Object.getNotifier will return null if the caller and the provided object are in differing security origins Further, it ensures that the global object can never be observed nor a notifier retrieved for it. Tests are included. R=verwaest@chromium.org, rossberg LOG=Y Review URL: https://codereview.chromium.org/265503002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2014 3 commits
-
-
yangguo@chromium.org authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/239113009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts r20802 . TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/239543010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=mvstanton@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/237673014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2014 1 commit
-
-
ishell@chromium.org authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/231103002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20644 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Mar, 2014 1 commit
-
-
adamk@chromium.org authored
This re-re-re-lands enabling Object.observe. The Chromium tests that failed last time this was rolled into Chromium have been disabled in https://src.chromium.org/viewvc/chrome?view=revision&revision=256706 This patch should be safe to merge once that lands. BUG=v8:2409 LOG=Y TBR=rossberg@chromium.org,dslomov@chromium.org,rafaelw@chromium.org Review URL: https://codereview.chromium.org/198383002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Mar, 2014 1 commit
-
-
dslomov@chromium.org authored
This reverts commit r19734 for breeaking ChromiumOS browser tests. 'OpenSpecialTypes/FileManagerBrowserTest.Test/3' started to time out, bisecting the roll led to this change. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22224 TBR=rafaelw@chromium.org,rossberg@chromium.org BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/195123005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2014 3 commits
-
-
rafaelw@chromium.org authored
Original Issue: https://codereview.chromium.org/183683022/ TBR=rossberg BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/189513010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
TBR=rossberg BUG= Review URL: https://codereview.chromium.org/190853007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rafaelw@chromium.org authored
R=rossberg@chromium.org, rossberg BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/183683022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-