- 08 Oct, 2015 2 commits
-
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg,v8_linux_gcc_rel Review URL: https://codereview.chromium.org/1393023003 Cr-Commit-Position: refs/heads/master@{#31185}
-
bmeurer authored
Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1383053005/ ) Reason for revert: Breaks Arm debug. Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116 > Cr-Commit-Position: refs/heads/master@{#31163} TBR=jochen@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1398643002 Cr-Commit-Position: refs/heads/master@{#31167}
-
- 07 Oct, 2015 1 commit
-
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg Review URL: https://codereview.chromium.org/1383053005 Cr-Commit-Position: refs/heads/master@{#31163}
-
- 05 Oct, 2015 2 commits
-
-
machenbach authored
Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1384873002/ ) Reason for revert: [Sheriff] Breaks the gcc 4.8 bot: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/3274 Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308 > Cr-Commit-Position: refs/heads/master@{#31105} TBR=jochen@chromium.org,bmeurer@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1376113005 Cr-Commit-Position: refs/heads/master@{#31112}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg Review URL: https://codereview.chromium.org/1384873002 Cr-Commit-Position: refs/heads/master@{#31105}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 04 Aug, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1265243003 Cr-Commit-Position: refs/heads/master@{#29997}
-
- 23 Jul, 2015 1 commit
-
-
danno authored
Previous to this CL, ICs used a slightly different code idiom to get to C++ code from generated code than runtime intrinsics, using an IC_Utility class that in essence provided exactly the same functionality as Runtime::FunctionForId, but in its own quirky way. This CL unifies the two mechanisms, folding IC_Utility away by making all IC entry points in C++ code, e.g. IC miss handlers, full-fledged runtime intrinsics. This makes it possible to eliminate a bunch of ad-hoc declarations and adapters that the IC system had to needlessly re-invent. As a bonus and the original reason for this yak-shave: IC-related C++ runtime functions are now callable from TurboFan. Review URL: https://codereview.chromium.org/1248303002 Cr-Commit-Position: refs/heads/master@{#29811}
-
- 06 Jul, 2015 1 commit
-
-
jochen authored
BUG=v8:4131 R=bmeurer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1224623004 Cr-Commit-Position: refs/heads/master@{#29473}
-
- 23 Jan, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/869963002 Cr-Commit-Position: refs/heads/master@{#26245}
-
- 27 Nov, 2014 1 commit
-
-
dcarney authored
a revival of https://codereview.chromium.org/467013003 R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/760883002 Cr-Commit-Position: refs/heads/master@{#25537}
-
- 20 Aug, 2014 1 commit
-
-
wingo@igalia.com authored
Add new "Name" type to API that is a supertype of Symbol and String. Object::SetDeclaredAccessor, Object::SetAccessorProperty, Template::Set, Template::SetAccessorProperty, and Template::SetDeclaredAccessor now take a Name as the property name instead of a String. Add Object::SetAccessor, Template::SetNativeDataProperty, and ObjectTemplate::SetAccessor overloads that can define accessors for symbol-named properties. R=dcarney@chromium.org, rossberg@chromium.org BUG=v8:3394 TEST=cctest/test-api/TestSymbolProperties LOG=Y Review URL: https://codereview.chromium.org/459413002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2014 1 commit
-
-
bmeurer@chromium.org authored
This was broken since r21879, as the RandomNumberGenerator constructor does no longer look at FLAG_random_seed implicitly. TEST=cctest/test-types R=jochen@chromium.org Review URL: https://codereview.chromium.org/370973002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Jun, 2014 1 commit
-
-
danno@chromium.org authored
The length_ field must be defined as intptr_t rather than int. This is due to the fact that we place native argc/argv values into stack slots (via SetFrameSlot) and then interpret the slots as a an instance of Arguments class. Little endian architectures get 'lucky' that the layout happens to work with implicit padding. Big endian is not as lucky. See Runtime_ArrayConstructor for an example. Based on https://github.com/andrewlow/v8/commit/d8c3570f71c0be9914e79139740124bd1ca711a7 BUG=v8:3366 LOG=N R=danno@chromium.org Review URL: https://codereview.chromium.org/314123003 Patch from Andrew Low <andrew_low@ca.ibm.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 May, 2014 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/307543009 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21556 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Apr, 2014 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/240053010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2013 1 commit
-
-
ulan@chromium.org authored
and preserve FP registers on NotifyStubFailure. In debug mode, clobber FP registers on each runtime call to increase chances of catching such bugs. R=danno@chromium.org Review URL: https://chromiumcodereview.appspot.com/78283002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18000 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Oct, 2013 1 commit
-
-
marja@chromium.org authored
This CL starts using positive array indices instead of negative array indices for the PropertyCallbackInfo and FunctionCallbackInfo fields. Also, the indices match now, so they can be unified in the next step. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17015 Review URL: https://codereview.chromium.org/24488006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17032 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2013 2 commits
-
-
marja@chromium.org authored
This reverts commit 977bfe3e9353ead1039878597590ffbd7dd5e725. This might be responsible of the Linux Webkit test failures. BUG= TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/25260005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17021 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
This CL starts using positive array indices instead of negative array indices for the PropertyCallbackInfo and FunctionCallbackInfo fields. Also, the indices match now, so they can be unified in the next step. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/24488006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17015 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2013 1 commit
-
-
marja@chromium.org authored
This step reorders the FunctionCallbackInfo fields. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/23484037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16961 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Sep, 2013 3 commits
-
-
dcarney@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/23903053 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
TBR=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/24196002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/23461039 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2013 3 commits
-
-
mstarzinger@chromium.org authored
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they contain the same fields. The field order will be: holder isolate return value default value return value data this This step 1 reorders the PropertyCallbackInfo fields. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16673 Review URL: https://codereview.chromium.org/23620036 Patch from Marja Hölttä <marja@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
TBR=marja@chromium.org Review URL: https://codereview.chromium.org/23431019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they contain the same fields. The field order will be: holder isolate return value default value return value data this This step 1 reorders the PropertyCallbackInfo fields. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/23620036 Patch from Marja Hölttä <marja@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Aug, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/23513004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16354 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jun, 2013 2 commits
-
-
mvstanton@chromium.org authored
Array access fix: g++ darwin 4.2.1 compiler clamped array index to 0 when confronted with negative indices. BUG=247303 R=jkummerow@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/15855015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/16642003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15024 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Jun, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/15793007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14952 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 May, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/12494012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Apr, 2013 3 commits
-
-
dslomov@chromium.org authored
This is a resubmit of codereview.chromium.org/13818012 with the following modifications: - src/x64/code-stubs-x64.cc for changes specific to Win64 calling conventions. - src/sampler.cc for Native Client support BUG=v8:2614 Committed: https://code.google.com/p/v8/source/detail?r=14491 Review URL: https://codereview.chromium.org/14305029 Patch from Brad Chen <bradchen@google.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r14991. (one file missing) git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14493 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This is a resubmit of codereview.chromium.org/13818012 with the following modifications: - src/x64/code-stubs-x64.cc for changes specific to Win64 calling conventions. - src/sampler.cc for Native Client support BUG=v8:2614 Review URL: https://codereview.chromium.org/14305029 Patch from Brad Chen <bradchen@google.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Apr, 2013 1 commit
-
-
dslomov@chromium.org authored
This reverts commit https://code.google.com/p/v8/source/detail?r=14230 The reason for revert is Win64 mksnapshot failure. Conflicts: src/arm/simulator-arm.cc BUG= Review URL: https://codereview.chromium.org/14096025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14307 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Apr, 2013 1 commit
-
-
ulan@chromium.org authored
Native method invocation from the arm/simulator-arm.cc previously made non-portable assumptions about calling conventions. This was okay for 32-bit stack-based machines, where by-value structs are automatically materialized on the stack, and where both int and double parameters could be passed on the stack. However they are not okay for x86-64, which has an elaborate scheme for passing parameters in registers. This CL replaces the previous non-portable code paths with portable code, using call-sites that accurately match the prototype of the callee. BUG=2614 Review URL: https://chromiumcodereview.appspot.com/13818012 Patch from Brad Chen <bradchen@google.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-