- 02 Feb, 2016 2 commits
-
-
jkummerow authored
BUG=chromium:583257 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1651253003 Cr-Commit-Position: refs/heads/master@{#33683}
-
jkummerow authored
This is a follow-up fix to f4872f74 / r33616. Review URL: https://codereview.chromium.org/1659853002 Cr-Commit-Position: refs/heads/master@{#33667}
-
- 29 Jan, 2016 1 commit
-
-
jkummerow authored
String wrappers (new String("foo")) are special objects: their string characters are accessed like elements, and they also have an elements backing store. This used to require a bunch of explicit checks like: if (obj->IsJSValue() && JSValue::cast(obj)->value()->IsString()) { /* Handle string characters */ } // Handle regular elements (for string wrappers and other objects) obj->GetElementsAccessor()->Whatever(...); This CL introduces new ElementsKinds for string wrapper objects (one for fast elements, one for dictionary elements), which allow folding the special-casing into new StringWrapperElementsAccessors. No observable change in behavior is intended. Review URL: https://codereview.chromium.org/1612323003 Cr-Commit-Position: refs/heads/master@{#33616}
-
- 22 Jan, 2016 2 commits
-
-
cbruni authored
Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1612413003/ ) Reason for revert: let me quickly revert the revert, wut? Goal: my CL should not be in the tree! Original issue's description: > Reland of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1619803003/ ) > > Reason for revert: > the deopt issues have been taken care of by benedikt > > Original issue's description: > > Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ ) > > > > Reason for revert: > > tanks for-in significantly > > > > Original issue's description: > > > [runtime] Do not use the enum-cache for keys retrieval. > > > > > > Currently we fail to properly handle shadowed properties. If the > > > receiver defines a non-enumerable property that reappears on the > > > prototype as enumerable it incorrectly shows up in [[Enumerate]]. > > > By extending the KeyAccumulator to track non-enumerable properties > > > we can now properly filter them out when seeing them further up in > > > the prototype-chain. > > > > > > BUG=v8:705 > > > LOG=y > > > > > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7 > > > Cr-Commit-Position: refs/heads/master@{#33405} > > > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=v8:705 > > LOG=n > > > > Committed: https://crrev.com/6e0573c6fff1c3041bab106d1197ab1b64aa9a6a > > Cr-Commit-Position: refs/heads/master@{#33443} > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:705 > > Committed: https://crrev.com/5569e270eda517b5ea74e3a7676b3230cbe2f7a9 > Cr-Commit-Position: refs/heads/master@{#33458} TBR=jkummerow@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:705 Review URL: https://codereview.chromium.org/1614313003 Cr-Commit-Position: refs/heads/master@{#33459}
-
cbruni authored
Reland of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1619803003/ ) Reason for revert: the deopt issues have been taken care of by benedikt Original issue's description: > Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ ) > > Reason for revert: > tanks for-in significantly > > Original issue's description: > > [runtime] Do not use the enum-cache for keys retrieval. > > > > Currently we fail to properly handle shadowed properties. If the > > receiver defines a non-enumerable property that reappears on the > > prototype as enumerable it incorrectly shows up in [[Enumerate]]. > > By extending the KeyAccumulator to track non-enumerable properties > > we can now properly filter them out when seeing them further up in > > the prototype-chain. > > > > BUG=v8:705 > > LOG=y > > > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7 > > Cr-Commit-Position: refs/heads/master@{#33405} > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:705 > LOG=n > > Committed: https://crrev.com/6e0573c6fff1c3041bab106d1197ab1b64aa9a6a > Cr-Commit-Position: refs/heads/master@{#33443} TBR=jkummerow@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:705 Review URL: https://codereview.chromium.org/1612413003 Cr-Commit-Position: refs/heads/master@{#33458}
-
- 21 Jan, 2016 1 commit
-
-
cbruni authored
Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ ) Reason for revert: tanks for-in significantly Original issue's description: > [runtime] Do not use the enum-cache for keys retrieval. > > Currently we fail to properly handle shadowed properties. If the > receiver defines a non-enumerable property that reappears on the > prototype as enumerable it incorrectly shows up in [[Enumerate]]. > By extending the KeyAccumulator to track non-enumerable properties > we can now properly filter them out when seeing them further up in > the prototype-chain. > > BUG=v8:705 > LOG=y > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7 > Cr-Commit-Position: refs/heads/master@{#33405} TBR=jkummerow@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:705 LOG=n Review URL: https://codereview.chromium.org/1619803003 Cr-Commit-Position: refs/heads/master@{#33443}
-
- 20 Jan, 2016 1 commit
-
-
cbruni authored
Currently we fail to properly handle shadowed properties. If the receiver defines a non-enumerable property that reappears on the prototype as enumerable it incorrectly shows up in [[Enumerate]]. By extending the KeyAccumulator to track non-enumerable properties we can now properly filter them out when seeing them further up in the prototype-chain. BUG=v8:705 LOG=y Review URL: https://codereview.chromium.org/1608523002 Cr-Commit-Position: refs/heads/master@{#33405}
-
- 18 Jan, 2016 1 commit
-
-
verwaest authored
Review URL: https://codereview.chromium.org/1600353003 Cr-Commit-Position: refs/heads/master@{#33364}
-
- 23 Dec, 2015 1 commit
-
-
cbruni authored
Essentially a revert of https://codereview.chromium.org/1346013005 but preserving the refactorings in elements.cc which happened in the mean time. drive-by-fix: pass isolate as argument to more functions in elements.cc. BUG=v8:4606 LOG=y Review URL: https://codereview.chromium.org/1543563002 Cr-Commit-Position: refs/heads/master@{#33023}
-
- 22 Dec, 2015 1 commit
-
-
bmeurer authored
There's actually no point trying to do Function.prototype.toString in JavaScript, as it always calls into C++ at least once, so it only complicates things (esp. once we start optimizing bound functions). Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also reflect the fact that these are builtins in the Function.prototype and not on Function itself. TBR=hpayer@chromium.org R=yangguo@chromium.org BUG=chromium:535408 LOG=n Review URL: https://codereview.chromium.org/1540953004 Cr-Commit-Position: refs/heads/master@{#32996}
-
- 03 Dec, 2015 1 commit
-
-
jkummerow authored
Not exposed/used yet, therefore also not testable yet. Review URL: https://codereview.chromium.org/1491743008 Cr-Commit-Position: refs/heads/master@{#32571}
-
- 02 Dec, 2015 1 commit
-
-
jkummerow authored
Split out of PropertyAttributes, and used for all filtering purposes. Also moved PropertyAttributes into the v8::internal:: namespace. No change in behavior intended. Review URL: https://codereview.chromium.org/1492653004 Cr-Commit-Position: refs/heads/master@{#32525}
-
- 25 Nov, 2015 1 commit
-
-
verwaest authored
BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{#32265}
-
- 18 Nov, 2015 1 commit
-
-
hpayer authored
This CL brings us one step closer to untangle the runtime-gc dependency, i.e. RecordWrites should not be called from the runtime. BUG= Review URL: https://codereview.chromium.org/1456533002 Cr-Commit-Position: refs/heads/master@{#32074}
-
- 11 Nov, 2015 1 commit
-
-
bmeurer authored
Change sloppy and strict arguments objects to FAST_ELEMENTS for their backing stores, which will allow us to optimize them easier. Also fixes a bug in the elements accessors that was triggered by this change. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1433133003 Cr-Commit-Position: refs/heads/master@{#31942}
-
- 04 Nov, 2015 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/1412223018 Cr-Commit-Position: refs/heads/master@{#31785}
-
- 19 Oct, 2015 1 commit
-
-
cbruni authored
Separately collect element keys from property keys to avoid slow corner-cases. Partly deal with keys generated by Proxies. BUG=chromium:536790 LOG=N Review URL: https://codereview.chromium.org/1397063002 Cr-Commit-Position: refs/heads/master@{#31378}
-
- 07 Oct, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1393833002 Cr-Commit-Position: refs/heads/master@{#31136}
-
- 06 Oct, 2015 1 commit
-
-
machenbach authored
Revert of [heap] Prepare code for smaller large object allocation limit than max allocatable memory. (patchset #10 id:180001 of https://codereview.chromium.org/1361853005/ ) Reason for revert: [Sheriff] Need to revert for reverting https://codereview.chromium.org/1358703003/ Original issue's description: > [heap] Prepare heap for smaller large object allocation limit than max allocatable memory. > > BUG=chromium:524425 > LOG=n > > Committed: https://crrev.com/c2bce747993c445daf78975392e587bff20c6677 > Cr-Commit-Position: refs/heads/master@{#31107} TBR=mlippautz@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1376413005 Cr-Commit-Position: refs/heads/master@{#31129}
-
- 05 Oct, 2015 1 commit
-
-
hpayer authored
BUG=chromium:524425 LOG=n Review URL: https://codereview.chromium.org/1361853005 Cr-Commit-Position: refs/heads/master@{#31107}
-
- 30 Sep, 2015 1 commit
-
-
jkummerow authored
No users of that functionality yet, those will come separately. Review URL: https://codereview.chromium.org/1375003002 Cr-Commit-Position: refs/heads/master@{#31024}
-
- 25 Sep, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/1372533002 Cr-Commit-Position: refs/heads/master@{#30935}
-
- 18 Sep, 2015 1 commit
-
-
cbruni authored
Reuse code for copying arguments and pushing/shifting elements. BUG= Review URL: https://codereview.chromium.org/1346013005 Cr-Commit-Position: refs/heads/master@{#30825}
-
- 17 Sep, 2015 1 commit
-
-
cbruni authored
The core bottleneck lies in N-square cost of array union. Depending on the size of the arrays involved it makes sense to rely on a hash-set/table for the lookup. LOG=N BUG=v8:2904 Review URL: https://codereview.chromium.org/1316213008 Cr-Commit-Position: refs/heads/master@{#30797}
-
- 15 Sep, 2015 1 commit
-
-
cbruni authored
Returning a result array with holey elements kind in where we actually have a packed kind causes performance regressions. LOG=N BUG=chromium:531357 Review URL: https://codereview.chromium.org/1340033002 Cr-Commit-Position: refs/heads/master@{#30736}
-
- 14 Sep, 2015 2 commits
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1341763002 Cr-Commit-Position: refs/heads/master@{#30717}
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1338983003 Cr-Commit-Position: refs/heads/master@{#30715}
-
- 07 Sep, 2015 1 commit
-
-
cbruni authored
- Moving parts of ArrayConcat from builtins.cc to the ElementsAccessor - Removing ArrayConcat Runtime Function BUG=v8:4317 LOG=N Review URL: https://codereview.chromium.org/1330483003 Cr-Commit-Position: refs/heads/master@{#30619}
-
- 02 Sep, 2015 2 commits
-
-
cbruni authored
- Use the new ElementsAccessor methods - improve test coverage BUG= Review URL: https://codereview.chromium.org/1317053006 Cr-Commit-Position: refs/heads/master@{#30546}
-
cbruni authored
Repeat the same signatures for future refactoring BUG= Review URL: https://codereview.chromium.org/1302413006 Cr-Commit-Position: refs/heads/master@{#30532}
-
- 01 Sep, 2015 1 commit
-
-
cbruni authored
Move BackingStore specific implementation from builtins.cc tp ElementsAccessor BUG= Review URL: https://codereview.chromium.org/1322803002 Cr-Commit-Position: refs/heads/master@{#30526}
-
- 31 Aug, 2015 2 commits
-
-
cbruni authored
Moving FastElements path to ElementsAccessor. BUG= Review URL: https://codereview.chromium.org/1325483002 Cr-Commit-Position: refs/heads/master@{#30477}
-
cbruni authored
- Move fast paths from builtins.cc ArraySlice to ElementsAccessor - Handle more argument types in the fast path BUG= Review URL: https://codereview.chromium.org/1321773002 Cr-Commit-Position: refs/heads/master@{#30471}
-
- 27 Aug, 2015 1 commit
-
-
cbruni authored
- remove the Backing-Store specific code from builtins.cc and put it in elements.cc. - adding tests to improve coverage of the splice method BUG= Review URL: https://codereview.chromium.org/1312033003 Cr-Commit-Position: refs/heads/master@{#30410}
-
- 25 Aug, 2015 3 commits
-
-
hablich authored
Revert of Moving ArraySplice Builtin to ElementsAccessor (patchset #8 id:140001 of https://codereview.chromium.org/1293683005/ ) Reason for revert: Fails layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/1450 Original issue's description: > - remove the Backing-Store specific code from builtins.cc and put it in elements.cc. > - adding tests to improve coverage of the splice method > > BUG= > > Committed: https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3 > Cr-Commit-Position: refs/heads/master@{#30269} > > Committed: https://crrev.com/07a4a6cb8e2ab940b28a7151a925c796da023524 > Cr-Commit-Position: refs/heads/master@{#30326} TBR=mvstanton@chromium.org,cbruni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1315823004 Cr-Commit-Position: refs/heads/master@{#30351}
-
cbruni authored
Revert of Array.prototype.unshift builtin improvements (patchset #3 id:40001 of https://codereview.chromium.org/1311343002/ ) Reason for revert: https://codereview.chromium.org/1315823004/ Original issue's description: > Array.prototype.unshift builtin improvements > > Moving unshift to ElementAccessor and increasing the range of arguments > handled directly in C++, namely directly supporting FastDoubleElementsKind. > This should yield a factor 19 speedup for unshift on fast double arrays. > > BUG= > > Committed: https://crrev.com/bf6764e6c1197e50ae148755488307a423b1d9b4 > Cr-Commit-Position: refs/heads/master@{#30347} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1311363003 Cr-Commit-Position: refs/heads/master@{#30350}
-
cbruni authored
Moving unshift to ElementAccessor and increasing the range of arguments handled directly in C++, namely directly supporting FastDoubleElementsKind. This should yield a factor 19 speedup for unshift on fast double arrays. BUG= Review URL: https://codereview.chromium.org/1311343002 Cr-Commit-Position: refs/heads/master@{#30347}
-
- 24 Aug, 2015 1 commit
-
-
cbruni authored
- adding tests to improve coverage of the splice method BUG= Committed: https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3 Cr-Commit-Position: refs/heads/master@{#30269} Review URL: https://codereview.chromium.org/1293683005 Cr-Commit-Position: refs/heads/master@{#30326}
-
- 20 Aug, 2015 2 commits
-
-
cbruni authored
Revert of Moving ArraySplice Builtin to ElementsAccessor (patchset #6 id:100001 of https://codereview.chromium.org/1293683005/ ) Reason for revert: failing bot http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/3827 Original issue's description: > - remove the Backing-Store speficic code from builtins.cc and put it in elements.cc. > - adding tests to improve coverage of the splice method > > BUG= > > Committed: https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3 > Cr-Commit-Position: refs/heads/master@{#30269} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1305763002 Cr-Commit-Position: refs/heads/master@{#30271}
-
cbruni authored
- adding tests to improve coverage of the splice method BUG= Review URL: https://codereview.chromium.org/1293683005 Cr-Commit-Position: refs/heads/master@{#30269}
-