- 09 Jul, 2018 12 commits
-
-
Andreas Haas authored
With this CL we now also support the decoding of the AnyFunc type. I will add the type more deeply in subsequent CLs. R=titzer@chromium.org Bug: v8:7581 Change-Id: I9f30706a442462f915adfd8f720eb65168b80bb8 Reviewed-on: https://chromium-review.googlesource.com/1014111 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54318}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I918af0461e86ce8eacb9155de18954d8b6270ecc Reviewed-on: https://chromium-review.googlesource.com/1123831 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54317}
-
Michael Starzinger authored
This adds an {AccountingAllocator} to the {WasmEngine}, separate from the allocator used per Isolate. It is in preparation of being able to share engines across multiple Isolates. For now we just add up the stats from both allocators until a public API for the engine becomes available. R=ahaas@chromium.org TEST=cctest/test-wasm-shared-engine/SharedEngineRunImported BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia915a1ae4aa7ebed27073b7b6bd067e31717a6ea Reviewed-on: https://chromium-review.googlesource.com/1127788 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54316}
-
Georg Neis authored
No changes were necessary. R=jarin@chromium.org Bug: v8:7790 Change-Id: I8a5c308b9534ee1fb669a901b6626c338883fbf8 Reviewed-on: https://chromium-review.googlesource.com/1128741Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54315}
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: I42c1208f3555a7e5a3a241860d0a1609b8530b79 Reviewed-on: https://chromium-review.googlesource.com/1128740Reviewed-by:
-
Georg Neis authored
No changes were necessary. R=jarin@chromium.org Bug: v8:7790 Change-Id: I70efc56dd07f778dffda3b38f28b9b94d634361e Reviewed-on: https://chromium-review.googlesource.com/1128739Reviewed-by:
-
Clemens Hammacher authored
This reduces the critical section in {NativeModule::AddOwnedCode} to not include the memcpy. It also contains small drive-by fixes. R=mstarzinger@chromium.org Bug: v8:7921 Change-Id: Idbed5d1ab5627fe2ab3f60887ec2b31c5525e36c Reviewed-on: https://chromium-review.googlesource.com/1127025 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54312}
-
Michael Lippautz authored
Deprecates EmbedderHeapTracer::NumberOfWrappersToTrace and replaces it with EmbedderHeapTracer::IsTracingDone. V8 only really cares about the final state (emptiness) here and embedders may choose implementations that have a hard time determinining exact size for their work queues. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1e141c47771ef08aab7dbe204e8175cfee99cf92 Reviewed-on: https://chromium-review.googlesource.com/1127599 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Change-Id: I755f2426d4f0e34115ff0c73e487e47db5290df1 Reviewed-on: https://chromium-review.googlesource.com/1127916Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54310}
-
Benedikt Meurer authored
This extends the current Promise Rejection Hook with two new events kPromiseRejectAfterResolved kPromiseResolveAfterResolved which are used to detect (and signal) misuse of the Promise constructor. Specifically the common bug like new Promise((res, rej) => { res(1); throw new Error("something") }); where the error is silently swallowed by the Promise constructor without the user ever noticing can be caught via this hook. Doc: https://goo.gl/2stLUY Bug: v8:7919 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I890a7e766cdd1be88db94844fb744f72823dba33 Reviewed-on: https://chromium-review.googlesource.com/1126099Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54309}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ec3bd1b..84b1e58 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ebf0d4a..230416c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib8c27d83cb9a23a6e1a2ad747ee95a2bd4142e34 Reviewed-on: https://chromium-review.googlesource.com/1128620 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54308}
-
jing.bao authored
Change-Id: Ic2c4f02d5e451c4a3a6612ae91e5cc8231d62448 Reviewed-on: https://chromium-review.googlesource.com/1119773 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54307}
-
- 08 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d0011aa..ec3bd1b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8a075d7..9eaedb7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d8cde7f..ebf0d4a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icfa0b58d4e4ece3a60401ef40a517005ecdbcf98 Reviewed-on: https://chromium-review.googlesource.com/1128542Reviewed-by:
-
- 07 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/911a0c5..d0011aa Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5715e98..8a075d7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5484b86..92745a5 Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/45571de..b41863e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I03d4d4235e8b767e210565891e91ef4bdc2ca2d2 Reviewed-on: https://chromium-review.googlesource.com/1128467Reviewed-by:
-
- 06 Jul, 2018 26 commits
-
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: Iff4f0561901c454fc3facfeb152727d3994b4f98 Reviewed-on: https://chromium-review.googlesource.com/1127947 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Bill Budge authored
- Refactors most of the logic into a helper CanonicalizeShuffle overload that is more easily tested. - Reorders these methods to be in the order they're used. - Adds unit tests for this helper. Bug: v8:6020 Change-Id: Ia7e08bd2ff3ae62b13c9283c6de04e0e1e85086b Reviewed-on: https://chromium-review.googlesource.com/1118706Reviewed-by:
-
Bill Budge authored
- Adds opcodes for 2x8, 4x4, and 8x2 byte reversing swizzles on ia32. Bug: v8:6020 Change-Id: I2c5d4ba88b42a17fc75ac0307e80d8c11d1838ba Reviewed-on: https://chromium-review.googlesource.com/1121956 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#54302}
-
Dan Elphick authored
Change GetHeap() in set methods to Heap::FromWritableHeapObject() since the object can't be read-only if set is being called on it. Also use the non-isolate form of set_the_hole to remove one GetIsolate(). Bug: v8:7786 Change-Id: I85cb95c8c7eb3baa9316b4a39eecf21bb13e5958 Reviewed-on: https://chromium-review.googlesource.com/1128081 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54301}
-
Bill Budge authored
- Eliminates I8x16SPLAT macro. This generates: push eax mov eax, #imm32 movd xmmDest, eax pxor xmmScratch, xmmScratch pshufb xmmDest, xmmScratch pop eax - Uses smaller sequence for I8x16Shl and I8x16ShrU that doesn't require a temp register. - Uses punpckbw, psraw, packsswb sequence for I8x16ShrS. Bug: v8:6020 Change-Id: I1dc4ecaba43b150a3412e9083fe930868d9e5d5d Reviewed-on: https://chromium-review.googlesource.com/1121045Reviewed-by:
-
Clemens Hammacher authored
Instead of creating a separate code object per exported function, we can share the code per signature, and load the function index from the {WasmExportedFunction} object which is being passed as an argument anyway. This greatly reduces instantiation time for modules with a lot of exports. As a next step, we could even share the code across instances, or (with more work) across isolates. R=mstarzinger@chromium.org Bug: chromium:860491 Change-Id: I6438065b2de0df59dce980fb52408a0f475144b3 Reviewed-on: https://chromium-review.googlesource.com/1127660 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
R=jarin@chromium.org Bug: v8:7902 Change-Id: I402b2711b8a5a820b8c95285dc929f2a10c55f98 Reviewed-on: https://chromium-review.googlesource.com/1127883 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54298}
-
Dan Elphick authored
This is a clean-up to completely remove the Heap accessors for roots accessible via ReadOnlyRoots. Where previously ReadOnlyRoots called the Heap accessor, now it accesses the roots array directly using the root index (since ReadOnlyRoots is a friend of Heap). Also clean up several cases where private Heap accessors were still being used by Heap and its friends. Bug: v8:7786 Change-Id: Iaca2e17b22822b30d395dec6250a4d5ae496c983 Reviewed-on: https://chromium-review.googlesource.com/1127172 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: Ibb8cd735036368c5bda83fe60b12b427e8e7ce7f Reviewed-on: https://chromium-review.googlesource.com/1127887Reviewed-by:
-
Georg Neis authored
- Move the CompilationDependencies member of OptimizedCompilationInfo to Turbofan's PipelineData (and thus into the compiler namespace). - Move compilation-dependencies.{cc,h} to the compiler directory. Bug: v8:7902 Change-Id: I5471d0923daf83abe975357325db5bc5ad0a8571 Reviewed-on: https://chromium-review.googlesource.com/1127793 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: -
jgruber authored
TBR=machenbach@chromium.org Bug: v8:7626 Change-Id: I1176d9703306159fed0c08f973104dd9357c9b1a Reviewed-on: https://chromium-review.googlesource.com/1127882Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54294}
-
jgruber authored
RegExp builtins were the first to be ported to CSA roughly two years ago. Back then, we weren't really aware of issues surrounding code size and CSA inlining, and thus some of these builtins were bigger than they should be. This CL adds a few new helper builtins and removes inlined calls to SubString, RegExpExecInternal, and StringAdd. It significantly reduces the size of affected builtins. Minor performance regressions due to call overhead are expected. Before: TFS Builtin, RegExpReplace, 20008 TFS Builtin, RegExpSplit, 17340 TFS Builtin, RegExpMatchFast, 17064 TFJ Builtin, RegExpStringIteratorPrototypeNext, 12862 After: TFS Builtin, RegExpReplace, 5067 TFS Builtin, RegExpSplit, 6329 TFS Builtin, RegExpMatchFast, 8164 TFJ Builtin, RegExpStringIteratorPrototypeNext, 6652 Bug: v8:5737 Change-Id: I1c077a084da85bb73c0c5adb7118b941f488e0ec Reviewed-on: https://chromium-review.googlesource.com/1127796Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54293}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: Ibab2798cde017b178bf6db51c92ecff9e81ef641 Reviewed-on: https://chromium-review.googlesource.com/1127787Reviewed-by:
-
Clemens Hammacher authored
When calling an import which is an exported wasm function, the interpreter needs to look through the jump table to find the actual code object. We already had that logic for indirect calls, but it was missing for imported calls. R=ahaas@chromium.org Bug: chromium:860392 Change-Id: I6b5a0192f79c23cb1de55407fe93f6df9a17235a Reviewed-on: https://chromium-review.googlesource.com/1127671Reviewed-by:
-
Sigurd Schneider authored
This reverts commit f45045cc. Reason for revert: <INSERT REASONING HERE> Original change's description: > [parser] Move some PPSD sanity checks to debug > > Move some of PreParsedScopeData's santity checks, such as the magic > value separating skippable function data from scope data, to be debug > only, to save memory. > > Start position of inner skippable functions is still kept, because it's > too good at catching bugs, but we may want to remove it in the future > as well. > > Bug: chromium:818642 > Change-Id: If86ff1b9845e8dd3b015b4e554d0033328b145bf > Reviewed-on: https://chromium-review.googlesource.com/1127046 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54263} TBR=marja@chromium.org,leszeks@chromium.org Change-Id: I15ceedd66d9ecb66cf65f5834d09975b41d3ed27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1127859Reviewed-by:
-
Georg Neis authored
This is a reland of 1ba5d5ba without any changes. TBR=jarin@chromium.org Original change's description: > Clean up DependentCode class. > > Also move some helpers there. > > Bug: v8:7902 > Change-Id: I1ef3d1e8317102afae2861382e9ba60b0ef6bba4 > Reviewed-on: https://chromium-review.googlesource.com/1121461 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54179} Bug: v8:7902 Change-Id: I9ef70b88be1b31b458a95442ff3806d651e809ee Reviewed-on: https://chromium-review.googlesource.com/1127719Reviewed-by:
-
Théotime Grohens authored
This CL implements Reduction and Lowering for the DataView Int32, Uint32, Float32 and Float64 getters. This makes DataView getters fully supported in TurboFan (except for BigInts), and should bridge the performance gap with TypedArrays. Change-Id: Ifa98df9cf13e44d6468ad9ec8a19c86b41c6d2b1 Reviewed-on: https://chromium-review.googlesource.com/1127360 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
Yang Guo authored
This reverts commit ccfa4ca7. Reason for revert: Infra supports this now. Original change's description: > [node] reset node checkout on v8 update > > This is a temporary measure to get bots back in order. > > Bug: chromium:860430 > > TBR=machenbach@chromium.org > > Change-Id: I3275150f4bc5dfe8ab90984e15f8a1a469d70caf > Reviewed-on: https://chromium-review.googlesource.com/1127166 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54269} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: I6a74ab702fd32b278caebb665be6868b4712dffb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:860430 Reviewed-on: https://chromium-review.googlesource.com/1127721Reviewed-by:
-
Sigurd Schneider authored
This CL surfaces AssemblerOptions to CodeAssembler::GenerateCode and to pipeline methods. To allow forward declaring AssemblerOptions, AssemblerBase::Options was moved out of the AssemblerBase class. Bug: v8:6666 Change-Id: If9fc50d3d4767bb5dd39a0c3b6e094021f4cae2b Reviewed-on: https://chromium-review.googlesource.com/1127039 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit 7fb1874d. Reason for revert: Infra supports this now. Original change's description: > [node] force checkout vee-eight-lkgr > > TBR=machenbach@chromium.org > > Bug: chromium:860430 > Change-Id: I5554468a7c11038903fc3ab5eca067c230b2849a > Reviewed-on: https://chromium-review.googlesource.com/1127370 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54279} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: I5d99abb4885f8da9929ab826db47cd8ffc416b81 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:860430 Reviewed-on: https://chromium-review.googlesource.com/1127720Reviewed-by:
-
Simon Zünd authored
This CL extends the existing ArrayPop C++ builtin with a generic slow-path that replaces the JavaScript fallback. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Change-Id: Ie3ce5379e5c65df67cbc4d956390a8701345ea3c Reviewed-on: https://chromium-review.googlesource.com/1127162 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Sigurd Schneider authored
This fixes a typo where we stored the framepointer in the constant pool register instead of the constant pool value. Bug: v8:7915 Change-Id: I612bf1860ed2e5e5707e2df4a2b92aefaaa9c5cb Reviewed-on: https://chromium-review.googlesource.com/1127639Reviewed-by:
-
Simon Zünd authored
This CL extends the existing ArrayPush C++ builtin with a generic slow-path that replaces the JavaScript fall-back. Bug: v8:7624 Change-Id: I1e8431601e8a872f3c5afba5d486f37fd5781d60 Reviewed-on: https://chromium-review.googlesource.com/1126922Reviewed-by:
-
Dominik Inführ authored
Originally intended for benchmarking but not good enough for that since recent changes cannot be easily disabled. Bug: chromium:844008 Change-Id: I4c7075fe2f1d5e85b76a0c40c854b0dbf7d4564b Reviewed-on: https://chromium-review.googlesource.com/1127376Reviewed-by:
-
Georg Neis authored
This is a reland of 4b9b9b68, which accidentally disabled optimization after dependency changes (instead of retrying). TBR=jarin@chromium.org TBR=mstarzinger@chromium.org Original change's description: > Reland "[turbofan] Rewrite CompilationDependencies" > > This is a reland of 52a10e50, after > eliminating an invalid assumption about maps. > > TBR=jarin@chromium.org > TBR=mstarzinger@chromium.org > > Original change's description: > > [turbofan] Rewrite CompilationDependencies > > > > Instead of installing code dependencies during graph reduction, > > install them after code generation. > > > > Bug: v8:7902, v8:7790 > > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > > Reviewed-on: https://chromium-review.googlesource.com/1119913 > > Commit-Queue: Georg Neis <neis@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54170} > > Bug: v8:7902, v8:7790 > Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f > Reviewed-on: https://chromium-review.googlesource.com/1126999 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54254} Bug: v8:7902, v8:7790 Change-Id: I2b7a7d186e03990350e375470569177e3309683c Reviewed-on: https://chromium-review.googlesource.com/1127579 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: chromium:860430 Change-Id: I5554468a7c11038903fc3ab5eca067c230b2849a Reviewed-on: https://chromium-review.googlesource.com/1127370 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
