1. 03 Nov, 2016 1 commit
  2. 07 Sep, 2016 1 commit
  3. 12 Jul, 2016 1 commit
  4. 20 May, 2016 1 commit
    • mlippautz's avatar
      [heap] Harden heap-related cctests · fdd9f6b9
      mlippautz authored
      - Move usable functions into proper heap-utils.h/.cc files and remove
        utils-inl.h file
      - Fix assumptions accross the board relying on certain behavior that is not
        invariant
      
      This is a requirement for modifying page size.
      
      BUG=chromium:581412
      LOG=N
      R=ulan@chromium.org
      
      Review-Url: https://codereview.chromium.org/1999753002
      Cr-Commit-Position: refs/heads/master@{#36410}
      fdd9f6b9
  5. 03 May, 2016 3 commits
    • mlippautz's avatar
      Reland of [turbofan] Restore basic write barrier elimination. (patchset #1... · 95b8f3b0
      mlippautz authored
      Reland of [turbofan] Restore basic write barrier elimination. (patchset #1 id:1 of https://codereview.chromium.org/1943743003/ )
      
      Reason for revert:
      Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination.
      
      Original issue's description:
      > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ )
      >
      > Reason for revert:
      > Breaks WBs that should be there ;)
      >
      > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305
      >
      > Will open repro bug asap.
      >
      > Original issue's description:
      > > [turbofan] Restore basic write barrier elimination.
      > >
      > > Restore the basic write barrier elimination that we used to run as part
      > > of the simplified lowering phase (in ChangeLowering actually) before, by
      > > moving the write barrier computation to SimplifiedLowering where we can
      > > still look at types and consider the heap/isolate, and just update the
      > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when
      > > lowering to a machine Load/Store.
      > >
      > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
      > > R=mstarzinger@chromium.org
      > > BUG=v8:4969,chromium:608636
      > > LOG=n
      > >
      > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62
      > > Cr-Commit-Position: refs/heads/master@{#35969}
      >
      > TBR=mstarzinger@chromium.org,bmeurer@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=v8:4969,chromium:608636
      >
      > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7
      > Cr-Commit-Position: refs/heads/master@{#35983}
      
      TBR=mstarzinger@chromium.org,bmeurer@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4969,chromium:608636
      
      Review-Url: https://codereview.chromium.org/1943323002
      Cr-Commit-Position: refs/heads/master@{#35984}
      95b8f3b0
    • mlippautz's avatar
      Revert of [turbofan] Restore basic write barrier elimination. (patchset #2... · a782e93c
      mlippautz authored
      Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ )
      
      Reason for revert:
      Breaks WBs that should be there ;)
      
      https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305
      
      Will open repro bug asap.
      
      Original issue's description:
      > [turbofan] Restore basic write barrier elimination.
      >
      > Restore the basic write barrier elimination that we used to run as part
      > of the simplified lowering phase (in ChangeLowering actually) before, by
      > moving the write barrier computation to SimplifiedLowering where we can
      > still look at types and consider the heap/isolate, and just update the
      > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when
      > lowering to a machine Load/Store.
      >
      > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
      > R=mstarzinger@chromium.org
      > BUG=v8:4969,chromium:608636
      > LOG=n
      >
      > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62
      > Cr-Commit-Position: refs/heads/master@{#35969}
      
      TBR=mstarzinger@chromium.org,bmeurer@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4969,chromium:608636
      
      Review-Url: https://codereview.chromium.org/1943743003
      Cr-Commit-Position: refs/heads/master@{#35983}
      a782e93c
    • bmeurer's avatar
      [turbofan] Restore basic write barrier elimination. · 7dcb6ad3
      bmeurer authored
      Restore the basic write barrier elimination that we used to run as part
      of the simplified lowering phase (in ChangeLowering actually) before, by
      moving the write barrier computation to SimplifiedLowering where we can
      still look at types and consider the heap/isolate, and just update the
      WriteBarrierKind in the FieldAccess/ElementAccess that we later use when
      lowering to a machine Load/Store.
      
      CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
      R=mstarzinger@chromium.org
      BUG=v8:4969,chromium:608636
      LOG=n
      
      Review-Url: https://codereview.chromium.org/1938993002
      Cr-Commit-Position: refs/heads/master@{#35969}
      7dcb6ad3
  6. 01 Mar, 2016 1 commit
  7. 25 Feb, 2016 1 commit
  8. 24 Feb, 2016 1 commit
    • ulan's avatar
      Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of... · 9146bc5e
      ulan authored
      Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ )
      
      Reason for revert:
      Revert because of canary crashes: crbug.com/589413
      
      Original issue's description:
      > Replace slots buffer with remembered set.
      >
      > Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>.
      >
      > The remembered set is extended to support typed slots.
      >
      > During parallel evacuation all migration slots are recorded in local slots buffers.
      > After evacuation all local slots are added to the remembered set.
      >
      > BUG=chromium:578883
      > LOG=NO
      >
      > Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152
      > Cr-Commit-Position: refs/heads/master@{#34212}
      
      TBR=jochen@chromium.org,hpayer@chromium.org,mlippautz@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:578883
      
      Review URL: https://codereview.chromium.org/1725073003
      
      Cr-Commit-Position: refs/heads/master@{#34238}
      9146bc5e
  9. 23 Feb, 2016 1 commit
    • ulan's avatar
      Replace slots buffer with remembered set. · 2285a99e
      ulan authored
      Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>.
      
      The remembered set is extended to support typed slots.
      
      During parallel evacuation all migration slots are recorded in local slots buffers.
      After evacuation all local slots are added to the remembered set.
      
      BUG=chromium:578883
      LOG=NO
      
      Review URL: https://codereview.chromium.org/1703823002
      
      Cr-Commit-Position: refs/heads/master@{#34212}
      2285a99e
  10. 16 Feb, 2016 1 commit
  11. 09 Feb, 2016 1 commit
  12. 08 Feb, 2016 1 commit
    • ulan's avatar
      New page local store buffer. · bb883395
      ulan authored
      This replaces the global remembered set with per-page remembered sets.
      
      Each page in the old space, map space, and large object space keeps track of
      the set of slots in the page pointing to the new space.
      
      The data structure for storing slot sets is a two-level bitmap, which allows
      us to remove the store buffer overflow and SCAN_ON_SCAVENGE logic.
      
      Design doc: https://goo.gl/sMKCf7
      
      BUG=chromium:578883
      LOG=NO
      
      Review URL: https://codereview.chromium.org/1608583002
      
      Cr-Commit-Position: refs/heads/master@{#33806}
      bb883395
  13. 29 Jan, 2016 1 commit
    • jkummerow's avatar
      Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS · f4872f74
      jkummerow authored
      String wrappers (new String("foo")) are special objects: their string
      characters are accessed like elements, and they also have an elements
      backing store. This used to require a bunch of explicit checks like:
      
      if (obj->IsJSValue() && JSValue::cast(obj)->value()->IsString()) {
        /* Handle string characters */
      }
      // Handle regular elements (for string wrappers and other objects)
      obj->GetElementsAccessor()->Whatever(...);
      
      This CL introduces new ElementsKinds for string wrapper objects (one for
      fast elements, one for dictionary elements), which allow folding the
      special-casing into new StringWrapperElementsAccessors.
      
      No observable change in behavior is intended.
      
      Review URL: https://codereview.chromium.org/1612323003
      
      Cr-Commit-Position: refs/heads/master@{#33616}
      f4872f74
  14. 26 Jan, 2016 1 commit
    • jarin's avatar
      Replace HeapType with a non-templated FieldType class. · cfaeb63b
      jarin authored
      This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map.
      
      The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h.
      
      TBR=rossberg@chromium.org
      
      Review URL: https://codereview.chromium.org/1636013002
      
      Cr-Commit-Position: refs/heads/master@{#33521}
      cfaeb63b
  15. 23 Dec, 2015 1 commit
  16. 11 Dec, 2015 1 commit
  17. 09 Dec, 2015 2 commits
  18. 07 Dec, 2015 1 commit
  19. 16 Nov, 2015 1 commit
  20. 29 Sep, 2015 2 commits
  21. 28 Sep, 2015 1 commit
  22. 25 Sep, 2015 1 commit
  23. 21 Sep, 2015 1 commit
    • mythria's avatar
      Continuing removing deprecated function from cctest · 41111e3d
      mythria authored
      Removes deprecated functions from the following files:
      
      test/cctest/compiler/function-tester.h
      test/cctest/test-thread-termination.cc
      test/cctest/test-threads.cc
      test/cctest/test-transitions.cc
      test/cctest/test-typedarrays.cc
      test/cctest/test-types.cc
      test/cctest/test-typing-reset.cc
      test/cctest/test-unbound-queue.cc
      test/cctest/test-unboxed-doubles.cc
      
      BUG=v8:4134
      LOG=n
      
      Review URL: https://codereview.chromium.org/1344583002
      
      Cr-Commit-Position: refs/heads/master@{#30846}
      41111e3d
  24. 15 Sep, 2015 1 commit
  25. 21 Aug, 2015 1 commit
  26. 11 Aug, 2015 1 commit
    • bmeurer's avatar
      [runtime] Store constructor function index on primitive maps. · 6c743b2b
      bmeurer authored
      This way we can greatly simplify the different variants of ToObject in
      our codebase and make them more uniform and robust.  Adding a new
      primitive doesn't require finding and changing all those places again,
      but it is sufficient to setup the constructor function index when
      allocating the map.
      
      We use the inobject properties field of Map, which is invalid primitive
      maps anyway.
      
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/1276533003
      
      Cr-Commit-Position: refs/heads/master@{#30119}
      6c743b2b
  27. 13 Jul, 2015 1 commit
  28. 08 Jun, 2015 1 commit
  29. 02 Jun, 2015 1 commit
  30. 23 Apr, 2015 1 commit
  31. 21 Apr, 2015 4 commits
    • jochen's avatar
      Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset... · 1692380f
      jochen authored
      Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/1094333002/)
      
      Reason for revert:
      Breaks gbemu
      
      Original issue's description:
      > Reland "LayoutDescriptor should inherit from JSTypedArray"
      >
      > Original issue's description:
      > > LayoutDescriptor should inherit from JSTypedArray
      > >
      > > It can't just inherit from a FixedTypedArray-like type, as we soon
      > > assume that a FixedTypedArray-like type is always held by an
      > > ArrayBufferView-like type
      > >
      > > BUG=v8:3996
      > > R=ishell@chromium.org,verwaest@chromium.org
      > > LOG=n
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      TBR=ishell@chromium.org,verwaest@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:3996
      
      Review URL: https://codereview.chromium.org/1080403004
      
      Cr-Commit-Position: refs/heads/master@{#27975}
      1692380f
    • jochen's avatar
      Reland "LayoutDescriptor should inherit from JSTypedArray" · d20660e0
      jochen authored
      Original issue's description:
      > LayoutDescriptor should inherit from JSTypedArray
      >
      > It can't just inherit from a FixedTypedArray-like type, as we soon
      > assume that a FixedTypedArray-like type is always held by an
      > ArrayBufferView-like type
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      BUG=v8:3996
      R=ishell@chromium.org,verwaest@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1094333002
      
      Cr-Commit-Position: refs/heads/master@{#27973}
      d20660e0
    • jochen's avatar
      Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1... · 8a309a1e
      jochen authored
      Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1 of https://codereview.chromium.org/1084793004/)
      
      Reason for revert:
      breaks mjsunit on debug bots
      
      Original issue's description:
      > LayoutDescriptor should inherit from JSTypedArray
      >
      > It can't just inherit from a FixedTypedArray-like type, as we soon
      > assume that a FixedTypedArray-like type is always held by an
      > ArrayBufferView-like type
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      TBR=ishell@chromium.org,verwaest@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:3996
      
      Review URL: https://codereview.chromium.org/1073053006
      
      Cr-Commit-Position: refs/heads/master@{#27968}
      8a309a1e
    • jochen's avatar
      LayoutDescriptor should inherit from JSTypedArray · 6d79ceb2
      jochen authored
      It can't just inherit from a FixedTypedArray-like type, as we soon
      assume that a FixedTypedArray-like type is always held by an
      ArrayBufferView-like type
      
      BUG=v8:3996
      R=ishell@chromium.org,verwaest@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1084793004
      
      Cr-Commit-Position: refs/heads/master@{#27964}
      6d79ceb2
  32. 15 Apr, 2015 2 commits