- 03 Nov, 2016 1 commit
-
-
ulan authored
This ensures that incremental marking step does not change the top and limit pointers of the old space, which is needed for allocation folding. For more info see: https://bugs.chromium.org/p/chromium/issues/detail?id=659165#c13 BUG=chromium:659165 Review-Url: https://codereview.chromium.org/2469273002 Cr-Commit-Position: refs/heads/master@{#40720}
-
- 07 Sep, 2016 1 commit
-
-
ulan authored
Now callers of Heap::CollectGarbage* functions need to specify the reason as an enum value instead of a string. Subsequent CL will add stats counter for GC reason. BUG= Review-Url: https://codereview.chromium.org/2310143002 Cr-Commit-Position: refs/heads/master@{#39239}
-
- 12 Jul, 2016 1 commit
-
-
hpayer authored
BUG= Review-Url: https://codereview.chromium.org/2139133003 Cr-Commit-Position: refs/heads/master@{#37685}
-
- 20 May, 2016 1 commit
-
-
mlippautz authored
- Move usable functions into proper heap-utils.h/.cc files and remove utils-inl.h file - Fix assumptions accross the board relying on certain behavior that is not invariant This is a requirement for modifying page size. BUG=chromium:581412 LOG=N R=ulan@chromium.org Review-Url: https://codereview.chromium.org/1999753002 Cr-Commit-Position: refs/heads/master@{#36410}
-
- 03 May, 2016 3 commits
-
-
mlippautz authored
Reland of [turbofan] Restore basic write barrier elimination. (patchset #1 id:1 of https://codereview.chromium.org/1943743003/ ) Reason for revert: Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination. Original issue's description: > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) > > Reason for revert: > Breaks WBs that should be there ;) > > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 > > Will open repro bug asap. > > Original issue's description: > > [turbofan] Restore basic write barrier elimination. > > > > Restore the basic write barrier elimination that we used to run as part > > of the simplified lowering phase (in ChangeLowering actually) before, by > > moving the write barrier computation to SimplifiedLowering where we can > > still look at types and consider the heap/isolate, and just update the > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > > lowering to a machine Load/Store. > > > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > R=mstarzinger@chromium.org > > BUG=v8:4969,chromium:608636 > > LOG=n > > > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > > Cr-Commit-Position: refs/heads/master@{#35969} > > TBR=mstarzinger@chromium.org,bmeurer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4969,chromium:608636 > > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 > Cr-Commit-Position: refs/heads/master@{#35983} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943323002 Cr-Commit-Position: refs/heads/master@{#35984}
-
mlippautz authored
Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) Reason for revert: Breaks WBs that should be there ;) https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 Will open repro bug asap. Original issue's description: > [turbofan] Restore basic write barrier elimination. > > Restore the basic write barrier elimination that we used to run as part > of the simplified lowering phase (in ChangeLowering actually) before, by > moving the write barrier computation to SimplifiedLowering where we can > still look at types and consider the heap/isolate, and just update the > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > lowering to a machine Load/Store. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > R=mstarzinger@chromium.org > BUG=v8:4969,chromium:608636 > LOG=n > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > Cr-Commit-Position: refs/heads/master@{#35969} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943743003 Cr-Commit-Position: refs/heads/master@{#35983}
-
bmeurer authored
Restore the basic write barrier elimination that we used to run as part of the simplified lowering phase (in ChangeLowering actually) before, by moving the write barrier computation to SimplifiedLowering where we can still look at types and consider the heap/isolate, and just update the WriteBarrierKind in the FieldAccess/ElementAccess that we later use when lowering to a machine Load/Store. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel R=mstarzinger@chromium.org BUG=v8:4969,chromium:608636 LOG=n Review-Url: https://codereview.chromium.org/1938993002 Cr-Commit-Position: refs/heads/master@{#35969}
-
- 01 Mar, 2016 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:3956 LOG=n Review URL: https://codereview.chromium.org/1731063007 Cr-Commit-Position: refs/heads/master@{#34398}
-
- 25 Feb, 2016 1 commit
-
-
ulan authored
Reland "Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ )" This reverts commit 9146bc5e. This contains a fix for the following crash: 1. We record slots for a fixed array. 2. We trim the fixed array, so that some recorded slots are now in free space. 3. During mark-compact we sweep the page with the fixed array. Now free list items contain memory with recorded slots. 4. We evacuate a byte array using the new free list items. 5. We iterate slots that are now inside the byte array and crash. BUG=chromium:589413,chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1735523002 Cr-Commit-Position: refs/heads/master@{#34302}
-
- 24 Feb, 2016 1 commit
-
-
ulan authored
Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ ) Reason for revert: Revert because of canary crashes: crbug.com/589413 Original issue's description: > Replace slots buffer with remembered set. > > Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. > > The remembered set is extended to support typed slots. > > During parallel evacuation all migration slots are recorded in local slots buffers. > After evacuation all local slots are added to the remembered set. > > BUG=chromium:578883 > LOG=NO > > Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152 > Cr-Commit-Position: refs/heads/master@{#34212} TBR=jochen@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:578883 Review URL: https://codereview.chromium.org/1725073003 Cr-Commit-Position: refs/heads/master@{#34238}
-
- 23 Feb, 2016 1 commit
-
-
ulan authored
Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. The remembered set is extended to support typed slots. During parallel evacuation all migration slots are recorded in local slots buffers. After evacuation all local slots are added to the remembered set. BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1703823002 Cr-Commit-Position: refs/heads/master@{#34212}
-
- 16 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
- 09 Feb, 2016 1 commit
-
-
ulan authored
BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1675163003 Cr-Commit-Position: refs/heads/master@{#33841}
-
- 08 Feb, 2016 1 commit
-
-
ulan authored
This replaces the global remembered set with per-page remembered sets. Each page in the old space, map space, and large object space keeps track of the set of slots in the page pointing to the new space. The data structure for storing slot sets is a two-level bitmap, which allows us to remove the store buffer overflow and SCAN_ON_SCAVENGE logic. Design doc: https://goo.gl/sMKCf7 BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1608583002 Cr-Commit-Position: refs/heads/master@{#33806}
-
- 29 Jan, 2016 1 commit
-
-
jkummerow authored
String wrappers (new String("foo")) are special objects: their string characters are accessed like elements, and they also have an elements backing store. This used to require a bunch of explicit checks like: if (obj->IsJSValue() && JSValue::cast(obj)->value()->IsString()) { /* Handle string characters */ } // Handle regular elements (for string wrappers and other objects) obj->GetElementsAccessor()->Whatever(...); This CL introduces new ElementsKinds for string wrapper objects (one for fast elements, one for dictionary elements), which allow folding the special-casing into new StringWrapperElementsAccessors. No observable change in behavior is intended. Review URL: https://codereview.chromium.org/1612323003 Cr-Commit-Position: refs/heads/master@{#33616}
-
- 26 Jan, 2016 1 commit
-
-
jarin authored
This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map. The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1636013002 Cr-Commit-Position: refs/heads/master@{#33521}
-
- 23 Dec, 2015 1 commit
-
-
ishell authored
BUG=chromium:570131 LOG=N Review URL: https://codereview.chromium.org/1546933002 Cr-Commit-Position: refs/heads/master@{#33029}
-
- 11 Dec, 2015 1 commit
-
-
ishell authored
During property reconfiguring ensure that the first map that gets new descriptors is the one that owns the whole descriptor array. This is necessary to guarantee that the whole descriptor would be marked, otherwise DescriptorArray pretenuring would cause crashes. Review URL: https://codereview.chromium.org/1520613006 Cr-Commit-Position: refs/heads/master@{#32812}
-
- 09 Dec, 2015 2 commits
-
-
mlippautz authored
* Move most heap related tests into heap/ subdir * IWYU for heap utility functions R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1512553002 Cr-Commit-Position: refs/heads/master@{#32706}
-
jochen authored
Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1505803004 Cr-Commit-Position: refs/heads/master@{#32701}
-
- 07 Dec, 2015 1 commit
-
-
bmeurer authored
The test expectations should fail consistently in both release and debug builds. DCHECK is only meant for debug-only checks in production code. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1506753002 Cr-Commit-Position: refs/heads/master@{#32639}
-
- 16 Nov, 2015 1 commit
-
-
jochen authored
BUG=none R=verwaest@chromium.org,rossberg@chromium.org,bmeurer@chromium.org,neis@chromium.org LOG=y Review URL: https://codereview.chromium.org/1413463006 Cr-Commit-Position: refs/heads/master@{#32014}
-
- 29 Sep, 2015 2 commits
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1374163002 Cr-Commit-Position: refs/heads/master@{#30998}
-
bmeurer authored
Revert of [heap] Remove retry space from AllocateRaw. (patchset #3 id:40001 of https://codereview.chromium.org/1370123002/ ) Reason for revert: Breaks arm64 nosnap simulator (bogus cctest?): https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/2934/steps/Bisect%202786ceec.Retry/logs/IncrementalWriteBarri.. Original issue's description: > [heap] Remove retry space from AllocateRaw. > > BUG= > > Committed: https://crrev.com/2786ceec1eb491494d24d29a59eefbe3b6704be2 > Cr-Commit-Position: refs/heads/master@{#30984} TBR=mstarzinger@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1379493003 Cr-Commit-Position: refs/heads/master@{#30991}
-
- 28 Sep, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1370123002 Cr-Commit-Position: refs/heads/master@{#30984}
-
- 25 Sep, 2015 1 commit
-
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1352453004 Cr-Commit-Position: refs/heads/master@{#30944}
-
- 21 Sep, 2015 1 commit
-
-
mythria authored
Removes deprecated functions from the following files: test/cctest/compiler/function-tester.h test/cctest/test-thread-termination.cc test/cctest/test-threads.cc test/cctest/test-transitions.cc test/cctest/test-typedarrays.cc test/cctest/test-types.cc test/cctest/test-typing-reset.cc test/cctest/test-unbound-queue.cc test/cctest/test-unboxed-doubles.cc BUG=v8:4134 LOG=n Review URL: https://codereview.chromium.org/1344583002 Cr-Commit-Position: refs/heads/master@{#30846}
-
- 15 Sep, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1343043002 Cr-Commit-Position: refs/heads/master@{#30746}
-
- 21 Aug, 2015 1 commit
-
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1293283003 Cr-Commit-Position: refs/heads/master@{#30301}
-
- 11 Aug, 2015 1 commit
-
-
bmeurer authored
This way we can greatly simplify the different variants of ToObject in our codebase and make them more uniform and robust. Adding a new primitive doesn't require finding and changing all those places again, but it is sufficient to setup the constructor function index when allocating the map. We use the inobject properties field of Map, which is invalid primitive maps anyway. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1276533003 Cr-Commit-Position: refs/heads/master@{#30119}
-
- 13 Jul, 2015 1 commit
-
-
mstarzinger authored
Note that there are currently no objects that require a pre-allocated properties backing store, all such slots are in-object properties from the begining. Hence {unused + pre_allocated - inobject == 0} holds. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1226203011 Cr-Commit-Position: refs/heads/master@{#29590}
-
- 08 Jun, 2015 1 commit
-
-
conradw authored
Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1144183004 Cr-Commit-Position: refs/heads/master@{#28839}
-
- 02 Jun, 2015 1 commit
-
-
conradw authored
Copied, with permission, from https://codereview.chromium.org/1151853003/ Initial patch set is an unmodified copy, rebased on top of related fixes from https://codereview.chromium.org/1158933002/ Subsequent patch sets contain fixes for remaining bugs in the CL. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1152093003 Cr-Commit-Position: refs/heads/master@{#28760}
-
- 23 Apr, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1099783003 Cr-Commit-Position: refs/heads/master@{#28024}
-
- 21 Apr, 2015 4 commits
-
-
jochen authored
Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/1094333002/) Reason for revert: Breaks gbemu Original issue's description: > Reland "LayoutDescriptor should inherit from JSTypedArray" > > Original issue's description: > > LayoutDescriptor should inherit from JSTypedArray > > > > It can't just inherit from a FixedTypedArray-like type, as we soon > > assume that a FixedTypedArray-like type is always held by an > > ArrayBufferView-like type > > > > BUG=v8:3996 > > R=ishell@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n TBR=ishell@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1080403004 Cr-Commit-Position: refs/heads/master@{#27975}
-
jochen authored
Original issue's description: > LayoutDescriptor should inherit from JSTypedArray > > It can't just inherit from a FixedTypedArray-like type, as we soon > assume that a FixedTypedArray-like type is always held by an > ArrayBufferView-like type > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=ishell@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1094333002 Cr-Commit-Position: refs/heads/master@{#27973}
-
jochen authored
Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1 of https://codereview.chromium.org/1084793004/) Reason for revert: breaks mjsunit on debug bots Original issue's description: > LayoutDescriptor should inherit from JSTypedArray > > It can't just inherit from a FixedTypedArray-like type, as we soon > assume that a FixedTypedArray-like type is always held by an > ArrayBufferView-like type > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n TBR=ishell@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1073053006 Cr-Commit-Position: refs/heads/master@{#27968}
-
jochen authored
It can't just inherit from a FixedTypedArray-like type, as we soon assume that a FixedTypedArray-like type is always held by an ArrayBufferView-like type BUG=v8:3996 R=ishell@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1084793004 Cr-Commit-Position: refs/heads/master@{#27964}
-
- 15 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (patchset #4 id:60001 of https://codereview.chromium.org/1082973003/) Reason for revert: [Sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3348 and maybe leads to timeouts/crashes on layout test bots: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002 Original issue's description: > Force full GC whenever CollectAllGarbage is meant to trigger a full GC. > > Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. > > Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. > > BUG= > > Committed: https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1 > Cr-Commit-Position: refs/heads/master@{#27831} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1088083002 Cr-Commit-Position: refs/heads/master@{#27834}
-
hpayer authored
Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. BUG= Review URL: https://codereview.chromium.org/1082973003 Cr-Commit-Position: refs/heads/master@{#27831}
-