- 06 Jul, 2018 17 commits
-
-
Clemens Hammacher authored
When calling an import which is an exported wasm function, the interpreter needs to look through the jump table to find the actual code object. We already had that logic for indirect calls, but it was missing for imported calls. R=ahaas@chromium.org Bug: chromium:860392 Change-Id: I6b5a0192f79c23cb1de55407fe93f6df9a17235a Reviewed-on: https://chromium-review.googlesource.com/1127671Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54291}
-
Sigurd Schneider authored
This reverts commit f45045cc. Reason for revert: <INSERT REASONING HERE> Original change's description: > [parser] Move some PPSD sanity checks to debug > > Move some of PreParsedScopeData's santity checks, such as the magic > value separating skippable function data from scope data, to be debug > only, to save memory. > > Start position of inner skippable functions is still kept, because it's > too good at catching bugs, but we may want to remove it in the future > as well. > > Bug: chromium:818642 > Change-Id: If86ff1b9845e8dd3b015b4e554d0033328b145bf > Reviewed-on: https://chromium-review.googlesource.com/1127046 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54263} TBR=marja@chromium.org,leszeks@chromium.org Change-Id: I15ceedd66d9ecb66cf65f5834d09975b41d3ed27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1127859Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54290}
-
Georg Neis authored
This is a reland of 1ba5d5ba without any changes. TBR=jarin@chromium.org Original change's description: > Clean up DependentCode class. > > Also move some helpers there. > > Bug: v8:7902 > Change-Id: I1ef3d1e8317102afae2861382e9ba60b0ef6bba4 > Reviewed-on: https://chromium-review.googlesource.com/1121461 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54179} Bug: v8:7902 Change-Id: I9ef70b88be1b31b458a95442ff3806d651e809ee Reviewed-on: https://chromium-review.googlesource.com/1127719Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54289}
-
Théotime Grohens authored
This CL implements Reduction and Lowering for the DataView Int32, Uint32, Float32 and Float64 getters. This makes DataView getters fully supported in TurboFan (except for BigInts), and should bridge the performance gap with TypedArrays. Change-Id: Ifa98df9cf13e44d6468ad9ec8a19c86b41c6d2b1 Reviewed-on: https://chromium-review.googlesource.com/1127360 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54288}
-
Yang Guo authored
This reverts commit ccfa4ca7. Reason for revert: Infra supports this now. Original change's description: > [node] reset node checkout on v8 update > > This is a temporary measure to get bots back in order. > > Bug: chromium:860430 > > TBR=machenbach@chromium.org > > Change-Id: I3275150f4bc5dfe8ab90984e15f8a1a469d70caf > Reviewed-on: https://chromium-review.googlesource.com/1127166 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54269} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: I6a74ab702fd32b278caebb665be6868b4712dffb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:860430 Reviewed-on: https://chromium-review.googlesource.com/1127721Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54287}
-
Sigurd Schneider authored
This CL surfaces AssemblerOptions to CodeAssembler::GenerateCode and to pipeline methods. To allow forward declaring AssemblerOptions, AssemblerBase::Options was moved out of the AssemblerBase class. Bug: v8:6666 Change-Id: If9fc50d3d4767bb5dd39a0c3b6e094021f4cae2b Reviewed-on: https://chromium-review.googlesource.com/1127039 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54286}
-
Yang Guo authored
This reverts commit 7fb1874d. Reason for revert: Infra supports this now. Original change's description: > [node] force checkout vee-eight-lkgr > > TBR=machenbach@chromium.org > > Bug: chromium:860430 > Change-Id: I5554468a7c11038903fc3ab5eca067c230b2849a > Reviewed-on: https://chromium-review.googlesource.com/1127370 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54279} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: I5d99abb4885f8da9929ab826db47cd8ffc416b81 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:860430 Reviewed-on: https://chromium-review.googlesource.com/1127720Reviewed-by:
-
Simon Zünd authored
This CL extends the existing ArrayPop C++ builtin with a generic slow-path that replaces the JavaScript fallback. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Change-Id: Ie3ce5379e5c65df67cbc4d956390a8701345ea3c Reviewed-on: https://chromium-review.googlesource.com/1127162 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This fixes a typo where we stored the framepointer in the constant pool register instead of the constant pool value. Bug: v8:7915 Change-Id: I612bf1860ed2e5e5707e2df4a2b92aefaaa9c5cb Reviewed-on: https://chromium-review.googlesource.com/1127639Reviewed-by:
-
Simon Zünd authored
This CL extends the existing ArrayPush C++ builtin with a generic slow-path that replaces the JavaScript fall-back. Bug: v8:7624 Change-Id: I1e8431601e8a872f3c5afba5d486f37fd5781d60 Reviewed-on: https://chromium-review.googlesource.com/1126922Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54282}
-
Dominik Inführ authored
Originally intended for benchmarking but not good enough for that since recent changes cannot be easily disabled. Bug: chromium:844008 Change-Id: I4c7075fe2f1d5e85b76a0c40c854b0dbf7d4564b Reviewed-on: https://chromium-review.googlesource.com/1127376Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@google.com> Cr-Commit-Position: refs/heads/master@{#54281}
-
Georg Neis authored
This is a reland of 4b9b9b68, which accidentally disabled optimization after dependency changes (instead of retrying). TBR=jarin@chromium.org TBR=mstarzinger@chromium.org Original change's description: > Reland "[turbofan] Rewrite CompilationDependencies" > > This is a reland of 52a10e50, after > eliminating an invalid assumption about maps. > > TBR=jarin@chromium.org > TBR=mstarzinger@chromium.org > > Original change's description: > > [turbofan] Rewrite CompilationDependencies > > > > Instead of installing code dependencies during graph reduction, > > install them after code generation. > > > > Bug: v8:7902, v8:7790 > > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > > Reviewed-on: https://chromium-review.googlesource.com/1119913 > > Commit-Queue: Georg Neis <neis@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54170} > > Bug: v8:7902, v8:7790 > Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f > Reviewed-on: https://chromium-review.googlesource.com/1126999 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54254} Bug: v8:7902, v8:7790 Change-Id: I2b7a7d186e03990350e375470569177e3309683c Reviewed-on: https://chromium-review.googlesource.com/1127579 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: chromium:860430 Change-Id: I5554468a7c11038903fc3ab5eca067c230b2849a Reviewed-on: https://chromium-review.googlesource.com/1127370 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Makes it safer to access from C++ Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib435382bd5568a62976a32b1ff4ca67c8413ddf2 Reviewed-on: https://chromium-review.googlesource.com/1127081Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I543078d72c9ce40c6927b57fd81b555f90bbfbff Reviewed-on: https://chromium-review.googlesource.com/1126764 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=sigurds@chromium.org Change-Id: Ibc6bcb9f9576a34d909a8f0d0fbdc2899f0b671e Reviewed-on: https://chromium-review.googlesource.com/1127369Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0cc2895..911a0c5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8221306..5715e98 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id7e56f5519adb8897cc9e3c0ec597b977a7d7a80 Reviewed-on: https://chromium-review.googlesource.com/1127485Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54275}
-
- 05 Jul, 2018 23 commits
-
-
Alexey Kozyatinskiy authored
- rewritten couple tests, - migrated JSMessageObject to real Script instead of wrapper, - removed wrapper. R=yangguo@chromium.org TBR=ulan@chromium.org Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia95492344c7b5978a940e2ab007b389384537148 Reviewed-on: https://chromium-review.googlesource.com/1112851Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
After liveedit removed - we do not need this context any more. R=yangguo@chromium.org TBR=clemensh@chromium.org Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idb43d016d51b8048f6cd2ca590fd7510abcacb49 Reviewed-on: https://chromium-review.googlesource.com/1106802 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Creddy authored
* Rename BoilerplateDescription to ObjectBoilerplateDescription * Add literal_type flag to ObjectBoilerplateDescription, which is stored as zeroth element of Fixed array * Create ArrayBoilerplateDescription with elements_kind and constant_elements field * Replace CompileTimeValue and ConstantElementPair with ArrayBoilerplateDescription * Kill ConstantElementPair and CompileTimeValue Change-Id: Icb42dcfd575a27e2b64ffd5e2e61f9d703d5e986 Bug: v8:7787, chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1122411 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54272}
-
Théotime Grohens authored
This CL adds a Reduction for the DataViewGetInt16 and -Uint16 builtins, and the corresponding handling in LoadDataViewElement node in the effect control linearizer. It also adds tests for the new getters. Change-Id: I5101755e47657c25f10be1417f105e3ae72a3c39 Reviewed-on: https://chromium-review.googlesource.com/1126919 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
Yang Guo authored
R=cbruni@chromium.org Change-Id: Iaac9794f2608db21c7b6d6a387085de04f0434d6 Reviewed-on: https://chromium-review.googlesource.com/1127165Reviewed-by:
-
Yang Guo authored
This is a temporary measure to get bots back in order. Bug: chromium:860430 TBR=machenbach@chromium.org Change-Id: I3275150f4bc5dfe8ab90984e15f8a1a469d70caf Reviewed-on: https://chromium-review.googlesource.com/1127166Reviewed-by:
-
Mike Stanton authored
Change-Id: I061df17a2bb713b00c09104c1b7fcfad218b8ad6 Reviewed-on: https://chromium-review.googlesource.com/1126929Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I4fb79b1b694c89f348dba71dae0ad68e82b614dc Reviewed-on: https://chromium-review.googlesource.com/1127051 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54267}
-
Clemens Hammacher authored
This avoids the need for the finisher task (running on the foreground thread) for Liftoff code. This CL just makes the simple change to call {AddCode} from the background thread. More cleanup will follow in separate CLs. R=mstarzinger@chromium.org Bug: v8:6600, v8:7921 Change-Id: I99ef29377efee5be36ba203aa7ed71e2471d86f3 Reviewed-on: https://chromium-review.googlesource.com/1126930 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sathya Gunasekaran authored
This unblocks new feature work that require this operation from C++, whilst the porting to C++ is underway. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icb7f05bbea42ecfa1abc3cefb6d1bf8542ed921b Reviewed-on: https://chromium-review.googlesource.com/1127082 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Maya Lekova authored
Replace CHECK with throwing exception when no or invalid arguments are passed to async_hooks.createHook. Bug: chromium:860481 Change-Id: Ie5a915ee66f2a0ff79c4df5aef94ff883866ecda Reviewed-on: https://chromium-review.googlesource.com/1127054Reviewed-by:
-
Leszek Swirski authored
Move some of PreParsedScopeData's santity checks, such as the magic value separating skippable function data from scope data, to be debug only, to save memory. Start position of inner skippable functions is still kept, because it's too good at catching bugs, but we may want to remove it in the future as well. Bug: chromium:818642 Change-Id: If86ff1b9845e8dd3b015b4e554d0033328b145bf Reviewed-on: https://chromium-review.googlesource.com/1127046 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Toon Verwaest authored
The embedder should ultimately be responsible for handling this since they anyway give us a copy of the data. They can easily make sure that the chunks we get do not have lonely bytes. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie862107bbbdd00c4d904fbb457a206c2fd52e5d0 Reviewed-on: https://chromium-review.googlesource.com/1127044Reviewed-by:
-
Michael Starzinger authored
This introduces a second factory method for allocating new module objects that are based on existing native modules which are potentially shared between multiple Isolates. R=clemensh@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: I8c74d821542d443a8ad2352cb77b84b445e21acb Reviewed-on: https://chromium-review.googlesource.com/1126931 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit 4b9b9b68. Reason for revert: Regresses Octane. Original change's description: > Reland "[turbofan] Rewrite CompilationDependencies" > > This is a reland of 52a10e50, after > eliminating an invalid assumption about maps. > > TBR=jarin@chromium.org > TBR=mstarzinger@chromium.org > > Original change's description: > > [turbofan] Rewrite CompilationDependencies > > > > Instead of installing code dependencies during graph reduction, > > install them after code generation. > > > > Bug: v8:7902, v8:7790 > > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > > Reviewed-on: https://chromium-review.googlesource.com/1119913 > > Commit-Queue: Georg Neis <neis@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54170} > > Bug: v8:7902, v8:7790 > Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f > Reviewed-on: https://chromium-review.googlesource.com/1126999 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54254} TBR=mstarzinger@chromium.org,jarin@chromium.org,neis@chromium.org Change-Id: Iece193046c48ee96ab7952d2b3bd7ad05f39b190 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7902, v8:7790 Reviewed-on: https://chromium-review.googlesource.com/1127119Reviewed-by:
-
Sathya Gunasekaran authored
Creates two different functions specialized for string and boolean types. Gets rid of several allocations and keeps the C++ <-> JS type conversions to a minimum. Improves the API as we don't have to create the fallback or V8 Strings unnecessarily. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I788e43e6ef23f3e9144ff719f01d6334fe6cb9ce Reviewed-on: https://chromium-review.googlesource.com/1126750 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Additionally now we only scan over flat heap strings. Change-Id: Ia73c538a3c7923ec66089e16efa529ef3cea2d06 Reviewed-on: https://chromium-review.googlesource.com/1126938 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This is a reland of 8e39af62 Original change's description: > [arm64] Use root register for addressing external references. > > This optimization is already done on x64 (7500e507). > > Bug: v8:7844 > Change-Id: Iccc3bb55aa79ef1d4423576c79d9ce6f829f2828 > Reviewed-on: https://chromium-review.googlesource.com/1120343 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54162} Bug: v8:7844 Change-Id: I2eab2d753fd8e374bf7c912a107c93edc58ef4c7 Reviewed-on: https://chromium-review.googlesource.com/1126259Reviewed-by:
-
jgruber authored
This adds the option to output statistics about the embedded blob. On x64 release, the output is currently: Total size: 724064 Metadata size: 6832 Instruction size: 703427 Padding: 13805 Embedded builtin count: 852 Instruction size (50th percentile): 222 Instruction size (75th percentile): 749 Instruction size (90th percentile): 1871 Instruction size (99th percentile): 9171 Total size is added to our Memory benchmark. Drive-by: Fix startup / context regexps for Memory benchmark. Bug: v8:6666, v8:7898 Change-Id: I90d4458877939d3b48593bd9dd3a33971fe78c44 Reviewed-on: https://chromium-review.googlesource.com/1126104 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Stephan Herhut authored
When assigning a register to a value that is used as a function argument, we use a hint to suggest the corresponding register. However, if the argument is also used after the call, the register will not be free for the entire live range of the value. Hence we need to split the live range. To minimize the number of splits, we aim to choose a register with maxium availability. This heuristic was implemented based on lifetime positions with sub-instruction precision. In such a model, argument registers typically have a shorter available time, as they need to hold a value before a call, whereas all other registers are free until right after the call, where they have been overwritten by the called function. Hence, we typically chose a non-argument register, ignoring the hint and creating an extra move. This change moves the heuristic to instruction granularity, which gives argument and other registers the same free time. We also now prefer hinted registers if they have the same free time. Change-Id: Ia8dd73b6c086d28859a836c42ea9ff8afce4c371 Reviewed-on: https://chromium-review.googlesource.com/1124852Reviewed-by:
-
Georg Neis authored
This is a reland of 52a10e50, after eliminating an invalid assumption about maps. TBR=jarin@chromium.org TBR=mstarzinger@chromium.org Original change's description: > [turbofan] Rewrite CompilationDependencies > > Instead of installing code dependencies during graph reduction, > install them after code generation. > > Bug: v8:7902, v8:7790 > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > Reviewed-on: https://chromium-review.googlesource.com/1119913 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54170} Bug: v8:7902, v8:7790 Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f Reviewed-on: https://chromium-review.googlesource.com/1126999Reviewed-by:
-
Ross McIlroy authored
Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54253}
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: Id7701375897f6f3cfac7327404751b43cfdb221c Reviewed-on: https://chromium-review.googlesource.com/1118888Reviewed-by:
-
