- 05 Jul, 2021 1 commit
-
-
Piotr Tworek authored
Commit 26d85ace "Use IMMEDIATE_CRASH on official build FATAL errors." has changed how FATAL macro behaves on such builds. Unfortunately this affects logging and random number generator v8 unittests which use ASSERT_DEATH_IF_SUPPORTED macro. After the change we no longer get any v8 CHECK crash messages on official builds thus failing those tests. Fix this by adjusting failing test expectations to reflect the new, expected results v8 now has on official builds. Change-Id: Ice9718c5e887b42a0cfd583340256f7d2591add4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991238Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75547}
-
- 05 Jan, 2021 1 commit
-
-
Clemens Backes authored
The tests were failing in official release builds, because those drop the fatal error message and always print "ignored" instead. R=ecmziegler@chromium.org Bug: v8:11251 Change-Id: I40512ca308337cf070ecb6a206dc4a5323d67415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595445Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71914}
-
- 21 Jan, 2020 1 commit
-
-
Milad Farazmand authored
Compilation is failing on certain versions of gcc with: 'sort' is not a member of 'std' 'adjacent_find' is not a member of 'std' 'count' is not a member of 'std' and Bug: v8:10145 Change-Id: I0672636987c515485318d29d251c3b49a22ff374 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2008307 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65884}
-
- 10 Sep, 2019 1 commit
-
-
Bill Budge authored
- Eliminates non-const reference parameters in test/unittests. Bug: v8:9429 Change-Id: Ia7b41482811183324a62859d27fc263e4032219a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794802Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63643}
-
- 08 Jul, 2019 1 commit
-
-
Clemens Hammacher authored
Cpplint usually checks for non-const reference arguments. They are forbidden in the style guide, and v8 does not explicitly make an exception here. This CL re-enables that warning, and fixes all current violations by adding an explicit "NOLINT(runtime/references)" comment. In follow-up CLs, we should aim to remove as many of them as possible. TBR=mlippautz@chromium.org Bug: v8:9429 Change-Id: If7054d0b366138b731972ed5d4e304b5ac8423bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687891Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62551}
-
- 18 Feb, 2019 1 commit
-
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature Bug: chromium:925652 Change-Id: I3cd02b9fa6dbece1594bbfd50a21ad7503c2aab9 Reviewed-on: https://chromium-review.googlesource.com/c/1475654Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#59666}
-
- 07 Nov, 2017 3 commits
-
-
Michal Majewski authored
This is a reland of 34e3e7f9 Original change's description: > Introduce gc flag for fuzzing over compaction. > > Bug: v8:6972 > Change-Id: If1f4ee04ae00c6ae1e037bbb1ca758e952a8f843 > Reviewed-on: https://chromium-review.googlesource.com/738112 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49191} Bug: v8:6972 Change-Id: I690a72a6d5da17c6f15449b2be4cbb681a67e60e Reviewed-on: https://chromium-review.googlesource.com/756894Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49195}
-
Michael Achenbach authored
This reverts commit 34e3e7f9. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Fuchsia/builds/474 Original change's description: > Introduce gc flag for fuzzing over compaction. > > Bug: v8:6972 > Change-Id: If1f4ee04ae00c6ae1e037bbb1ca758e952a8f843 > Reviewed-on: https://chromium-review.googlesource.com/738112 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49191} TBR=machenbach@chromium.org,hpayer@chromium.org,majeski@google.com Change-Id: I63a14763a4958c948fbcad1e75c284abb580e7be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6972 Reviewed-on: https://chromium-review.googlesource.com/755596Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49192}
-
Michal Majewski authored
Bug: v8:6972 Change-Id: If1f4ee04ae00c6ae1e037bbb1ca758e952a8f843 Reviewed-on: https://chromium-review.googlesource.com/738112Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49191}
-
- 01 Oct, 2014 1 commit
-
-
bmeurer@chromium.org authored
As per discussion on the V8 team, this is the place we want them to live, not following the Chrome Style Guide for this. BUG=v8:3489 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/615393002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-