1. 29 Mar, 2017 5 commits
  2. 24 Mar, 2017 4 commits
  3. 22 Mar, 2017 2 commits
    • kozyatinskiy's avatar
      [inspector] follow up for e27d18c9 · 69ad35ac
      kozyatinskiy authored
      - renamed inspector-test methods,
      - tuned comment in debug.h
      
      BUG=v8:6118
      TBR=dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2766283002
      Cr-Commit-Position: refs/heads/master@{#44043}
      69ad35ac
    • kozyatinskiy's avatar
      [debugger] tuned StepNext and StepOut at return position · e27d18c9
      kozyatinskiy authored
      Proposed behaviour:
      - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side);
      - StepOut at return position go into next non-current function call.
      
      We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners).
      
      New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test):
      - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another:
      var foo = () => 1;
      callAll(foo, foo, () => 2);
      If we break inside of first call of function foo. Then on..
      ..StepNext - we're able to reach second call of function foo,
      ..StepOut - we're able to reach () => 2 call.
      
      - let's consider case with native function:
      [1,2,3].map(x => x * 2)
      If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call.
      
      Implementation details:
      - when we request break we schedule step-in function call for any step action at return position and for step-in at any position,
      - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call,
      - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break.
      
      Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit
      
      BUG=v8:6118,chromium:583193
      R=dgozman@chromium.org,yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2758483002
      Cr-Commit-Position: refs/heads/master@{#44028}
      e27d18c9
  4. 14 Mar, 2017 1 commit
  5. 07 Mar, 2017 1 commit
  6. 06 Mar, 2017 1 commit
  7. 03 Mar, 2017 1 commit
    • clemensh's avatar
      [wasm] Fix importing wasm functions which are being debugged · eb36a7db
      clemensh authored
      If the imported wasm function is being debugged (i.e. redirects to the
      interpreter), call it via the JS_TO_WASM stub, such that we can disable
      the breakpoint later by patching the exported function.
      
      This also contains a drive-by fix in wasm-translation.cc (for the case
      that all known positions are bigger than the requested one).
      
      R=titzer@chromium.org, kozyatinskiy@chromium.org
      BUG=v8:5971, v8:5822
      
      Review-Url: https://codereview.chromium.org/2720813002
      Cr-Commit-Position: refs/heads/master@{#43583}
      eb36a7db
  8. 28 Feb, 2017 1 commit
  9. 27 Feb, 2017 2 commits
  10. 03 Feb, 2017 1 commit
  11. 31 Jan, 2017 1 commit
  12. 27 Jan, 2017 1 commit
  13. 26 Jan, 2017 1 commit
  14. 13 Dec, 2016 1 commit
  15. 06 Dec, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce debug::WasmScript · 12cdb31b
      clemensh authored
      *and* report all "virtual" wasm scripts right when the wasm script is
      registered at the inspector.
      
      WasmScript is a subtype of Script, with the cast checking that it is
      actually a wasm script.
      This layout makes it quite easy to implement functionality that is only
      available for wasm scripts, and allows to later directly use the
      WasmCompiledModule instead of the i::Script for backing the
      debug::WasmScript. We might also add virtual methods to
      provide different implementations for GetSourcePosition, Source and
      others.
      
      DisassembleWasmFunction now also becomes a method of this class instead
      of a static function on the DebugInterface.
      
      The WasmTranslation now uses the new WasmScript type instead of the
      Script wrapper, and also registers all virtual wasm scripts immediately
      when the wasm script is made public to the inspector (when the wasm
      module is created).
      
      R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
      BUG=chromium:613110,chromium:659715
      
      Review-Url: https://codereview.chromium.org/2531163010
      Cr-Commit-Position: refs/heads/master@{#41519}
      12cdb31b
  16. 04 Nov, 2016 1 commit
  17. 28 Oct, 2016 1 commit
    • clemensh's avatar
      Fix detection of BUILTIN functions · 1cac34ed
      clemensh authored
      In the asm.js to wasm pipeline, we generate an entry function with
      BUILTIN code, but still attached to a TYPE_NORMAL script.
      This fix avoids trying to set a breakpoint there, resulting in a crash
      on DCHECK(shared->HasDebugInfo()).
      
      Also add two inspector tests to track regressions.
      
      BUG=v8:5568
      R=titzer@chromium.org,mstarzinger@chromium.org
      
      Review-Url: https://codereview.chromium.org/2457433002
      Cr-Commit-Position: refs/heads/master@{#40633}
      1cac34ed
  18. 25 Oct, 2016 1 commit
    • kozyatinskiy's avatar
      [inspector] enable inspector by default · d7a18896
      kozyatinskiy authored
      To achieve this:
      - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else.
      - fixed asan for d8 - unique_ptr on array has single element type.
      - force Debugger.disable at the end of test.
      
      BUG=chromium:635948
      R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
      
      Review-Url: https://codereview.chromium.org/2450653002
      Cr-Commit-Position: refs/heads/master@{#40546}
      d7a18896
  19. 05 Oct, 2016 2 commits
  20. 03 Oct, 2016 3 commits
  21. 02 Oct, 2016 1 commit
  22. 30 Sep, 2016 2 commits