1. 18 Jan, 2021 1 commit
    • Jakob Gruber's avatar
      [compiler] Use StateValuesAccess to access frame state parameters · 0ef84f99
      Jakob Gruber authored
      FrameState parameters must not be iterated directly since parameters
      can be encoded into StateValues (i.e. parameter i is not necessarily
      InputAt(i)). Instead, they should be accessed through the
      StateValuesAccess helper class.
      
      One example:
      
       82: StateValues[sparse:^^^^^^](81, 31, 32, 33, 34, 35)
        81: StateValues[sparse:^^^^^^^^](110, 24, 25, 26, 27, 28, 29, 30)
        31: NumberConstant[8]
        32: NumberConstant[9]
        33: NumberConstant[10]
        34: NumberConstant[11]
        35: NumberConstant[13]
      
      Here, node 81 holds multiple parameters. These are properly iterated
      by the StateValuesAccess class.
      
      Bug: chromium:1166136
      Change-Id: I12725f83994e1c05571bcba153ff45154b16d93f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625879
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72126}
      0ef84f99