• Benedikt Meurer's avatar
    [liveedit] Reduce peak memory usage of text diffing. · 3fa681db
    Benedikt Meurer authored
    The algorithm used to compute the textual differences uses requires
    quadratic space (in the size of the input scripts). Previously the
    implementation was naively allocating a single matrix, which is commonly
    very sparse, since the expectation for LiveEdit is that only a small
    portion of the script is actually altered. So we can use a std::map here
    instead to reduce the cost.
    
    We can also significantly reduce the cost (especially of the stack grow
    due to the recursion) by precomputing the common prefix, and pre-filling
    the table for the common suffix, both of which are also assumed to make
    up for the majority of the script in case of LiveEdit.
    
    This is still only ducktape, but should mitigate the crashes in the wild
    significantly. Ideally we'd eventually replace this with an
    implementation of the Myers algorithm that runs in linear space.
    
    Fixed: chromium:1199807
    Change-Id: Ib5fa0b1aa63c67631f919dc3b6641dfc0b20ae74
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867470Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74344}
    3fa681db
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...