1. 09 Mar, 2022 1 commit
    • Camillo Bruni's avatar
      [runtime] Clean up runtime function Arguments accesses · cead6573
      Camillo Bruni authored
      Replace all CONVERT_XXX_ARG_XXX() macros from runtime-util.h with direct
      calls to Arguments or the fully expanded equivalent.
      
      - This replaces many of the hard CHECKs with DCHECK (as is common
        practice in most V8 code)
      - Instead of relying on verbose comments we now have readable code
      - Rename Arguments.::xxx_at with Arguments::xxx_value_at since these
        methods don't return the Object but rather their double/int value
      
      - Add Oddball::ToBool helper
      - Add and use v8::internal::PropertyAttributesFromInt helper
      - Add stronger DCHECK for PropertyAttributes returned in
        GetPropertyAttributesWithInterceptorInternal
      
      
      
      Bug: v8:11263
      Change-Id: I8d531857e05d19f3198753b05af28d993a391854
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497768Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79418}
      cead6573
  2. 07 Feb, 2022 1 commit
  3. 24 Mar, 2021 1 commit
  4. 23 Mar, 2021 1 commit
    • Maya Lekova's avatar
      Revert "Reland [dict-proto] C++ implementation of SwissNameDictionary, pt. 10" · 5e8417a2
      Maya Lekova authored
      This reverts commit bb2ca416.
      
      Reason for revert: WrapAround test is timing out on TSAN and closing the tree, please check https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/36014/overview.
      
      Original change's description:
      > Reland [dict-proto] C++ implementation of SwissNameDictionary, pt. 10
      >
      > This is a reland of
      > https://chromium-review.googlesource.com/c/v8/v8/+/2744138. It
      > shortens the runtime of the Copy and EnumerationOrder tests in
      > cctest/test-swiss-name-dictionary-csa for TSAN and CFI builds, as
      > compared to the original version.
      >
      > Original description:
      >
      > This CL is part of a series that adds the C++ implementation of
      > SwissNameDictionary, a deterministic property backing store based on
      > Swiss Tables.
      >
      > This CL adds the actual tests for SwissNameDictionary, defined in
      > test-swiss-name-dictionary-shared-tests.h, using the infrastructure
      > in test-swiss-name-dictionary-infra.[h|cc].
      >
      > Bug: v8:11388
      > Change-Id: Ia3f83f6e27be80bfdd63c2cb868638dc90d24cbc
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778416
      > Commit-Queue: Frank Emrich <emrich@google.com>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#73589}
      
      Bug: v8:11388
      Change-Id: Ib95a7183cf9de35a33ec641bc1ec38915c3711c8
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2780294
      Auto-Submit: Maya Lekova <mslekova@chromium.org>
      Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#73593}
      5e8417a2
  5. 22 Mar, 2021 3 commits
  6. 18 Mar, 2021 1 commit