- 20 Feb, 2018 1 commit
-
-
Michael Achenbach authored
This is a partial revert of: https://crrev.com/c/890938 and https://crrev.com/c/893982 Before this CL, the test runner blocked on ongoing tests in order to process their results after an internal timeout. However, the logic required for this feature was overly complicated and prevented an acceptable implementation for fast aborts. Furthermore, also the fuzzers suffered from timeouts on swarming due to hanging tests. Instead, we now abort immediately on internal timeout (used on fuzzers), SIGINT (Ctrl-C) and SIGTERM. Ongoing tests are immediately terminated and their results are disregarded. On SIGTERM and SIGINT, we return with non-zero exit codes, and zero on internal timeout. This will also properly return json output, when the external hard timeout is reached on swarming (causes SIGTERM). TBR=sergiyb@chromium.org Bug: v8:7423, chromium:813065 Change-Id: Ib20f835f58a0970693bdd3b21dc5d766d8e115d8 Reviewed-on: https://chromium-review.googlesource.com/924852Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51399}
-
- 31 Jan, 2018 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: If91defd11c91fd26bdbacc146992745ea772a941 Reviewed-on: https://chromium-review.googlesource.com/890938Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50985}
-
- 07 Feb, 2017 1 commit
-
-
Michael Achenbach authored
That was forgotten in: https://codereview.chromium.org/1652003002 BUG=v8:5861 NOTRY=true TBR=tandrii@chromium.org Change-Id: I259539e5827a81bc8e22c44a8a5e374a0329c7af Reviewed-on: https://chromium-review.googlesource.com/439304Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#42995}
-
- 08 Apr, 2015 1 commit
-
-
machenbach authored
NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1064043002 Cr-Commit-Position: refs/heads/master@{#27653}
-
- 14 May, 2014 1 commit
-
-
machenbach@chromium.org authored
The new process pool allows adding jobs after testing has been started. It will also allow to restructure building the job queue (in a follow up CL), so that testing can start instantly while the queue is being built. Also attempts to clean up the keyboard-interrupt logic. Idea: Only catch keyboard interrupt once per process at the outermost level. Use proper "finally" clauses to clean up everywhere where a keyboard interrupt might occur. Never turn named exceptions into none-exceptions using anonymous "raise". TEST=python -m unittest pool_unittest R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/275093002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21310 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-