Skip to content

V
V8
Switch branch/tag
  1. 15 May, 2018 1 commit
  3. 08 May, 2018 1 commit
  5. 26 Apr, 2018 1 commit
    • Jungshik Shin's avatar
      Fix the fast path for locale canonicalization · 919270e0
      Jungshik Shin authored 
      Not all 2 or 3 letter language codes are canonical. Some of them need
to be canonicalized.

Specifically, exclude {jw,ji,iw,in} and all three-letter codes from the
fast path except for 'fil'.

{jw,ji,iw,in} are deprecated ISO 639 codes for
{Javanese, Yiddish, Hebrew, Indonesian}. They should be
canonicalized to {jv,yi,he,id}. So, do not return early
in the fast path, but pass it down to the full canonicalization.

In addition, there are 70+ deprecated 3-letter codes that need to be
replaced by their modern equivalents. Instead of checking and replacing
in v8, just pass them to ICU to handle.

Along with the following ICU change, two more tests will pass.

  https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1026797

These two tests still fail because of the disagreement between ICU and the test
expectations about 5 grandfathered tags with no preferred value (e.g.
i-default, zh-min, cel-gaulish).

  'intl402/Intl/getCanonicalLocales/canonicalized-tags'
  'intl402/Intl/getCanonicalLocales/preferred-grandfathered'

Bug: v8:5693, v8:7669
Test: test262/intl402/language-tags-canonicalized.js
Test: test262/intl402/Intl/preferred-variants.js
Test: intl/general/language_tags_with_preferred_values.js
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Ide7e9c90ac046859604c7b71c641f84ce9c64be5
Reviewed-on: https://chromium-review.googlesource.com/1023379Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52823}
      919270e0
  7. 25 Apr, 2018 1 commit
  9. 21 Apr, 2018 1 commit
  11. 12 Apr, 2018 1 commit
  13. 28 Mar, 2018 3 commits
  15. 26 Mar, 2018 1 commit
  17. 01 Feb, 2018 1 commit
  19. 31 Jan, 2018 2 commits
  21. 30 Jan, 2018 3 commits
  23. 27 Jan, 2018 1 commit
  25. 23 Jan, 2018 1 commit
  27. 18 Dec, 2017 1 commit
  29. 13 Dec, 2017 2 commits
  31. 12 Dec, 2017 1 commit
  33. 16 Nov, 2017 1 commit
  35. 13 Nov, 2017 2 commits
  37. 08 Nov, 2017 1 commit
  39. 07 Nov, 2017 1 commit
  41. 27 Oct, 2017 1 commit
  43. 19 Oct, 2017 1 commit
    • Jungshik Shin's avatar
      Intl.DateTimeFormat: throw RangeError for non-finite input · 831bc233
      Jungshik Shin authored 
      intl.js throws an exception when datetime-value to format is
Infinity or NaN, but there was a way to thwart the check.

Moreover, intl.js and runtime-intl.cc have unnecessary conversions
of 'Number->Date->Number'. I removed the unnecessary conversion
and made 'Number' be passed to %InternalDateFormat.  With this
streamlining, the work-around mentioned above does not work
anymore.

Add a check in runtime_intl.cc for Infinity/NaN and throw a
RangeError.

Add invalid-time test for invalid datetime-values passed to
Intl.DateTimeFormat.format().

Bug: chromium:774833
Test: intl/date-format/invalid-time.js
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Idc575e532a86ee110dc4bb945ae023d6516650ee
Reviewed-on: https://chromium-review.googlesource.com/724860
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48765}
      831bc233
  45. 12 Oct, 2017 1 commit
  47. 02 Aug, 2017 1 commit
  49. 12 Jul, 2017 1 commit
  51. 29 Jun, 2017 1 commit
  53. 22 May, 2017 1 commit
  55. 04 May, 2017 2 commits
  57. 18 Apr, 2017 2 commits
  59. 17 Apr, 2017 1 commit
  61. 28 Mar, 2017 1 commit