- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
rossberg@chromium.org authored
This requires introducing proper bounds on all leaf types, so that intersection between bitsets and these types can be accurately represented. Extending a union also becomes more involved. (On the upside, the modified union/intersect algorithm would now allow support for proper variance for function types.) Not sure if it is worth landing this. Distributivity isn't really a crucial property for our use cases. It seems fine if intersection is slightly lossy. R=bmeurer@chromium.org, jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/251753005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 1 commit
-
-
rossberg@chromium.org authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/296213005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/257523002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Apr, 2014 1 commit
-
-
adamk@chromium.org authored
BUG=v8:3281 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/246993003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/240813002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2014 5 commits
-
-
rossberg@chromium.org authored
Just wanted to add two constructors to a datatype, how ugly can it get? R=bmeurer@chromium.org, jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20809 Committed: https://code.google.com/p/v8/source/detail?r=20815 Review URL: https://codereview.chromium.org/228263005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/237963016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Just wanted to add two constructors to a datatype, how ugly can it get? R=bmeurer@chromium.org, jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20809 Review URL: https://codereview.chromium.org/228263005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/240143003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Just wanted to add two constructors to a datatype, how ugly can it get? R=bmeurer@chromium.org, jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/228263005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 3 commits
-
-
rossberg@chromium.org authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/237143002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Need to reproduce wrong result only occurring with ASAN. TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/236873002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Fixes size approximation in Intersect. Also lowers the number of fuzzed types in test, to address time-outs. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/226523004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Apr, 2014 3 commits
-
-
dcarney@chromium.org authored
This reverts r20684. TBR=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/235133002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20687 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Some fixes of corner cases on the way R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/230923005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/234743003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2014 3 commits
-
-
bmeurer@chromium.org authored
TEST=cctest/test-types R=rossberg@chromium.org Review URL: https://codereview.chromium.org/232913002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/232843002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Add tests for TypeImpl::Of(), TypeImpl::NowOf() and TypeImpl::NowContains(). Improves the implementation of TypeImpl::NowIs() to match that of TypeImpl::NowContains(). Mark test-types with NO_VARIANTS to speedup testing, since the variants do not affect the type system at all. Also improve test coverage for types. TEST=cctest/test-types R=rossberg@chromium.org Review URL: https://codereview.chromium.org/230673002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/230463003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Apr, 2014 2 commits
-
-
rossberg@chromium.org authored
Same as before, except that it's now using a void array instead of a struct, to shut up Clang warnings. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/224733023 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20574 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
This reverts commit r20538 for breaking gcmole. TBR=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/228223002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Apr, 2014 2 commits
-
-
rossberg@chromium.org authored
Also, simplfy representation of zone types, using a simple struct. R=bmeurer@chromium.org BUG= LOG=N Review URL: https://codereview.chromium.org/225923002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/227473002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20531 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Apr, 2014 2 commits
-
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/224723007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20502 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/225353004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20496 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/221813002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 3 commits
-
-
rossberg@chromium.org authored
Also, rename all *Currently methods to Now*. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/219523003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
Currently, internalizing a cons string could result in either an in-place converted internalized cons string or a newly created internalized sequential string, depending on allocation success. The former could end up being embedded into an IC, which is not supported. R=mstarzinger@chromium.org BUG=357103 LOG=N Review URL: https://codereview.chromium.org/218993011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/220193007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=verwaest@chromium.org, bmeurer@chromium.org BUG=chromium:357330 LOG=Y Review URL: https://codereview.chromium.org/219333003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Also: - improve type pretty-printing, - update doc comments, - some renamings for consistency. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/176843006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20025 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/186743002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Mar, 2014 1 commit
-
-
verwaest@chromium.org authored
Due to performance regression. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/189843006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Mar, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/187353005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Feb, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/166203002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jan, 2014 1 commit
-
-
rossberg@chromium.org authored
R=danno@chromium.org BUG= Review URL: https://codereview.chromium.org/145083007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jan, 2014 2 commits
-
-
rossberg@chromium.org authored
Clean up some zone/isolate handling in AST and its visitors on the way. (Based on https://codereview.chromium.org/103743004/) R=jkummerow@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/102563004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Works around apparent scoping bug in VS, the only change to before being a method rename in the test suite: --- a/test/cctest/test-types.cc +++ b/test/cctest/test-types.cc @@ -153,7 +153,7 @@ struct ZoneRep { return reinterpret_cast<ZoneList<ZoneType*>*>(AsTagged(t)); } - static Zone* Region(Zone* zone, Isolate* isolate) { return zone; } + static Zone* ToRegion(Zone* zone, Isolate* isolate) { return zone; } }; @@ -168,7 +168,7 @@ struct HeapRep { static Object* AsConstant(Handle<Type> t) { return Box::cast(*t)->value(); } static FixedArray* AsUnion(Handle<Type> t) { return FixedArray::cast(*t); } - static Isolate* Region(Zone* zone, Isolate* isolate) { return isolate; } + static Isolate* ToRegion(Zone* zone, Isolate* isolate) { return isolate; } }; @@ -183,7 +183,7 @@ struct Tests : Rep { isolate(CcTest::i_isolate()), scope(isolate), zone(isolate), - T(Rep::Region(&zone, isolate), isolate) { + T(Rep::ToRegion(&zone, isolate), isolate) { } static void CheckEqual(TypeHandle type1, TypeHandle type2) { R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/143693003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-