Commits · 3ba75a2dc3f0f7365b157cfb3b7765f7b661a51d · Linshizhi / V8

15 Nov, 2013 22 commits

MIPS: Generate KeyedLoadDictionaryElementStub with Hydrogen · 3ba75a2d

palfia@homejinni.com authored Nov 15, 2013

Port r17804 (15aa3804)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/74363002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ba75a2d

Fix bogus allocation limit in allocation folding. · ed034b39

mstarzinger@chromium.org authored Nov 15, 2013

R=ishell@chromium.org
TEST=mjsunit/allocation-folding

Review URL: https://codereview.chromium.org/73563004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed034b39

Generate KeyedLoadDictionaryElementStub with Hydrogen · 4ed25382

danno@chromium.org authored Nov 15, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/19492007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ed25382

Add suppressions for regress-319722-ArrayBuffer. · 7832aab7

dslomov@chromium.org authored Nov 15, 2013

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/59093007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7832aab7

MIPS: Reland and fix "Add support for keyed-call on arrays of fast elements”. · e9bfe9bc

plind44@gmail.com authored Nov 15, 2013

Port r17782 (32e3232)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/74013002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9bfe9bc

Limit size of dehoistable array indices · c9b41c69

jkummerow@chromium.org authored Nov 15, 2013

LOG=Y
BUG=chromium:319835,chromium:319860
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/74113002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9b41c69

Limit the size for typed arrays to MaxSmi. · 7936ca39

dslomov@chromium.org authored Nov 15, 2013

R=jkummerow@chromium.org
LOG=Y
BUG=319722

Review URL: https://codereview.chromium.org/73943004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7936ca39

Revert "Limit the size for typed arrays to MaxSmi." · c01aa1fc

dslomov@chromium.org authored Nov 15, 2013

This reverts commit r17798 for allocating too much memroy in tests.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/74093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c01aa1fc

Limit the size for typed arrays to MaxSmi. · 09ca1318

dslomov@chromium.org authored Nov 15, 2013

R=jkummerow@chromium.org
LOG=Y
BUG=319722

Review URL: https://codereview.chromium.org/73943004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09ca1318

Provide Type::Of and Type::CurrentOf operators · edb64827

rossberg@chromium.org authored Nov 15, 2013

R=verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/73193004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

edb64827

Add allocation tracker test for bumb pointer allocations · 88e7d631

yurys@chromium.org authored Nov 15, 2013

Test that allocations which regularly happen inline in the generated code and create objects in bump pointer space will be recorded by the allocation tracker.

BUG=chromium:277984
LOG=N
R=loislo@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/73893005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

88e7d631

Allow passing flags to Runtime_AllocateInTargetSpace. · 7758713a

mstarzinger@chromium.org authored Nov 15, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/73973002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17792 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7758713a

Make some internal Heap helpers private. · 6e66fae4

mstarzinger@chromium.org authored Nov 15, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/66993006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e66fae4

ARM: Merge redundant entries in literal pool. · c54d6552

bmeurer@chromium.org authored Nov 15, 2013

This patch also clean up 64-bits literals handling.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/61763025

Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c54d6552

Regression fix: HForceRepresentation shouldn't be an idef. · 5b9569b5

mvstanton@chromium.org authored Nov 15, 2013

Instead, code sites that are interested in underlying constant integer values
should use HValue::IsInteger32Constant(). The issue is that the infer representation phase shouldn't "see through" HForceRepresentation nodes to an underlying, and less specific representation.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/65643003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5b9569b5

Reland and fix "Add support for keyed-call on arrays of fast elements" · 341d4053

verwaest@chromium.org authored Nov 15, 2013

BUG=
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/71783003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

341d4053

Add ability to do "else-if" clauses in IfBuilder · d62337e1

danno@chromium.org authored Nov 15, 2013

- In an Else block it's possible to add more If<>'s in the same builder that are
  treated as an else if.
- Simplified and cleaned-up some of the IfBuilder's internals.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/66983002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d62337e1

Prepare push to trunk. Now working on version 3.23.6. · a6ba455b

machenbach@chromium.org authored Nov 15, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/63643004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a6ba455b

Replace miss_mode flag with explicit Load/Store Force Generic methods. · c3270daa

verwaest@chromium.org authored Nov 15, 2013

R=ishell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/70233009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c3270daa

Use path relatinve to cctest folder in cctest.status · 14a25f1e

yurys@chromium.org authored Nov 15, 2013

BUG=v8:3005
LOG=N
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/68173023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17773 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14a25f1e

Fix missing type feedback check for Generic*String addition. · 2ee5aa95

bmeurer@chromium.org authored Nov 15, 2013

TEST=mjsunit/regress/regress-crbug-318671
BUG=318671
LOG=y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/67473007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17772 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ee5aa95

Mark cctest/test-alloc/CodeRange as flaky on Windows · 1c24c44e

yurys@chromium.org authored Nov 15, 2013

BUG=v8:3005
LOG=N
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/65833003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c24c44e

14 Nov, 2013 18 commits

Reland [Object.observe] Don't force normalization of elements for observed objects · bdf78a7a

rafaelw@chromium.org authored Nov 14, 2013

Original Issue: https://codereview.chromium.org/29353003/

Note that this version of the patch includes logic for bailing out of compiled ArrayPush/ArrayPop calls if the array is observed (see stub-cache-*)

R=danno@chromium.org
BUG=v8:2946
LOG=N

Review URL: https://codereview.chromium.org/68343016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bdf78a7a

Revert "Improvements in positions handling in optimizing compiler." (r17765) · 25b450b2

rafaelw@chromium.org authored Nov 14, 2013

Original issue: https://codereview.chromium.org/49203002/

TBR=vegorov

Review URL: https://codereview.chromium.org/63343003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25b450b2

MIPS: Also support smi in load-ICs. · f923ff3c

plind44@gmail.com authored Nov 14, 2013

Port r17756 (12e5896)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/72603006

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f923ff3c

Improvements in positions handling in optimizing compiler. · 9d440ac4

vegorov@chromium.org authored Nov 14, 2013

- When building binary arithmetic op and comparison restore source position of the operation itself before building operation itself after it was changed by building operands. This ensures that position recorded for operation points to the operation token instead of pointing to the rightmost operand;

- Add support for recording operands' positions and use these positions when inserting HChange instructions;

- When generating hydrogen.cfg emit H-instruction position as BCI (previously 0 was emitted), additionally on every lithium instruction emit annotation pointing to corresponding hydrogen-instruction. This allows to easily reach from deopt_id to lithium instruction and from it to hydrogen instruction and source position.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/49203002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d440ac4

Fix GCMole warning · 5e8e9cd4

rafaelw@chromium.org authored Nov 14, 2013

R=adamk@chromium.org
TBR=mstarzinger@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/73123002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5e8e9cd4

MIPS: Handle all object types (minus smi) in load/store ICs. · ee575e8f

plind44@gmail.com authored Nov 14, 2013

Port r17755 (bfef904)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/72983002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ee575e8f

MIPS: Remove unused LoadNumber* from macro assembler. · 488a0be3

plind44@gmail.com authored Nov 14, 2013

Port r17748 (595bed6)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/70233011

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

488a0be3

MIPS: Inline zero argument array constructor. · 166799c2

plind44@gmail.com authored Nov 14, 2013

Port r17741 (fe14ef8)

Original commit message:
patch from issue 54583003 (dependent code).

Zero arguments - very easy

1 argument - three special cases:
a) If length is a constant in valid array length range,
no need to check it at runtime.
b) respect DoNotInline feedback on the AllocationSite for
cases that the argument is not a smi or is an integer
with a length that should create a dictionary.
c) if kind feedback is non-holey, and length is non-constant,
we'd have to generate a lot of code to be correct.
Don't inline this case.

N arguments - one special case:
a) If a deopt ever occurs because an input argument isn't
compatible with the elements kind, then set the
DoNotInline flag.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/72893003

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

166799c2

Handlify JSObject::SetElement & brethren · 161cc3cd

rafaelw@chromium.org authored Nov 14, 2013

Because SetElement & co are interdependent, this patch handlfies all of JSObject::
-SetElement
-SetFastElement
-SetDictionaryElement
-SetFastDoubleElement
-SetElementWithInterceptor
-SetElementWithoutInterceptor
-SetElementWithCallbackSetterInPrototype

R=mstarzinger@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/66803002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

161cc3cd

Also support smi in load-ICs. · 6befb8d5

verwaest@chromium.org authored Nov 14, 2013

BUG=
R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/68523009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6befb8d5

Handle all object types (minus smi) in load/store ICs · 93f2ed48

verwaest@chromium.org authored Nov 14, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/62953007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

93f2ed48

Remove obsolete distance switch in SubStringStub::Generate. · 883a5c80

mstarzinger@chromium.org authored Nov 14, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/72073004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17754 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

883a5c80

Do not update survival rate if the new space size is zero. · 31493412

ulan@chromium.org authored Nov 14, 2013

BUG=v8:2333
LOG=N
R=hpayer@chromium.org

Review URL: https://chromiumcodereview.appspot.com/48443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31493412

Add ability to disable inline bump-pointer allocation. · 9f4591c3

mstarzinger@chromium.org authored Nov 14, 2013

R=ulan@chromium.org, yurys@chromium.org
TEST=cctest/test-heap/DisableInlineAllocation

Review URL: https://codereview.chromium.org/69953023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f4591c3

[Sheriff] Revert "Add support for keyed-call on arrays of fast elements" · eef8694a

machenbach@chromium.org authored Nov 14, 2013

This reverts commit r17746 for breaking layout tests.

TBR=verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/72753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eef8694a

Fixed blocking dcommit in push-to-trunk script. · a2c722a7

machenbach@chromium.org authored Nov 14, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/72703002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a2c722a7

Add ChangeLog presubmit check. · 901e4f60

machenbach@chromium.org authored Nov 14, 2013

LOG=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/61733023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

901e4f60

Remove unused LoadNumber* from ARM macro assembler. · fe0987c9

yangguo@chromium.org authored Nov 14, 2013

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/70093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe0987c9