1. 01 Dec, 2020 1 commit
  2. 26 Nov, 2020 1 commit
  3. 11 Aug, 2020 1 commit
  4. 28 Jul, 2020 1 commit
  5. 21 Jul, 2020 1 commit
  6. 20 Jul, 2020 2 commits
  7. 14 Jul, 2020 2 commits
  8. 23 Jun, 2020 1 commit
  9. 20 May, 2020 1 commit
  10. 02 Mar, 2020 1 commit
    • Andreas Haas's avatar
      Reland "[wasm] Refactor AtomicWait implementation" · 7ad6b04e
      Andreas Haas authored
      Stack parameters in the StubCallDescriptor were set to the wrong type. I
      changed it now so that for stack parameters that are specified in the
      CallInterfaceDescriptor, type specified type is used. All other
      parameters are assumed to be tagged, as it has been until now.
      
      Original change's description:
      > [wasm] Refactor AtomicWait implementation
      >
      > The existing implementation included aspects that are not
      > straight-forward to implement in Liftoff and seemed inefficient:
      > * Convert the timeout in WebAssembly code from I64 to F64, just to
      >   convert it back in the runtime.
      >   * On 32-bit platforms this conversion needs an additional C-call.
      > * Split the I64 expected value from I64 into two I32 values in the
      >   wasm-compiler.
      >   * Ideally the int64-lowering takes care of 32-bit specific handling.
      >
      > With this CL the timeout and the expected value are passed as I64 to
      > the runtime (a builtin moves the I64 into a bigint for that). The
      > int64-lowering takes care of 32-bit platforms. There are special
      > builtins for 32-bit platforms, but they are written such that ideally
      > also the int64-lowering could create them.
      
      Bug: v8:10108
      Change-Id: Ib87b543666708457c0d686208a86e46cdca3f9a2
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080362Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66533}
      7ad6b04e
  11. 28 Feb, 2020 2 commits
    • Sathya Gunasekaran's avatar
      Revert "[wasm] Refactor AtomicWait implementation" · 9945e908
      Sathya Gunasekaran authored
      This reverts commit 77d4e230.
      
      Reason for revert: verify csa build bot broken
      https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20verify%20csa/16218?
      
      Original change's description:
      > [wasm] Refactor AtomicWait implementation
      > 
      > The existing implementation included aspects that are not
      > straight-forward to implement in Liftoff and seemed inefficient:
      > * Convert the timeout in WebAssembly code from I64 to F64, just to
      >   convert it back in the runtime.
      >   * On 32-bit platforms this conversion needs an additional C-call.
      > * Split the I64 expected value from I64 into two I32 values in the
      >   wasm-compiler.
      >   * Ideally the int64-lowering takes care of 32-bit specific handling.
      > 
      > With this CL the timeout and the expected value are passed as I64 to
      > the runtime (a builtin moves the I64 into a bigint for that). The
      > int64-lowering takes care of 32-bit platforms. There are special
      > builtins for 32-bit platforms, but they are written such that ideally
      > also the int64-lowering could create them.
      > 
      > R=​jkummerow@chromium.org, binji@chromium.org
      > 
      > Bug: v8:10108
      > Change-Id: I2dbba5839779961b1c5bde4c23fc3f38f1895a52
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071867
      > Commit-Queue: Andreas Haas <ahaas@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Ben Smith <binji@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#66497}
      
      TBR=binji@chromium.org,jkummerow@chromium.org,ahaas@chromium.org,clemensb@chromium.org
      
      Change-Id: If284aa07eedddd2fbea4df8c53c7d371cac1d42e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10108
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080250Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
      Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66498}
      9945e908
    • Andreas Haas's avatar
      [wasm] Refactor AtomicWait implementation · 77d4e230
      Andreas Haas authored
      The existing implementation included aspects that are not
      straight-forward to implement in Liftoff and seemed inefficient:
      * Convert the timeout in WebAssembly code from I64 to F64, just to
        convert it back in the runtime.
        * On 32-bit platforms this conversion needs an additional C-call.
      * Split the I64 expected value from I64 into two I32 values in the
        wasm-compiler.
        * Ideally the int64-lowering takes care of 32-bit specific handling.
      
      With this CL the timeout and the expected value are passed as I64 to
      the runtime (a builtin moves the I64 into a bigint for that). The
      int64-lowering takes care of 32-bit platforms. There are special
      builtins for 32-bit platforms, but they are written such that ideally
      also the int64-lowering could create them.
      
      R=jkummerow@chromium.org, binji@chromium.org
      
      Bug: v8:10108
      Change-Id: I2dbba5839779961b1c5bde4c23fc3f38f1895a52
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071867
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarBen Smith <binji@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66497}
      77d4e230
  12. 05 Aug, 2019 1 commit
  13. 02 Aug, 2019 2 commits
  14. 23 May, 2019 1 commit
  15. 22 May, 2019 1 commit
  16. 26 Dec, 2018 1 commit
  17. 30 Nov, 2018 1 commit
  18. 29 Nov, 2018 1 commit
    • Aseem Garg's avatar
      Revert "[wasm] Add I64AtomicWait implementation" · f4775f1c
      Aseem Garg authored
      This reverts commit 9436e8a8.
      
      Reason for revert: Breaks TSAN.
      
      Original change's description:
      > [wasm] Add I64AtomicWait implementation
      > 
      > Bug=v8:8075
      > R=​adamk@chromium.org,binji@chromium.org
      > 
      > Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd
      > Reviewed-on: https://chromium-review.googlesource.com/c/1342948
      > Reviewed-by: Adam Klein <adamk@chromium.org>
      > Reviewed-by: Ben Smith <binji@chromium.org>
      > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57917}
      
      TBR=binji@chromium.org,adamk@chromium.org,aseemgarg@chromium.org
      
      Change-Id: Ic82ce8794410a0d4d19de07abd9bb8a7aaff1c1c
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/1351303Reviewed-by: 's avatarAseem Garg <aseemgarg@chromium.org>
      Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57919}
      f4775f1c
  19. 28 Nov, 2018 1 commit
  20. 20 Nov, 2018 1 commit
  21. 18 Jul, 2018 1 commit
  22. 19 Jun, 2018 1 commit
  23. 05 Jun, 2018 1 commit
  24. 29 May, 2018 1 commit
  25. 01 Feb, 2017 1 commit
  26. 27 Jan, 2017 1 commit
  27. 13 Jul, 2016 1 commit
  28. 30 Sep, 2015 1 commit
  29. 21 Aug, 2015 1 commit
    • binji's avatar
      Signal a blocked futex if the isolate is interrupted; don't busy-wait · b7cf7327
      binji authored
      FutexEmulation::Wait can potentially block forever on a condition variable. We
      want to allow this to be interrupted (for a debugger, or to terminate the
      thread, for example).
      
      The previous implementation would periodically wake up the waiter to check for
      interrupts. This CL modifies the StackGuard so it wakes the blocked futex if
      the thread should be interrupted.
      
      BUG=chromium:497295
      R=jarin@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1230303005
      
      Cr-Commit-Position: refs/heads/master@{#30311}
      b7cf7327
  30. 11 Aug, 2015 1 commit
  31. 17 Jul, 2015 1 commit