- 20 May, 2020 1 commit
-
-
Marja Hölttä authored
There's no need for it to be a JSArray. In the spec it's a List which roughly corresponds to FixedArray (but not JSArray). Gotchas: - There's no good point in time where we know the array length, since resolving might be interleaved with iteration. - Using ExtractFixedArray in places where we don't need to extract, since it takes care of things like allocating the resulting array in the right space etc. Drive-by fix: Previously we pre-allocated an array 1 elements too big, but never noticed it since the last element was the hole. Bug: v8:10506 Change-Id: I6a72fbf1fc0cc031f2c8bad9314c4ed21d544a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202905Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#67919}
-
- 19 May, 2020 1 commit
-
-
Marja Hölttä authored
In this case, we'll already have values in "errors" in PerformPromiseAny step 8.d. Bug: v8:9808 Change-Id: I5bb0cba41887f4bbdab3bb15e8f52dd94acec9c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204277 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67884}
-
- 30 Apr, 2020 1 commit
-
-
Marja Hölttä authored
CL adopted from joshualitt@: https://chromium-review.googlesource.com/c/v8/v8/+/2002932 Link to explainer is here: https://github.com/tc39/proposal-promise-anyCo-authored-by: Joshua Litt <joshualitt@chromium.org> Bug: v8:9808 Change-Id: I6872020e857d4b131d5663f95fd58e6271ccb067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124834 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67502}
-
- 23 May, 2019 1 commit
-
-
Yang Guo authored
TBR=bmeurer@chromium.org,leszeks@chromium.org Bug: v8:9247 Change-Id: I8d14d0192ea8c705f8274e8e61a162531826edb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624220Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61769}
-
- 13 Dec, 2018 1 commit
-
-
Alexander Timokhin authored
This is a reland of 2e36e9ea Was reverted because of v8_presubmit.py issue in https://chromium-review.googlesource.com/c/v8/v8/+/1374292 Original change's description: > Don't use |v8_initializers| code in |v8_base| > > Removing |CodeStubAssembler| from |v8_base| source list (see > https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to > linkage problems with some build configurations because it was explicitly > and implicitly included in |v8_base| code. > > This CL decouple this code and fixes problems. > > Bug: v8:7777 > Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 > Reviewed-on: https://chromium-review.googlesource.com/c/1372067 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58200} Bug: v8:7777 Change-Id: Iaa00e73c7dbd8c413fbf15a17709aa12eda9a706 Reviewed-on: https://chromium-review.googlesource.com/c/1375654Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58209}
-
- 12 Dec, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 2e36e9ea. Reason for revert: Missing explicit include in cc file: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Presubmit/986 Original change's description: > Don't use |v8_initializers| code in |v8_base| > > Removing |CodeStubAssembler| from |v8_base| source list (see > https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to > linkage problems with some build configurations because it was explicitly > and implicitly included in |v8_base| code. > > This CL decouple this code and fixes problems. > > Bug: v8:7777 > Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 > Reviewed-on: https://chromium-review.googlesource.com/c/1372067 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58200} TBR=jkummerow@chromium.org,jgruber@chromium.org,bmeurer@chromium.org,atimoxin@yandex-team.ru Change-Id: I3e41fb5f8a9db6a78c56546a08e55610885d312b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1374292Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58201}
-
Alexander Timokhin authored
Removing |CodeStubAssembler| from |v8_base| source list (see https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to linkage problems with some build configurations because it was explicitly and implicitly included in |v8_base| code. This CL decouple this code and fixes problems. Bug: v8:7777 Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 Reviewed-on: https://chromium-review.googlesource.com/c/1372067Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58200}
-
- 21 Mar, 2017 1 commit
-
-
jkummerow authored
BUG=v8:6055 Review-Url: https://codereview.chromium.org/2760953002 Cr-Commit-Position: refs/heads/master@{#43975}
-
- 16 Mar, 2017 1 commit
-
-
jkummerow authored
This is in preparation for linking the former only into mksnapshot. Just shuffling code around, no changes in functionality. BUG=v8:6055 Review-Url: https://codereview.chromium.org/2752143004 Cr-Commit-Position: refs/heads/master@{#43858}
-
- 17 Feb, 2017 1 commit
-
-
gsathya authored
Adds five new TF builtins for the spec defined functions/closures. This follows mechanism similar to promise resolving functions approach where we store the closure variables in a custom context. Adds a new --harmony-promise-finally flag. BUG=v8:5967 Review-Url: https://codereview.chromium.org/2695753002 Cr-Commit-Position: refs/heads/master@{#43294}
-
- 20 Jan, 2017 1 commit
-
-
jgruber authored
This moves AsyncFunctionAwait{Caught,Uncaught} to CSA, and removes async-await.js. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2643023002 Cr-Commit-Position: refs/heads/master@{#42579}
-
- 18 Jan, 2017 1 commit
-
-
caitp authored
First step in splitting apart https://codereview.chromium.org/2622833002/ to land piece by piece. Porting src/js/async-await.js to TF builtins using this boilerplate is now very straightforward. BUG=v8:4483, v8:5855 R=jgruber@chromium.org, gsathya@chromium.org Review-Url: https://codereview.chromium.org/2635353002 Cr-Commit-Position: refs/heads/master@{#42466}
-
- 17 Jan, 2017 2 commits
-
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2637523002 Cr-Commit-Position: refs/heads/master@{#42423}
-
gsathya authored
Also moves some functions to prologue.js BUG=v8:5343 Review-Url: https://codereview.chromium.org/2630593004 Cr-Commit-Position: refs/heads/master@{#42417}
-
- 12 Jan, 2017 1 commit
-
-
jochen authored
Since we only can do limited checks during microtask execution, do the checks before actually creating a promise BUG=chromium:658194 R=bmeurer@chromium.org,gsathya@chromium.org Review-Url: https://codereview.chromium.org/2628863002 Cr-Commit-Position: refs/heads/master@{#42265}
-
- 06 Jan, 2017 1 commit
-
-
gsathya authored
Also moves most of the runtime function into TF. There are lots of runtime calls but they happen only for the debug case so it's fine. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2611083002 Cr-Commit-Position: refs/heads/master@{#42109}
-
- 04 Jan, 2017 3 commits
-
-
gsathya authored
Add a more low level BranchIfFastPath to take the native_context and promise_fun as args and change the existing one to use this. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2592933004 Cr-Commit-Position: refs/heads/master@{#42075}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2614603003 Cr-Commit-Position: refs/heads/master@{#42073}
-
gsathya authored
This removes all the promise allocation related methods from the CSA and moves them PromiseBuiltinsAssembler with some edits. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2604273003 Cr-Commit-Position: refs/heads/master@{#42070}
-
- 02 Jan, 2017 1 commit
-
-
caitp authored
- Adds CodeAssembler::ConstructJS() to simplify calling JS functions as constructors, used by NewPromiseCapability() - Defines PromiseCapability as a special JSObject subclass, with a non-exensible Map, and read-only non-configurable DataDescriptors which point to its in-object fields. This allows its fields to be used by JS builtins until there is no longer any need. Currently, the performance benefit comes from https://codereview.chromium.org/2567033003/, but does not appear to regress performance in any significant way. BUG=v8:5343 TBR=ulan@chromium.org Review-Url: https://codereview.chromium.org/2567333002 Cr-Commit-Position: refs/heads/master@{#42014}
-
- 29 Dec, 2016 1 commit
-
-
gsathya authored
This patch stores the promise, resolve, reject properties of the deferred object created by CreateInternalPromiseCapability and NewPromiseCapability directly on the promise (if the promise hasn't been fulfilled), otherwise they are stored on the PromiseReactionJobInfo. This patch removes the currently unused CreateInternalPromiseCapability and inlines the call to create the deferred promise object. NewPromiseCapability is the only function that works with a deferred. This patch results in a 8.5% improvement in benchmarks over 5 runs. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2590563003 Cr-Commit-Position: refs/heads/master@{#41991}
-
- 21 Dec, 2016 1 commit
-
-
gsathya authored
This patch also refactors most of PromiseThen into InternalPromiseThen to be reused with PromiseCatch and also changes InternalResolvePromise to return and not branch. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2596553002 Cr-Commit-Position: refs/heads/master@{#41902}
-
- 19 Dec, 2016 2 commits
-
-
gsathya authored
2% improvement on benchmarks over 5 runs. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2567033003 Cr-Commit-Position: refs/heads/master@{#41827}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2585133002 Cr-Commit-Position: refs/heads/master@{#41816}
-