- 16 Jun, 2015 1 commit
-
-
jochen authored
This is the first step towards unifying external and on-heap typed arrays. The end-state will be that this base pointer either points to the on-heap values or to the externally allocated array buffer. BUG=v8:3996 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1176263004 Cr-Commit-Position: refs/heads/master@{#29039}
-
- 08 Jun, 2015 1 commit
-
-
jochen authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1135353003 Cr-Commit-Position: refs/heads/master@{#28834}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 16 Apr, 2015 1 commit
-
-
erikcorry authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1086263002 Cr-Commit-Position: refs/heads/master@{#27876}
-
- 10 Apr, 2015 1 commit
-
-
verwaest authored
This fixes the arm(64) and mips(64) write barriers BUG= Review URL: https://codereview.chromium.org/1073133002 Cr-Commit-Position: refs/heads/master@{#27751}
-
- 09 Apr, 2015 3 commits
-
-
adamk authored
Revert of Merge cellspace into old pointer space (patchset #8 id:180001 of https://codereview.chromium.org/1010803012/) Reason for revert: Causes test failures on ARM bots related to cells and write barriers. Original issue's description: > Merge cellspace into old pointer space > > BUG= > > Committed: https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 > Cr-Commit-Position: refs/heads/master@{#27707} TBR=hpayer@chromium.org,balazs.kilvady@imgtec.com,yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1053243003 Cr-Commit-Position: refs/heads/master@{#27711}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1010803012 Cr-Commit-Position: refs/heads/master@{#27707}
-
hpayer authored
MarkBit cleanup: They have to be accessed through Marking accessors. Avoid arbitrary abuse of mark bits and make marking explicit. Added DCHECKs to mark bit transitions to check source state. BUG= Review URL: https://codereview.chromium.org/1040443002 Cr-Commit-Position: refs/heads/master@{#27689}
-
- 07 Apr, 2015 1 commit
-
-
hpayer authored
This reverts commit cbfcee55. BUG= Review URL: https://codereview.chromium.org/1051233002 Cr-Commit-Position: refs/heads/master@{#27623}
-
- 30 Mar, 2015 1 commit
-
-
erikcorry authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1040763002 Cr-Commit-Position: refs/heads/master@{#27520}
-
- 28 Mar, 2015 1 commit
-
-
jkummerow authored
And reland "Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer." This reverts commits de018fbd and d23a9f7a. Reason for relanding: looking fine on Canary, let's get these fixes back in. BUG=chromium:454297,chromium:470801 LOG=y TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/1043703003 Cr-Commit-Position: refs/heads/master@{#27507}
-
- 27 Mar, 2015 1 commit
-
-
ishell authored
Revert of Reland "Filter invalid slots out from the SlotsBuffer after marking." (patchset #2 id:2 of https://codereview.chromium.org/1032833002/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Reland "Filter invalid slots out from the SlotsBuffer after marking." > > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > > This CL also adds useful machinery that helps triggering incremental write barriers. > > > BUG=chromium:454297 > > LOG=Y > > NOTRY=true > > Committed: https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b > Cr-Commit-Position: refs/heads/master@{#27433} TBR=machenbach@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1041593002 Cr-Commit-Position: refs/heads/master@{#27491}
-
- 25 Mar, 2015 1 commit
-
-
ulan authored
> There are two reasons that could cause invalid slots appearance in SlotsBuffer: > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > BUG=chromium:454297 > LOG=Y NOTRY=true Review URL: https://codereview.chromium.org/1032833002 Cr-Commit-Position: refs/heads/master@{#27433}
-
- 24 Mar, 2015 4 commits
-
-
machenbach authored
Revert of Track how many pages trigger fallback strategies in GC (patchset #2 id:20001 of https://codereview.chromium.org/1029323003/) Reason for revert: This seems to cause lots of crashes in layout tests debug: ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp(67) : void blink::useCounterCallback(v8::Isolate *, v8::Isolate::UseCounte http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2332 Original issue's description: > Track how many pages trigger fallback strategies in GC > > R=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb > Cr-Commit-Position: refs/heads/master@{#27421} TBR=hpayer@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1000523003 Cr-Commit-Position: refs/heads/master@{#27427}
-
machenbach authored
Revert of Filter invalid slots out from the SlotsBuffer after marking. (patchset #6 id:220001 of https://codereview.chromium.org/1010363005/) Reason for revert: Need to revert in order to revert https://codereview.chromium.org/1029323003/ Original issue's description: > Filter invalid slots out from the SlotsBuffer after marking. > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/5c47c1c0d3e4a488f190c16a64ee02f5a14e6561 > Cr-Commit-Position: refs/heads/master@{#27423} TBR=hpayer@chromium.org,erik.corry@gmail.com,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Review URL: https://codereview.chromium.org/1033453005 Cr-Commit-Position: refs/heads/master@{#27426}
-
ishell authored
There are two reasons that could cause invalid slots appearance in SlotsBuffer: 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297 LOG=Y Review URL: https://codereview.chromium.org/1010363005 Cr-Commit-Position: refs/heads/master@{#27423}
-
erikcorry authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1029323003 Cr-Commit-Position: refs/heads/master@{#27421}
-
- 19 Mar, 2015 1 commit
-
-
hpayer authored
TBR=verwaest@chromium.org,ulan@chromium.org,ishell@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1027463002 Cr-Commit-Position: refs/heads/master@{#27323}
-
- 18 Mar, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1012023002 Cr-Commit-Position: refs/heads/master@{#27259}
-
- 16 Mar, 2015 3 commits
-
-
hpayer authored
Store buffer does not contain stale pointers anymore. Hence, sweeper threads and store buffer processing does not collide. BUG= Review URL: https://codereview.chromium.org/1007273002 Cr-Commit-Position: refs/heads/master@{#27217}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1009323002 Cr-Commit-Position: refs/heads/master@{#27214}
-
ishell authored
Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Review URL: https://codereview.chromium.org/1004623003 Cr-Commit-Position: refs/heads/master@{#27207}
-
- 11 Mar, 2015 1 commit
-
-
ishell authored
The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297, chromium:465273 LOG=Y Review URL: https://codereview.chromium.org/988363002 Cr-Commit-Position: refs/heads/master@{#27141}
-
- 10 Mar, 2015 3 commits
-
-
hpayer authored
There are no stale store buffer pointers anymore. The sweeper thread can not be in conflict with store buffer processing. BUG= Review URL: https://codereview.chromium.org/993983002 Cr-Commit-Position: refs/heads/master@{#27107}
-
hpayer authored
We can do that now since we have the invariant that the store buffer always has valid slots after marking. BUG= Review URL: https://codereview.chromium.org/991853002 Cr-Commit-Position: refs/heads/master@{#27105}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/994893002 Cr-Commit-Position: refs/heads/master@{#27092}
-
- 09 Mar, 2015 2 commits
-
-
hpayer authored
The store buffer can contain stale store buffer entries, i.e., slot in dead objects pointing to new space objects. These slots are treaded as live slots which cause problems with non-pointer fields and makes concurrent sweeping complicated. Removing these pointers from the store buffer before it is used makes life easier. BUG= Review URL: https://codereview.chromium.org/985453003 Cr-Commit-Position: refs/heads/master@{#27068}
-
ishell@chromium.org authored
Revert of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #4 id:230001 of https://codereview.chromium.org/957273002/) Reason for revert: It caused a lot of Canary crashes. Original issue's description: > Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/9633ebabd405c264d33f603f8798c31f59418dcd > Cr-Commit-Position: refs/heads/master@{#27054} TBR=verwaest@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Review URL: https://codereview.chromium.org/991793002 Cr-Commit-Position: refs/heads/master@{#27063}
-
- 06 Mar, 2015 1 commit
-
-
ishell authored
The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297 LOG=Y Review URL: https://codereview.chromium.org/957273002 Cr-Commit-Position: refs/heads/master@{#27054}
-
- 25 Feb, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/946973008 Cr-Commit-Position: refs/heads/master@{#26844}
-
- 05 Feb, 2015 1 commit
-
-
mstarzinger authored
R=hpayer@chromium.org BUG=chromium:454615 LOG=N Review URL: https://codereview.chromium.org/900793004 Cr-Commit-Position: refs/heads/master@{#26452}
-
- 08 Jan, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/804603006 Cr-Commit-Position: refs/heads/master@{#26002}
-
- 15 Dec, 2014 1 commit
-
-
ishell authored
LayoutDescriptorHelper is now able to calculate the length of contiguous regions of tagged/non-tagged fields. This functionality is now used by both object visitor and store buffer. TEST=cctest/test-unboxed-doubles Review URL: https://codereview.chromium.org/726713003 Cr-Commit-Position: refs/heads/master@{#25816}
-
- 10 Dec, 2014 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/787383002 Cr-Commit-Position: refs/heads/master@{#25745}
-
- 24 Nov, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/751643005 Cr-Commit-Position: refs/heads/master@{#25483}
-
- 22 Nov, 2014 2 commits
-
-
ishell authored
Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id:40001 of https://codereview.chromium.org/753503002/) Reason for revert: GCMole and gc-stress issues. Original issue's description: > Enable inobject double fields unboxing for 64-bit archs. TBR=verwaest@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/751863002 Cr-Commit-Position: refs/heads/master@{#25470}
-
ishell authored
Review URL: https://codereview.chromium.org/753503002 Cr-Commit-Position: refs/heads/master@{#25469}
-
- 11 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/711313002 Cr-Commit-Position: refs/heads/master@{#25258} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Nov, 2014 2 commits
-
-
verwaest@chromium.org authored
Revert "Fixes for Windows and Mac builds after r25250." TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/699613004 Cr-Commit-Position: refs/heads/master@{#25252} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
This CL introduces LayoutDescriptor which is responsible for tracking which in-object fields are tagged and which are not. LayoutDescriptor field added to Map. Currently unboxing is disabled. R=hpayer@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/391693002 Cr-Commit-Position: refs/heads/master@{#25250} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-