1. 07 Jan, 2020 1 commit
  2. 12 Sep, 2019 1 commit
  3. 05 Sep, 2019 1 commit
    • Sigurd Schneider's avatar
      [debugger] Fix code coverage for async functions · 3b0f89d0
      Sigurd Schneider authored
      Async functions were not correctly fixed up for code coverage, which
      caused an additional uncovered range to be reported between a return
      statement and the closing bracket.
      
      This CL adds code that detects such ranges, and removes them, similarly
      to how the ranges are removed for normal functions. The removal process
      is different, because the parser rewrites async functions to contain a
      try-catch handling promise rejection.
      
      Change-Id: I73b08d64be74d26c32f2f9652d027430d4671251
      
      Bug: chromium:981313, v8:8381
      Change-Id: I82a7f0c54d3a48609ef5255a7659d9557e163566
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782837Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63561}
      3b0f89d0
  4. 21 Dec, 2018 1 commit
    • Jakob Gruber's avatar
      [coverage] Rework continuation counter handling · 9365d090
      Jakob Gruber authored
      This changes a few bits about how continuation counters are handled.
      
      It introduces a new mechanism that allows removal of a continuation
      range after it has been created. If coverage is enabled, we run a first
      post-processing pass on the AST immediately after parsing, which
      removes problematic continuation ranges in two situations:
      
      1. nested continuation counters - only the outermost stays alive.
      2. trailing continuation counters within a block-like structure are
         removed if the containing structure itself has a continuation.
      
      R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org
      
      Bug: v8:8381, v8:8539
      Change-Id: I6bcaea5060d8c481d7bae099f6db9f993cc30ee3
      Reviewed-on: https://chromium-review.googlesource.com/c/1339119Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58443}
      9365d090