- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 07 Sep, 2018 1 commit
-
-
Dan Elphick authored
Move everything defined in the v8::internal namespace from include/v8.h into a separate header that can be included by globals.h/checks.h instead of the whole v8.h. Also moves V8_EXPORT into v8config.h (so it can be use in the new v8-internal.h). Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I22cdc2728d91a94b309a3d030ed06c0f8a06c723 Reviewed-on: https://chromium-review.googlesource.com/1210102Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55707}
-
- 14 Apr, 2018 1 commit
-
-
Jakob Kummerow authored
The "Address" type is V8's general-purpose type for manipulating memory addresses. Per the C++ spec, pointer arithmetic and pointer comparisons are undefined behavior except within the same array; since we generally don't operate within a C++ array, our general-purpose type shouldn't be a pointer type. Bug: v8:3770 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779 Reviewed-on: https://chromium-review.googlesource.com/988657 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52601}
-
- 27 Sep, 2016 1 commit
-
-
machenbach authored
BUG=chromium:648864 Review-Url: https://codereview.chromium.org/2373743002 Cr-Commit-Position: refs/heads/master@{#39754}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 21 Apr, 2015 1 commit
-
-
dcarney authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/679143002 Cr-Commit-Position: refs/heads/master@{#27951}
-
- 30 Jan, 2015 3 commits
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/877753007 Cr-Commit-Position: refs/heads/master@{#26346}
-
Benedikt Meurer authored
This reverts commit 6a4c0a3b and commit 0deaa4b6 for breaking GCC bots. TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/893533003 Cr-Commit-Position: refs/heads/master@{#26342}
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/888613002 Cr-Commit-Position: refs/heads/master@{#26340}
-
- 08 Dec, 2014 1 commit
-
-
jochen authored
When compiling with the macro DCHECK_ALWAYS_ON defined, DCHECKs and supporting code gets compiled and enabled. This increases test coverage for chromium release buildbots BUG=v8:3731 R=jkummerow@chromium.org LOG=y Review URL: https://codereview.chromium.org/760213005 Cr-Commit-Position: refs/heads/master@{#25701}
-
- 06 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/444803003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2014 1 commit
-
-
danno@chromium.org authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/426233002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 3 commits
-
-
jochen@chromium.org authored
BUG=none R=mvstanton@chromium.org TBR=mvstanton@chromium.org LOG=n Review URL: https://codereview.chromium.org/314703002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
Jacob.Bramley@arm.com authored
BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/308023007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21620 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 May, 2014 1 commit
-
-
jochen@chromium.org authored
With this, change, atomicops, once, and lazy instance are no longer dependant on v8 core. I'll move them in a follow-up change to the libbase as well. BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/303463005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21546 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
jochen@chromium.org authored
It's just an alias, and STATIC_ASSERT is used way more often BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/304553002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21527 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Mar, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=354405 R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=y Review URL: https://codereview.chromium.org/207823003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Mar, 2014 1 commit
-
-
marja@chromium.org authored
After this change, you can just call DumpBacktrace in any function. Previously the only function printing stack traces was V8_Fatal, but that also terminated the program, so not very useful for debugging. Note that DumpBacktrace is roughly equivalent to base::debug::StackTrace functionality in Chromium, except less fancy, but it's enough for us. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/200343003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19993 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Feb, 2014 2 commits
-
-
rmcilroy@chromium.org authored
- Remove arch specific check macros - Remove duplicate code in code-stubs.h - Remove flag check in bootstrap.cc which was introduced for A64 bringup - Remove A64 specific test message expectations R=rodolph.perfetta@arm.com, ulan@chromium.org Review URL: https://codereview.chromium.org/134333011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19325 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
BUG=v8:3113 LOG=Y R=jochen@chromium.org, rmcilroy@chromium.org, rodolph.perfetta@arm.com Review URL: https://codereview.chromium.org/148293020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Nov, 2013 1 commit
-
-
jkummerow@chromium.org authored
BUG=v8:2767,v8:2149 R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/69413002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Oct, 2013 1 commit
-
-
danno@chromium.org authored
Thereby ensuring there is only a minimal performance regression vs. NDEBUG (now it's only about 10% slower rather than ~2x). R=jkummerow@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/39183004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2013 1 commit
-
-
titzer@chromium.org authored
BUG= R=rossberg@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/23609020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Aug, 2013 1 commit
-
-
bmeurer@chromium.org authored
From now on the v8config.h header should be the one and only file where we do (freaky) checks to detect OS, C++ compiler or certain compiler features. Since we need that both internally and for the public API, the new v8config.h is the proper place to add (everything is prefixed with V8_ so we are safe). R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/23248006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16281 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Aug, 2013 1 commit
-
-
bmeurer@chromium.org authored
Also improve detection of V8_INFINITY while we're at it. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/23323003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16254 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Jul, 2013 1 commit
-
-
bmeurer@chromium.org authored
Revert "Fix NaCl build." Revert "Revert target arch detection." Revert "Fix typo." Revert "Simplify implementation of Mutex." Revert "Fix for older clang releases that lack __has_extension." Revert "Reland initial bits of "Implement correct OS and CC detection."" TBR=danno@chromium.org,svenpanne@chromium.org Review URL: https://codereview.chromium.org/21095008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2013 1 commit
-
-
bmeurer@chromium.org authored
This adds the OS and CC detection and cleans up the globals.h to some degree. It also places all of the C++11 feature detection into globals.h. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21223003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15953 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jul, 2013 2 commits
-
-
bmeurer@chromium.org authored
This fixes build breakage introduced with r15736. TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/19671009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/19684009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Sep, 2012 1 commit
-
-
jkummerow@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10917088 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jan, 2012 1 commit
-
-
svenpanne@chromium.org authored
CheckHelper was only used within the macro itself. Furthermore, GCC with -Winline was not always happy with the inline function. Simple solution: Inline the inline function into the macro itself. Inlining squared! Review URL: https://chromiumcodereview.appspot.com/9295048 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10550 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jan, 2012 1 commit
-
-
kmillikin@chromium.org authored
Namely they are SLOW_ASSERT, RETURN_IF_SCHEDULED_EXCEPTION, and RETURN_IF_EMTPY_HANDLE_VALUE. R=svenpanne@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8983016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10329 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Nov, 2011 1 commit
-
-
kmillikin@chromium.org authored
This shaves 416+ KB, just under 1% off the size of the debug d8 executable on Linux (mostly because the CheckHelper functions for assertions were getting separate copies for each compilation unit). The difference in release builds is negligible---a size reduction of 0.1%. Also, change namespace-level 'static const' variables to remove the static storage class as it's the default. R=danno@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8680013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Oct, 2011 2 commits
-
-
vegorov@chromium.org authored
TBR=erik.corry@gmail.com Review URL: http://codereview.chromium.org/8383031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vegorov@chromium.org authored
Makes debug build 20% faster. R=erik.corry@gmail.com Review URL: http://codereview.chromium.org/8256011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Oct, 2011 1 commit
-
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/8267004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-