- 18 Jul, 2019 1 commit
-
-
Ulan Degenbaev authored
When the main thread contributes to an item parallel job and runs an item parallel task, it currently emits a background GC trace event. That is confusing and may lead to incorrect accounting of main thread GC time. This patch fixes it by introducing a 'Runner' parameter to ItemParalllelJob::Task::RunInParallel and emitting a foreground GC event if the runner is the main thread. Bug: v8:9508 Change-Id: I755751bfe9eef427666d5f16fb50aa6093059e80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706485Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62798}
-
- 22 May, 2019 1 commit
-
-
Yang Guo authored
Bug: v8:9247 Change-Id: I79e0553e8a0d6dac2aa16b94a6c0e05b6ccde4a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621934 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61725}
-
- 19 Feb, 2019 1 commit
-
-
Michael Lippautz authored
The histogram is not used anymore. Remove to safe resources. Bug: chromium:926072 Change-Id: I929f34f7ab0613431eaf9740f3342b6b2cec6cbd Reviewed-on: https://chromium-review.googlesource.com/c/1477672Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59684}
-
- 17 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibdb4b81e1ba764d73bac6592eeef5783097076fc Reviewed-on: https://chromium-review.googlesource.com/1225896Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55965}
-
- 13 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibe5906fa96f2d7327bce1eff70637a2d00f99668 Reviewed-on: https://chromium-review.googlesource.com/1224030Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55865}
-
- 06 Feb, 2018 1 commit
-
-
Gabriel Charette authored
It will record the time-to-schedule-after-job-start for different task types to try to highlight use cases where contention might be a problem (and show improvements to it later). Also introducing AsyncTimedHistogram to support this use case whose reported timings go beyond a single scope (i.e. the async version of ScopedTimedHistogram). Bug: chromium:807606 Change-Id: Ib4d581fa8b001723dfe8c91102280e9608b4fabb Reviewed-on: https://chromium-review.googlesource.com/899365Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#51131}
-
- 01 Feb, 2018 1 commit
-
-
Gabriel Charette authored
Otherwise bots with a low number of cores will hang trying to schedule a mere 4 tasks. This change allowing scheduling of an arbitrary number of test tasks, the count was also augmented to better stress test the system. Bug: chromium:805932 Change-Id: Ia10cd583c0675c256b4fd5d2765b50855d77a7f9 Reviewed-on: https://chromium-review.googlesource.com/895584 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51019}
-
- 30 Jan, 2018 3 commits
-
-
Gabriel Charette authored
This is a reland of 76195d9e. It was reverted because the new parallel tasks (with higher number of workers) hang on client.v8.ports bots. Since each test task steals the worker thread it's assigned but only processes one item before waiting for completion by others: I think the problem is that there aren't enough workers in client.v8.ports' config. There aren't any try bots for this config... reduce the tests to use 4 tasks and hope for the best (i.e. a 4 core machine that uses "num cores")... Original change's description: > Smoother distribution of worker assignment in parallel task array. > > This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 > and https://chromium-review.googlesource.com/c/v8/v8/+/887084 > > Which implements the fix in CL 887084 correctly in a world where > there can be more tasks_ than items_ (crbug.com/806237). > > Bug: chromium:805932 > Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 > Reviewed-on: https://chromium-review.googlesource.com/892883 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50956} Reverted-on: https://chromium-review.googlesource.com/893462 Bug: chromium:805932 Change-Id: I4d0bda3b9f52e9160e613a8f34a95e48b814bb9e Reviewed-on: https://chromium-review.googlesource.com/893362Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#50967}
-
Gabriel Charette authored
This reverts commit 76195d9e. Reason for revert: New parallel tests timeout on the waterfall (I think because it's configured to use less worker threads and TaskProcessingOneItem is currently designed to steal a worker but only process one item...). Original change's description: > Smoother distribution of worker assignment in parallel task array. > > This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 > and https://chromium-review.googlesource.com/c/v8/v8/+/887084 > > Which implements the fix in CL 887084 correctly in a world where > there can be more tasks_ than items_ (crbug.com/806237). > > Bug: chromium:805932 > Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 > Reviewed-on: https://chromium-review.googlesource.com/892883 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50956} TBR=gab@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: Icf52eb3afeb9467557c1e0db6922d590466943f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:805932 Reviewed-on: https://chromium-review.googlesource.com/893462Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#50965}
-
Gabriel Charette authored
This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 and https://chromium-review.googlesource.com/c/v8/v8/+/887084 Which implements the fix in CL 887084 correctly in a world where there can be more tasks_ than items_ (crbug.com/806237). Bug: chromium:805932 Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 Reviewed-on: https://chromium-review.googlesource.com/892883 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50956}
-
- 29 Jan, 2018 2 commits
-
-
Gabriel Charette authored
This reverts commit 8a27c7d3. Reason for revert: Having more tasks then work items is intentional in some use cases, i.e. Scavenging where RunInParallel() does parallel processing on a dynamic workload *after* the initial set of work items: { barrier_->Start(); TimedScope scope(&scavenging_time); PageScavengingItem* item = nullptr; while ((item = GetItem<PageScavengingItem>()) != nullptr) { item->Process(scavenger_); item->MarkFinished(); } do { scavenger_->Process(barrier_); } while (!barrier_->Wait()); scavenger_->Process(); } Original change's description: > v8::ItemParallelJob : Do not launch more Tasks than there are Items to process. > > Except when there are 0 items. For some reason I don't quite understand yet, not > calling Run() on tasks_[0] when there are 0 items results in DCHECKs... > > Bug: chromium:806237 > Change-Id: I38c8fffde64a42f93f4efda492832651137eebd7 > Reviewed-on: https://chromium-review.googlesource.com/888704 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50924} TBR=gab@chromium.org,mlippautz@chromium.org Change-Id: Iad2ab16bb41f339de8e3fbca1c08c5d26b8a0111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:806237 Reviewed-on: https://chromium-review.googlesource.com/891186Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#50928}
-
Gabriel Charette authored
Except when there are 0 items. For some reason I don't quite understand yet, not calling Run() on tasks_[0] when there are 0 items results in DCHECKs... Bug: chromium:806237 Change-Id: I38c8fffde64a42f93f4efda492832651137eebd7 Reviewed-on: https://chromium-review.googlesource.com/888704 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50924}
-
- 17 May, 2017 1 commit
-
-
Michael Lippautz authored
TBR=ulan@chromium.org Bug: chromium:651354 Change-Id: Ib3a53a62e048e438bc31cbfd2ea44d17fd6a3b94 Reviewed-on: https://chromium-review.googlesource.com/506204Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45360}
-
- 16 May, 2017 1 commit
-
-
Michael Lippautz authored
Adds a generic job that is based on items and tasks. Bug: chromium:651354 Change-Id: I378e04741c5761ea6c4a74816b9af8ea22867f53 Reviewed-on: https://chromium-review.googlesource.com/506075 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45353}
-