- 22 Apr, 2016 1 commit
-
-
adamk authored
The feature was deprecated in M49 and flagged off in M50. This patch removes it entirely from the codebase. Review URL: https://codereview.chromium.org/1909433003 Cr-Commit-Position: refs/heads/master@{#35714}
-
- 10 Mar, 2016 1 commit
-
-
rossberg authored
R=mstarzinger@chromium.org,bmeurer@chromium.org,adamk@chromium.org BUG=v8:3956 LOG=Y Review URL: https://codereview.chromium.org/1773653002 Cr-Commit-Position: refs/heads/master@{#34669}
-
- 18 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1704353002 Cr-Commit-Position: refs/heads/master@{#34118}
-
- 11 Dec, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1513313003 Cr-Commit-Position: refs/heads/master@{#32790}
-
- 10 Dec, 2015 1 commit
-
-
ishell authored
Function subclasses did not have function properties installed (name, prototype, etc.). Now when an instance of a Function subclass is created it gets initial map that corresponds to the language mode of the function body. The language mode dependent maps are cached as special transitions on initial map of the subclass constructor. BUG=v8:4597, v8:3101, v8:3330 LOG=Y Review URL: https://codereview.chromium.org/1510753005 Cr-Commit-Position: refs/heads/master@{#32764}
-
- 03 Dec, 2015 1 commit
-
-
hpayer authored
Reland of Introduce instance type for transition arrays. (patchset #1 id:1 of https://codereview.chromium.org/1483003002/ ) Reason for revert: Suspect for crashing found, relanding for canary coverage. Original issue's description: > Revert of Introduce instance type for transition arrays. (patchset #6 id:100001 of https://codereview.chromium.org/1480873003/ ) > > Reason for revert: > Broken canary. Trying to find out root cause. > > Original issue's description: > > Introduce instance type for transition arrays. > > > > The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. > > > > BUG=chromium:554488 > > LOG=NO > > > > Committed: https://crrev.com/026095a3c7932573e1810b8064ec3008ed696601 > > Cr-Commit-Position: refs/heads/master@{#32396} > > TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:554488 > > Committed: https://crrev.com/38bf70b9cd2a07b99ac0c0b7eda111849e79c146 > Cr-Commit-Position: refs/heads/master@{#32404} TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:554488 Review URL: https://codereview.chromium.org/1500623002 Cr-Commit-Position: refs/heads/master@{#32561}
-
- 30 Nov, 2015 2 commits
-
-
hpayer authored
Revert of Introduce instance type for transition arrays. (patchset #6 id:100001 of https://codereview.chromium.org/1480873003/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Introduce instance type for transition arrays. > > The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. > > BUG=chromium:554488 > LOG=NO > > Committed: https://crrev.com/026095a3c7932573e1810b8064ec3008ed696601 > Cr-Commit-Position: refs/heads/master@{#32396} TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:554488 Review URL: https://codereview.chromium.org/1483003002 Cr-Commit-Position: refs/heads/master@{#32404}
-
ulan authored
The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. BUG=chromium:554488 LOG=NO Review URL: https://codereview.chromium.org/1480873003 Cr-Commit-Position: refs/heads/master@{#32396}
-
- 25 Nov, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1472393002 Cr-Commit-Position: refs/heads/master@{#32297}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 18 Jun, 2015 1 commit
-
-
ulan authored
Revert of Replace ad-hoc weakness in transition array with WeakCell. (patchset #5 id:80001 of https://codereview.chromium.org/1157943003/) Reason for revert: Breaks descriptor array clearing. Original issue's description: > Replace ad-hoc weakness in transition array with WeakCell. > > BUG= > > Committed: https://crrev.com/885455e99de817f86a0b5df2dc0d932cfc179749 > Cr-Commit-Position: refs/heads/master@{#29083} TBR=jkummerow@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1194673002 Cr-Commit-Position: refs/heads/master@{#29121}
-
- 17 Jun, 2015 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1157943003 Cr-Commit-Position: refs/heads/master@{#29083}
-
- 06 Mar, 2015 1 commit
-
-
jkummerow authored
Original issue: https://codereview.chromium.org/980573002/ Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/988703002 Cr-Commit-Position: refs/heads/master@{#27044}
-
- 05 Mar, 2015 2 commits
-
-
jkummerow authored
Revert of Simplify and compact transitions storage (patchset #4 id:80001 of https://codereview.chromium.org/980573002/) Reason for revert: x64 test failures Original issue's description: > Simplify and compact transitions storage > > Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. > To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. > > Committed: https://crrev.com/45fbef7f2252fce10634931cb103ccc1fc95ae6a > Cr-Commit-Position: refs/heads/master@{#27029} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/982143002 Cr-Commit-Position: refs/heads/master@{#27030}
-
jkummerow authored
Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/980573002 Cr-Commit-Position: refs/heads/master@{#27029}
-
- 12 Dec, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/801813002 Cr-Commit-Position: refs/heads/master@{#25802}
-
- 10 Dec, 2014 2 commits
-
-
adamk authored
They both now run fast (due to utilizing transitions instead of always creating new maps) and sealed or non-extensible objects can stay in fast mode after transitioning. This almost entirely reuses the code for transitioning objects frozen by Object.freeze(), with the added benefit of freeing up a bit on the map (we no longer keep track of frozen-ness, as that bit wasn't used for anything interesting). BUG=v8:3662,chromium:115960 LOG=y Review URL: https://codereview.chromium.org/776143005 Cr-Commit-Position: refs/heads/master@{#25759}
-
ishell authored
Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name." Review URL: https://codereview.chromium.org/793453004 Cr-Commit-Position: refs/heads/master@{#25750}
-
- 24 Nov, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/739013004 Cr-Commit-Position: refs/heads/master@{#25482}
-
- 13 Nov, 2014 2 commits
-
-
ishell@chromium.org authored
This reverts the commit because it possibly causes renderer hangs. BUG=chromium:431807 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/725633002 Cr-Commit-Position: refs/heads/master@{#25338}
-
ishell@chromium.org authored
Revert "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name." Revert "Fix for an assertion failure in Map::FindTransitionToField(...). Appeared after r25136." This revert is made in order to revert r25099 which potentially causes renderer hangs. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/722873004 Cr-Commit-Position: refs/heads/master@{#25332}
-
- 05 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/661133002 Cr-Commit-Position: refs/heads/master@{#25136} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
This is a prerequisite for https://codereview.chromium.org/661133002/. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/698043003 Cr-Commit-Position: refs/heads/master@{#25099} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
BUG=chromium:427813 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/676393002 Cr-Commit-Position: refs/heads/master@{#25082} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Oct, 2014 1 commit
-
-
verwaest@chromium.org authored
Revert "Limit the number of transitions allowed per hidden class." Due to crashes in ClearMapTransitions BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/661583004 Cr-Commit-Position: refs/heads/master@{#24900} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24900 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Oct, 2014 1 commit
-
-
verwaest@chromium.org authored
Each time a transition is added to a hidden class, the whole transitions array must be copied, which causes poor performance in some circumstances. This change limits the maximum size of the transition array, avoiding this behavior in the pathological case. For example, this improves the performance of the EtchMark benchmark by nearly 60%. BUG=v8:3616 LOG= R=verwaest@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/635883003 Patch from Kevin M. McCormick <mckev@amazon.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Oct, 2014 1 commit
-
-
ishell@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/659363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24837 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Apr, 2014 1 commit
-
-
hpayer@chromium.org authored
Instread of using the transition array map to store the iteration index, we are using the constructor field of the map. Moreover, I removed the unchecked transition array accessors. BUG= R=mstarzinger@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/223533002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20503 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Mar, 2014 1 commit
-
-
ulan@chromium.org authored
BUG=353954 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/203593014 Patch from Dmitry Zvorygin <zvorygin@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Feb, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG=chromium:343964 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/170343003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Dec, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:2637 LOG=N R=titzer@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/101853003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Jul, 2013 1 commit
-
-
verwaest@chromium.org authored
This is preparatory work for reordering the transition tree. Since elements transitions will be at the root of the transition tree, runtime access to them is slow since we have to walk the transition tree backwards first. Hence remove the optimization that promoted them to a special field, requiring a pointer (mostly NULL) in every non-simple transition array. R=titzer@chromium.org Review URL: https://chromiumcodereview.appspot.com/21228002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15993 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Mar, 2013 1 commit
-
-
rossberg@chromium.org authored
Since symbols and strings share a common representation, most of this change is about consistently replacing 'String' with 'Name' in all places where property names are expected. In particular, no new logic at all is necessary for maps, property dictionaries, or transitions. :) The only places where an actual case distinction is needed have to do with generated type checks, and with conversions of names to strings (especially in logger and profiler). Left in some TODOs wrt to the API: interceptors and native getters don't accept symbols as property names yet, because that would require extending the external v8.h. (Baseline CL: https://codereview.chromium.org/12296026/) R=verwaest@chromium.org,mstarzinger@chromium.org BUG=v8:2158 Review URL: https://codereview.chromium.org/12330012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Oct, 2012 1 commit
-
-
verwaest@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/11189089 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Oct, 2012 1 commit
-
-
verwaest@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/11188031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Oct, 2012 1 commit
-
-
verwaest@chromium.org authored
Secondary changes: - don't transfer ownership back on CNLT - turned debugging checks back into ASSERT Review URL: https://chromiumcodereview.appspot.com/11099064 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2012 1 commit
-
-
verwaest@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10915260 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-