- 07 Mar, 2016 1 commit
-
-
verwaest authored
BUG=chromium:592305 LOG=n Review URL: https://codereview.chromium.org/1770833002 Cr-Commit-Position: refs/heads/master@{#34552}
-
- 04 Mar, 2016 3 commits
-
-
verwaest authored
BUG=588893, 325923 LOG=n Review URL: https://codereview.chromium.org/1762273002 Cr-Commit-Position: refs/heads/master@{#34493}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1765713003 Cr-Commit-Position: refs/heads/master@{#34492}
-
verwaest authored
This is the equivalent of the fast-path in ApplyTransitionToDataProperty. BUG=588893, 325923 LOG=n Review URL: https://codereview.chromium.org/1765633003 Cr-Commit-Position: refs/heads/master@{#34488}
-
- 03 Mar, 2016 1 commit
-
-
machenbach authored
This reverts commit 2608ecc7. Revert "Specialize helper methods in the LookupIterator by is_element." This reverts commit 6eb483f8. Revert "Avoid SetPropertyInternal if the LookupIterator is NotFound" This reverts commit ca5bd8d4. Revert "Inline fast-bailout-checks for LookupIterator::UpdateProtector" This reverts commit d98570a1. This breaks layout tests with timeouts: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5060 It also seems to break jsfunfuzz: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/7930 The other three CLs are reverted to be able to revert the first. BUG=v8:4798 LOG=n TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/1761593003 Cr-Commit-Position: refs/heads/master@{#34457}
-
- 02 Mar, 2016 4 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1754023003 Cr-Commit-Position: refs/heads/master@{#34438}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1752383002 Cr-Commit-Position: refs/heads/master@{#34436}
-
verwaest authored
This speeds up lookup. BUG= Review URL: https://codereview.chromium.org/1753273002 Cr-Commit-Position: refs/heads/master@{#34430}
-
verwaest authored
This introduces a new instance type and reorders the JSObject types so any type requiring special LookupIterator support can be identified with a single range check. In addition, it restructures the Next for better performance, avoiding unnecessary calls. BUG= Review URL: https://codereview.chromium.org/1751043002 Cr-Commit-Position: refs/heads/master@{#34429}
-
- 22 Feb, 2016 1 commit
-
-
littledan authored
This patch makes ArraySpeciesCreate fast in V8 by avoiding two property reads when the following conditions are met: - No Array instance has had its __proto__ reset - No Array instance has had a constructor property defined - Array.prototype has not had its constructor changed - Array[Symbol.species] has not been reset For subclasses of Array, or for conditions where one of these assumptions is violated, the full lookup of species is done according to the ArraySpeciesCreate algorithm. Although this is a "performance cliff", it does not come up in the expected typical use case of @@species (Array subclassing), so it is hoped that this can form a good start. Array subclasses will incur the slowness of looking up @@species, but their use won't slow down invocations of, for example, Array.prototype.slice on Array base class instances. Possible future optimizations: - For the fallback case where the assumptions don't hold, optimize the two property lookups. - For Array.prototype.slice and Array.prototype.splice, even if the full lookup of @@species needs to take place, we still could take the rest of the C++ fastpath. However, to do this correctly requires changing the calling convention from C++ to JS to pass the @@species out, so it is not attempted in this patch. With this patch, microbenchmarks of Array.prototype.slice do not suffer a noticeable performance regression, unlike their previous 2.5x penalty. TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1689733002 Cr-Commit-Position: refs/heads/master@{#34199}
-
- 19 Feb, 2016 3 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1715543003 Cr-Commit-Position: refs/heads/master@{#34150}
-
verwaest authored
Review URL: https://codereview.chromium.org/1717603002 Cr-Commit-Position: refs/heads/master@{#34149}
-
verwaest authored
This should restore the splay regression. BUG= Review URL: https://codereview.chromium.org/1714753003 Cr-Commit-Position: refs/heads/master@{#34144}
-
- 18 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1704353002 Cr-Commit-Position: refs/heads/master@{#34118}
-
- 17 Feb, 2016 4 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1706833002 Cr-Commit-Position: refs/heads/master@{#34087}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1705713002 Cr-Commit-Position: refs/heads/master@{#34070}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1702623002 Cr-Commit-Position: refs/heads/master@{#34063}
-
verwaest authored
Minor improvements measured through by https://github.com/kpdecker/six-speed/blob/master/tests/object-assign/object-assign.es6. Mostly due to inlining of NowContains on the FieldType Review URL: https://codereview.chromium.org/1703513002 Cr-Commit-Position: refs/heads/master@{#34060}
-
- 16 Feb, 2016 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1702443002 Cr-Commit-Position: refs/heads/master@{#34024}
-
- 15 Feb, 2016 1 commit
-
-
verwaest authored
By not calling ReloadPropertyInformation, we avoid expensive descriptor array lookup. BUG= Review URL: https://codereview.chromium.org/1697153002 Cr-Commit-Position: refs/heads/master@{#33995}
-
- 08 Feb, 2016 1 commit
-
-
verwaest authored
Generally we only care whether the next object is a hidden prototype. It's simpler to check whether the current object has a hidden prototype instead of walking to the next prototype and checking its map. BUG= Review URL: https://codereview.chromium.org/1675223002 Cr-Commit-Position: refs/heads/master@{#33816}
-
- 04 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1667083002 Cr-Commit-Position: refs/heads/master@{#33737}
-
- 03 Feb, 2016 1 commit
-
-
verwaest authored
This was inconsistent in the spec in case of has vs get, set. Removing receiver==holder simplifies the lookup; so tentatively removing this additional check which was broken until yesterday anyway. See https://github.com/tc39/ecma262/issues/347 for more information. Review URL: https://codereview.chromium.org/1660903002 Cr-Commit-Position: refs/heads/master@{#33701}
-
- 02 Feb, 2016 1 commit
-
-
verwaest authored
This includes 2 fixes: 1) We didn't properly advance the holder when checking whether Receiver==Holder, so we'd inadvertently block loading the property if the first property we find is on the typed array. 2) Reflect.get may cause any object on the prototype chain of the holder to be the receiver; so we need to recheck for this special state for each object we perform lookup on. Review URL: https://codereview.chromium.org/1651913005 Cr-Commit-Position: refs/heads/master@{#33689}
-
- 29 Jan, 2016 1 commit
-
-
jkummerow authored
String wrappers (new String("foo")) are special objects: their string characters are accessed like elements, and they also have an elements backing store. This used to require a bunch of explicit checks like: if (obj->IsJSValue() && JSValue::cast(obj)->value()->IsString()) { /* Handle string characters */ } // Handle regular elements (for string wrappers and other objects) obj->GetElementsAccessor()->Whatever(...); This CL introduces new ElementsKinds for string wrapper objects (one for fast elements, one for dictionary elements), which allow folding the special-casing into new StringWrapperElementsAccessors. No observable change in behavior is intended. Review URL: https://codereview.chromium.org/1612323003 Cr-Commit-Position: refs/heads/master@{#33616}
-
- 26 Jan, 2016 1 commit
-
-
jarin authored
This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map. The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1636013002 Cr-Commit-Position: refs/heads/master@{#33521}
-
- 18 Jan, 2016 1 commit
-
-
jochen authored
BUG=chromium:571365 R=verwaest@chromium.org,neis@chromium.org LOG=n Review URL: https://codereview.chromium.org/1587633002 Cr-Commit-Position: refs/heads/master@{#33358}
-
- 11 Jan, 2016 1 commit
-
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1573143002 Cr-Commit-Position: refs/heads/master@{#33212}
-
- 03 Dec, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:4537 LOG=N R=neis@chromium.org, rossberg@chromium.org, jkummerow@chromium.org Review URL: https://codereview.chromium.org/1492923002 Cr-Commit-Position: refs/heads/master@{#32570}
-
- 27 Nov, 2015 1 commit
-
-
pan.deng authored
BUG=None LOG=n Review URL: https://codereview.chromium.org/1473023004 Cr-Commit-Position: refs/heads/master@{#32354}
-
- 02 Nov, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1406113007 Cr-Commit-Position: refs/heads/master@{#31714}
-
- 26 Oct, 2015 1 commit
-
-
jkummerow authored
along with follow-up fixes: - "introduce LookupIterator::Restart() and use it" - "always reset the LookupIterator before storing" - "API-style accessors can throw, check for that" Revert reason was fixed in Chromium: https://codereview.chromium.org/1415453003/ This reverts the following commits: 0188aead 984f8af8 dc9d2c16 a0f5d499 Review URL: https://codereview.chromium.org/1424503003 Cr-Commit-Position: refs/heads/master@{#31578}
-
- 23 Oct, 2015 1 commit
-
-
hablich authored
Revert of Introduce LookupIterator::Restart() and use it (patchset #2 id:20001 of https://codereview.chromium.org/1416053007/ ) Reason for revert: Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441 Needed so the reverts applies cleanly and seems to be related to the offending CL. Original issue's description: > Introduce LookupIterator::Restart() and use it > > Committed: https://crrev.com/5676415b4add059b78f98a9a762d00c8d721dbcd > Cr-Commit-Position: refs/heads/master@{#31483} TBR=verwaest@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1418213003 Cr-Commit-Position: refs/heads/master@{#31534}
-
- 22 Oct, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/1416053007 Cr-Commit-Position: refs/heads/master@{#31483}
-
- 09 Oct, 2015 1 commit
-
-
jochen authored
This will allow for probing access from any context to any receiver in a future CL. BUG=none R=jkummerow@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1398093002 Cr-Commit-Position: refs/heads/master@{#31196}
-
- 05 Oct, 2015 1 commit
-
-
mstarzinger authored
This removes the lookup-inl.h header file, which actually would break compilation if included more than once in the codebase. It only holds methods used solely in the lookup.cc compilation unit. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1375843004 Cr-Commit-Position: refs/heads/master@{#31104}
-
- 30 Sep, 2015 1 commit
-
-
jkummerow authored
Continuing unification of properties/elements handling, the new LookupIterator::PropertyOrElement(..., Handle<Object> key, ...) takes any Object and does the required ToPrimitive/ToName/ToArrayIndex conversions on it. Review URL: https://codereview.chromium.org/1375943002 Cr-Commit-Position: refs/heads/master@{#31023}
-
- 23 Sep, 2015 1 commit
-
-
jkummerow authored
Whenever a generalization is computed, the inputs must be checked for being cleared, and if they are, the generalization must be Type::Any. Hopefully this fixes Chromium issue 527994 as well. BUG=v8:4325,chromium:527994 LOG=n Review URL: https://codereview.chromium.org/1361103002 Cr-Commit-Position: refs/heads/master@{#30887}
-
- 10 Sep, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1330153003 Cr-Commit-Position: refs/heads/master@{#30676}
-