- 04 Aug, 2015 15 commits
-
-
bbudge authored
Change IS_SIMD_OBJECT to IS_SIMD_VALUE, and IsSimdObject to IsSimdValue. R=rossberg LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1253103006 Cr-Commit-Position: refs/heads/master@{#30004}
-
vogelheim authored
The race occurred when Workers were used. Since Workers call Shell::ExecuteString from a different thread, TSAN (correctly) flags this as a racy write. Solution would be to either synchronize the writes, or to 'lift' the write higher up in the call stack and only write the flag from the main thread. This implements this latter solution. These methods call Shell::ExecuteString, but do *not* set script_executed: - ExecuteInThread: Can only occur is JS has already been executed. - Shell::Load: Callback for JS; so JS has already been executed when we get there. - Shell::RunShell: Interactive shell. We no longer need script_executed once we're here. BUG=v8:4330 LOG=N Review URL: https://codereview.chromium.org/1258303004 Cr-Commit-Position: refs/heads/master@{#30003}
-
rossberg authored
Store arity in FormalParameters; store name (instead of var) and is_rest flag in individual parameters. Ensure that the arity is always maintained consistently. This is preparation for more parameter destructuring adjustments. In particular, a follow-up CL will separate parameter recording from declaring the variables. R=adamk@chromium.org, littledan@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1259013003 Cr-Commit-Position: refs/heads/master@{#30002}
-
rossberg authored
TBR=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1263043004 Cr-Commit-Position: refs/heads/master@{#30001}
-
yangguo authored
Revert of Remove serializer-specific hash table size heuristic. (patchset #1 id:1 of https://codereview.chromium.org/1265983006/ ) Reason for revert: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/3088/steps/Mjsunit/logs/load-proxy Original issue's description: > Remove serializer-specific hash table size heuristic. > > The heuristic can cause weird behavior when bootstrapping. > The memory savings is not worth this hassle. > > Committed: https://crrev.com/a246e296c6366dcd0a2d8aa0df973d57093178f6 > Cr-Commit-Position: refs/heads/master@{#29992} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1257873006 Cr-Commit-Position: refs/heads/master@{#30000}
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1269183002 Cr-Commit-Position: refs/heads/master@{#29999}
-
rossberg authored
They need to be properly recorded in the scope's temps set, otherwise allocation doesn't know about them and can break. (Not observable right now, but necessary for follow-up changes to parameter destructuring.) Also, print temporary variables in a useful manner. R=adamk@chromium.org BUG= Review URL: https://codereview.chromium.org/1263563002 Cr-Commit-Position: refs/heads/master@{#29998}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1265243003 Cr-Commit-Position: refs/heads/master@{#29997}
-
ulan authored
BUG=chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1263373002 Cr-Commit-Position: refs/heads/master@{#29996}
-
yangguo authored
This is a pure refactor and does not change functionality. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1264993002 Cr-Commit-Position: refs/heads/master@{#29995}
-
ulan authored
BUG=chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1257833005 Cr-Commit-Position: refs/heads/master@{#29994}
-
paul.lind authored
Port 7b9670b6 Only fails in debug builds. TEST=mjsunit/harmony/simd BUG= Review URL: https://codereview.chromium.org/1264103005 Cr-Commit-Position: refs/heads/master@{#29993}
-
yangguo authored
The heuristic can cause weird behavior when bootstrapping. The memory savings is not worth this hassle. Review URL: https://codereview.chromium.org/1265983006 Cr-Commit-Position: refs/heads/master@{#29992}
-
hpayer authored
That makes going to the page safe. Addresses can be in arbitrary locations of an object, e.g. in a large object but not on the first 1M page. BUG= Review URL: https://codereview.chromium.org/1256203004 Cr-Commit-Position: refs/heads/master@{#29991}
-
v8-autoroll authored
Rolling v8/buildtools to 565d04e8741429fb1b4f26d102f2c6c3b849edeb TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1267173003 Cr-Commit-Position: refs/heads/master@{#29990}
-
- 03 Aug, 2015 25 commits
-
-
ofrobots authored
The recursion between AllocateRaw* and SlowAllocateRaw makes incremental stepping very complicated. This patch removes the recursion. Follow-on patches will improve accounting of allocations done by incremental mark. See: https://codereview.chromium.org/1252053003/#msg5 BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1265443003 Cr-Commit-Position: refs/heads/master@{#29989}
-
oth authored
Change minimum BytecodeArray frame size to zero now return value is in the accumulator. Fix inconsistent checks in bytecode-array-builder.cc. Simplify bytecode disassembly by adding Bytecodes::Decode to disassemble one bytecode and operands. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1259193004 Cr-Commit-Position: refs/heads/master@{#29988}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1261373006 Cr-Commit-Position: refs/heads/master@{#29987}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1270873002 Cr-Commit-Position: refs/heads/master@{#29986}
-
yangguo authored
There is only one use case for it: String.prototype.search converts a string argument into a RegExp. The cache is used to avoid repeating that conversion. However, this does not make the added complexity worthwhile. Review URL: https://codereview.chromium.org/1267493006 Cr-Commit-Position: refs/heads/master@{#29985}
-
dstence authored
R=danno@chromium.org, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1252913007 Cr-Commit-Position: refs/heads/master@{#29984}
-
mlippautz authored
High promotion mode limits new space size in the case where many objects (high rate) are promoted. The result is frequent scavenger runs with low pause times. The approach conflicts with pretenuring which requires a larger new space size to collect enough feedback to be usable. Ultimately the goal is to have pretenuring catch allocation sites that have high promotion rates. Revert "Bring back high promotion mode to shrink young generation size when scavenging latency is high." This reverts commit 37be1d5e. Revert "GC. Delay/avoid entering high promotion mode" This reverts commit a5221d07. BUG=chromium:499507,chromium:506910 LOG=n Review URL: https://codereview.chromium.org/1247723003 Cr-Commit-Position: refs/heads/master@{#29983}
-
binji authored
BUG=chromium:514081 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1264723002 Cr-Commit-Position: refs/heads/master@{#29982}
-
jochen authored
As demanded by the spec. BUG=chromium:516251 R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/1261453004 Cr-Commit-Position: refs/heads/master@{#29981}
-
bbudge authored
Rename method EmitIsSpecObject -> EmitIsSimdObject. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1263473008 Cr-Commit-Position: refs/heads/master@{#29980}
-
hpayer authored
BUG=chromium:454297 LOG=n Review URL: https://codereview.chromium.org/1268663004 Cr-Commit-Position: refs/heads/master@{#29979}
-
mbrandy authored
NOPRESUBMIT=true R=titzer@chromium.org, michael_dawson@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1271583002 Cr-Commit-Position: refs/heads/master@{#29978}
-
titzer authored
R=mstarzinger@chromium.org BUG= NOTREECHECKS=true Review URL: https://codereview.chromium.org/1263363002 Cr-Commit-Position: refs/heads/master@{#29977}
-
hpayer authored
Reland of land concurrent sweeping of code space. (patchset #1 id:1 of https://codereview.chromium.org/1263343002/) Reason for revert: Bogus revert. Original issue's description: > Revert of Reland concurrent sweeping of code space. (patchset #6 id:100001 of https://codereview.chromium.org/1242333002/) > > Reason for revert: > Reverted because 507840 came back on recent Chromecrash. Should not have committed this Cl. > > Original issue's description: > > Reland concurrent sweeping of code space. > > > > BUG= > > > > Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e > > Cr-Commit-Position: refs/heads/master@{#29967} > > TBR=jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/5c6e7d00438cc82a5584e3178d7dadf36e4a34f8 > Cr-Commit-Position: refs/heads/master@{#29975} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1271773002 Cr-Commit-Position: refs/heads/master@{#29976}
-
hpayer authored
Revert of Reland concurrent sweeping of code space. (patchset #6 id:100001 of https://codereview.chromium.org/1242333002/) Reason for revert: Reverted because 507840 came back on recent Chromecrash. Should not have committed this Cl. Original issue's description: > Reland concurrent sweeping of code space. > > BUG= > > Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e > Cr-Commit-Position: refs/heads/master@{#29967} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1263343002 Cr-Commit-Position: refs/heads/master@{#29975}
-
bbudge authored
Adds Int32x4, Bool32x4, Int16x8, Bool16x8, Int8x16, Bool8x16. Adds Simd128Value base heap object class. Changes heap/factory construction pattern to use arrays. Adds replaceLane functions to facilitate testing. NOPRESUBMIT=true (presubmit checks erroneously interpret array declaration in macro definition as variable size array.) LOG=Y BUG=v8:4124 Review URL: https://codereview.chromium.org/1250733005 Cr-Commit-Position: refs/heads/master@{#29974}
-
jarin authored
The calculation now takes into account the size of the arguments object if it is present in the optimized frame. (Yang, many thanks for the awesome repro!) BUG=chromium:514362 LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1264483008 Cr-Commit-Position: refs/heads/master@{#29973}
-
machenbach authored
BUG=v8:4141 LOG=n NOTRY=true TBR=yangguo@chromium.org, vogelheim@chromium.org Review URL: https://codereview.chromium.org/1263033005 Cr-Commit-Position: refs/heads/master@{#29972}
-
jarin authored
This fixes a bug introduced by r28826 (Unify decoding of deoptimization translations, https://codereview.chromium.org/1136223004), where we started leaking arguments marker sentinel to the debugger, which would then cause crashes. This change replaces the sentinel with the undefined value in the debugger-inspectable frame. BUG=chromium:514362 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1263333002 Cr-Commit-Position: refs/heads/master@{#29971}
-
oth authored
The BytecodeArrayBuilder has responsibility for emitting the BytecodeArray. It will be used by the AST walker. Bytecode now uses an accumulator plus registers rather being pure register based. Update BytecodeArray::Disassemble to print operand information. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1266713004 Cr-Commit-Position: refs/heads/master@{#29970}
-
yangguo authored
No-snap builds are still failing. NOTREECHECKS=true NOTRY=true TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1260283006 Cr-Commit-Position: refs/heads/master@{#29969}
-
ulan authored
Original CL: https://crrev.com/5aaceefd9a84327ce6afeaea16557449bf83ce57 BUG=chromium:515721 LOG=NO Review URL: https://codereview.chromium.org/1264063003 Cr-Commit-Position: refs/heads/master@{#29968}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1242333002 Cr-Commit-Position: refs/heads/master@{#29967}
-
yangguo authored
Otherwise we may choose sloppy const or strict const depending on whether the function is parsed the first time. R=mvstanton@chromium.org BUG=v8:4336 LOG=N Review URL: https://codereview.chromium.org/1260053004 Cr-Commit-Position: refs/heads/master@{#29966}
-
mvstanton authored
Use a CHECK statement to find any violations of this rule. Review URL: https://codereview.chromium.org/1255383004 Cr-Commit-Position: refs/heads/master@{#29965}
-