1. 19 May, 2020 3 commits
    • Clemens Backes's avatar
      Revert "[wasm][debug] Fix tier down during streaming compilation" · 8d3cca97
      Clemens Backes authored
      This reverts commit 3cc981cb.
      
      Reason for revert: TSan failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/31572
      
      Original change's description:
      > [wasm][debug] Fix tier down during streaming compilation
      > 
      > If the debugger is enabled while streaming compilation is happening, we
      > won't correctly tier down to Liftoff. This is because during streaming
      > compilation, we always compile for no debugging. Fixing that is a bit
      > tricky, since when the debugger is enabled, functions can either already
      > have finished compiling, or they are currently being compiled, or their
      > wire bytes are not received yet.
      > Instead of handling this correctly while streaming compilation is
      > running, we just recompile the whole module with Liftoff after streaming
      > compilation finished.
      > 
      > For testing this, we use the existing tests for async compilation, and
      > enable --wasm-test-streaming, which compiles via the streaming decoder
      > even in the async compilation case.
      > 
      > R=​thibaudm@chromium.org
      > 
      > Bug: v8:10531
      > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133
      > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
      > Commit-Queue: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67882}
      
      TBR=clemensb@chromium.org,thibaudm@chromium.org
      
      Change-Id: I26e750c6c6d0783b5e4a0f19a5462a5fbe99a742
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10531
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207186Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67885}
      8d3cca97
    • Richard Stotz's avatar
      [wasm][liftoff][ia32] Add saturated conversion float->int64 · 73bf6079
      Richard Stotz authored
      We implement the conversions via C functions (external references)
      because 64-bit conversions are difficult to implement on ia32 and
      would not be significantly faster.
      
      Bug: v8:10520
      Change-Id: I3573d30bf6b3d558f708c7e0273f027c30a1a771
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202988
      Commit-Queue: Richard Stotz <rstz@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67883}
      73bf6079
    • Clemens Backes's avatar
      [wasm][debug] Fix tier down during streaming compilation · 3cc981cb
      Clemens Backes authored
      If the debugger is enabled while streaming compilation is happening, we
      won't correctly tier down to Liftoff. This is because during streaming
      compilation, we always compile for no debugging. Fixing that is a bit
      tricky, since when the debugger is enabled, functions can either already
      have finished compiling, or they are currently being compiled, or their
      wire bytes are not received yet.
      Instead of handling this correctly while streaming compilation is
      running, we just recompile the whole module with Liftoff after streaming
      compilation finished.
      
      For testing this, we use the existing tests for async compilation, and
      enable --wasm-test-streaming, which compiles via the streaming decoder
      even in the async compilation case.
      
      R=thibaudm@chromium.org
      
      Bug: v8:10531
      Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67882}
      3cc981cb
  2. 18 May, 2020 12 commits
  3. 15 May, 2020 13 commits
  4. 14 May, 2020 6 commits
  5. 13 May, 2020 6 commits