1. 05 Jul, 2013 13 commits
  2. 04 Jul, 2013 10 commits
  3. 03 Jul, 2013 17 commits
    • olivf@chromium.org's avatar
      Revert "Convert UnaryOpStub to a HydrogenCodeStub" · 950a3728
      olivf@chromium.org authored
      The problem is the HCallConstantFunction which is not context sensitive, so we leak the builtin. We first need a Hydrogen version of __ IvokeBuiltin.
      
      BUG=
      R=danno@chromium.org, machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/18650003
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15486 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      950a3728
    • yurys@chromium.org's avatar
      Fix Mac compilation after r15484 · 282926a7
      yurys@chromium.org authored
      BUG=None
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18023019
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15485 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      282926a7
    • yurys@chromium.org's avatar
      Do not store fp and sp values in TickSample · 9ef762b6
      yurys@chromium.org authored
      Their values are not used neither by the tick processor nor by CpuProfiler so it is just a waste of space.
      
      TickSample used to be a transport for grabbed register values to TickSample::Trace, now they are passed in a special structure RegisterState which is allocated on the stack for the sampling period.
      
      Some common pieces were moved from platform-dependent code into Sampler::SampleStack and TickSample::Init.
      
      BUG=None
      R=jkummerow@chromium.org, loislo@chromium.org
      
      Review URL: https://codereview.chromium.org/18620002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      9ef762b6
    • jkummerow@chromium.org's avatar
      Revert "Fix stack alignment corruption for MinGW32 build" · 91be57a4
      jkummerow@chromium.org authored
      due to compile failures.
      
      This reverts r15480.
      
      R=dslomov@chromium.org
      
      Review URL: https://codereview.chromium.org/18649002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      91be57a4
    • yurys@chromium.org's avatar
      Remove #include "cpu-profiler-inl.h" from v8.h · 678c9dc9
      yurys@chromium.org authored
      This significantly reduces amount of files to be recompiled after changes in cpu-profiler.h and its dependencies.
      
      BUG=None
      R=loislo@chromium.org, yangguo@chromium.org
      
      Review URL: https://codereview.chromium.org/18522004
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      678c9dc9
    • jkummerow@chromium.org's avatar
      Format stack layout comments for X64 · 77c582d2
      jkummerow@chromium.org authored
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18607002
      
      Patch from Haitao Feng <haitao.feng@intel.com>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      77c582d2
    • jkummerow@chromium.org's avatar
      Fix stack alignment corruption for MinGW32 build · 45681dbd
      jkummerow@chromium.org authored
      Contributed by Peter Varga <pvarga@inf.u-szeged.hu>
      
      BUG=
      TEST=cctest/test-assembler-ia32/StackAlignmentForSSE2,cctest/test-assembler-x64/StackAlignmentForSSE2,cctest/test-platform/StackAlignment
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18300003
      
      Patch from Peter Varga <pvarga@inf.u-szeged.hu>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      45681dbd
    • jkummerow@chromium.org's avatar
      Change mjsunit tests to work with and without the i18n extension · dd37adc4
      jkummerow@chromium.org authored
      BUG=v8:2745
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18187006
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      dd37adc4
    • jkummerow@chromium.org's avatar
      Mark i18n functions as native and set proper names · 84833a59
      jkummerow@chromium.org authored
      BUG=v8:2745
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18075004
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      84833a59
    • mstarzinger@chromium.org's avatar
      GDBJIT: Remove codes when they are garbage collected. · 5a71b173
      mstarzinger@chromium.org authored
      R=mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/13880031
      
      Patch from Haitao Feng <haitao.feng@intel.com>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15477 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      5a71b173
    • jkummerow@chromium.org's avatar
      Sort the i18n extension sources correctly. · 6659869b
      jkummerow@chromium.org authored
      It's important that e.g. the header comes first, and the footer last
      
      BUG=v8:2745
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18187005
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15476 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      6659869b
    • jkummerow@chromium.org's avatar
      Fix typo in api.cc · b8969357
      jkummerow@chromium.org authored
      BUG=v8:2745
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18471005
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15475 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      b8969357
    • mstarzinger@chromium.org's avatar
      Fix GDBJIT compilation on Mac after r15467. · 0a6b0645
      mstarzinger@chromium.org authored
      R=machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/18259007
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      0a6b0645
    • olivf@chromium.org's avatar
      Convert UnaryOpStub to a HydrogenCodeStub · 0d2fed8f
      olivf@chromium.org authored
      BUG=
      R=danno@chromium.org
      
      Review URL: https://codereview.chromium.org/17229005
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      0d2fed8f
    • yangguo@chromium.org's avatar
      Add 4K more memory for HugeConsStringOutOfMemory test case · 1963ec4b
      yangguo@chromium.org authored
      R=yangguo@chromium.org
      
      Review URL: https://codereview.chromium.org/18068007
      
      Patch from Haitao Feng <haitao.feng@intel.com>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15472 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1963ec4b
    • yurys@chromium.org's avatar
      Fix test-cpu-profiler/FunctionCallSample flakiness under GC stress testing · 44dfaa2a
      yurys@chromium.org authored
      The test flakes on "V8 GC Stress" bots and the sample looks like this:
      [Top down]:
         90     0   (root) [-1] #0 1
          1     1    (program) [-1] #0 2
         89    89    (garbage collector) [-1] #0 3
      which means that almost all samples are inside GC and we have no |start| node in the collected profile.
      
      Running the test with different combinations of --gc-interval=500 and --stress-compaction flags gives the results quoted below. They don't give a ground to require |start| node presense in the profile when doing GC stress testing. So this change makes the |start| node optional in the collected profile if GC stress testing is on.
      
      $ ./out/ia32.debug/cctest --gc-interval=500 --stress-compaction --trace-gc  test-cpu-profiler/FunctionCallSample
      [10291]       76 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.5 ms (+ 0.2 ms in 1 steps since start of marking, biggest step 0.2 ms) [StackGuard GC request] [GC in old space requested].
      [10291]      110 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 25.3 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10291]      135 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 22.8 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10291]      179 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 39.9 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [10291]      209 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 29.1 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [10291]      240 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 29.1 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [Top down]:
         99     0   (root) [-1] #0 1
          4     4    start [-1] #16 3
         93    93    (garbage collector) [-1] #0 4
          2     2    (program) [-1] #0 2
      
      $ ./out/ia32.debug/cctest --gc-interval=500  --trace-gc  test-cpu-profiler/FunctionCallSample
      [10328]       46 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 14.9 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10328]       61 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 12.9 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10328]       65 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       67 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       69 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       70 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       72 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       73 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       75 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       77 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       78 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       80 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       81 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       83 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       85 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       86 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       88 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       89 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       91 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       93 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       94 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       96 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       97 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       99 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      101 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      102 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      104 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      105 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      107 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      109 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      110 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      112 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      113 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      115 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      117 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      118 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      120 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      121 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      123 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      125 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      126 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      128 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      129 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      131 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      133 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      134 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      136 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      137 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      139 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      141 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      142 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      144 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      145 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      147 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      149 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      150 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      152 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      153 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      155 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      157 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      158 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      160 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      162 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      163 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [Top down]:
         95     0   (root) [-1] #0 1
         12    11    start [-1] #16 3
          1     1      bar [-1] #16 4
         81    81    (garbage collector) [-1] #0 5
          2     2    (program) [-1] #0 2
      
      $ ./out/ia32.debug/cctest --stress-compaction --trace-gc  test-cpu-profiler/FunctionCallSample
      [10355]       76 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.9 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      110 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 25.5 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10355]      135 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 22.9 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10355]      189 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.8 ms (+ 0.2 ms in 1 steps since start of marking, biggest step 0.2 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      234 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 42.5 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      278 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 42.5 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [Top down]:
        135     0   (root) [-1] #0 1
          6     6    start [-1] #16 3
        127   127    (garbage collector) [-1] #0 4
          2     2    (program) [-1] #0 2
      
      BUG=None
      R=jkummerow@chromium.org, loislo@chromium.org
      
      Review URL: https://codereview.chromium.org/18068012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      44dfaa2a
    • yurys@chromium.org's avatar
      Relax test expectations for test-cpu-profiler/FunctionApplySample · 41c9adff
      yurys@chromium.org authored
      The profile may look a bit different on the bots (see below). We expected this only under GC stress testing, the change makes regular expectations the same.
      
      [Top down]:
         68     0   (root) [-1] #0 1
          1     1    (program) [-1] #0 2
         67    65    start [-1] #16 3
          2     0      (unresolved function) [-1] #0 4
          2     2        apply [-1] #0 5
      
      BUG=None
      TBR=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18331012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      41c9adff